1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-07 17:18:11 +03:00
Commit Graph

1455 Commits

Author SHA1 Message Date
Jelmer Vernooij
cca032f1cd Fix bug in '-d'
(This used to be commit 8c15db105a)
2002-10-26 14:49:30 +00:00
Jeremy Allison
7689a9c969 First cut of new ACL mapping code from Andreas Gruenbacher <agruen@suse.de>.
This is not 100% the same as what SuSE shipped in their Samba, there is
a crash bug fix, a race condition fix, and a few logic changes I'd like to
discuss with Andreas. Added Andreas to (C) notices for posix_acls.c
Jeremy.
(This used to be commit a81d700ae9)
2002-10-23 01:22:45 +00:00
Andrew Tridgell
66ad44b588 reverted an incorrect fix. What I was trying to do was fix a problem
with filenames with spaces in mangle_hash.c but the real problem is
that mangle_hash.c assumes that the set of valid characters for 8.3
names is the same as the set of valid characters for long names. Thats
an invalid assumption, with space being the obvious example.
(This used to be commit e0065f4db4)
2002-10-21 03:47:51 +00:00
Andrew Tridgell
d51c1e333b a space is a standard valid character in a filename
(This used to be commit 0db79d4a37)
2002-10-21 03:40:18 +00:00
Tim Potter
a07df8249d Bugfix for pidfile_create() from Kelledin.
(This used to be commit 4808a95f5f)
2002-10-21 00:05:01 +00:00
Andrew Bartlett
d00d56faea It seems that I'm meant to be using the helper function here, not the struct
directly...

Andrew Bartlett
(This used to be commit 0abeb8725e)
2002-10-18 22:27:55 +00:00
Jim McDonough
e042a93cce Format objectGUIDs on ads dumps.
(This used to be commit 7eaf7e7115)
2002-10-18 20:11:29 +00:00
Jeremy Allison
e13dd2f302 Start to merge the new ACL mapping code from Andreas Gruenbacher <agruen@suse.de>.
Jeremy.
(This used to be commit f6103f866a)
2002-10-18 19:46:28 +00:00
Andrew Bartlett
4ac9ccfde4 Nice *big* patch from metze.
The actual design change is relitivly small however:

It all goes back to jerry's 'BOOL store', added to many of the elements in a
SAM_ACCOUNT.  This ensured that smb.conf defaults did not get 'fixed' into
ldap.  This was a great win for admins, and this patch follows in the same way.

This patch extends the concept - we don't store values back into LDAP unless
they have been changed.  So if we read a value, but don't update it, or we
read a value, find it's not there and use a default, we will not update
ldap with that value.  This reduced clutter in our LDAP DB, and makes it
easier to change defaults later on.

Metze's particular problem was that when we 'write back' an unchanged value,
we would clear any muliple values in that feild.  Now he can still have his
mulitivalued 'uid' feild, without Samba changing it for *every* other
operation.

This also applies to many other attributes, and helps to eliminate a nasty
race condition.  (Time between get and set)

This patch is big, and needs more testing, but metze has tested usrmgr, and
I've fixed some pdbedit bugs, and tested domain joins, so it isn't compleatly
flawed ;-).

The same system will be introduced into the SAM code shortly, but this fixes
bugs that people were coming across in production uses of Samba 3.0/HEAD, hence
it's inclusion here.

Andrew Bartlett
(This used to be commit 7f237bde21)
2002-10-12 03:38:07 +00:00
Simo Sorce
650e0274a1 try to put every security descriptors related definitions in the same file.
also try to uniform names to a clean scheme.

first part.
(This used to be commit a123e05877)
2002-10-06 23:53:34 +00:00
Jelmer Vernooij
7ee8de012b Add more common options to popt_common - and start using
the ones for debuglevel and configuration file in pdbedit
(This used to be commit cb0d03a393)
2002-10-05 05:43:44 +00:00
Jeremy Allison
9c94d1a2f7 Add a timeout to tdb_lock_bystring(). Ensure we never have more than
MAX_PRINT_JOBS in a queue.
Jeremy.
(This used to be commit bb58a08af4)
2002-10-04 22:53:30 +00:00
Jelmer Vernooij
f7832e935f Remove useless spaces - this broke make proto
(This used to be commit 0341fb4582)
2002-10-04 20:14:41 +00:00
Andrew Bartlett
08387abd7d Another patch from Steve Langasek <vorlon@netexpress.net>, again from the
Debian patchset.

The idea is to still allow DNS domains to be specified in 'hosts allow' and
'hosts deny' without making the admin set 'hostname lookups' in their smb.conf.
His concern is about upgrades.

This has been designed not to change the value of %M.

Andrew Bartlett
(This used to be commit f428ee98d8)
2002-10-03 03:31:41 +00:00
Jeremy Allison
b69d0e39bc Added const. Anal formatting fixup.
Jeremy.
(This used to be commit ae4bf35f94)
2002-10-02 19:11:59 +00:00
Jeremy Allison
a9ccc38c08 Fix Solaris sendfile detection. Add small fixes to sendfile code.
Jeremy.
(This used to be commit ef7bcaf1b7)
2002-10-01 05:55:25 +00:00
Jeremy Allison
7dc8aa0854 Added Solaris sendfile patch + configure tests from Pierre Belanger <belanger@yahoo.com>.
Jeremy.
(This used to be commit 8db4d46dc9)
2002-09-30 21:14:46 +00:00
Jeremy Allison
09507f5315 Don't zero out numwritten before using.... Found by Pierre Belanger belanger@pobox.com
Jeremy.
(This used to be commit a7009ad5c8)
2002-09-30 05:19:43 +00:00
Andrew Bartlett
6b1367a7bc Fix the compile issue in bin/samtest, and make the 'system' token just have the
System sid.  This avoids comparing with ACEs that we don't yet support in the
ADS Domain security descriptor.
(This used to be commit ace7738e12)
2002-09-30 02:28:28 +00:00
Andrew Bartlett
df316e3cd9 Remove sam/api.c.
In order to reduce complexity, this patch removes the upper layer of the SAM
API.  Also, we remove the function pointers on the sam context - there really
is no point making these replaceable - that's for the modules.

Move a number of functions in include/interface.c around to allow for use of
'static' and to keep the external API in one chunk, at the bottem.  All these
functions were renamed to remove the context_sam -> sam

Consequential changes in the samtest module, and back out metze's change for
ACB filtering, becouse I think it belongs in the SAM backeds.  (But I will take
debate on this one).

Changes to the lib/util_sid.c code to create a 'system' token, and make it a
SAM_ASSERT() enforced requirement to have a token on those calls that specify
it.  samtest now uses this.

We should have a samtest call to set your own token.

We also need to extend our se_access code to cover the things that Win2k is
returning in it's access tokens.  Currently our system token doesn't pass, due
to unexpected flags.  (When running sam_ads against Win2k)

Andrew Bartlett
(This used to be commit b9036900d0)
2002-09-29 06:07:58 +00:00
Andrew Bartlett
0a23b0b4d5 Add const.
(This used to be commit f7dd66e88d)
2002-09-28 12:11:19 +00:00
Andrew Bartlett
3cfd42e83b Add const.
(This used to be commit 0f5d18626b)
2002-09-28 00:12:49 +00:00
Andrew Bartlett
5f662896aa Vance picked up a pile of typos etc at the CIFS confernce, and finally got them
off his laptop :-)

Andrew Bartlett
(This used to be commit df8f0338fa)
2002-09-27 05:29:43 +00:00
Andrew Bartlett
55b6cebbd4 Some small cleanups to the libads code (mainly error checking), and give a
sane prototype for the push_utf8_allocate code.

Andrew Bartlett
(This used to be commit ce00a3238e)
2002-09-27 03:05:20 +00:00
Andrew Bartlett
ad514000db Patch from "Stefan (metze) Metzmacher" <metze@metzemix.de> to do a *much*
better job of working with usrmgr.   Previously we were blanking out entires,
and all sort of mischif.

The new patch (which I've now had a chance to test/modify) also takes care not
to expand % values (ie we go \\%L\%U -> \\server\user, we don't want to store
\\server\user back) and to correctly notice 'not set' compared to 'null string'
etc.

Andrew Bartlett
(This used to be commit ab878b6cc4)
2002-09-26 10:25:34 +00:00
Andrew Bartlett
8a3bb8b36b Kill of Get_Pwnam_Modify and smb_getpwnam(). The latter assumes some things
that just don't apply any more - now that we always keep username and domain
seperate.  Also, the policy it was trying to permit is now implemented by the
auth code.

Andrew Bartlett
(This used to be commit 760c0740ca)
2002-09-25 09:55:41 +00:00
Jeremy Allison
b952ddfbe6 Merge of "profile acls" code.
Jeremy.
(This used to be commit cfd1bf250b)
2002-09-25 05:11:25 +00:00
Jeremy Allison
515c1d42ee Merge back Richard's FreeBSD sendfile fixes.
Jeremy.
(This used to be commit f4845b0213)
2002-09-21 08:53:05 +00:00
Jeremy Allison
994638f577 HPUX sendfile is now detected correctly.
Jeremy.
(This used to be commit 91e41ebe97)
2002-09-18 20:07:56 +00:00
Jeremy Allison
8b46126a07 Never, *ever* hold a mutex lock in the message database where there may
be traversals being attempted. Yes, this was from bitter experience (and
an out of control server :-). Also allow callers to break out of a tdb_chainlock
with sigalarm if desired.
Jeremy.
(This used to be commit a7781f91d8)
2002-09-17 23:45:21 +00:00
Jeremy Allison
9bab1d0c1a Actually use sendfile if selected.
Jeremy.
(This used to be commit 5881f0a226)
2002-09-17 19:48:19 +00:00
Jeremy Allison
f74086ccf0 Attempt to make broken Linux sendfile work.... Still in progress.
Jeremy.
(This used to be commit f956a4d29d)
2002-09-17 01:00:03 +00:00
Jelmer Vernooij
479e82b8d8 Put unixsocket calls between #ifdef HAVE_UNIXSOCKET's - required for Stratus VOS
(Double checked)
(This used to be commit dc3c14fc2b)
2002-09-15 17:49:53 +00:00
Jeremy Allison
3f02393bfd Use HAVE_SENDFILE64, not SENDFILE64.
Jeremy.
(This used to be commit 7e2f9769c9)
2002-09-14 01:38:55 +00:00
Jeremy Allison
febd3f929b Added fix for broken Linux (no sendfile64). When offset + count > 2GB
then return ENOSYS and let the upper layer handle it.
Jeremy
(This used to be commit 872dfd87cd)
2002-09-14 00:34:46 +00:00
Jeremy Allison
6cf499ecff Fixed up FreeBSD sendfile code - only Solaris left then I can add the
configure tests...
Jeremy.
(This used to be commit 9dad88e1d4)
2002-09-12 18:18:35 +00:00
Jeremy Allison
8c5f577c6f HPUX takes offset, not pointer to offset.
Jeremy.
(This used to be commit d7024e8cb9)
2002-09-12 06:26:06 +00:00
Jeremy Allison
fdb8c4dfe1 Fixup sendfile to match HPUX semantics with signal interrups. This was
fiddly.... :-(.
Jeremy.
(This used to be commit 2b33a500a8)
2002-09-12 06:24:41 +00:00
Jeremy Allison
4f613ac61e First cut at portable sendfile code. Only used in readX at the moment
and doesn't actually call sendfile. Needs to be vectored through the
VFS and tested on all supported platforms (Solaris/HPUX/FreeBSD/Linux).
Linux doesn't actually work (2.4.19 kernel) at the moment because it
doesn't have a 64-bit clean sendfile.
Jeremy.
(This used to be commit fd772ca7b1)
2002-09-12 02:12:52 +00:00
Andrew Tridgell
cdca2ad1c4 added gencache implementation from mimir - thanks!
(This used to be commit 05a202c287)
2002-09-11 14:07:21 +00:00
Herb Lewis
dc1c14ca22 lowercase global_myname in %L substitution
(This used to be commit 43a39e85b6)
2002-09-09 21:01:53 +00:00
Simo Sorce
ec4f2af04a configure.in:
reflect the new example/VFS/ directory organization

lib/substitue.c:
added helper functions needed by recycle bin
(This used to be commit 29b4b9a2b5)
2002-09-07 04:08:03 +00:00
Andrew Bartlett
df4e6c9bcc As per the 'OK' at CIFS2002, only use the readline headers (and this crasy
#ifdef mess...) in readline.c, we don't need or use them in the rest of Samba.

(This OK was of course conditional on 'if you break it, you better fix it...')

Andrew Bartlett
(This used to be commit 55ee289f58)
2002-09-06 23:10:28 +00:00
Andrew Bartlett
2d88135714 patch from metze: add a 'vfs' debug class
(This used to be commit 601b56e04f)
2002-09-06 11:58:18 +00:00
Jeremy Allison
a1aafce4dc Add bcast_msg_flags to connection struct. Allows sender to filter when
sending broadcast messages. Also initial cut-down of printing notify
messages (not yet finished).
Jeremy.
(This used to be commit aca3337196)
2002-09-04 19:13:06 +00:00
Jelmer Vernooij
d38ab3857f Fix typo - Thanks Kai
(This used to be commit 8fb4534212)
2002-09-02 10:58:03 +00:00
Simo Sorce
098b0b40fe wrong way to handle things, bug found by kai
(This used to be commit 58f912da47)
2002-09-01 10:24:34 +00:00
Andrew Bartlett
7aca67c3e9 Add a bit of 'const' and move a lot of our 'repeditive' DEBUG() statements to
'DEBUGADD', so we don't repeat headers.  (Makes them much easier to read).

(Based on patch by kai)

Andrew Bartlett
(This used to be commit 9deada345c)
2002-08-31 06:59:00 +00:00
Herb Lewis
dd0d4b5270 based on function prototype, the args were switched - this gave an error
on the IRIX compiler. could whoever put the FIXME message take a look and
see if it is still broken.
(This used to be commit 29a8f21211)
2002-08-30 14:05:22 +00:00
Jelmer Vernooij
8e729a4d84 Move samr_make_sam_obj_sd to lib/util_seaccess.c. samtest now compiles and
links successfully!
(This used to be commit 0ea4bcb6b7)
2002-08-29 16:38:43 +00:00
Jelmer Vernooij
b786c9a2ec Make debuglevel a string for use with debug classes
(This used to be commit fc29385029)
2002-08-29 16:35:33 +00:00
Jelmer Vernooij
2b2b0f7119 Put in intermediate version of new SAM system. It's not stable yet, code
might be ugly, etc - please don't blame me for anything but instead try to fix
the code :-). Compiling of the new sam system can be enabled with the
configure option --with-sam

Removing passdb/passgrp.c as it's unused
fix typo in utils/testparm.c
(This used to be commit 4b7de5ee23)
2002-08-28 04:54:43 +00:00
Jelmer Vernooij
61e4ee500f Make const
(This used to be commit b1ab3bec8d)
2002-08-28 04:21:11 +00:00
Tim Potter
f1597ae9d1 Some debugs for panic_action.
(This used to be commit 8f065f788b)
2002-08-28 02:11:24 +00:00
Simo Sorce
8f6c926a8f add a trivial seeking function to xfile (tseek) that does not do SEEK_CUR
and add commands reget and reput to smbclient that continues a transfer that has been onterrupted.

thanks to josef Zlomek that did the original patch.
(This used to be commit b275547c9e)
2002-08-27 09:07:08 +00:00
Andrew Bartlett
2560c73026 Updates!
- Don't print an uninitialised buffer in service.c
- Change some charcnv.c functions to take smb_ucs2_t ** instead of void **
- Update NTLMv2 code to use dynamic buffers
- Update experimental SMB signing code - still more work to do
- Move sys_getgrouplist() to SAFE_FREE() and do a DEBUG() on initgroups()
  failure.

Andrew Bartlett
(This used to be commit de1964f7fa)
2002-08-26 03:08:37 +00:00
Andrew Bartlett
9c7742727a Try to support non-root-mode systems without getgrouplist().
Andrew Bartlett
(This used to be commit 17096315a0)
2002-08-26 00:43:06 +00:00
Andrew Bartlett
014792fc03 Clarify function comments
(This used to be commit a613dde7ed)
2002-08-25 23:33:22 +00:00
Andrew Bartlett
b97a387c0f Patch from mimir to back out idra's attempted DOS mitigation patch.
(It broke port 139 name exchange)

I've been thinking about this, and doing is properly is actually rather
difficult - but I'll try and get somthing in there.  (My worry is what
smb_read_error should be set to, and how that interacts with the rest of
samba).

Andrew Bartlett
(This used to be commit 3e682867bb)
2002-08-25 21:46:49 +00:00
Simo Sorce
f38fc7b3b1 We never checked if the smb packet len is != 0
Should fix a supposed DoS too.
(This used to be commit f76e5b2677)
2002-08-23 15:01:07 +00:00
Andrew Bartlett
548203a0c4 We need to return the value here...
Andrew Bartlett
(This used to be commit 8fbc964f2f)
2002-08-23 12:31:36 +00:00
Andrew Tridgell
89586f0b7c added smb_xstrndup()
(This used to be commit 26fc20187d)
2002-08-22 22:53:33 +00:00
Andrew Tridgell
a10519049e added a useful unistr2 display function
(This used to be commit f458113364)
2002-08-22 22:44:06 +00:00
Tim Potter
3276da4314 Spelling fixes.
(This used to be commit 24fa84bda4)
2002-08-22 09:48:06 +00:00
Gerald Carter
7c4d1ba058 fix a few segfaults
(This used to be commit ccb02f7cfc)
2002-08-22 02:51:32 +00:00
Jelmer Vernooij
d3aa76cef5 Patch from Paul Green <Paul.Green@stratus.com> to be more POSIX-compatible
(This used to be commit addf29e676)
2002-08-21 19:59:23 +00:00
Volker Lendecke
1ea5e17f95 Fix debug level initialization for net.c
Volker
(This used to be commit 5af5326f13)
2002-08-21 11:48:05 +00:00
Jeremy Allison
f744db7a5d IFSTEST fixes for open fid, nametoolong.
Jeremy.
(This used to be commit e53a81261e)
2002-08-20 20:54:32 +00:00
Andrew Tridgell
e6fa31d6cb added a generic print_guid utility, and get the byte order handing
right
(This used to be commit ec2c17c56f)
2002-08-19 16:55:29 +00:00
Jelmer Vernooij
10e7ae7e74 remove 'admin log' parameter (discussed with Jeremy)
remove 'alternate permissions' parameter (deprecated and not used since 2.0) (discussed with tridge)
(This used to be commit 6e34651591)
2002-08-19 15:33:54 +00:00
Andrew Bartlett
8690b271a6 Move tridge's getgrouplist() replacement function from replace.c to a new
'system_smbd.c' file, where it can link with become_root() and unbecome_root(),
and therefore avoiding some nasty 'it workes on linux' bugs.

(The replacement function is implemented in terms of initgroups(), which is
naturally only avaliable to root).

Andrew Bartlett
(This used to be commit a91018dd02)
2002-08-17 07:09:22 +00:00
Andrew Bartlett
ba1d348265 The idea of this function is not to touch the argument, so make it const too...
(This used to be commit 8a63fe4505)
2002-08-17 04:56:38 +00:00
Tim Potter
88d321becd Merge of netbios namecache code from APPLIANCE_HEAD.
Tridge suggested a generic caching mechanism for Samba to avoid the
proliferation of little cache files hanging around limpet like in the
locks directory.  Someone should probably implement this at some
stage.
(This used to be commit dad31483b3)
2002-08-16 00:25:48 +00:00
Simo Sorce
10712f9a22 *** empty log message ***
(This used to be commit cb72eead70)
2002-08-15 13:25:25 +00:00
Jim McDonough
f3a15363d8 Use byteorder.h macros
(This used to be commit eb9004efc3)
2002-08-12 16:39:10 +00:00
Jim McDonough
d8d1d65958 Code to generate uuids for ADS setups. Uses our random generator but
conforms to standard OSF/DCE uuid format.
(This used to be commit 3b50c3b8cd)
2002-08-12 13:48:19 +00:00
Andrew Bartlett
dd5615c042 Make 'remote_machine' private to lib/substitute.c, and fix all the user to use
the new accessor functions.

Andrew Bartlett
(This used to be commit f393de2310)
2002-08-11 02:30:35 +00:00
Andrew Bartlett
6ddba1e99b Fix the %m security bug again - and try to make it harder to reintroduce in
future.

This moves us from fstrcpy() and global variables to 'get' and 'set' functions.

In particular, the 'set' function sainity-checks the input, in the same way as
we always have.

Andrew Bartlett
(This used to be commit e57a896f06)
2002-08-10 23:20:04 +00:00
Andrew Tridgell
4da476001e fixed a memory corruption bug in the wins code
(This used to be commit 3f6ca04003)
2002-08-06 00:56:39 +00:00
Andrew Tridgell
ab0b4e6f58 make sure we zero the unusued elements in a SID when parsing
(This used to be commit aa5beb63f1)
2002-07-31 09:32:45 +00:00
Andrew Tridgell
4516a14dbb added support for smbd listening on port 445 and 139. It now listens
on both by default, and you can specify a list of ports to listen on
either with "smb ports = " in smb.conf or using the -p option to smbd.

this is needed for proper netbiosless operation.
(This used to be commit 5dee0a7b5e)
2002-07-31 04:56:16 +00:00
Andrew Bartlett
01d9beba6c Make some of the charconv code a bit easier to read and work with - when we
are dealing with utf8 we may as well specify char** for the pointer, save
otherwise casting in the caller.

Andrew Bartlett
(This used to be commit 46021f85b6)
2002-07-30 09:21:57 +00:00
Tim Potter
362f534fa1 Our include popt is starting to get a bit old - fixed some compile
problems here.

Also fixed some non-constant initialisers in samsync.
(This used to be commit 33bd721473)
2002-07-29 23:50:54 +00:00
Tim Potter
6eaa06ac53 A place to store common popt routines.
(This used to be commit b5b64a4e90)
2002-07-29 09:23:01 +00:00
Simo Sorce
a4ec4acd61 found nasty bug in intl/lang_tdb.c tdb structure was not tested to not be null before close
this one fixes swat not working with browsers that set more then one language.

along the way implemented language priority in web/neg_lang.c with bubble sort

also changet str_list_make to be able to use a different separator string

Simo.
(This used to be commit 69765e4faa)
2002-07-28 18:10:39 +00:00
Andrew Tridgell
c4fcf56380 good security patch from Timothy.Sell@unisys.com
we could generate short passwords!
samba-patches 880
(This used to be commit 1466acba7e)
2002-07-28 06:08:30 +00:00
Andrew Bartlett
74d235ff1a It seems I didn't need to write a dup2() wrapper - as we already use it a
lot.  But as thats done, we might as well use it anyway.

Andrew Bartlett
(This used to be commit d78cce806d)
2002-07-28 02:20:15 +00:00
Andrew Bartlett
24675d99e5 Make it possible to query account policy values from pdbedit (set to come soon).
Update account_pol.c to use just uint32, rather then uint32 for paramaters,
int32 for storage.  (The int32 functions didn't have seperate return/status
values, uint32 functions use a pointer-paramater).

Move the #define -> string from a swtich to a table, so we can look it up
both ways.

Andrew Bartlett
(This used to be commit c5b5e3d653)
2002-07-24 05:26:32 +00:00
Andrew Tridgell
fef9d6187e implemented getgrouplist() for systems that don't have it and use it
in get_alias_user_groups(). The old method used getgrent() which is
extremely slow when the number of groups is large
(This used to be commit 44e92b6523)
2002-07-23 09:22:29 +00:00
Andrew Bartlett
afb7d1dc48 Another smattering of static and const
(This used to be commit 897cc4a610)
2002-07-21 03:26:10 +00:00
Tim Potter
27211c55e2 Don't try and sys_dup2(dbf->fd) if dbf == NULL.
(This used to be commit 0fd155a06c)
2002-07-20 21:56:26 +00:00
Andrew Bartlett
aff20d822c Add some const to try and get less warnings.
Andrew Bartlett
(This used to be commit 2a3d821c77)
2002-07-20 11:06:37 +00:00
Andrew Bartlett
714abda3e7 Add support for duplicating stderr into our logfiles.
This is for two things:  To allow panic actions etc to pump out backtraces to
stderr and to allow vangrind to put its stuff in a logfile - making it possible
to debug smbd when launched from inetd.

I've also cleaned up some of the duplicate names in procedures between smbd and
nmbd.

Andrew Bartlett
(This used to be commit 4bcb327319)
2002-07-20 07:02:45 +00:00
Andrew Bartlett
b96de65b26 Add a wrapper for dup2() to our system.c
Andrew Bartlett
(This used to be commit b24b6307f6)
2002-07-20 06:50:47 +00:00
Gerald Carter
39bbeff5b3 fixed a logic error in the sorted_tree_find_child() routine
that caused a valid search to fail.  The printing registry
view now works again.
(This used to be commit 2050859f03)
2002-07-20 02:42:04 +00:00
Gerald Carter
3c0a9c46d8 fixed seg fault in registry frontend caused by trying to
use a destroyed TALLOC_CTX*
(This used to be commit 432b9f8d7c)
2002-07-19 22:16:03 +00:00
Jeremy Allison
3c9e5a9416 Never ignore valgrind messages :-). Don't reference before the start
of a string....
Jeremy.
(This used to be commit 35f0fbd254)
2002-07-19 19:56:27 +00:00
Gerald Carter
9fe3bd1259 * refactored registry operations some. subkey lists and
registry values are now passed around in containers
  (REGSUBKEY_CTR & REGVAL_CTR) which each possess a TALLOC_CTX.

* removed subkey_specific_fn() from REGISTRY_OPS.  Is implemented
  in the form of a wrapper

* temporarily broke the printing registry ops.

* implemented inheritence for the data_p of nodes in a SORTED_TREE

* All REGISTRY_KEY instances now store a valid REGISTRY_HOOK since
  the default REGOSTRY_OPS structure is stored in the root of the
  cache_tree.

* Probably some other change I forgot....  T
(This used to be commit e7b55e8f01)
2002-07-19 18:49:44 +00:00
Andrew Tridgell
ce16d9a26d fixed line buffer mode in XFILE
thanks to tim for finding this bug
(This used to be commit 91bff75454)
2002-07-19 04:00:21 +00:00
Jeremy Allison
923a3a0e1c Previous fix was incorrect. len in string_sub and all_string_sub is
number of *bytes*. >= check was correct, the len=0 case needed changing
to len = ls + 1.
Jeremy.
(This used to be commit 06a4a6d30a)
2002-07-18 23:43:33 +00:00