8 Commits

Author	SHA1	Message	Date
Philipp Gesang	0a66c73953	s3-lib: restore truncating behavior of push_ascii_nstring() ... Some users of push_ascii_nstring() (notably name_to_unstring()) expect the output to be truncated if it would exceed the size of an nstring after conversion. However this broke in 2011 due to commit d546adeab5 ("Change convert_string_internal() and convert_string_error() to bool return"). This patch restores the old behavior. The issue can be observed in syslog after setting the ``workgroup`` to a 16+ characters long string which triggers a DEBUG() message: Oct 17 11:28:45 dev nmbd[11716]: name_to_nstring: workgroup name 0123456789ABCDEF0123456789ABCDEF is too long. Truncating to Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com> Reviewed-by: Noel Power <npower@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Noel Power <npower@samba.org> Autobuild-Date(master): Tue Oct 25 16:25:40 UTC 2022 on sn-devel-184	2022-10-25 16:25:40 +00:00
Andrew Bartlett	43deb9745b	s3-lib Remove more unused fstring.c functions ... Signed-off-by: Andrew Tridgell <tridge@samba.org>	2011-04-13 14:47:07 +10:00
Andrew Bartlett	b6a8418ff6	s3-lib: Remove unused pull_ucs2_fstring() ... Signed-off-by: Andrew Tridgell <tridge@samba.org>	2011-04-13 14:47:06 +10:00
Jeremy Allison	c109a70531	Fix convert_string() to take a *converted_size arg. and return a bool. ... Makes these interfaces much harder to misuse and easier to ensure error checking. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 30 23:59:37 CEST 2011 on sn-devel-104	2011-03-30 23:59:37 +02:00
Jeremy Allison	d546adeab5	Change convert_string_internal() and convert_string_error() to bool return. ... Move closer to makeing all convert_string_XXX functions return bool. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 30 20:58:10 CEST 2011 on sn-devel-104	2011-03-30 20:58:10 +02:00
Jeremy Allison	048471d14b	Fix the nstring calls to use the correct sizes.	2011-03-30 10:13:01 -07:00
Andrew Tridgell	232fb016a1	s3-string: removed last use of conv_silent ... This replaces the push_ascii_nstring() implementation with a call to convert_string_error() Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>	2011-03-25 04:37:06 +01:00
Andrew Tridgell	f705fc9002	s3-string: moved fstring functions into their own file ... Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>	2011-03-25 04:37:06 +01:00