Volker Lendecke
80838491e6
s3: Make cli_cm_open return NTSTATUS
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jul 3 23:57:53 CEST 2011 on sn-devel-104
2011-07-03 23:57:53 +02:00
Volker Lendecke
714e1014c5
s3: Make cli_cm_connect return NTSTATUS
2011-07-03 22:45:26 +02:00
Volker Lendecke
7ca63fb8fe
s3: Make "do_connect" return NTSTATUS
2011-07-03 22:45:26 +02:00
Volker Lendecke
3414182af0
s3: Remove a use of cli_errstr
2011-07-03 22:45:25 +02:00
Volker Lendecke
4569a3a75a
s3: Remove a use of cli_errstr
2011-07-03 22:45:25 +02:00
Volker Lendecke
8238d89823
s3: Remove a use of cli_errstr
2011-07-03 22:45:25 +02:00
Volker Lendecke
cfbd339b4a
s3: Remove a use of cli_errstr
2011-07-03 22:45:25 +02:00
Volker Lendecke
e5ad524902
s3: Remove two uses of cli_errstr
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jul 3 12:43:32 CEST 2011 on sn-devel-104
2011-07-03 12:43:32 +02:00
Volker Lendecke
c3a6e9b7ce
s3: RAP errors are WERROR
2011-07-03 11:31:29 +02:00
Volker Lendecke
c0d168392f
s3: Remove some bogus error mappings
...
The old cli_session_request that used this is gone
2011-07-03 11:31:29 +02:00
Volker Lendecke
c31871264c
s3: Allow NULL for arg pwritten in cli_write_andx
2011-07-03 11:31:29 +02:00
Volker Lendecke
25df2fe8e2
S3: Fix some nonempty blank lines
2011-07-03 11:31:29 +02:00
Volker Lendecke
79d27e28ad
s3: Fix symlink_reparse_buffer_parse
2011-07-03 11:31:29 +02:00
Volker Lendecke
c1094a8cb0
s3: Add cli_readlink
2011-07-03 11:31:29 +02:00
Volker Lendecke
bbe8e0bcf4
s3: Add cli_symlink
2011-06-24 21:24:17 +02:00
Volker Lendecke
829974c940
s3: Add symlink reparse point marshalling routines
2011-06-24 21:24:17 +02:00
Volker Lendecke
f0ff6f390a
Use tevent_req_oom
...
This fixes a few Coverity errors
2011-06-20 12:33:24 +02:00
Rusty Russell
ca1936fbb2
tdb_compat: use tdb_open_compat.
...
This is a helper for the common case of opening a tdb with a logging
function, but it doesn't do all the work, since TDB1 and TDB2's log
functions are different types.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
9850f25633
tdb_chainunlock: ignore return value.
...
TDB2 returns void here. tdb_chainunlock will *always* return with the
chain unlocked, but it will complain via the log function if it wasn't
locked.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
868d77bc5b
tdb_chainlock: check returns for 0, not -1.
...
TDB2 returns a negative error number on failure. This is compatible
if we always check for != 0 instead of == -1.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
6bc59d77b6
tdb_store: check returns for 0, not -1.
...
TDB2 returns a negative error number on failure. This is compatible
if we always check for != 0 instead of == -1.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
1078eb21c4
tdb_delete: check returns for 0, not -1.
...
TDB2 returns a negative error number on failure. This is compatible
if we always check for != 0 instead of == -1.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
058c4f8492
tdb_fetch_compat: use instead of tdb_fetch.
...
This is a noop for tdb1.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
0e4c358e27
tdb_compat.h: divert every tdb build and includes to tdb_compat
...
We change all the headers and wscript files to use tdb_compat; this
means we have one place to decide whether to use TDB1 or TDB2.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:34 +02:00
Rusty Russell
20687dcd7b
smb_share_modes: don't use tdb_jenkins_hash.
...
It's a nice hash, but this usage has nothing to do with TDB. So use the
Jenkins hash directly from CCAN instead (it's the same one).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:34 +02:00
Volker Lendecke
9cc68e49ee
s3: Fix Coverity ID 2583: RESOURCE_LEAK
2011-06-19 19:36:27 +02:00
Volker Lendecke
59887edd1d
s3: Remove unused name_queries
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 19 15:14:38 CEST 2011 on sn-devel-104
2011-06-19 15:14:38 +02:00
Volker Lendecke
809e5ea5ba
s3: Fix some type-punned warnings
2011-06-19 14:03:52 +02:00
Volker Lendecke
f811e894c4
s3: Add name_resolve_bcast_send/recv
2011-06-19 14:03:51 +02:00
Volker Lendecke
bc3261f0c5
s3: Fix a memleak in name_resolve_bcast
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 19 12:40:55 CEST 2011 on sn-devel-104
2011-06-19 12:40:55 +02:00
Volker Lendecke
8e02b70767
s3: Add incomplete cli_nttrans_create
...
secdesc only at this moment
2011-06-19 11:08:12 +02:00
Volker Lendecke
ef816f1c4e
s3: Correctly align even
2011-06-19 11:08:12 +02:00
Andrew Tridgell
264409750a
s3-util: remove the s3 nterr.c
...
this is now in common code
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-06-17 17:09:00 +10:00
Andrew Bartlett
1233ba7bf3
libclu/util: Move get_friendly_nt_error_msg() in common.
...
Andrew Bartlett
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-06-17 17:08:59 +10:00
Volker Lendecke
c118bcf755
s3: Use resolve_wins_send/recv in resolve_wins
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 12 18:19:41 CEST 2011 on sn-devel-104
2011-06-12 18:19:41 +02:00
Volker Lendecke
0dfcf3ef78
s3: Add resolve_wins_send/recv
2011-06-12 17:07:48 +02:00
Volker Lendecke
12c3c35596
s3: Add query_wins_list_send/recv
2011-06-12 17:07:48 +02:00
Volker Lendecke
f0994c7495
s3: Fix IO_TIMEOUT handling for wins queries
2011-06-12 17:07:47 +02:00
Volker Lendecke
ebf04d79ab
s3: Remove "struct ip_service" from resolve_wins
2011-06-12 17:07:47 +02:00
Stefan Metzmacher
fdfb5e95fe
s3:libsmb: remove unused cli_state_seqnum infrastructure
...
metze
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jun 10 20:37:54 CEST 2011 on sn-devel-104
2011-06-10 20:37:54 +02:00
Stefan Metzmacher
f0ba1afe5f
s3:libsmb/clireadwrite: calculate cli_write_max_bufsize() correct based on max_xmit
...
This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
73128b7cc7
s3:libsmb/clireadwrite: calculate cli_read_max_bufsize() correct based on max_xmit
...
This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
5d06b2197b
s3:libsmb/clitrans: correctly transfer the seqnum between secondary and primary requests
...
This is needed to implement SMB signing correct.
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
1dd24ac06a
s3:libsmb/clitrans: fix handling of multi pdu [nt]trans[s][2] calls
...
We now keep the primary request open for the whole logical request.
The primary request is the one that gets all incoming replies.
While secondary requests are handled as separate one-way requests.
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
10bb088cf1
s3:libsmb/clitrans: use subreq2 as variable for the secondary requests
...
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
5146c9ba9d
s3:libsmb/clitrans: move MID handling to the end of cli_trans_send() and add a comment
...
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
0a8fd50bd8
s3:libsmb/clitrans: correctly marshall [nt]trans[s][2] requests
...
We need to align params and data to 4 byte offsets.
This also correctly recalculates the useable space after each step.
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
6f7af1b038
s3:libsmb/clitrans: marshall SMBnttrans[2] as the others
...
This is just to make the code more readable
and easier to notice how many words we're using in vwv.
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
428a86c92b
s3:libsmb/clitrans: use uint32_t for param and data variables
...
SMBnttrans uses 32-bit values there.
metze
2011-06-10 19:27:05 +02:00
Stefan Metzmacher
2ae565b681
s3:libsmb/clitrans: remove unused secondary_request_ctx
...
metze
2011-06-10 19:27:05 +02:00