1
0
mirror of https://github.com/samba-team/samba.git synced 2025-07-15 16:59:09 +03:00
Commit Graph

237 Commits

Author SHA1 Message Date
d6a5476ee7 Use sockaddr_storage only where we rely on the size, use sockaddr
otherwise (to clarify we can also pass in structs smaller than
sockaddr_storage, such as sockaddr_in).
2008-10-23 19:53:15 +02:00
aa982895e5 Add data_blob_string_const_null() function that includes the terminating
null byte and use it in Samba 3.

This matches the behaviour prior to my data_blob changes.
2008-10-13 05:20:26 +02:00
304554115a Cleanup of DC enumeration in get_dcs()
This is a fix for a few small inefficiencies/bugs in the get_dcs() path.

* because the third add_one_dc_unique() loop was outside the ADS check all DCs
  returned from the non-sitename lookup were being tacked onto the dc_name_ip
  list twice.
* add_one_dc_unique() now checks if the given IP address already exists before
  adding it to the list, making the returned list actually unique
* added more thorough doxygen comment headers
(This used to be commit cb2d488e1d)
2008-09-04 11:50:25 -07:00
06d0790c07 Fix various build warnings
This fixes various build warnings on our platform. I'm sure I haven't
caught them all, but it's a start.
(This used to be commit 6b73f259cb)
2008-07-22 15:00:48 +02:00
272690bda8 Minor style correction
Set sin[6]_family instead of ss_family in in[6]_addr_to_sockaddr_storage
so that assignments look like they're going to the same place.
(This used to be commit 3d19112f64)
2008-07-08 15:58:19 -07:00
d36434f312 Security fix for CVE-2008-1105: Boundary failure when parsing SMB responses
can result in a buffer overrun.
Jeremy.
(This used to be commit 23b825e9d2)
2008-05-28 09:31:42 -07:00
b6e9fffaa2 increase log level for this failed setsockopt call. EINVAL is a normal error on Solaris when we do this on an already resetted connection.
(This used to be commit 42bc4ff7fd)
2008-04-07 11:49:54 +02:00
f4f0d39bfa Fix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....
Make sure that IPv4 addresses are not enclised in []'s.
(This used to be commit 4ddf58dbdc)
2008-03-26 16:58:27 -05:00
22d7cd6605 Ignore port when pulling IP addr from struct sockaddr_storage.
Linux man page states that getaddinfo() will leave the port
uninitialized when passing in NULL for the service name.  So we
can't really trust that anymore.  I doubt non-default KDC ports
are an issues so just drop the port from the generated krb5.conf.
AIX exhibits this bug the most.
(This used to be commit 36f8bafbd3)
2008-03-24 17:25:13 -05:00
a5e1910f82 Fix Coverity ID 567
Jeremy, please push it if you like it and mark the bug as fixed on the Coverity
site.

Thanks,

Volker
(This used to be commit 2fd2542370)
2008-03-16 12:23:44 -07:00
e9c2515df0 Eliminate tons of build warnings on non-IPV6 system.
Michael
(This used to be commit ee4810099c)
2008-02-29 13:35:16 +01:00
3176392878 Fix some warnings
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
(This used to be commit ad37b7b0ae)
2008-02-25 16:09:26 +01:00
abf8465659 Fix possible close of invalid fd if call to socket() returns -1.
(This used to be commit f7d2f69299)
2008-02-20 17:58:50 -08:00
abe2fd7697 Fix a debug message
(This used to be commit 24aa3518ae)
2008-02-05 22:22:03 +01:00
b42a5d68a3 Convert read_data() to NTSTATUS
(This used to be commit af40b71023)
2008-02-02 11:03:23 +01:00
88c27f83d4 Convert receive_smb_raw to NTSTATUS
(This used to be commit ba771bd858)
2008-02-02 11:03:23 +01:00
6ddfa6ae77 read_socket_with_timeout_ntstatus->read_socket_with_timeout
(This used to be commit 90554799af)
2008-02-02 11:03:22 +01:00
5e43eeb1b6 Get rid of read_socket_with_timeout
(This used to be commit f9c8ac83ff)
2008-02-02 11:03:22 +01:00
9f6e983d0b Convert read_smb_length to return NTSTATUS
(This used to be commit 5750c3a51b)
2008-02-02 11:03:21 +01:00
0afbfa4284 Convert read_smb_length_return_keepalive to return NTSTATUS
(This used to be commit 73a79a957a)
2008-02-02 11:03:21 +01:00
3e5b98555b Convert read_smb_length_return_keepalive to read_socket_with_timeout_ntstatus
(This used to be commit 59e8f22f36)
2008-02-02 11:03:21 +01:00
3f970f91c2 Add read_socket_with_timeout_ntstatus
(This used to be commit 546ca0414a)
2008-02-02 11:03:21 +01:00
680a0f0c69 Fix a typo
(This used to be commit 1efdef08ae)
2008-02-01 23:32:51 +01:00
e2ad28509c Tiny simplification
(This used to be commit e78f6872bf)
2008-01-25 20:55:51 +01:00
31a6f80784 Remove a pointless while loop
(This used to be commit f591bd68ea)
2008-01-25 20:55:51 +01:00
9344628bef More read_data -> read_socket_with_timeout
(This used to be commit f1d7de462c)
2008-01-24 09:41:22 +01:00
a925a53f61 read_socket_with_timeout has timeout=0 handling
(This used to be commit 7101026061)
2008-01-23 17:09:10 +01:00
36e3e75e06 util_sock: Don't return a pointer to freed memory.
Fix a bug in my bugfix. Thanks to vl for spotting that one.
(This used to be commit 24f68b90cc)
2008-01-21 18:02:24 +01:00
7b6a439efe util_sock: Fix memcache bug in get_mydnsfullname.
get_mydnsfullname relied on memcache_add(); memcache_lookup() working.
When run from ntlm_auth, the global_cache variable in memcache is NULL, so
the add and lookup both fail. In that case, just return the result of the
getaddrinfo call.

Jeremy, please check.
(This used to be commit 1db41ff525)
2008-01-21 13:28:06 +01:00
bd8abea49f Fix IPv6 bug #5204, which caused krb5 DNS lookups
for a name '[<ipv6 addr>'.
Jeremy.
(This used to be commit f2aa921505)
2008-01-16 13:21:46 -08:00
9254bb4ef1 Refactor the crypto code after a very helpful conversation
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
(This used to be commit c4e5a50504)
2008-01-04 12:56:23 -08:00
149e86b842 Trivial simplification
... things you come across when you review code
(This used to be commit 1e006bcfb1)
2008-01-03 10:24:45 +01:00
cc957c7f6d Convert the little caches in util_sock.c to use
the singleton memcache. Vl please check (passes
make valgrindtest).
Jeremy.
(This used to be commit a4d613cde8)
2008-01-02 17:37:39 -08:00
afc93255d1 Add SMB encryption. Still fixing client decrypt but
negotiation works.
Jeremy.
(This used to be commit d78045601a)
2007-12-26 17:12:36 -08:00
daba3f8b54 Fix connect(2) callers to use correct sockaddr size.
Some systems (eg Mac OSX 10.5) require the length passed to match
the socket address family. This introduces sys_connect() that does
the right thing, and replaces all uses oc connect(2) with sys_connect().

Note that there are some LGPL callers that still call connect(2)
directly.
(This used to be commit e1bfdc17c4)
2007-12-09 13:28:00 -08:00
42cfffae80 Remove next_token - all uses must now be next_token_talloc.
No more temptations to use static length strings.
Jeremy.
(This used to be commit ec003f3936)
2007-12-07 17:32:32 -08:00
dc9237d231 Doh ! Don't use #else when #endif is needed.
Jeremy.
(This used to be commit a04e916b89)
2007-11-21 10:31:18 -08:00
e68bbe3548 Add set_sockaddr_port function for winbindd.
Jeremy.
(This used to be commit 4b47052694)
2007-11-21 10:10:52 -08:00
acb829ecc3 Add MAX_DNS_NAME_LENGTH, remove more pstrings.
Jeremy.
(This used to be commit a1725f4ff7)
2007-11-15 18:27:26 -08:00
91c1933e67 Remove a pstring.
Jeremy.
(This used to be commit c0412b5d13)
2007-11-11 21:45:55 -08:00
d40e47db4b Remove more fstring/pstring bad useage. Go talloc !
Jeremy.
(This used to be commit 2a0173743d)
2007-11-08 17:25:45 -08:00
e501c0cd44 Unify the name and addr cache for client_name to
make threading easier ultimately.
Jeremy.
(This used to be commit 48e0725cd6)
2007-11-07 12:48:58 -08:00
36441da424 Remove the horror that was the global smb_rw_error.
Each cli struct has it's own local copy of this variable,
so use that in client code. In the smbd server, add one
static to smbd/proccess.c and use that inside smbd. Fix
a bunch of places where smb_rw_error could be set by
calling read_data() in places where we weren't reading
from the SMB client socket (ie. winbindd).
Jeremy.
(This used to be commit 255c2adf7b)
2007-11-05 11:12:56 -08:00
536a9e7922 Don't alloc struct iface_struct nics[MAX_INTERFACES]; (128 entries)
on the stack - use talloc.
Jeremy
(This used to be commit b5e37af251)
2007-11-04 22:20:04 -08:00
6a2a27076f This should really be a cond_set_smb_read_error().
Jeremy.
(This used to be commit 5ab76b58c0)
2007-11-04 22:14:19 -08:00
85ff0b2d75 Don't use 0 when we mean SMB_READ_OK.
Jeremy.
(This used to be commit 08ee4314a9)
2007-11-04 22:12:31 -08:00
5b0b4f23ef Remove most of the remaining globals out of lib/util_sock.c.
I have a plan for dealing with the remaining..... Watch
this space.
Jeremy.
(This used to be commit 963fc76852)
2007-11-03 23:20:10 -07:00
51a0354d75 Remove more static data from lib/util_sock.c and
callers.
Jeremy.
(This used to be commit 35aaa36f82)
2007-11-03 22:34:46 -07:00
56aa420195 Missed one case where I need to pass down addrlen.
Jeremy
(This used to be commit 62b5ca3334)
2007-11-03 20:27:59 -07:00
25074433f4 I can't get away without a 'length' arg. :-).
Jeremy.
(This used to be commit 95d01279a5)
2007-11-03 18:41:26 -07:00