1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-30 13:18:05 +03:00
Commit Graph

2151 Commits

Author SHA1 Message Date
Gerald Carter
c992f66d73 adding some initiaial code to sert %a to Win2K3 (using Native LanMan string from .NET RC2)
(This used to be commit 4c823e61d1)
2003-03-12 15:40:43 +00:00
Jeremy Allison
0a2d131a35 We use unsigned now, so use %u.
Jeremy.
(This used to be commit 01727b0296)
2003-03-11 20:57:41 +00:00
Jeremy Allison
77916f652f Fix up zero termination. Spotted by Sebastian Krahmer <krahmer@suse.de>.
Jeremy.
(This used to be commit 69becdb563)
2003-03-11 18:10:36 +00:00
Andrew Bartlett
8cad904f38 Don't segfault on make_server_info_guest() failure - instead return the
error code.

make_server_info_guest() requires an entry in the SAM at the moment, but
this will change before release.

Andrew Bartlett
(This used to be commit 6a956390fa)
2003-03-10 12:08:32 +00:00
Andrew Bartlett
01289b14a7 Make sure that the 'remote' machine name can only be set once. For some weird
reason, during a Win2003 installation, when you select 'domain join' it sends
one machine name in the name exchange, and litraly 'machinename' during the
NTLMSSP login.

Also fix up winbindd's logfile handling, so that it matches smbd and nmbd.

(This helps me, by seperating the logs by pid).

Andrew Bartlett
(This used to be commit afe5a3832f)
2003-03-08 10:22:50 +00:00
Jeremy Allison
7b2409214f Fix typo in earlier fix, caught by Ranjit @ HP.
Jeremy.
(This used to be commit 13ab94fa73)
2003-03-08 01:16:30 +00:00
Jeremy Allison
eed8772da1 Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.
Jeremy.
(This used to be commit c0930e6d15)
2003-03-07 23:34:55 +00:00
Jeremy Allison
24c95539d5 Missed parentheses around complex logic.
Jeremy.
(This used to be commit e81427c2d6)
2003-03-07 19:46:51 +00:00
Jeremy Allison
6a141b7963 Patch from Michael Steffens. In his own words :
-------------------------------------------------------------------------
I think there are basically two problem:

  1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
     and SMB_ACL_OTHER.
     The function ensure_canon_entry_valid() is prepared for that, but tries
     to "guess" values from group or other permissions, respectively, otherwise
     falling back to minimum r-- for the owner. Even if the owner had full
     permissions before setting ACL. This is the problem with W2k clients.

  2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
     This is ok in a take-ownership situation, but must fail if the file is
     to be given away. This is the problem with XP clients, trying to transfer
     ownership of the original file to the temp file.

The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.

I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:

  1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
     as "preserve current value" instead of attempting to build one ourself.
     The original code is still in, but only as fallback in case current values
     can't be retrieved.

  2. Rearrange set_nt_acl() such that chown is only done before setting
     ACLs if there is either no change of owning user, or change of owning
     user is towards the current user. Otherwise chown is done after setting
     ACLs.

It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
(This used to be commit 8ec20cbae7)
2003-03-07 19:37:27 +00:00
Jeremy Allison
cea6fd0b0a Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.
Jeremy.
(This used to be commit 1cbd53dc3c)
2003-03-07 00:34:43 +00:00
Jeremy Allison
3327f13795 Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parameters
differently to W2K, cope with this.
Jeremy.
(This used to be commit 172f415c9e)
2003-03-07 00:30:29 +00:00
Andrew Bartlett
6684c85714 more off-by-one safe_strcpy()
(This used to be commit d8d2d5e755)
2003-03-06 08:24:39 +00:00
Andrew Bartlett
7f15d5828f Another pstrcpy() into malloc()ed buffer fix.
Andrew Bartlett
(This used to be commit bd0c84d60b)
2003-03-03 23:53:35 +00:00
Jeremy Allison
6a58faf462 Const warning fixes.
Jeremy.
(This used to be commit 3ad62ebe26)
2003-03-03 20:12:07 +00:00
Andrew Tridgell
9043696121 i forgot to commit the privilege db init call
(This used to be commit e8ec2b1180)
2003-03-01 10:47:38 +00:00
Gerald Carter
17c417e6e6 don't forget the NULL
(This used to be commit f806101204)
2003-02-27 23:52:37 +00:00
Gerald Carter
3a7d807ec9 and the winner of "i should have just written it in assembly
is..."

don't use pstrcpy() when you are not dealing with pstrings.
(This used to be commit 7d547f50f9)
2003-02-27 23:24:26 +00:00
Gerald Carter
dc1cd583cb don't pass NULL pointers to strcmp()
(This used to be commit 6631984b12)
2003-02-27 21:37:54 +00:00
Gerald Carter
97e7d2ffae additional fix for CR 601
* distinguish WinXP from Win2k
  * add a 1/3 of a second delay in OpenPrinter
    in order to trigger a LAN/WAN optimization in
    2k clients.
(This used to be commit 96570699d1)
2003-02-27 21:21:02 +00:00
Jelmer Vernooij
d21b15ff57 - Rename 'modules = ' to 'preload modules = '
- Add smb_probe_module()
- Add init_modules()
- Call these functions
(This used to be commit f8f2165322)
2003-02-27 01:54:41 +00:00
Jeremy Allison
f6f76ad5ed Fix to allow blocking lock notification to be done rapidly (no wait
for smb -> smb lock release). Adds new PENDING_LOCK type to lockdb
(does not interfere with existing locks).
Jeremy.
(This used to be commit 22fc0d48ff)
2003-02-27 00:43:23 +00:00
Gerald Carter
7c7d796b6d Progress on CR 601
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.

Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
(This used to be commit 33c7b75225)
2003-02-25 20:51:23 +00:00
Andrew Bartlett
eb64538dba Patch from Luke Howard to add mutual kerberos authentication, and SMB session
keys for kerberos authentication.

Andrew Bartlett
(This used to be commit 8b798f03db)
2003-02-24 11:09:21 +00:00
Andrew Bartlett
7e110f782a More signed/unsigned fixes (yes, I run with funny compiler options) and
make x_fwrite() match fwrite() in returning a size_t.

Andrew Bartlett
(This used to be commit 2943c69578)
2003-02-22 12:22:06 +00:00
Jeremy Allison
2935d15376 Added comments to make it clearer when we're assigning a pointer that it
must not be freed afterwards.
Jeremy.
(This used to be commit 80bad908c0)
2003-02-21 06:25:39 +00:00
Tim Potter
9383d61f6c Fixed compiler warning.
(This used to be commit b3f9cf8c1c)
2003-02-21 04:47:24 +00:00
Andrew Bartlett
512405321a Like for NTLM logins, lookup the 'winbind' user first, then the 'local' user.
This needs to change, to be a SID->UID lookup from the PAC.

Andrew Bartlett
(This used to be commit 4071ed06a0)
2003-02-20 10:50:09 +00:00
Jeremy Allison
673cdea310 Fix inspired by Stefan (metze) Metzmacher - cache the sidtype also.
Jeremy.
(This used to be commit 634f20dff6)
2003-02-19 22:30:57 +00:00
Andrew Bartlett
9e3198cca7 Fix logfile formatting, we were missing a "\n"
(This used to be commit 53b8f8a441)
2003-02-19 11:30:09 +00:00
Jeremy Allison
b63edf9a28 Fix from Corny.Bondad@hp.com for missing if (setting_acls) on default
perms.
Jeremy.
(This used to be commit ac96fa173c)
2003-02-19 02:34:33 +00:00
Andrew Bartlett
cc0202884b This patch fixes one of my longest-standing pet hates with Samba :-).
When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.

I'm sure this will fix some nasty performance issues, particularly on large
domains etc.  In particular, this avoids contacting winbind at all, if the
group is not a winbind group.

(This caused a deadlock on my winbind-on-PDC setup).

The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.

Andrew Bartlett
(This used to be commit 9be21976f7)
2003-02-17 12:27:34 +00:00
Jeremy Allison
bf6dfb26e9 Added code based on Michael Steffens <michael.steffens@hp.com> uid/gid
caching code. Reduces load on winbindd. Probably should be moved to
use gencache at some future date.
Jeremy.
(This used to be commit 19f577e23b)
2003-02-12 23:51:05 +00:00
Jeremy Allison
b792454963 Correctly return access denied on share mode deny when we can't open the
file. This is a regression that was damaged by other code.
Jeremy.
(This used to be commit 5cdc957ea6)
2003-02-12 01:12:33 +00:00
Andrew Tridgell
8c60a408e1 add a note about relative opens with blank paths - its a re-open!
(not implemented yet)
(This used to be commit bceac9cdde)
2003-02-12 00:41:35 +00:00
Jeremy Allison
cc99ea0ef0 Fix delete on close semantics to match W2K. I (think:-) I understand it now :-).
Thanks to Nir Livni <nirl@cyber-ark.com> for giving me the test case to
track it down.
Jeremy.
(This used to be commit c98ebb3031)
2003-02-11 02:24:45 +00:00
Andrew Bartlett
ec7a1994b0 Some cleanups:
- Don't use pstrcpy into an allocated string - use safe_strcpy() directly
instead.

- Keep a copy of the 'server_info' attached to the vuid.  In future use this
for things like the session key, homedir and full name instead of current
copies.

- Try to avoid memory leak/segfault on Realloc failure

- clear up #endif comments

Andrew Bartlett
(This used to be commit 162477bb08)
2003-02-10 09:16:05 +00:00
Gerald Carter
36657d41ce check pointer before dereferencing it
(This used to be commit 786d91d75c)
2003-02-07 16:20:58 +00:00
Andrew Tridgell
4dc434c804 make sure we don't run over the end of 'name' in unix_convert()
Thanks to Andrew Bartlett for spotting this.
(This used to be commit b4c210ccb0)
2003-02-07 04:01:36 +00:00
Jeremy Allison
15fda89ab6 Check for too many processes *before* the fork.
Jeremy.
(This used to be commit dfb596b012)
2003-02-05 21:17:12 +00:00
Andrew Bartlett
89152846b7 Patch from Edmund Lam <epl@unimelb.edu.au> to fix braindead Tru64 behaviour:
Apparently acl_type is #defined to acl_common.entry_type in their acl.h....

Andrew Bartlett
(This used to be commit 3dfdaa0208)
2003-02-04 08:26:04 +00:00
Jeremy Allison
349c83f243 Ensure we only ever set fsp->conn in one place.
Jeremy.
(This used to be commit 2110901b38)
2003-02-04 01:43:11 +00:00
Jeremy Allison
3e822dd2c6 Ensure Samba passes the open attribute truncate tests in smbtorture.
Jeremy.
(This used to be commit 651db9f242)
2003-02-04 01:11:33 +00:00
Simo Sorce
a3a1ce50e0 untest fix for wide links parameter bug.
it work properly on 2.2 and the patch apply so I think it should be ok.
(This used to be commit 36b2f6c932)
2003-02-02 18:08:43 +00:00
Andrew Bartlett
95a604f5df Non-error connection numbers are always positive
(This used to be commit 69e94440cd)
2003-02-01 06:24:07 +00:00
Jeremy Allison
b102e79e75 Add 3 second timeout when terminating server and sending print notify
messages. Stops build-up of large numbers of smbd's waiting to terminate
on large print throughput.
Jeremy.
(This used to be commit 4ae130bfa8)
2003-01-30 23:55:13 +00:00
Jeremy Allison
f26591b3de Fix for interesting resource constraint condition. When all opens are
level 2 and a request for open with no oplock is received then the
smbd should send *synchronous* break messages, not asynchronous,
otherwise it spins very rapidly, releasing the lock, sending the
'break to none' messages and then re-acquiring the lock before
any other process has a chance to get the lock and remove it's own
oplock (at least on linux).
Jeremy.
(This used to be commit d1e8991a76)
2003-01-30 01:42:08 +00:00
Andrew Bartlett
6b84af6421 As per a comment by herb a little while back, this should be >=, not == to keep
identical behaviour with previous versions
(This used to be commit 7cbb194b58)
2003-01-28 11:51:55 +00:00
Andrew Bartlett
0041b2c46e The previous patch (NTLMSSP common code factoring) was missing a minor detail -
testing :-).  This gets the 'signiture' after the extended security blob,
rather than over the top of it.

Also move that code to the top of the file, with some of the other util functions.

Andrew Bartlett
(This used to be commit e5c67a0124)
2003-01-28 05:13:07 +00:00
Andrew Bartlett
dc4bb3bed8 Factor out common code in the NTLMSSP/SPNEGO code.
The idea here is to seperate, as much as possible, the SPNEGO layer from the
NTLMSSP layer.  This not only helps us with protocol correctness, but also
should allow further mechinisms to be added with relitive ease.  I indend to
make the kerberos code use this shortly.

I've never seen the 'zero length blob' form of the anonymous login, so I've
removed that case.

Andrew Bartlett
(This used to be commit a8773c9f82)
2003-01-28 03:37:14 +00:00
Gerald Carter
99bb7dccb2 performance patch from HP-UX folks (cant remember who)
(This used to be commit 9180e2d062)
2003-01-28 02:14:33 +00:00
Tim Potter
bb3bf8d3f4 Merge of increment_smbd_process_count() fix from appliance.
(This used to be commit c39c54e6b6)
2003-01-24 04:04:49 +00:00
Tim Potter
644d31ae25 Merge of max log file fixes from appliance:
- smbd/process.c: check log file sizes more often than in
       timeout_processing()

 - lib/debug.c: increment debug_count inside Debug1() instead of
       when log file sizes are checked.
(This used to be commit 303710c206)
2003-01-23 03:02:08 +00:00
Jeremy Allison
074c99a852 Fix reference count bug where smbd's would not terminate with no
open resources.
Jeremy.
(This used to be commit 0173d6fe16)
2003-01-17 06:35:33 +00:00
Tim Potter
f1ffe1b1dc Remove unused variable in reply_spnego_ntlmssp_ok
(This used to be commit 60c13a7675)
2003-01-17 01:08:09 +00:00
Andrew Bartlett
d92b21280e Updates to the NTLMSSP code again - moving the base64 decode fuctionality out
of the SWAT code, and adding a base64 encoder.

The main purpose of this patch is to add NTLMSSP support to 'ntlm_auth', for
use with Squid.  Unfortunetly the squid side doesn't quite support what we need
yet.

Changes to winbind to get us the info we need, and a couple of consequential
changes/cleanups in the rest of the code.

Andrew Bartlett
(This used to be commit fe50ca8f54)
2003-01-16 03:29:54 +00:00
Tim Potter
9184bf744b Removed level 0 DEBUG leftover from testing.
(This used to be commit 7ed8046d04)
2003-01-15 22:15:07 +00:00
Gerald Carter
5fb5950258 small merges from SAMBA_3_0; mostly typos, renames, etc...
(This used to be commit 9ac196dad4)
2003-01-15 18:31:46 +00:00
Andrew Bartlett
58fe4d9c20 Refactor the NTLMSSP code again - this time we use function pointers to
eliminate the dependency on the auth subsystem.  The next step is to add
the required code to 'ntlm_auth', for export to Squid etc.

Andrew Bartlett
(This used to be commit 9e48ab86da)
2003-01-15 12:52:38 +00:00
Gerald Carter
74d4198a9c [merge] removing unused variable and unused file
(This used to be commit 099e844571)
2003-01-14 23:55:14 +00:00
Gerald Carter
05edd278c2 make -i flag work lik eit did in 2.2
(This used to be commit 54b054c1ed)
2003-01-14 15:52:45 +00:00
Andrew Tridgell
6d030555a1 query_alt_name takes a forced unicode string in win2000. It is not
null terminated.

Thanks to Metze for finding this.
(This used to be commit e4ce26332b)
2003-01-14 02:51:37 +00:00
Andrew Bartlett
e3293c7181 Updates to our NTLMSSP code:
This tries to extract our server-side code out of sessetup.c, and into a more
general lib.  I hope this is only a temporay resting place - I indend to
refactor it again into an auth-subsystem independent lib, using callbacks.

Move some of our our NTLMSSP #defines into a new file, and add two that I found
in the COMsource docs - we seem to have a double-up, but I've verified from
traces that the NTLMSSP_TARGET_TYPE_{DOMAIN,SERVER} is real.

This code also copes with ASCII clients - not that we will ever see any here,
but I hope to use this for HTTP, were we can get them.  Win2k authenticates
fine under forced ASCII, btw.

Tested with Win2k, NTLMv2 and Samba's smbclient.

Andrew Bartlett
(This used to be commit b6641badcb)
2003-01-13 12:48:37 +00:00
Andrew Bartlett
9742f673fd Ensure we do not pass uninitialised data to the kernel. (Picked up by
valgrind).

Andrew Bartlett
(This used to be commit f8d9880c5f)
2003-01-13 08:09:32 +00:00
Andrew Bartlett
e009abb20a Oops, this is the change to use an fstring for the incoming service buffer -
the commit to reply.c just matches a pstrcpy for the pstring.  (harmless, fixes
it for the automated test).

Andrew Bartlett
(This used to be commit ef9c7586ac)
2003-01-12 11:31:03 +00:00
Andrew Bartlett
ebb60c0302 Make the 'service' in make_connection() use an fstrcpy(), and an fstring,
becouse that is what it's input (reply_tcon_and_x) uses, and becouse we really
don't want supprises for service names.

Also remove a legacy #define, in favor of the lp_ equiv.

Andrew Bartlett
(This used to be commit 7854a439ac)
2003-01-12 11:29:02 +00:00
Andrew Bartlett
1a6e78fda3 Remove an unused paramter for our old LM-only password change code, and fix a
(harmless) fstring/pstring mixup.

Andrew Bartlett
(This used to be commit 5ff5f540cc)
2003-01-11 12:13:03 +00:00
Andrew Bartlett
674c750df7 No point having this for both parts of the 'if' statement.
Andrew Bartlett
(This used to be commit 3b2e5f68cd)
2003-01-11 03:23:16 +00:00
Gerald Carter
47873e781d [merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491
(This used to be commit 142c5029c7)
2003-01-11 02:29:23 +00:00
Tim Potter
c4b4386996 Remove read_with_timeout() and replaced its only caller (the passwd chat
stuff) with a call to read_socket_with_timeout() which does the same thing.

Passwd chat still works but I couldn't figure out the right arguments to
passwd chat to get it to work right but data was definitely getting
through.
(This used to be commit 88eb9e9486)
2003-01-09 06:58:07 +00:00
Tim Potter
642fad95ef Moved smbd process counting functions from smbd/server.c to smbd/process.c
so that bin/vfstest can link.
(This used to be commit 812ce0368c)
2003-01-09 05:49:51 +00:00
Jeremy Allison
619fcbdb68 Ensure we return disk full by default on short writes.
Jeremy.
(This used to be commit 6a2b7fd82c)
2003-01-08 23:49:37 +00:00
Jeremy Allison
65195b4d54 Ensure we don't get an invalid number for total smbd's if the tdb update
fails.
Jeremy.
(This used to be commit 99e69fd74d)
2003-01-08 21:42:43 +00:00
Jeremy Allison
8df73edd8e Fix erroneous free of SAM_ACCOUNT (make clearer when allocated
memory is being returned).
Jeremy
(This used to be commit b0d547b739)
2003-01-08 07:02:18 +00:00
Jeremy Allison
f420f75508 Fix open problem with changing attributes on an existing file - based
on work by  <steve@griffin.sio2.nl>.
Jeremy.
(This used to be commit 465d86d95f)
2003-01-08 02:09:14 +00:00
Tim Potter
33e019a0c5 Remove unused variable.
(This used to be commit 4bc82624f6)
2003-01-07 03:31:52 +00:00
Jeremy Allison
be0ff9d809 Fix memory leaks in pdb_ code.
Jeremy.
(This used to be commit ddf741c717)
2003-01-06 21:48:43 +00:00
Andrew Bartlett
cfe7718e9a Fix a segfault when we don't correctly load a VFS module (don't keep it in
the loaded list on error).  Also change some of the error returns, becouse
NT_STATUS_UNSUCCESSFUL gives a most useless error message on the client.

As for which error, my logic is that a share without a valid VFS module is
not a valid share, and therefore should return the same error as a non-existant
share.

Andrew Bartlett
(This used to be commit 41178afdbd)
2003-01-06 06:15:34 +00:00
Andrew Bartlett
ef553ab814 Even when I can't manage to do QA, at least the build farm will catch some of
the silly stuff.

(fixes password changes from RAP based clients like smbpasswd)

Andrew Bartlett
(This used to be commit 066e4f9a4b)
2003-01-05 04:59:42 +00:00
Jeremy Allison
a26f2fbe2b Fix problem with "hide unreadable". stat file opens are baaack :-).
Jeremy.
(This used to be commit 6e0cfec165)
2003-01-03 19:07:26 +00:00
Gerald Carter
df4af79c78 patch to include support for daemontools from Michael Handler
(This used to be commit 4c48c475a2)
2003-01-03 17:32:11 +00:00
Jeremy Allison
1afa539299 pstring/fstring missmatches found by Andrew Bartlett.
Jeremy.
(This used to be commit 585a73b810)
2003-01-02 20:43:27 +00:00
Andrew Bartlett
81c6415aa1 Becouse these functions return a size_t, they can't return negitive numbers.
So a < 0 check is pointless, instead check against -1, which will be cast to
unsigned.

Andrew Bartlett
(This used to be commit c7e5797a95)
2003-01-02 13:01:44 +00:00
Andrew Bartlett
6d66fb308a BIG patch...
This patch makes Samba compile cleanly with -Wwrite-strings.
 - That is, all string literals are marked as 'const'.  These strings are
always read only, this just marks them as such for passing to other functions.

What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables).  The rest
is just adding a lot of 'const'.

As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).

Andrew Bartlett
(This used to be commit 92a777d0ea)
2003-01-02 09:07:17 +00:00
Andrew Bartlett
60f9614400 Move our password change code along a little - use NTSTATUS, and implmenet
minimum password age and min password length for all password changes.

Andrew Bartlett
(This used to be commit 028f808c03)
2003-01-01 04:19:34 +00:00
Simo Sorce
2eb7a80a46 fix for bad check spotted by Ray Simard <ray@sylvan-glade.com>
(This used to be commit 63a669475b)
2002-12-31 10:23:37 +00:00
Shirish Kalele
ab42271cd6 Add msdfs proxy functionality to HEAD.
(This used to be commit 9df93b1ffc)
2002-12-29 23:29:08 +00:00
Jeremy Allison
7f23546730 Forward port the change to talloc_init() to make all talloc contexts
named. Ensure we can query them.
Jeremy.
(This used to be commit 842e08e52a)
2002-12-20 20:23:06 +00:00
Jeremy Allison
72e16f233d Fix for old DOS client when veto files is set to /.*/
Jeremy.
(This used to be commit 636ab292db)
2002-12-13 19:07:25 +00:00
Jeremy Allison
120ead2f94 Added "kernel change notify" boolean to allow easier valgrind testing.
Jeremy.
(This used to be commit ac856fbb96)
2002-12-12 02:01:53 +00:00
Jeremy Allison
7dd847ba9c Fixed auth module code. Added VALGRIND defines to reduce spurious warnings.
Jeremy.
(This used to be commit ff3a8d3728)
2002-12-11 23:54:46 +00:00
Jeremy Allison
76e685e628 The element in fsp->print_job should be a RAP jobid, not a uint32 RPC
jobid. This was causing Win9x client "set name" calls to fail.
Still need one cleanup fix to finish.
Jeremy.
(This used to be commit 15f0bad1fc)
2002-12-05 03:59:56 +00:00
Tim Potter
bb2aa240de Remove FILE_MACRO as __FILE__ is ANSI C.
(This used to be commit 2a9d183cf6)
2002-12-04 23:57:15 +00:00
Jeremy Allison
39734e2be8 Added Volker's directory fix - save the attributes
from the first call.
Jeremy.
(This used to be commit 2fe7504a08)
2002-12-04 22:48:25 +00:00
Gerald Carter
4ba8936707 change_trust_account_password() must always use the PDC for rpc
password changes.

jerry
(This used to be commit 974822526f)
2002-12-04 20:13:29 +00:00
Jeremy Allison
a6a0b156bd Need brackets around macro args. Spotted by Patrick Welche <prlw1@newn.cam.ac.uk>.
Jeremy.
(This used to be commit 51c2cf3a9c)
2002-12-04 18:44:21 +00:00
Jeremy Allison
d67ec06b7b Missed the removal of the incorrect ifdef.
Jeremy.
(This used to be commit 9cfa245bba)
2002-12-04 03:21:18 +00:00
Jeremy Allison
9dc3ec5af3 Fix for 64 bit issues with oplocks and allocation size.
Jeremy.
(This used to be commit 4a9c995e50)
2002-12-04 03:12:28 +00:00
Jeremy Allison
e7f2ae9c7f Reformat of reply.c before Volker's patch.
Jeremy.
(This used to be commit d41858b9e6)
2002-12-03 23:57:55 +00:00
Jeremy Allison
9a0b6a2273 Fixed nasty bug where file writes with start offsets in the range
0x80000000 -> 0xFFFFFFFF would fail as they were being cast
from IVAL (uint32) to SMB_OFF_T (off_t or off64_t, both *signed* types).
The sign extension would cause the offset to be treated as negative.
Thanks to Herb for helping me track this one down (IRIX is good for large
file tests :-).
Jeremy.
PS. That horrid EXEXIST thing has broken configure.....
(This used to be commit fc7d3faed7)
2002-12-03 08:02:21 +00:00
Andrew Bartlett
a65dc990f8 As per Jeremy's request back this out, so as to re-gain the implicit length
check.

Andrew Bartlett
(This used to be commit 323088259f)
2002-12-01 19:52:09 +00:00