1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

23361 Commits

Author SHA1 Message Date
Günther Deschner
0dac766109 Fix IDL for winreg_QueryValue.
Guenther
2008-03-25 10:54:27 +01:00
Gerald (Jerry) Carter
36f8bafbd3 Ignore port when pulling IP addr from struct sockaddr_storage.
Linux man page states that getaddinfo() will leave the port
uninitialized when passing in NULL for the service name.  So we
can't really trust that anymore.  I doubt non-default KDC ports
are an issues so just drop the port from the generated krb5.conf.
AIX exhibits this bug the most.
2008-03-24 17:25:13 -05:00
Gerald (Jerry) Carter
6e9287c5c3 Fix libtdb some to move back towards allowing out of tree builds
Remaining problem is that not all *.syms linker scripts are generated
so the LD command needs to look in a single place.  Out of tree
builds now work but report write access to the source tree in order
to create the $(srcdir)/expotrs/libtdb.sysms file.
2008-03-24 17:25:13 -05:00
Eric Cronin
f19d1e3d93 Missing HAVE_UPDWTMPX check before using updwtmpx().
In 10.5 Mac OS X added enough utmpx support to make it past the
first two preprocessor checks around line 390 of src/smbd/utmp.c
and on to the utmpx block which uses updwtmpx().  Unfortunately,
as ./configure correctly surmised, 10.5 doesn't have that.

https://bugzilla.samba.org/show_bug.cgi?id=5184
2008-03-24 12:33:04 -07:00
Volker Lendecke
07a9f7daa8 Fix Coverity ID 514
Not exactly an uninitialized variable, but having Coverity figure out that
we're only UNMARSHALLING here is probably asking for a bit too much.
2008-03-23 19:44:55 +01:00
Volker Lendecke
4e6f8a19a6 Fix Coverity ID 504 2008-03-23 19:44:55 +01:00
Volker Lendecke
5c43c38271 Fix Coverity ID 503 2008-03-23 19:44:55 +01:00
Volker Lendecke
a0859529c8 Fix Coverity ID 488
"status" was used uninitialized on success -- metze, please check
2008-03-23 19:44:55 +01:00
Volker Lendecke
22cee9c1af Fix Coverity ID 487 2008-03-23 19:44:55 +01:00
Volker Lendecke
d3b6df67fe Fix Coverity ID 471 2008-03-23 18:28:24 +01:00
Volker Lendecke
94c29f5593 Fix Coverity ID 472
Simo, S4 also has this code. You might want to cherry-pick.

Volker
2008-03-23 18:28:24 +01:00
Volker Lendecke
f17b1b0fc6 Fix Coverity ID 477 2008-03-23 18:28:24 +01:00
Volker Lendecke
5f77938dc4 Fix Coverity ID 478 2008-03-23 18:28:23 +01:00
Volker Lendecke
70b33397ba Fix Coverity ID 479 2008-03-23 18:28:23 +01:00
Volker Lendecke
45677e8694 Fix Coverity ID 480 2008-03-23 18:28:23 +01:00
Volker Lendecke
700cceb694 Fix Coverity ID 450 2008-03-23 18:28:23 +01:00
Volker Lendecke
8f875674e7 Fix Coverity ID 453 2008-03-23 18:28:23 +01:00
Volker Lendecke
9cf1e16a9c Fix Coverity ID 462 2008-03-23 18:28:23 +01:00
Volker Lendecke
7070c77ee2 Fix Coverity ID 432 2008-03-23 16:22:00 +01:00
Volker Lendecke
9e0ee1ad4f Fix Coverity ID 436 2008-03-23 16:21:59 +01:00
Volker Lendecke
0d50b4ee90 Fix Coverity warnings
ID 449, 448, 447, 446, 445, 444, 443, 442, 441, 440, 439, 438, 437
2008-03-23 16:16:13 +01:00
Karolin Seeger
4e609ffb2f VERSION: Update pre release number.
Karolin
2008-03-23 07:28:13 +01:00
Michael Adam
4185ed03a3 libgpo: open the registry in gp_init_reg_ctx().
I forgot the regdb_open() call: registry_init_basic() closes
the registry in the end... sorry.

Michael
2008-03-22 02:45:04 +01:00
Michael Adam
10ae8accb4 libgpo: replace hand-crafted registry initialization by registry_init_basic.
IMO there is no need to imitate a custom registry backend.
Only default regdb hooks are used here, so a plain initialization
of regdb should suffice.

This way, only reg_api is used in libgpo, and no registry
backend code is visible.

Michael
2008-03-22 02:29:40 +01:00
Michael Adam
4717e6d0cf libgpo: use reg_setkeysecurity() instead of regdb_set_secdesc().
That is, use the reg_api function instead of the backend function.
For this, code had to be changed, to take a "struct registry_key"
instead of a char *.

Michael
2008-03-22 02:29:34 +01:00
Michael Adam
1831042bdc registry: add reg_init_basic() - init registry with only the db backend.
Michael
2008-03-22 02:05:53 +01:00
Michael Adam
5aa3141bff registry: close registry in exit path in registry_init_smbconf().
Michael
2008-03-22 01:54:18 +01:00
Michael Adam
f33095e44b registry: some whitespace cleanup in init_registry().
Michael
2008-03-22 01:53:44 +01:00
Michael Adam
81993db828 registry: remove unneeded talloc stackframe variable.
Michael
2008-03-22 01:52:03 +01:00
Michael Adam
73b325fe7a registry: close regdb in error path (and use it) in init_registry().
Michael
2008-03-22 01:49:21 +01:00
Michael Adam
f4d87fdbf2 registry: fix registry_init_smbconf() to close the registry at the end.
Michael
2008-03-21 23:50:49 +01:00
Michael Adam
03e72e1307 libsmbconf: add internal open/close handling to registry backend.
This internally keeps track of opened registry in the private data
struct. The first call that really accesses data, opens the registry
and it is kept open until the destructor is called.

This behaviour might be changed in the future.

Michael
2008-03-21 23:43:52 +01:00
Michael Adam
513ae78ef7 libsmbconf: add a comment.
Michael
2008-03-21 22:55:20 +01:00
Michael Adam
a02163356b libsmbconf: add private_data section to smbconf_ctx.
This private data should be used by backends.
The token for the registry backend is moved from
the context to the private data section, since
this is registry specific.

Michael
2008-03-21 22:52:27 +01:00
Michael Adam
96434d9dc7 libsmbconf: add a "path" variable to the conf context.
This is passed to the module init routines.
In case of the registry, this is the path of the
basekey in registry, that is to be used, defaulting
to KEY_SMBCONF (HKLM\software\samba\smbconf), when
NULL is given. This is the only case currently used.

In order to support other keys, registry initialization
for smbconf has to be changed to support different keys.

Michael
2008-03-21 18:19:24 +01:00
Michael Adam
4f816df276 libsmbconf: add structuring comments to the prototypes in the public header.
Michael
2008-03-21 16:45:25 +01:00
Michael Adam
83b9453c88 libsmbconf: adapt a comment to new circumstances
Michael
2008-03-21 16:42:42 +01:00
Michael Adam
e8ed8ad077 libsmbconf: group together functions in smbconf.c more appropriately
Michael
2008-03-21 16:40:20 +01:00
Michael Adam
8974b28368 libsmbconf: add a comment.
Michael
2008-03-21 16:35:52 +01:00
Michael Adam
431b10bfe0 libsmbconf: move registry implementation to a module of its own.
Michael
2008-03-21 16:26:50 +01:00
Volker Lendecke
19eb8c9316 On Solaris, size_t seems to be only 32 bit.
Fix bug 5341, thanks a lot to Karoly Vegh for testing it!

Volker
2008-03-21 13:41:42 +01:00
Volker Lendecke
b82cf75c82 Fix Coverity ID 473
Simo, S4 also has this bug, you might want to merge the fix.
2008-03-21 11:52:34 +01:00
Volker Lendecke
c9add4d59a Fix Coverity ID 506 2008-03-21 11:48:09 +01:00
Volker Lendecke
4ea5798b97 Fix Coverity ID 507 2008-03-21 11:45:57 +01:00
Volker Lendecke
b19ea3635c Fix Coverity ID 537 2008-03-21 11:42:42 +01:00
Volker Lendecke
d69b8b19ae Fix Coverity ID 538 2008-03-21 11:41:15 +01:00
Volker Lendecke
120d8c889f Fix Coverity ID 547
Günther, please check. If r->in.ads==NULL, we can't call ads_leave_realm at
all.

Thanks,

Volker
2008-03-21 10:40:40 +01:00
Volker Lendecke
e2021c5b57 Fix Coverity ID 548
Günther, please check -- in all infolevels we do a comment=talloc_strdup

Thanks,

Volker
2008-03-21 10:28:33 +01:00
Volker Lendecke
1a0aed566b Fix Coverity IDs 553, 552 2008-03-21 10:22:15 +01:00
Günther Deschner
4689057f63 Add my copyright.
Guenther
2008-03-21 04:16:22 +01:00