Volker Lendecke
d3b6df67fe
Fix Coverity ID 471
2008-03-23 18:28:24 +01:00
Volker Lendecke
f17b1b0fc6
Fix Coverity ID 477
2008-03-23 18:28:24 +01:00
Volker Lendecke
5f77938dc4
Fix Coverity ID 478
2008-03-23 18:28:23 +01:00
Michael Adam
1831042bdc
registry: add reg_init_basic() - init registry with only the db backend.
...
Michael
2008-03-22 02:05:53 +01:00
Michael Adam
5aa3141bff
registry: close registry in exit path in registry_init_smbconf().
...
Michael
2008-03-22 01:54:18 +01:00
Michael Adam
f33095e44b
registry: some whitespace cleanup in init_registry().
...
Michael
2008-03-22 01:53:44 +01:00
Michael Adam
81993db828
registry: remove unneeded talloc stackframe variable.
...
Michael
2008-03-22 01:52:03 +01:00
Michael Adam
73b325fe7a
registry: close regdb in error path (and use it) in init_registry().
...
Michael
2008-03-22 01:49:21 +01:00
Michael Adam
f4d87fdbf2
registry: fix registry_init_smbconf() to close the registry at the end.
...
Michael
2008-03-21 23:50:49 +01:00
Volker Lendecke
c9add4d59a
Fix Coverity ID 506
2008-03-21 11:48:09 +01:00
Michael Adam
6bac03a2ec
registry: use available string constant in debug statement.
...
Michael
2008-03-20 15:01:52 +01:00
Michael Adam
27d67365ad
registry: in regdb_init, not only complain about INFO/version, store it...
...
Michael
2008-03-20 15:01:52 +01:00
Michael Adam
11da885f1e
registry: reformat regdb_init() slightly, breaking long lines.
...
Michael
2008-03-20 15:01:52 +01:00
Michael Adam
504058df97
registry: untangle assignment and if-statement in regdb_init().
...
Michael
2008-03-20 15:01:52 +01:00
Michael Adam
59fdd30c78
registry: separate initialization of registry data from regdb_init().
...
Leave this to the users (currently registry_init_smbconf() and
init_registry()) to initialize as much of preliminary registry data
as needed.
Michael
2008-03-20 15:01:52 +01:00
Michael Adam
8b9cff84d5
registry: add a transaction wrapper to init_registry_key_internal().
...
Michael
2008-03-20 15:01:52 +01:00
Michael Adam
55233f875e
registry: refactor creation of subkeys out of init_registry_data().
...
Michael
2008-03-20 15:01:51 +01:00
Günther Deschner
e9c56250eb
Bind Group Policy processing closer to the samba registry.
...
Guenther
2008-03-18 21:31:24 +01:00
Marc VanHeyningen
3fc85d2259
Coverity fixes
2008-03-17 20:52:25 +01:00
Michael Adam
64664d25cf
registry: untangle assignment and if-clause in init_registry_data().
...
Michael
2008-03-17 13:12:47 +01:00
Michael Adam
3ea0a0beb4
registry: convert regdb REGISTRY_OPS to named struct initializers.
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
df848d8eee
registry: use talloc instead of malloc and provide common exit point
...
in regdb_get_secdesc().
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
76dad05e4c
registry: remove an unused variable from regdb_set_secdesc().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
d553b5d725
registry: untangle assignments and if statements in regdb_set_secdesc().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
e4f2c856ec
registry: use talloc_stackframe instead of hand crafted temporary context.
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
860316cbe7
registry: use talloc instead of malloc for tdb data in regdb_store_values().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
7454e426f2
registry: don't use talloc_stackframe() instead of talloc_tos() als temp ctx
...
in regdb_store_values(). Also provide common exit path for
freeing memory.
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
3a1d79116b
registry: don't leak to talloc stack in regdb_fetch_keys().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
93ea27a3e2
registry: explicitly use talloc context instead of talloc_tos()
...
in regdb_fetch_keys().
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
331d7fd2ea
registry: don't leak on success path in regdb_store_keys().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
a99b51159a
registry: allocate tempory data in talloc stack in regdb_store_keys().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
e1d4a2fa5b
registry: separate cancel and failur exit paths in regdb_store_keys().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
9315de4048
registry: don't leak memory on transaction fail in regdb_store_keys().
...
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
95525772f2
registry: don't leak (to talloc_tos()) in regdb_store_keys().
...
use talloc_stackframe() and free on error path.
Michael
2008-03-17 08:22:33 +01:00
Michael Adam
966b2414cb
registry: reformat regdb_store_keys_internal(), killing long lines.
...
Michael
2008-03-17 08:22:32 +01:00
Michael Adam
76e4cdc25f
registry: don't leak (to talloc_tos()) in regdb_store_keys_internal().
...
Michael
2008-03-17 08:22:32 +01:00
Michael Adam
f357b1ddd3
registry: reformat init_registry_data() some, killing long lines.
...
Michael
2008-03-17 08:22:32 +01:00
Michael Adam
8b0dd1e758
registry: explicitly use talloc context instead of talloc_tos()
...
in init_registry_data().
Michael
2008-03-17 08:22:32 +01:00
Michael Adam
7fd0ae3edc
registry: don't leak (to talloc_tos()) in init_registry_data().
...
Michael
2008-03-17 08:22:32 +01:00
Michael Adam
d39957e2c9
registry: rename tdb_refcount to regdb_refcount after change to dbwrap.
...
Michael
2008-03-17 08:22:32 +01:00
Michael Adam
79f37d4765
registry: rename tdb_reg to regdb after change to dbwrap.
...
Michael
2008-03-17 08:22:32 +01:00
Michael Adam
3c42d8ee16
registry: migrate tdb registry backend to dbwrap.
...
Michael
2008-03-17 08:22:32 +01:00
Günther Deschner
29ccc0e233
Fix return of reg values below HKLM/SOFTWARE/MICROSOFT/WINDOWSNT/CURRENTVERSION.
...
Michael, please check.
Guenther
2008-03-11 10:52:32 +01:00
Günther Deschner
956bc60206
Fix init_registry_data for subkeyless top-level keys.
...
On a fresh install with no existing registry.tdb, make sure we are able to
create our initial top-level entries.
Michael, Volker, please check.
Guenther
2008-03-01 01:02:15 +01:00
Tim Potter
737bb950d5
Fix double free bugs after calling regfio_close()
2008-02-20 18:28:41 -08:00
Michael Adam
951d3fae2c
Make regdb_init() behave like regdb_open() when registry is already opened.
...
I.e. increment the refcounter.
Michael
2008-02-19 09:09:04 +01:00
Michael Adam
2c66413de2
Remove (now) unused function make_default_reg_sd().
...
Michael
2008-02-18 17:41:21 +01:00
Michael Adam
194e00822c
Grab secdesc for key from registry for reg_savekey()
...
instead of construction another default secdesc.
Michael
2008-02-18 17:41:21 +01:00
Michael Adam
9f0448ca32
Add NT Authority\System as group sid to default registry key security descriptor.
...
Michael
2008-02-18 17:41:20 +01:00
Michael Adam
91dbe79df2
Change construct_registry_sd() to return WERROR instead of the SEC_DESC *.
...
Michael
2008-02-18 17:41:20 +01:00