1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-17 02:05:21 +03:00

243 Commits

Author SHA1 Message Date
Volker Lendecke
10bc204efb r11923: Add samr_lookup_rids for the builtin domain. Doing it this way feels a bit
wrong, but so far we don't have proper multi-domain support in passdb yet...

Volker
(This used to be commit c917cfc320f0250d23fda3525a7632bc01643707)
2007-10-10 11:05:36 -05:00
Volker Lendecke
046a8873b9 r11922: Looks bigger than it is: There's no point in allocating arrays in
samr_lookup_rids twice. It was done in the srv_samr_nt.c code as well as in
the pdb module. Remove the latter, this might happen more often.

Volker
(This used to be commit 57f0cf8cdd6928f4759036e5dd53d41736aa910d)
2007-10-10 11:05:36 -05:00
Volker Lendecke
fcf14ebee2 r11921: samr_open_domain can only open "our" domain and BUILTIN.
Volker
(This used to be commit 049920ce4f78723bc884c46b2ee4ef22f25c482c)
2007-10-10 11:05:36 -05:00
Volker Lendecke
add1493a86 r11919: The generic mappings in srv_samr_nt.c are only used there -- make them
static.

One long overdue simplification: Change local_lookup_sid to local_lookup_rid
its responsible for "our" domain only, in fact it checked for it.

Volker
(This used to be commit 35ba5e083cddfa5ddba5ad84233262fadfbe87b2)
2007-10-10 11:05:35 -05:00
Volker Lendecke
5976053f05 r11918: Remove two unused variables
(This used to be commit 5524d662954165eef3fdd15986fe0b4de09180d7)
2007-10-10 11:05:35 -05:00
Volker Lendecke
3088a85c62 r11915: Remove unused extern declarations
(This used to be commit 3c35fb642a187b785816bb8cbb3573df9612a9f8)
2007-10-10 11:05:35 -05:00
Volker Lendecke
ed6936598e r11898: Add a missing become_root().
Volker
(This used to be commit efb7576d4e970e3cbb4621ebd754d329eec58b5a)
2007-10-10 11:05:33 -05:00
Jeremy Allison
a509c20eb6 r11865: The only way to stop multiple LDAP searches is to agressively cache
results. We now cache them for 10 seconds, down from 30 seconds
(however each re-use will refresh the idle timeout). Any set calls
will flush the cache.
Jeremy.
(This used to be commit c9a0720f552719eb77a2c72fc2e942de52fbf1d6)
2007-10-10 11:05:32 -05:00
Günther Deschner
2770e98aec r11856: Replace unknown1 with group_attr.
Can anyone remember why we initialize groups only with 0x03 instead of 0x07 ?

Guenther
(This used to be commit 3282c7c458d390547fbaca44821eff376e8f9aaa)
2007-10-10 11:05:30 -05:00
Jeremy Allison
9be0ce4422 r11793: Fix the SAMR cache so it works across completely insane
client behaviour (ie.:
open pipe/open SAMR handle/enumerate 0 - 1024
close SAMR handle, close pipe.
open pipe/open SAMR handle/enumerate 1024 - 2048...
close SAMR handle, close pipe.
And on ad-nausium. Amazing.... probably object-oriented
client side programming in action yet again.
This change should *massively* improve performance when
enumerating users from an LDAP database.
Jeremy.
(This used to be commit 8ce705d9cc1b6a79d710a10ff38f72a0f1006dda)
2007-10-10 11:05:28 -05:00
Jeremy Allison
d09beee040 r11769: Looking at a performance problem enumerating accounts, wondered
if changing to support samr_connect5 might help so quickly coded
it up. No it doesn't :-(. Don't merge this for 3.0.21 please.
Jeremy.
(This used to be commit bff1df678a8948d382f4555e83a1df23146a4b12)
2007-10-10 11:05:27 -05:00
Jeremy Allison
c9effb004c r11451: Fix -O1 "might be using uninitialized" errors.
Jeremy.
(This used to be commit cab76c3c33883aad444eefb6562ab1b27d9ca88a)
2007-10-10 11:05:16 -05:00
Jeremy Allison
a656626d0f r11433: Fix for bug #3223 - ensure we're root before doing
any potential lib/smbldap.c calls.
Jeremy.
(This used to be commit 915cfb48f08b3748e22e68ed028eaca6d558cbad)
2007-10-10 11:05:16 -05:00
Jim McDonough
1113cad9c0 r11236: Implement user rename for smbpasswd and ldap backends. Some cleanup on
tdb as well to make naming consistent.
(This used to be commit ee91eb9a39cc5e3edd9e97eb040e7557930e4e62)
2007-10-10 11:05:08 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a788c735e56d53d63265255830ec21208)
2007-10-10 11:05:02 -05:00
Jim McDonough
254938c636 r10911: part of #2861: add rename support for usrmgr.exe when using tdbsam
This gets it working before replacing tdb with the samba4 version.
(This used to be commit 8210b0503a050e12ee1b4335fa6e50d10ad06577)
2007-10-10 11:04:56 -05:00
Gerald Carter
54abd2aa66 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
(This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10 11:04:48 -05:00
Gerald Carter
d4f2df5d5c r9956: Ensure accounts with the SeAddUsersPrivilege can modify domain and local group attributes (posted to samba ml and confirmed fix)
(This used to be commit 005d4cb3c636383ccf70c4891cd7cc4bd3b48ad2)
2007-10-10 11:03:29 -05:00
Gerald Carter
be0f3f159f r9660: real fix for group enumeration bug in 3.0.20; only affected the ldapsam code
(This used to be commit 62f9fb5e3a9bce539c9fedc5fdec1b8741a922c7)
2007-10-10 11:03:24 -05:00
Gerald Carter
e76107dd9b r9594: return the mapped name in enum_dom_groups()
(This used to be commit a769aaec88257ae006c61f0fcfd98efd4b639268)
2007-10-10 11:03:22 -05:00
Tim Potter
36115e7ebc r9275: Remove some dead code. Bugzilla #2982.
(This used to be commit e1fc7d89c26b671e77c7cb14e03690091b671b1d)
2007-10-10 11:00:30 -05:00
Gerald Carter
6014bb000e r9098: fix another usrmgr.exe crash when viewing user properties at debuglevel 10
(This used to be commit f5756c2611df5a026d78f8acb229d7c25f1fd383)
2007-10-10 11:00:26 -05:00
Günther Deschner
3ada346cbe r8971: Fix querydispinfo (still need to look at enumdomusers) to allow to list
more then 511 users.

After the rewrite, the old NT_STATUS-semantics didn't fit any longer.

Guenther
(This used to be commit 690da51d835fd780b16d8ce6521957146c90da78)
2007-10-10 11:00:23 -05:00
Jeremy Allison
263a51cd62 r8564: Sometimes we're too dumb to live... Fix samr calls where we were
using USER_INFO_XX structs and functions where XX was sometimes
in hex and sometimes in decimal. Now it's all in decimal (should
be no functionality change).
Jeremy.
(This used to be commit 84651aca04cbcbf50ab2e78333cc9d9e49dd92f5)
2007-10-10 11:00:09 -05:00
Volker Lendecke
864ca4f051 r7836: Fix the bug where users show up as trusting domains.
Volker
(This used to be commit 61585fa56b4f838f416815598f4a301aa9ee12d7)
2007-10-10 10:57:58 -05:00
Gerald Carter
cfe8933754 r7581: fix bad merge
(This used to be commit 55d08311032b75724b525d8e0df506de3e988b15)
2007-10-10 10:57:14 -05:00
Gerald Carter
6109b8ad9d r7578: use global well known DOM_SID objects when possible
(This used to be commit 643dc05eb5a8e41cf9cb1768ef42f5dbc0320846)
2007-10-10 10:57:14 -05:00
Gerald Carter
450e8d5749 r7130: remove 'winbind enable local accounts' code from the 3.0 tree
(This used to be commit 318c3db4cb1c85be40b2f812f781bcf5f1da5c19)
2007-10-10 10:57:01 -05:00
Volker Lendecke
0e5aa494dd r6772: Fix a valgrind error for samr_open_alias uncovered by one of John's test.
Jerry, in query_aliasmem, set_aliasinfo and set_groupinfo (and possibly
others) need become_root()/unbecome_root() around the pdb calls. I'm not sure
I would do the access checks correctly, I would much rather leave that to
you.

Volker
(This used to be commit 88a67e96d1c54fddadbb6a33e4bc5fba884e58e6)
2007-10-10 10:56:54 -05:00
Gerald Carter
03377b2a21 r6642: BUG 2686: shouold fix the group_setinfo() failures; similar to alias_setinfo() patch from last week
(This used to be commit 611cca473ef6c50aeeda79c323f55e8e3402b1b1)
2007-10-10 10:56:49 -05:00
Gerald Carter
28824fb197 r6601: fixing query and set alias info calls (level 1 from the
MMC manage computer plugin.
(This used to be commit c43c1ec80cb52569ccabcdf95e4004386ecb29d6)
2007-10-10 10:56:46 -05:00
Gerald Carter
a7145e26c9 r6566: fix a couple of local group bugs.
* ensure that we set full access on the handle
  returned from _samr_create_dom_alias() so that
  future set_alias commands succeed

* fix bug when looking for internal domains in winbindd
  (caused winbindd_getgrgid() for local groups to fail).
(This used to be commit 4615c96ccb8906af4eb1fbe6d0cbf6bb3bcc3fcf)
2007-10-10 10:56:45 -05:00
Gerald Carter
57eb9f47d0 r6421: use add machine script when creating a user (ACB_NORMAL)
who has a name ending in '$' (usrmgr.exe does this for
domain trusts (that's was jfm's original comment I think).

avoid an assert() call in libldap.
(This used to be commit 0ac57ae94202190ddbe538f7180a0443463b48cf)
2007-10-10 10:56:41 -05:00
Volker Lendecke
d3d6126d94 r6351: This is quite a large and intrusive patch, but there are not many pieces that
can be taken out of it, so I decided to commit this in one lump. It changes
the passdb enumerating functions to use ldap paged results where possible. In
particular the samr calls querydispinfo, enumdomusers and friends have
undergone significant internal changes. I have tested this extensively with
rpcclient and a bit with usrmgr.exe. More tests and the merge to trunk will
follow later.

The code is based on a first implementation by Günther Deschner, but has
evolved quite a bit since then.

Volker
(This used to be commit f0bb44ac58e190e19eb4e92928979b0446e611c9)
2007-10-10 10:56:38 -05:00
Volker Lendecke
110d86876e r6282: Before converting enum_dom_groups, better get the previous version a bit
closer to being correct. 'svn blame' shows CVSIN, but somehow I get the
feeling this is my code...

Volker
(This used to be commit 5d34bd617535a26ae121a72add41dc7b8cec4580)
2007-10-10 10:56:35 -05:00
Volker Lendecke
83e11ba86c r6263: Get rid of generate_wellknown_sids, they are const static and initializable
statically.

Volker
(This used to be commit 3493d9f383567d286e69c0e60c0708ed400a04d9)
2007-10-10 10:56:33 -05:00
Herb Lewis
978ca84860 r6225: get rid of warnings from my compiler about nested externs
(This used to be commit efea76ac71412f8622cd233912309e91b9ea52da)
2007-10-10 10:56:30 -05:00
Volker Lendecke
e84ead0cfd r6080: Port some of the non-critical changes from HEAD to 3_0. The main one is the
change in pdb_enum_alias_memberships to match samr.idl a bit closer.

Volker
(This used to be commit 3a6786516957d9f67af6d53a3167c88aa272972f)
2007-10-10 10:56:20 -05:00
Jim McDonough
cf7d098b2c r5965: Apply Volker's patch for "ldapsam trusted = yes" for samr_lookup_rids. Gives us
again up to ~6x improvement on group membership lookups.
(This used to be commit e2117bcb09cbd21df3b6621c2794a006418c1d9e)
2007-10-10 10:56:13 -05:00
Gerald Carter
93e04e941e r5961: final round of compiler warning fixes based on feedback from Jason Mader
(This used to be commit 9e77da9320c900b3e437d534e31fa5ff81e9acfd)
2007-10-10 10:56:13 -05:00
Gerald Carter
9b38ced168 r5950: more compiler warning's from Jason Mader
(This used to be commit 27c6e85ad59a86ab45ae3297c7445c4ff15546c8)
2007-10-10 10:56:10 -05:00
Gerald Carter
43f4930ed3 r5943: remove unneccessary se_priv_copy()
(This used to be commit 2db04a90c4197a3950bbc322948468cb306b3557)
2007-10-10 10:56:09 -05:00
Volker Lendecke
140752fd35 r5647: Caches are good for performance, but you get a consistency problem.
Fix bug # 2401.

Volker
(This used to be commit eb4ef94f244d28fe531d0b9f724a66ed3834b687)
2007-10-10 10:55:53 -05:00
Volker Lendecke
dc0ec44483 r5471: In cli_samr_lookup_rids, flags is not a flags but an array size. W2k3 rejects
everything but 1000 here, so there's no point in exposing that to the caller.

Thanks,

Volker
(This used to be commit 03ec1bd9e54b065c0494bc57a3d78ac0ae28e234)
2007-10-10 10:55:42 -05:00
Volker Lendecke
0d63de34ba r5469: Fix error codes of samr_lookup_rids: There's also STATUS_SOME_UNMAPPED.
Thanks,

Volker
(This used to be commit 43dcf0f5cb5dc2dd37ab3cdc2905970d9cc50ba4)
2007-10-10 10:55:42 -05:00
Volker Lendecke
a90a58ff22 r5467: Optimize _samr_query_groupmem with LDAP backend for large domains.
Could someone else please look at this patch, verifying that I did not break
the ldapsam:trusted = False fallback to the old behaviour? It works fine for
me, but you never know. You're certainly free to review the new code as well :-)

Thanks,

Volker
(This used to be commit e1c3ca182b299dc65da1fa39aadb69876b5e16b8)
2007-10-10 10:55:41 -05:00
Volker Lendecke
96edc93c23 r5419: Fix some unitialized variable warnings
(This used to be commit 9004b7897416d142ab9e3bee60c7bda589f94750)
2007-10-10 10:55:39 -05:00
Günther Deschner
6c84ecb556 r5349: After talking with Jerry, reverted the addition of account policies to
passdb in 3_0 (they are still in trunk).

Guenther
(This used to be commit fdf9bdbbac1d8d4f3b3e1fc7e49c1e659b9301b1)
2007-10-10 10:55:38 -05:00
Günther Deschner
5f54cc9bd3 r5264: Log with loglevel 0 when account-administration scripts fail.
Guenther
(This used to be commit 3d391ef149639750db376b05528a27422f8a3321)
2007-10-10 10:55:35 -05:00
Günther Deschner
e98f56373b r5262: Fix server_role in the samr_query_dom_info calls. When we are a BDC we
should not say we are a PDC.

Guenther
(This used to be commit 6cdf3b97de2c28ac92f972621b0ce04c1c80cea5)
2007-10-10 10:55:34 -05:00