1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-05 21:57:51 +03:00

10202 Commits

Author SHA1 Message Date
Jeremy Allison
11077368ec Fix typo in earlier fix, caught by Ranjit @ HP.
Jeremy.
-
Jeremy Allison
723e9ee31c Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.
Jeremy.
-
Jeremy Allison
183ce97d37 Extra const committed by mistake - revert.
Jeremy.
-
Jeremy Allison
7f8d3a49b2 Missed parentheses around complex logic.
Jeremy.
-
Jeremy Allison
1d3b8c528b Patch from Michael Steffens. In his own words :
-------------------------------------------------------------------------
I think there are basically two problem:

  1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
     and SMB_ACL_OTHER.
     The function ensure_canon_entry_valid() is prepared for that, but tries
     to "guess" values from group or other permissions, respectively, otherwise
     falling back to minimum r-- for the owner. Even if the owner had full
     permissions before setting ACL. This is the problem with W2k clients.

  2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
     This is ok in a take-ownership situation, but must fail if the file is
     to be given away. This is the problem with XP clients, trying to transfer
     ownership of the original file to the temp file.

The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.

I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:

  1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
     as "preserve current value" instead of attempting to build one ourself.
     The original code is still in, but only as fallback in case current values
     can't be retrieved.

  2. Rearrange set_nt_acl() such that chown is only done before setting
     ACLs if there is either no change of owning user, or change of owning
     user is towards the current user. Otherwise chown is done after setting
     ACLs.

It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
-
Jeremy Allison
05a8a61af8 Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.
Jeremy.
-
Jeremy Allison
5e2755508f Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parameters
differently to W2K, cope with this.
Jeremy.
-
Gerald Carter
52ef84b534 add #define for the max device name length in a DEVICEMODE -
Jeremy Allison
fa93763248 More const fixes.
Jeremy.
-
Jeremy Allison
c832e95c2f Writable string const fixes.
Jeremy.
-
Jeremy Allison
75b36459ab Fix for little-used lpq parser.
Jeremy.
-
Jeremy Allison
3cc2ace771 Connectathon fix. W2K -> W2K over port 445 doing a tconX does the full
\\server\share syntax, not just a "share" tconX syntax. This broke interop
with a vendor.
Jeremy.
-
Gerald Carter
f5c9895f83 preparing for release of 3.0alpha22 -
Richard Sharpe
1af39523cc More janitorial duties, fixing the BIG_UINT changes for large offsets. -
Jeremy Allison
30e8ae8e03 Const warning fixes.
Jeremy.
-
Jeremy Allison
dedc18212a Fix const warning.
Jeremy.
-
Jeremy Allison
54e5413a92 dlysym takes a const char *.
Jeremy.
-
Gerald Carter
e138336816 * always report ourselves as a Windows 2000 print server (even
without ADS support)
* add "MinorVersion" print server data key and comment on "OSVersion"
-
Gerald Carter
e8939165b7 * CR1868: only send a change notify message if we have something
that changed that the client is monitoring.

* couple of comments abnout how we need to validate driver names
  on SetPrinter() and AddPrinter()

* up the debug level on some overly verbose dev mode parsing messages
-
Jeremy Allison
e1b0001c8d Added limit to number of jobs enumerated. Set to 0 (means no limit).
Yes I will add the docs....
Jeremy.
-
Jeremy Allison
a75d9fc4e1 Ensure added jobs increment total_jobs.
Jeremy.
-
Jelmer Vernooij
e660b0b8d0 Fix HTTP error codes (patch by Vance Lankhaar) -
Martin Pool
732d94b83e Remove reference to "mainpage.dox" and CodingStandards, which have
been removed.

Put subdirectory names in file list, so we get lib/util_chr.c, not
just util_chr.c.
-
Jim McDonough
507e5738fb Move net ads lookup improvements over from HEAD -
Jeremy Allison
7a586552a3 *Excellent* patch from Michael Steffens <michael_steffens@hp.com> to limit
the unix domain sockets used by winbindd (also solves FD_SETSIZE problem
in winbindd to boot !). Adds a "last_access" field to winbindd connections,
and will close the oldest idle connection once the number of open connections
goes over WINBINDD_MAX_SIMULTANEOUS_CLIENTS (defined in local.h as 200
currently).
Jeremy.
-
Gerald Carter
4aa611958e don't forget the NULL -
Gerald Carter
e1b21381f3 and the winner of "i should have just written it in assembly
is..."

don't use pstrcpy() when you are not dealing with pstrings.
-
Gerald Carter
9b0a49a0bc don't pass NULL pointers to strcmp() -
Gerald Carter
c7712fa054 additional fix for CR 601
* distinguish WinXP from Win2k
  * add a 1/3 of a second delay in OpenPrinter
    in order to trigger a LAN/WAN optimization in
    2k clients.
-
Martin Pool
38fa289896 Doxygen merge from head -
Martin Pool
3ff4845bc4 Merge 1.100 patch from HEAD:
init_valid_table: Fix a memory leak that would lose the
dynamically-created valid table every time the configuration was
reloaded.
-
Jeremy Allison
766928bbba Fix to allow blocking lock notification to be done rapidly (no wait
for smb -> smb lock release). Adds new PENDING_LOCK type to lockdb
(does not interfere with existing locks).
Jeremy.
-
Andrew Bartlett
1cba3ceae1 Merge adding -Wwrite-strings to our CFLAGS when --enable-developer is set -
Tim Potter
eac4b7ef29 Link wbinfo with popt_common.o -
Tim Potter
c2e9673328 Merge of exit path cleanup for EnumDomainUsers. -
Tim Potter
19676de275 Merge of python prototype header removal. -
Tim Potter
df49463e62 Merge: newline on debug message. -
Tim Potter
8de62f7896 Merge: add popt_common_version to command line options table. -
Tim Potter
20f153cee3 Merge: const fixes.
Merge: add popt_common_version to command line options table.

Merge: mbp's rewrite of do_cmd()
-
Tim Potter
5f8a008a52 Merge: const fixes.
Merge: add popt_common_version to command line options table.
-
Tim Potter
a20aba0999 Merge: const fixes. -
Tim Potter
55ee43cfb8 Merge: fix compiler warning. -
Gerald Carter
31272d3b6b Progress on CR 601
cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.

Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
-
Jeremy Allison
9634b1fba0 Merge from HEAD. Use pstrcpy not safe_strcpy.
Jeremy.
-
Jeremy Allison
6521601bf8 Merge from head. Move off-by-one buggy malloc()/safe_strcpy() combination to strdup() instead.
Jeremy.
-
Martin Pool
3761f8ebe3 Merge documentation from HEAD -
Andrew Bartlett
eacb8dde7a Make sure these values are never uninitialsised. -
Andrew Bartlett
a25f612664 Cleint-side-auth/kerberos fixes from HEAD, and don't connect to a share
twice, let the libsmb code determine what form the share name should take.

Andrew Bartlett
-
Andrew Bartlett
935c66f6a0 Iconv as seperate library fixes from HEAD -
Andrew Bartlett
723ce5c531 Signed/unsigned fix from HEAD -