1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-25 06:04:04 +03:00

103 Commits

Author SHA1 Message Date
Günther Deschner
1181e6c791 r25809: Add basic security descriptor inheritance test for winreg.
Guenther
(This used to be commit 7a64b009d4d3733b6ded8da9569e25bdfb5f3a26)
2007-12-21 05:44:08 +01:00
Günther Deschner
01fd8e97d7 r25808: Move basic security descriptor test to a test_SecurityDescriptors() call.
Guenther
(This used to be commit 6023e6843090342dd0533f72b503aee0975b05cf)
2007-12-21 05:44:08 +01:00
Günther Deschner
36b10da94a r25807: Close handle during winreg test.
Guenther
(This used to be commit ca53f1fb5d7be9de92b9c573da477be599904843)
2007-12-21 05:44:07 +01:00
Günther Deschner
f2002541ce r25803: Make our security descriptor acl manipulation methods more generic so that we
can add and delete ACEs for SACLs as well as for DACLs.

Guenther
(This used to be commit 947fff994181f0ae50ac76d09621ddd684873112)
2007-12-21 05:44:06 +01:00
Günther Deschner
cfd09eed40 r25731: Document winreg_NotifyChangeKeyValue's notify flags.
Guenther
(This used to be commit 4468b1cc49bd4a92c08aeb76419abfe00791b2c2)
2007-12-21 05:43:32 +01:00
Günther Deschner
ade07a34d9 r25730: Fix IDL for incorrect winreg_SetKeySecurity.
Guenther
(This used to be commit 767867c3ee126c3832750d1b1e7de81005c4eaff)
2007-12-21 05:43:31 +01:00
Günther Deschner
bdf71f5dc6 r25612: Add test_SetKeySecurity() call.
Guenther
(This used to be commit a5e4d13eef9f20fdd304bff7279e56e09aa070f2)
2007-12-21 05:42:53 +01:00
Günther Deschner
89f6f464ea r25611: Smaller fix for winreg test.
Guenther
(This used to be commit e9e6ee4f73c5ed88cbf4585aa7e1a40e06cc131f)
2007-12-21 05:42:52 +01:00
Günther Deschner
bf1293e9f2 r25609: Reformat RPC-WINREG test.
Guenther
(This used to be commit 617091fb5aa708f4bfef3312d1442c3fc627bd30)
2007-12-21 05:42:51 +01:00
Günther Deschner
a6c4b9d179 r25607: Allow to set security descriptor type flags at creation time with
security_descriptor_create().

Guenther
(This used to be commit 7dd0d28d254f78891b0807492baafa188b42df16)
2007-12-21 05:42:51 +01:00
Günther Deschner
50bf951977 r25606: Allow test_GetKeySecurity() to return a security descriptor.
Guenther
(This used to be commit 3a0d22f572bac4f53902cf1fcb6534fe88e6edab)
2007-12-21 05:42:50 +01:00
Michael Adam
f0b3f20efb r25532: Fix some more indentations. Sorry Günther, could not resist, after
having gone through this just before you committed r25529. :-)

Michael
(This used to be commit 3670b3148d3d4483292bb1a5153e521d4703019a)
2007-10-10 15:07:48 -05:00
Günther Deschner
35ea519ca8 r25529: Reformatting.
Guenther
(This used to be commit 4bb21a1b0077ff00eeec6a2e78ba719f6772bba7)
2007-10-10 15:07:48 -05:00
Jelmer Vernooij
d05d5da1e8 r24846: Use metadata about dangerous tests.
(This used to be commit f914b828ff486d41e123e6dafa1c8fd76b34b44b)
2007-10-10 15:03:18 -05:00
Jelmer Vernooij
18302e7030 r24751: Run more tests, remove empty testsuites, more small improvements.
(This used to be commit 2a5a0819eea86ba322434306e062d13893b5722e)
2007-10-10 15:03:02 -05:00
Jelmer Vernooij
0e6773525f r24741: More use of the torture API.
(This used to be commit de05c3651a6e9e6611b296873526afd9292327c1)
2007-10-10 15:03:02 -05:00
Jelmer Vernooij
b409d4120f r24667: Finally merge the registry improvements that Wilco Baan Hofman and I have
been working on for at least half a year now. Contains the following
improvements:

 * proper layering (finally!) for the registry library. Distinction is
   now made between 'real' backends (local, remote, wine, etc) and
   the low-level hive backends (regf, creg, ldb, ...) that are only used
   by the local registry backend
 * tests for all important hive and registry operations
 * re-enable RPC-WINREG tests (still needs more work though, as
							   some return values aren't checked yet)
 * write support for REGF files
 * dir backend now supports setting/reading values, creating keys
 * support for storing security descriptors
 * remove CREG backend as it was incomplete, didn't match the data model
   and wasn't used at all anyway
 * support for parsing ADM files as used by the policy editor (see lib/policy)
 * support for parsing PREG files (format used by .POL files)
 * new streaming interface for registry diffs (improves speed and memory usage
	for regdiff/regpatch significantly)

   ... and fixes a large number of bugs in the registry code
(This used to be commit 7a1eec6358bc863dfc671c542b7185d3e39d7b5a)
2007-10-10 15:02:34 -05:00
Stefan Metzmacher
f14bd1a90a r24557: rename 'dcerpc_table_' -> 'ndr_table_'
metze
(This used to be commit 84651aee81aaabbebf52ffc3fbcbabb2eec6eed5)
2007-10-10 15:02:15 -05:00
Michael Adam
57484f56c0 r23821: Extend the winreg test by a test for DeleteKey on a
key that has subkeys. This should return WERR_ACCESS_DENIED.

Michael
(This used to be commit 9b8789a4b5f444e643ed7ee3ff55dc0c41986d07)
2007-10-10 14:59:23 -05:00
Andrew Tridgell
0479a2f1cb r23792: convert Samba4 to GPLv3
There are still a few tidyups of old FSF addresses to come (in both s3
and s4). More commits soon.
(This used to be commit fcf38a38ac691abd0fa51b89dc951a08e89fdafa)
2007-10-10 14:59:12 -05:00
Michael Adam
f604ee4320 r23561: Fix an output message.
(This used to be commit bf1edba3f184cbddea70388058e16f044c2bea54)
2007-10-10 14:53:28 -05:00
Jelmer Vernooij
a60ab76694 r22339: Run some more tests.
(This used to be commit 1b73e6a776a3ef478718f656523d125d28589f5c)
2007-10-10 14:51:06 -05:00
Jelmer Vernooij
1d75e907e2 r21694: Some more testing updates.
(This used to be commit 9247626b1c5f1eec0cedd6be221aafc41d9a26ab)
2007-10-10 14:49:13 -05:00
Jelmer Vernooij
b7a46675fb r21386: Run all NDR tests in the buildfarm, import some functions from Samba3's IDL.
(This used to be commit 15a4b81ba0b5eeb25126a0b1a7bea7d3bf921ab2)
2007-10-10 14:48:24 -05:00
Jelmer Vernooij
a39f239cb2 r19392: Use torture_setting_* rather than lp_parm_* where possible.
(This used to be commit b28860978fe29c5b10abfb8c59d7182864e21dd6)
2007-10-10 14:21:24 -05:00
Andrew Tridgell
6adb5717f5 r18566: fixed the winreg pipe and winreg tests
Jerry, there is a big difference on the wire between these two:

  [out] uint32 x;
and
  [out] uint32 *x;

if you change from

  [out] uint32 x;

then you need to change to:

  [out,ref] uint32 *x;

otherwise it changes the format on the wire, which means we are no
longer compatible with MS servers.

but be aware that even if you change to a ref ptr, you also need to
change all the client code to set all the return variables in the out
part of the structure. That's why I don't like the MIDL restriction of
forcing the use of ref pointers for output variables - it makes life
much harder when writing client code, and makes the code much more
error prone (just look at all the extra code needed to make this work
again).

I know we could auto-allocate these variables in the generated client
side NDR code, but if we did that then we would have no way of doing a
_real_ ref out pointer, which we really wanted to set to some already
allocated variable.

So please hold off on changing our idl to use the MIDL convention for
output variables until Jelmer and I have had a good "chat" about this :-)
(This used to be commit 555aed43ba3c08360ca7fa921622b80732a7f657)
2007-10-10 14:18:47 -05:00
Gerald Carter
dce0c9e4fd r18561: Fix [out] pointers in winreg IDL
(This used to be commit 694677dafefdd94fa0a9bed93efab70c528dcb26)
2007-10-10 14:18:46 -05:00
Jelmer Vernooij
9727b061f3 r15776: Don't generate ref pointers in Samba4-generated code. There is no point
in having pointers for outgoing data when you can already modify the top-level
element.

This can be overridden (temporarily) by specifying the new "keepref"
attribute. Once we've removed keepref from all IDL files, I'll remove this
attribute as well.
(This used to be commit bdc6dd37503ced8322a671d225122ccffbb8bfec)
2007-10-10 14:08:18 -05:00
Jelmer Vernooij
cf0f4ec073 r15358: Fix some compiler warnings / type safety. Found by tcc
(This used to be commit 12ba42de5886f9f4f9b1698476557e0c217d06f3)
2007-10-10 14:05:25 -05:00
Stefan Metzmacher
1af925f394 r14860: create libcli/security/security.h
metze
(This used to be commit 9ec706238c173992dc938d537bdf1103bf519dbf)
2007-10-10 13:59:44 -05:00
Jelmer Vernooij
909b111f58 r14720: Add torture_context argument to all torture tests
(This used to be commit 3c7a5ce29108dd82210dc3e1f00414f545949e1d)
2007-10-10 13:59:13 -05:00
Jelmer Vernooij
4f1c8daa36 r14470: Remove some unnecessary headers.
(This used to be commit f7312dab3b9aba2b2b82e8a6e0c483a32a03a63a)
2007-10-10 13:57:29 -05:00
Jelmer Vernooij
8528016978 r14464: Don't include ndr_BASENAME.h files unless strictly required, instead
try to include just the BASENAME.h files (containing only structs)
(This used to be commit 3dd477ca5147f28a962b8437e2611a8222d706bd)
2007-10-10 13:57:27 -05:00
Jelmer Vernooij
1060f6b3f6 r14402: Generate seperate headers for RPC client functions.
(This used to be commit 7054ebf0249930843a2baf4d023ae8f62cedb109)
2007-10-10 13:57:19 -05:00
Jelmer Vernooij
eefe30b7d8 r14379: Build torture/rpc/ as a seperate smbtorture module. Move helper
functions for rpc out of torture/torture.c
(This used to be commit 1d2d970f3b8aef3f36c2befb94b5dd72c0086639)
2007-10-10 13:57:16 -05:00
Jelmer Vernooij
4ac2be9958 r13924: Split more prototypes out of include/proto.h + initial work on header
file dependencies
(This used to be commit 122835876748a3eaf5e8d31ad1abddab9acb8781)
2007-10-10 13:52:24 -05:00
Jelmer Vernooij
25bb00fbcd r12693: Move core data structures out of smb.h into core.h
torture prototypes in seperate header
(This used to be commit 73610639b23ca3743077193fa0b1de7c7f65944d)
2007-10-10 13:49:39 -05:00
Jelmer Vernooij
acd6a086b3 r12510: Change the DCE/RPC interfaces to take a pointer to a
dcerpc_interface_table struct rather then a tuple of interface
name, UUID and version.

This removes the requirement for having a global list of DCE/RPC interfaces,
except for these parts of the code that use that list explicitly
(ndrdump and the scanner torture test).

This should also allow us to remove the hack that put the authservice parameter
in the dcerpc_binding struct as it can now be read directly from
dcerpc_interface_table.

I will now modify some of these functions to take a dcerpc_syntax_id
structure rather then a full dcerpc_interface_table.
(This used to be commit 8aae0f168e54c01d0866ad6e0da141dbd828574f)
2007-10-10 13:47:48 -05:00
Andrew Tridgell
e8c23e4e2d r11457: fixed the winreg IDL and torture code so key and value enumerations
work again. The automatic value() is fine for the length, but cannot
be used for the size as the size is not the number of bytes being
sent, but the number of bytes that the server is allowed to use in the
reply
(This used to be commit 46e91f269c83707863a726e716325eade38e1142)
2007-10-10 13:45:39 -05:00
Tim Potter
9759d435ca r11261: Rename access_required field in winreg idl to access_mask so it matches
the other interfaces.
(This used to be commit 8eb582b5780188b6304c560b3e84fd7d75c483f8)
2007-10-10 13:45:09 -05:00
Jelmer Vernooij
568dd26ac7 r11243: length and size can now be filled in automatically.
(This used to be commit 99444c129d08fe3e3e381b04c2da5ea5c9c10270)
2007-10-10 13:45:06 -05:00
Tim Potter
20685ca815 r11210: Log registry open function name when starting hive tests.
(This used to be commit 3416a6d78f205f9d3fd73161cbed6dcd9c2bfdf8)
2007-10-10 13:45:02 -05:00
Andrew Tridgell
782fd6946f r9578: fixed an endless loop and memory leak in the QueryMultipleValues test
(This used to be commit ba909a64e92e9b2d2c8fd02fc9e9e0e7aa49dd0a)
2007-10-10 13:34:31 -05:00
Andrew Tridgell
26bae69bb9 r9575: more automatic cleanup code in winreg test
(This used to be commit 0e30c80a53af45ee9112513c02a6a231e8b1a133)
2007-10-10 13:34:30 -05:00
Andrew Tridgell
3eb52c6cd6 r9574: - made the sec_info fields in lsa and samr use a IDL bitmap
- fixed winreg_GetKeySecurity() to use a sec_info field correctly

- simplied the winreg torture code, removing the separate opens for
  each hive

- added torture cleanup code in winreg test

- added 'create with security descriptor' in the winreg torture test
(This used to be commit f20695decd587f7b6bbdbd4861441bd19ab85078)
2007-10-10 13:34:30 -05:00
Andrew Tridgell
649882d8d5 r9567: fixed the winreg IDL for CreateKey, including a security
descriptor. To keep it simple I just use normal IDL buffers for now,
avoiding the complex methods metze used in spoolss. We might change
that later

Also added decoding of the security_descriptor in
winreg_GetKeySecurity() in smbtorture
(This used to be commit 439f34a9621e2e96329c30cfed8d78b8fdfbd8a2)
2007-10-10 13:34:29 -05:00
Andrew Tridgell
9fffd12799 r9338: fixed the winreg IDL to be correct for the EnumKey and EnumValue
calls. The previous IDL was just a workaround for the limitations of
our older rpc infrastructure. Now that Jelmer has added much improved
string support using the charset keyword we can correctly implemenent
the unusual winreg string buffers.

Jelmer, note the little comment I put on winreg_StringBuf() about why
I couldn't use [value()] for the length field.

This also fixes EnumKey() and EnumValue() to use NTTIME fields for the
last_changed_time. I don't know why we were using a pair of uint32's,
as it is just a NTTIME.
(This used to be commit 8354b016122cc4f3cff042b3ada1de07e1614eb7)
2007-10-10 13:33:25 -05:00
Tim Potter
372f3fae88 r8171: According to Samba 3 and Ethereal, the winreg_OpenUnkown stuff is
actually a uint16 * without the [string] attribute, a la the the
system_name argument to samr_Connect().

Initialising the pointer to NULL is sufficient and we still pass the
RPC-WINREG test against win2k3.
(This used to be commit 407d962dacf7c833b36cb739e48fe97226968a34)
2007-10-10 13:19:16 -05:00
Jelmer Vernooij
fb52ab1446 r6961: Add RPC-WINREG to list of win2k3 tests
Fix bug in test for QueryMultipleValues
Ignore errors from CreateKey() and GetKeySecurity() for now
(This used to be commit 7b6b8d6b34de01d2585b23ddb994d8e7403a21f6)
2007-10-10 13:17:00 -05:00
Andrew Bartlett
645711c602 r5941: Commit this patch much earlier than I would normally prefer, but metze needs a working tree...
The main volume of this patch was what I started working on today:
 - Cleans up memory handling around DCE/RPC pipes, to have a parent talloc context.
 - Uses sepereate inner loops for some of the DCE/RPC tests

The other and more important part of this patch fixes issues
surrounding the new credentials framwork:

This makes the struct cli_credentials always a talloc() structure,
rather than on the stack.  Parts of the cli_credentials code already
assumed this.

There were other issues, particularly in the DCERPC over SMB handling,
as well as little things that had to be tidied up before test_w2k3.sh
would start to pass.

Andrew Bartlett
(This used to be commit 0453f9d05d2e336fba1f85dbf2718d01fa2bf778)
2007-10-10 13:11:11 -05:00