1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
Commit Graph

1199 Commits

Author SHA1 Message Date
Stefan Metzmacher
12050962f6 r17429: implement the LDAP_SERVER_SHOW_DELETED control in the client
metze
(This used to be commit 40dc7c1787)
2007-10-10 14:15:24 -05:00
Stefan Metzmacher
8ac0237eba r17420: add client support for the LDAP_SERVER_DOMAIN_SCOPE control
metze
(This used to be commit 84e74a759c)
2007-10-10 14:15:24 -05:00
Stefan Metzmacher
817610f385 r17419: add client support for the LDAP_SERVER_SEARCH_OPTIONS support.
with this you can limit a search to a specific partitions
or a search over all partitions without getting referrals.
(Witch is the default behavior on the Global Catalog Port)

metze
(This used to be commit 4ccd0f8171)
2007-10-10 14:15:24 -05:00
Stefan Metzmacher
b4028ca104 r17418: add client support for the LDAP_SERVER_SD_FLAGS control
metze
(This used to be commit 23759a1e9b)
2007-10-10 14:15:23 -05:00
Stefan Metzmacher
3455998edc r17414: add new error code
metze
(This used to be commit e15a015a1d)
2007-10-10 14:15:23 -05:00
Stefan Metzmacher
3437c2d92c r17319: make better usage of the composite api
metze
(This used to be commit 8f9e201b9a)
2007-10-10 14:15:11 -05:00
Stefan Metzmacher
7c50eec25e r17318: make better usage of the composite api
metze
(This used to be commit 683fc25f65)
2007-10-10 14:15:11 -05:00
Stefan Metzmacher
7e949c9fb1 r17317: - add a composite_create() function that allocates and initialize
the composite_context structue, we should try to convert all code
  to use this because there're a lot of places where the we have
  bugs with this task...
- add a composite_continue_smb2() helper

We should try to hide the internals of the composite code from the users
to avoid errors (and I found a lot of them... and will fix then step by step)

metze
(This used to be commit a16180f202)
2007-10-10 14:15:10 -05:00
Stefan Metzmacher
6d35c07811 r17278: fix un uninitialized value found by valgrind
metze
(This used to be commit fe463bc568)
2007-10-10 14:15:05 -05:00
Stefan Metzmacher
9c8fa196ba r17277: we need to trigger an event when we return directly,
otherwise the callers callback function will not be called
and the caller is hanging forever...

metze
(This used to be commit e231eba828)
2007-10-10 14:15:05 -05:00
Stefan Metzmacher
ec8d486e26 r17230: don't overwrite the error with NT_STATUS_NO_MEMORY
metze
(This used to be commit f2196bf9b6)
2007-10-10 14:10:22 -05:00
Andrew Bartlett
9d6f276717 r17222: Change the function prototypes for the GENSEc and TLS socket creation
routines to return an NTSTATUS.  This should help track down errors.

Use a bit of talloc_steal and talloc_unlink to get the real socket to
be a child of the GENSEC or TLS socket.

Always return a new socket, even for the 'pass-though' case.

Andrew Bartlett
(This used to be commit 003e2ab93c)
2007-10-10 14:10:20 -05:00
Andrew Bartlett
ba07fa43d0 r17197: This patch moves the encryption of bulk data on SASL negotiated security
contexts from the application layer into the socket layer.

This improves a number of correctness aspects, as we now allow LDAP
packets to cross multiple SASL packets.  It should also make it much
easier to write async LDAP tests from windows clients, as they use SASL
by default.  It is also vital to allowing OpenLDAP clients to use GSSAPI
against Samba4, as it negotiates a rather small SASL buffer size.

This patch mirrors the earlier work done to move TLS into the socket
layer.

Unusual in this pstch is the extra read callback argument I take.  As
SASL is a layer on top of a socket, it is entirely possible for the
SASL layer to drain a socket dry, but for the caller not to have read
all the decrypted data.  This would leave the system without an event
to restart the read (as the socket is dry).

As such, I re-invoke the read handler from a timed callback, which
should trigger on the next running of the event loop.  I believe that
the TLS code does require a similar callback.

In trying to understand why this is required, imagine a SASL-encrypted
LDAP packet in the following formation:

+-----------------+---------------------+
| SASL  Packet #1 | SASL Packet #2      |
----------------------------------------+
| LDAP Packet #1       | LDAP Packet #2 |
----------------------------------------+

In the old code, this was illegal, but it is perfectly standard
SASL-encrypted LDAP.  Without the callback, we would read and process
the first LDAP packet, and the SASL code would have read the second SASL
packet (to decrypt enough data for the LDAP packet), and no data would
remain on the socket.

Without data on the socket, read events stop.  That is why I add timed
events, until the SASL buffer is drained.

Another approach would be to add a hack to the event system, to have it
pretend there remained data to read off the network (but that is ugly).

In improving the code, to handle more real-world cases, I've been able
to remove almost all the special-cases in the testnonblock code.  The
only special case is that we must use a deterministic partial packet
when calling send, rather than a random length.  (1 + n/2).  This is
needed because of the way the SASL and TLS code works, and the 'resend
on failure' requirements.

Andrew Bartlett
(This used to be commit 5d7c9c12cb)
2007-10-10 14:10:18 -05:00
Stefan Metzmacher
a5bafffd66 r17083: - implement SMB2 Cancel in the client
- the 0xffffffffffffffff seqnum is reserved for SMB2 Break (oplock breaks)
  so don't use it in a request. we should someday try to test this...

metze
(This used to be commit 730cdc4475)
2007-10-10 14:10:11 -05:00
Volker Lendecke
152ea280f1 r17082: Add a test that walks and tests denying tconX access via the share security
descriptor. This is something that W2k3 does _not_ pass and probably is not
expected to, it seems the don't check access at tconX time.

Thanks to metze for the hint how in the srvsvc_NetShareInfo1501 struct the
length of the sd can be encoded in idl.

As metze says, there's probably more to the share secdesc, this needs more
testing. This one is here to walk the samba3 code.

Volker
(This used to be commit 6718550822)
2007-10-10 14:10:11 -05:00
Stefan Metzmacher
73b066281e r17081: add idle handler support to the smb2 client lib too
metze
(This used to be commit 1f48e7dca6)
2007-10-10 14:10:11 -05:00
Stefan Metzmacher
440d0487a6 r17020: pass the real error to the failing requests
metze
(This used to be commit 49b96ac44a)
2007-10-10 14:10:08 -05:00
Stefan Metzmacher
09b9d831c2 r17019: don't timeout on notifies
metze
(This used to be commit 8d4fd35b10)
2007-10-10 14:10:08 -05:00
Stefan Metzmacher
a8958391e8 r16980: - make struct smb_notify a union and add levels RAW_NOTIFY_NTTRANS,RAW_NOTIFY_SMB2
- parse SMB2 Notify reponse

metze
(This used to be commit de50e0ccdd)
2007-10-10 14:10:06 -05:00
Stefan Metzmacher
86c3e628e0 r16975: implement SMB2 Notify call in the client lib
metze
(This used to be commit a455dc7a83)
2007-10-10 14:10:04 -05:00
Stefan Metzmacher
d89b4adf7a r16949: add and fix some NOTIFY return codes
metze
(This used to be commit e40d62363c)
2007-10-10 14:10:02 -05:00
Stefan Metzmacher
5468516f9a r16918: the SMB2 Ioctls are sometimes called with a wildcard handle
the operation doesn't need a valid file handle in that case

metze
(This used to be commit d41a83d559)
2007-10-10 14:10:00 -05:00
Stefan Metzmacher
a3797ff66a r16875: implement SMB2 Find in the frontend
metze
(This used to be commit 58bed7322c)
2007-10-10 14:09:56 -05:00
Stefan Metzmacher
7c810db7da r16873: - grow the buffer with the correct size, we maybe had 1 byte preallocated
- body_size doesn't contain the preallocated byte so don't remove it

metze
(This used to be commit 3cf50e26b7)
2007-10-10 14:09:55 -05:00
Stefan Metzmacher
bb158b74da r16871: zero padding bytes
(found by valgrind)

metze
(This used to be commit 283bec8295)
2007-10-10 14:09:55 -05:00
Stefan Metzmacher
af0a9eb529 r16834: split the level's of smb_search_first/smb_search_next and the levels
of smb_search_data

metze
(This used to be commit 78c201db8a)
2007-10-10 14:09:49 -05:00
Günther Deschner
91e4f9f6d8 r16801: Adding WERR_DS_DRA_ACCESS_DENIED.
Guenther
(This used to be commit 075242b976)
2007-10-10 14:09:46 -05:00
Rafal Szczesniak
464e352380 r16791: Typo fix in a comment.
rafal
(This used to be commit 48a9f82244)
2007-10-10 14:09:46 -05:00
Stefan Metzmacher
6acd9aed93 r16734: the 2 bytes after the opcode and before the flags,
is no padding...

the following patch is needed for vista beta2 to connect to samba4

metze
(This used to be commit 58baae8fc4)
2007-10-10 14:09:42 -05:00
Stefan Metzmacher
63d0c5a057 r16708: the packet format of SMB2 SessionSetup has changed,
there're 8 more unknown bytes...

Note:
 - vista-CTP also support this as a server,
   but uses the old format as client
 - but vista-beta2 only uses and accept the new format

metze
(This used to be commit b3bdd4afde)
2007-10-10 14:09:40 -05:00
Stefan Metzmacher
bd0dcebe36 r16705: fix a bug found by valgrind...
as we setup the 1 padding byte for non present dynamic part,
we need to overwrite it when we're getting a real dynamic part,
so we need to remove the buf->size +=1 when we do the first
push to the dynamic part (when buf->dynamic is still but->body + buf->body_fixed)

metze
(This used to be commit f309209629)
2007-10-10 14:09:39 -05:00
Stefan Metzmacher
d63dd113ae r16699: the layout of SMB2 Read and Write is identical...
so we know that the 9th bytes is just uninitialized padding

metze
(This used to be commit f97a21b970)
2007-10-10 14:09:39 -05:00
Stefan Metzmacher
bd1efc1235 r16669: this calls don't expect any valid error codes than NT_STATUS_OK
metze
(This used to be commit 429215113b)
2007-10-10 14:09:37 -05:00
Stefan Metzmacher
332f5b19a1 r16667: - use ndr_pull_struct_blob() to make the RAW_FILEINFO_SEC_DESC pull code
simpler
- use ndr_push_struct_blob() for RAW_SFILEINFO_SEC_DESC

metze
(This used to be commit 79e51f033e)
2007-10-10 14:09:37 -05:00
Stefan Metzmacher
0646a91bc9 r16569: - use push_string()
metze
(This used to be commit f099fcb6e3)
2007-10-10 14:09:35 -05:00
Stefan Metzmacher
7dc22bf3e0 r16566: add pull function for a site32/offset32 blob
metze
(This used to be commit 81702c36c2)
2007-10-10 14:09:35 -05:00
Stefan Metzmacher
7bf085571e r16464: split client and server min/max protocol settings
metze
(This used to be commit 6164d1e22e)
2007-10-10 14:09:29 -05:00
Stefan Metzmacher
d3b3436ce1 r16406: use the generic smb_handle in smb2_getinfo/smb2_setinfo
metze
(This used to be commit dcc02df829)
2007-10-10 14:09:13 -05:00
Gerald Carter
e3a6c6be79 r16100: Patch from Michael Wood <mwood@icts.uct.ac.za>: s/then/than/ for correct grammar
(This used to be commit 26a2fa97e4)
2007-10-10 14:08:59 -05:00
Volker Lendecke
7613015f47 r16091: Without this patch Samba3 will not accept this, and simply setting the "92" to
"100" will give funny permissions...

Volker
(This used to be commit b76a3d4f59)
2007-10-10 14:08:59 -05:00
Andrew Bartlett
c38f24b021 r16073: On an incoming wildcard search, it is critical that the size be
correct, or we try and do a memcmp on the trailing '\0'.

This happens because we now use memcmp for the prefix matching.

I just wish I had a test other than a particular invocation of the OSX
client.  (I've tried and failed so far)

Andrew Bartlett
(This used to be commit 36aa839080)
2007-10-10 14:08:57 -05:00
Andrew Tridgell
971d30bb20 r15854: more talloc_set_destructor() typesafe fixes
(This used to be commit 61c6100617)
2007-10-10 14:08:32 -05:00
Andrew Tridgell
0b56e916a7 r15835: fixed locking in the client library
(This used to be commit 7ea51fb624)
2007-10-10 14:08:31 -05:00
Andrew Tridgell
e5e9bcd398 r15834: fixed a memory leak in the session code
(This used to be commit 8a7047c102)
2007-10-10 14:08:30 -05:00
Stefan Metzmacher
e982523bc0 r15820: this line was just for testing
metze
(This used to be commit 1a9bfa2ac9)
2007-10-10 14:08:28 -05:00
Stefan Metzmacher
a2f463bb3a r15815: add SMB2 Lock client code
metze
(This used to be commit 4a307d7185)
2007-10-10 14:08:27 -05:00
Stefan Metzmacher
d9bdfb0a07 r15814: add SMB2 Lock interface structure
metze
(This used to be commit 8f1850ef65)
2007-10-10 14:08:27 -05:00
Andrew Tridgell
79183f68fc r15794: fixed a problem with DOS status codes - found by kukks (thanks!)
(This used to be commit 1a57b16715)
2007-10-10 14:08:21 -05:00
Stefan Metzmacher
39fd6db42b r15775: add some privilege related WERROR codes
metze
(This used to be commit 4e8c9bbd76)
2007-10-10 14:08:17 -05:00
Stefan Metzmacher
1911475976 r15770: when there's a dynamic body, we need to send the first byte even if the
dynamic size if 0

metze
(This used to be commit c7e8e79d75)
2007-10-10 14:08:16 -05:00