1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

73 Commits

Author SHA1 Message Date
Andrew Bartlett
3b6695de36 r23994: Finish my work to ensure that non-root and non-administrator users
cannot vampire, provision or upgrade a Samba4 server via SWAT.

(The previous commit was an accident, and not complete).

This should get Samba4 closer to being 'secure' for an alpha release.

Andrew Bartlett
2007-10-10 15:01:16 -05:00
Andrew Bartlett
d61061052d r23966: It isn't great, but at least now we have some access control in SWAT
This patch prevents non-root and non-administrator users from running
the provision, upgrade and vampire pages.  *I think* the rest of SWAT
is LDB operations, or otherwise authenticated, so we should now be
secure.

I wish I had a better way to 'prove' we got this right, but this is better than nothing, and moves us closer to an alpha.

Andrew Bartlett
2007-10-10 15:01:13 -05:00
Andrew Bartlett
430c998dc9 r23351: Merge from SAMBA_4_0_RELEASE:
Fix a nasty issue we had with SWAT.  We could not provision into a
different domain, as we didn't re-calcuate the DOMAINDN after the user
changed it in the form.

Andrew Bartlett
2007-10-10 14:53:11 -05:00
Andrew Bartlett
96df61e3a8 r23325: Remove items from menu that have been removed from SVN long ago, with
the start of the transition to the new SWAT.

Andrew Bartlett
2007-10-10 14:53:11 -05:00
Andrew Bartlett
bed522df4b r23286: In SWAT, it was not possible to use a domain name other than the default.
Fix this in the same way the setup/provision script does.

Andrew Bartlett
2007-10-10 14:53:08 -05:00
Rafal Szczesniak
01b1b2b36b r22501: dispatching events explicitly is not necessary.
rafal
2007-10-10 14:51:34 -05:00
Rafal Szczesniak
ebc67bc0ae r22500: there's a better way to find out if there are any children
rafal
2007-10-10 14:51:34 -05:00
Rafal Szczesniak
c438284adf r22499: UsrCtx should be created within UsersView. Tree widget just
opens it and passes the domain name(s) to operate on (selectable
via combo box).

rafal
2007-10-10 14:51:34 -05:00
Rafal Szczesniak
3face29cc2 r22487: Add a separate widget class for listing users and reposition
things on NetManager's screen. Qooxdoo layout positioning can
be tricky sometimes...

rafal
2007-10-10 14:51:32 -05:00
Rafal Szczesniak
00098b6d55 r22346: Fix small mistake - after sending rpc request we should go to await
rpc result state instead of idle.

rafal
2007-10-10 14:51:06 -05:00
Rafal Szczesniak
543bbb4e56 r22325: Typo fix
rafal
2007-10-10 14:51:02 -05:00
Rafal Szczesniak
3f717e7fc7 r22324: Another step closer to nice listing of user accounts.
rafal
2007-10-10 14:51:02 -05:00
Rafal Szczesniak
f12a7f223d r22136: Fix incorrect event handling.
Submitted by John Jorgensen <jorgensen.john@gmail.com>

rafal
2007-10-10 14:49:54 -05:00
Rafal Szczesniak
aac34f79d0 r22005: Add more code (doesn't work at the moment) preparing a place for
listing user accounts.

rafal
2007-10-10 14:49:41 -05:00
Rafal Szczesniak
2ee075605e r21852: Further work on initialising libnet context from netmgr.
rafal
2007-10-10 14:49:37 -05:00
Derrell Lipman
44d5f5ec6d r21810: - The height of a widget is in relation to its enclosing widget. Specifying a
height of 100% means that if the enclosing widget is 100 pixels high, this
  widget should be 100 pixels high.  If this widget is then placed someplace
  other than at the top of the enclosing widget, e.g. with top:20, the bottom
  of this widget will fall off the bottom of the enclosing widget.

  The normal way to solve this is to specify top and bottom attributes rather
  than top and height attributes.  Also, since widgets often look better if
  they don't extend all the way to the very bottom, specifying a bottom
  attribute equal to the top attribute typically has an appealing appearance.

  I've fixed the tree widget so it no longer falls off the bottom of the page.
2007-10-10 14:49:30 -05:00
Derrell Lipman
ab620c9554 r21809: - If the canvas is never initialized with the tree, the tree will never
appear.  Now that the finite state machine properly ignores events from
  widgets which are not handled, the initialization of the tree should be done
  when the module's canvas appears (i.e. just after the canvas has had the
  module's gui applied to it).
2007-10-10 14:49:30 -05:00
Derrell Lipman
512dc61e84 r21808: - Fix a nasty bug in the finite state machine that allowed an event from a
non-handled widget to be processed as if the event originated from a handled
  widget.  This was allowing the appear event for the module's canvas in
  Mimir's Net Manager (an event which was not handled) to load the tree,
  followed by the tree appear event (intended to be handled, albeit
  incorrectly -- see subsequent check-in of Mimir's Fsm.js) to again load the
  tree, thus the double entry.

  Wow, the above paragraph is really hard to read. :-)
2007-10-10 14:49:30 -05:00
Rafal Szczesniak
de0f7c42be r21787: Add new module to the swat application.
rafal
2007-10-10 14:49:26 -05:00
Rafal Szczesniak
d92604ebd2 r21786: My initial attempts in qooxdoo coding. Derrell, please take
a look and I'll have a lot of questions to you.

rafal
2007-10-10 14:49:25 -05:00
Simo Sorce
37484924bc r21371: Ehmm I was reseting the wrong dataModel... 2007-10-10 14:48:21 -05:00
Simo Sorce
115a8658c6 r21367: Clear out the table with a deleted object contents after the record is deleted.
Could be confusing otherwise.
2007-10-10 14:48:21 -05:00
Simo Sorce
fab315bb8c r21366: Until we have a schema enforcing module (which will make it
impossible to add object without an objectclass), we need to
use the default ldb search filter (an empty one), to retrieve
all objects, and all record contents.
2007-10-10 14:48:20 -05:00
Simo Sorce
8ed568ae10 r21328: Ok, now we can successfully modify the ldb and refresh the tree
but ...
- we have a problem with removeAll() in ldbmodify
- we seem to not properly cactch errors, we always return a "success"
  alert even if the operation is not successful :(
2007-10-10 14:48:13 -05:00
Derrell Lipman
39a4803ad1 r21326: get rid of old qooxdoo version. 2007-10-10 14:48:12 -05:00
Derrell Lipman
4ee68f55da r21325: delete children in reverse order since the array is manipulated during the recursive delete 2007-10-10 14:48:11 -05:00
Derrell Lipman
6c86cd416b r21321: - Allow pruning all of the children of a node without removing the node
itself.

- By default, create only one meta column if only the tree is displayed.  If
  additional columns are displayed, then put all of them in a separate meta
  column, and the tree in the first meta column by itself.
2007-10-10 14:48:10 -05:00
Derrell Lipman
2dc0748640 r21304: - Get rid of the extra set of scroll bars in the tree. The tree never grows
or needs scroll bars; rather, it's internal areas within the tree widget
  that provide the scroll bars.  (The next version of TreeVirtual will prevent
  setting overflow to anything other than "hidden".)
2007-10-10 14:48:07 -05:00
Jelmer Vernooij
07652f65ce r21297: Remove the GTK+ tools and library from the main repository. They are now maintained separately in bzr at http://people.samba.org/bzr/jelmer/samba-gtk
This also adds some more headers to the list that is installed and a couple of extra #include lines so these
headers can be used externally without problems.
2007-10-10 14:48:04 -05:00
Derrell Lipman
a6fc47eff3 r21287: Improve user feedback. Cursor now changes to stopwatch during RPC and module loading. 2007-10-10 14:45:00 -05:00
Derrell Lipman
a66b64026a r21286: Tree column now resizes wiith splitter adjustment, but scrollbars don't yet update properly 2007-10-10 14:44:59 -05:00
Derrell Lipman
c3c93ad36a r21285: - Add the new ResizeTableColumnModel and make use of it in TreeVirtual. This
allows the Ldb Browser tree to properly size itself upon initially appearing
  and upon window resizes.  There are still a few problems with it that I need
  to resolve, including an occasional set of double scrollbars, and making it
  resize the tree column when the splitter is resized.
2007-10-10 14:44:59 -05:00
Simo Sorce
0cee51ca2e r21266: Add/Modify/Delete operations seem to work correctly now
Still no refresh, so the results may seem confusing
2007-10-10 14:44:56 -05:00
Simo Sorce
ed7e00e2a0 r21252: Add operation works now, still to do mod and del ops
Need to implement tree refresh as well
2007-10-10 14:44:53 -05:00
Simo Sorce
3367f2fe69 r21249: Now the ldif is generated correctly, but still rpc is not happy 2007-10-10 14:44:53 -05:00
Derrell Lipman
c3c3030a7d r21248: - Test for Simo: no change of selected row(s) upon open/close click. Simo,
I haven't done any testing of this.  Please let me know the side effects, if
  any, of this change.
2007-10-10 14:44:53 -05:00
Derrell Lipman
ca3b806070 r21221: 'make build' should be the default target for us 2007-10-10 14:44:48 -05:00
Derrell Lipman
341e12496c r21220: enable 'make source' (and 'make') to work properly 2007-10-10 14:44:48 -05:00
Derrell Lipman
23a8b77763 r21187: - Convert LdbBrowse to use TreeVirtual. This adds the following capabilities
that Simo asked for:

  * One can now open a branch without selecting the row.  The previously
    selected row (if any) remains selected.

  * Selecting a row does not automatically open the branch.  That can be done
    by either clicking on the open/close button or pressing Enter while that
    row is selected.

  * The entire tree can now be disabled.  In LdbBrowse, the fsm is configured
    to disable the tree during each remote procedure call, so that a pile of
    requests don't get queued during RPC.

  The most obvious flaw with TreeVirtual right now, is that the tree does not
  properly resize (or even initially size itself) to its container.  Fixing
  that is my next task.  It's actually a generic Table issue that people have
  been asking for for ages: having columns resize themselves automagically.
2007-10-10 14:44:44 -05:00
Derrell Lipman
1dde7f477b r21185: Fix PNG images in TreeVirtual, for when using IE 2007-10-10 14:44:44 -05:00
Derrell Lipman
194880f1ff r21169: - Step 3: Upgrade qooxdoo release code with latest qooxdoo svn's Table and
TreeVirtual.  The TreeVirtual that was in the release was a very early
  pre-release, and had a number of problems and missing features.  This brings
  it up-to-date and provides what seems to be a pretty well-working and highly
  useful widget.
2007-10-10 14:44:39 -05:00
Derrell Lipman
754c4fe01f r21168: - Step 2: Update swat for the latest qooxdoo version. The build now copies
only those icons which are actually used.  This means that instead of a few
  thousand files getting copied to /usr/local/samba/share/webapps (or
  wherever), the number is less than an order of magnitude fewer.  This should
  make Andrew happier yet.
2007-10-10 14:44:39 -05:00
Derrell Lipman
d161c1382c r21167: - Upgrade to latest released qooxdoo. This is step 1 of the upgrade process,
which involves adding the latest SDK.  This new version has not 2, but 4
  icon themes.  In order to quiet Andrew B. who thinks that 9000+ files in a
  gui api is too many (come on, disk space is free these days :-), I have
  removed 3 of the 4 icon themes, leaving only the default, Nuvola.  That
  lowers the file count by 1/3.  I'm sure Andrew still isn't happy, but I hope
  he's a bit happier...  Step 2 will make him happier yet.
2007-10-10 14:44:34 -05:00
Simo Sorce
433591c430 r21136: First attempt at implementing add/modify rpc calls.
The code does not work, but Derrell asked me to commit to analyze the problem.

Simo.
2007-10-10 14:44:32 -05:00
Simo Sorce
afa61d5971 r21126: Enhance the modal window so that it gets focus and just presing enter works.
Still I don't see the cursor :(

Swap -/+ buttons, you risk to delete an attribute by mistake when instead you want to add a new one,
and you might even not notice it.

Simo.
2007-10-10 14:44:31 -05:00
Simo Sorce
e2d1f6d291 r21118: Looks a bit better ... 2007-10-10 14:44:30 -05:00
Simo Sorce
d25e828dbe r21095: Expose all naming contexts 2007-10-10 14:44:29 -05:00
Simo Sorce
f0ddc50382 r21065: The framework is complete (yes the gui layout still sucks but that will
be handled later)
next will be to build out the code to actually commit changes
2007-10-10 14:44:26 -05:00
Simo Sorce
9cd488cf57 r21048: Start coding add/modify widgets.
Not functional yet.
2007-10-10 14:44:25 -05:00
Andrew Bartlett
b3fdbfbe81 r21008: We added a new argument to the provision() function, but I forgot to
update SWAT.

Andrew Bartlett
2007-10-10 14:44:20 -05:00