1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

47 Commits

Author SHA1 Message Date
Jeremy Allison
12ba88574b r22542: Move over to using the _strict varients of the talloc
calls. No functional changes. Looks bigger than it is :-).
Jeremy.
(This used to be commit f6fa3080fe)
2007-10-10 12:19:44 -05:00
Jeremy Allison
b22ffe77e5 r21666: (only in 3.0, not 3.0.25). Fix bad parameter to call.
Jeremy.
(This used to be commit 9b16c57960)
2007-10-10 12:18:23 -05:00
Jelmer Vernooij
62e11c4f17 r20832: Remove extra pointers previously added to unique [out] pointers. Instead,
add [ref] pointers where necessary (top-level [ref] pointers,
by spec, don't appear on the wire).

This brings us closer to the DCE/RPC standard again.
(This used to be commit 580f2a7197)
2007-10-10 12:17:11 -05:00
Volker Lendecke
d6d17ea883 r20271: Fix the build
(This used to be commit c703d2ae1f)
2007-10-10 12:16:38 -05:00
Herb Lewis
e59e787b48 r20269: merge -r20264:20267 from SAMBA_3_0_24
more no previous prototype warnings
(This used to be commit 41be182f78)
2007-10-10 12:16:38 -05:00
Volker Lendecke
f57cd1f63c r19914: The "default" value with the name "" need different 0-length treatment as the
other StringBufs, otherwise clicking on a key with this value being set leads
to regedit.exe on w2k3 chew all memory.
(This used to be commit b148cde7f3)
2007-10-10 12:16:09 -05:00
Volker Lendecke
9849f04868 r19790: Check in the PIDL change and the converted unixinfo and winbind pipes without
waiting for comments. This is what version control is for, and it does fix a
segfault I ran into ;-)

Nevertheless, Jelmer & Jerry, please take a look!

Thanks,

Volker
(This used to be commit 95c14a822c)
2007-10-10 12:15:55 -05:00
Gerald Carter
ff8f68840d r19006: Final cleanups for the winreg libmsrpc functions.
Needs thorough testing but the code has been adapted
to the new rpccli_winreg_XX() API.
(This used to be commit c3d1c3ca4d)
2007-10-10 12:14:56 -05:00
Gerald Carter
18d4176633 r18981: * cleanup some vestiges of old cli_reg.c code and mark some TODO
items in cac_winreg.c
* Get 'net rpc registry enumerate' to list values again
* Fix winreg.idl QueryInfoKey().  The max_subkeysize is the
  max_classlen (we previously had this correct in Samba3")
* fix valgrind error about uninitialized memory and use-before-set
  on size value inmemset() call
* Fix key enumeration in 'net rpc registry enumerate'
* regenerate gen_dir files based on local pidl patches

Please note that the generated ndr files are from my local
copy of pidl.  If you need to regenerate, please apply the
patch that I posted to the samba-technical list earlier today.
(This used to be commit 5d843612a1)
2007-10-10 12:14:53 -05:00
Gerald Carter
2326b147d0 r18963: * Move parts of registry headers that were still in
use to reg_objects.h
* Remove unused rpc headers
(This used to be commit 4f79d8c83d)
2007-10-10 12:14:51 -05:00
Gerald Carter
94c9d52872 r18959: reformat using indent
(This used to be commit 69c298f85d)
2007-10-10 12:14:50 -05:00
Gerald Carter
bbaa0b178d r18919: * Get the new rpccli_winreg_XXXX() functions into the tree
There some broken functionality here that I'm still working on.
* remove unneeded parsing routines
(This used to be commit cbfe1a4b49)
2007-10-10 12:14:46 -05:00
Gerald Carter
05ba38f754 r18747: replace rpccli_lsa_close() with rpccli_lsa_Close()
(This used to be commit 50d74ce048)
2007-10-10 12:00:54 -05:00
Jelmer Vernooij
4db7642caa r18745: Use the Samba4 data structures for security descriptors and security descriptor
buffers.

Make security access masks simply a uint32 rather than a structure
with a uint32 in it.
(This used to be commit b41c52b9db)
2007-10-10 12:00:54 -05:00
Gerald Carter
a6ddf9bf5d r18711: Replace the following hand code client routines:
* rpccli_reg_abort_shutdown()
* rpccli_reg_flush_key()
Remove the cmd_reg.c from rpcclient since the entire file
was unused
(This used to be commit c4788f0c13)
2007-10-10 12:00:51 -05:00
Jelmer Vernooij
4e7d11449a r18654: Rename "struct uuid" => "struct GUID" for consistency.
(This used to be commit 5de76767e8)
2007-10-10 11:52:19 -05:00
Gerald Carter
c4013df0c1 r18560: * Add in the winreg and initshutdown IDL files
* rename PI_SHUTDOWN from include/smb.h to PI_INITSHUTDOWN
  for compatibility with pidl libndr output
(This used to be commit 23a8828613)
2007-10-10 11:51:50 -05:00
Gerald Carter
2b27c93a9a r18271: Big change:
* autogenerate lsa ndr code
* rename 'enum SID_NAME_USE' to 'enum lsa_SidType'
* merge a log more security descriptor functions from
  gen_ndr/ndr_security.c in SAMBA_4_0

The most embarassing thing is the "#define strlen_m strlen"
We need a real implementation in SAMBA_3_0 which I'll work on
after this code is in.
(This used to be commit 3da9f80c28)
2007-10-10 11:51:18 -05:00
Jelmer Vernooij
995205fc60 r18188: merge 3.0-libndr branch
(This used to be commit 1115745cae)
2007-10-10 11:43:56 -05:00
Volker Lendecke
467ec2a32b r17363: Some C++ warnings
(This used to be commit fd82f185a2)
2007-10-10 11:38:28 -05:00
Jeremy Allison
fbdcf2663b r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
(This used to be commit 9dafb7f48c)
2007-10-10 11:19:14 -05:00
Jeremy Allison
2b8abc030b r16644: Fix bug #3887 reported by jason@ncac.gwu.edu
by converting the lookup_XX functions to correctly
return SID_NAME_TYPE enums.
Jeremy.
(This used to be commit ee2b2d96b6)
2007-10-10 11:19:05 -05:00
Jeremy Allison
f18df87fe9 r16585: Fix Klocwork #1976. Possible null deref.
Jeremy.
(This used to be commit a912ef0d97)
2007-10-10 11:19:01 -05:00
Jeremy Allison
7d187fe7e0 r16546: Fix bug #3865 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit be888a3cda)
2007-10-10 11:18:59 -05:00
Jim McDonough
0e0d21dd3d r14408: More on fix for coverity #36. The previous fix would cause us to
marshall a buffer based on an unknown size.  Zero out the sec_desc
buffer to prevent this.  This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
(This used to be commit cb370cc28c)
2007-10-10 11:15:29 -05:00
Jeremy Allison
fa42d65a47 r14406: Disable this call until we can sort out how this
should be done correctly. Fix coverity #37.
Jeremy.
(This used to be commit d241f74e06)
2007-10-10 11:15:29 -05:00
Jeremy Allison
e6676a9a69 r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
(This used to be commit f65d7afe19)
2007-10-10 11:15:27 -05:00
Simo Sorce
be738dd31d r14377: Fix coverity #4 for 3_0 too
(This used to be commit aa26642ee1)
2007-10-10 11:15:27 -05:00
Volker Lendecke
5c1e6f0a9e r14367: Not that I fully understand what's going on here, but the code as it was here
was clearly buggy as Coverity showed with bug id #36.

According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship
it in the request.

Volker
(This used to be commit 075e784491)
2007-10-10 11:15:27 -05:00
Jeremy Allison
15603e1c2f r14261: Fix coverity #38. No null deref.
Jeremy.
(This used to be commit 2a2b966b7b)
2007-10-10 11:15:21 -05:00
Volker Lendecke
cdf4508058 r14224: Fix Coverity bug # 6
(This used to be commit e1c617adae)
2007-10-10 11:15:18 -05:00
Jeremy Allison
de106cf702 r14212: Definately fixes a coverity issue but I've lost track
of the coverity id.... Oh well - definately needs a fix.
Jeremy.
(This used to be commit 54c899ef3b)
2007-10-10 11:15:16 -05:00
Jeremy Allison
1e34c29596 r14196: Move to using talloc, not malloc for all policy handles.
Jeremy
(This used to be commit 6f4804a265)
2007-10-10 11:15:16 -05:00
Jeremy Allison
cfa4589662 r14194: Coverity bug #35. Fix uninitialized pipe_hnd.
Jeremy.
(This used to be commit 8aca76f035)
2007-10-10 11:15:16 -05:00
Jeremy Allison
5fe30d0f35 r14192: Don't forget to correctly initialize pipe_hnd.
Coverity fix #34.
Jeremy.
(This used to be commit 6b3dc96dcf)
2007-10-10 11:15:16 -05:00
Jeremy Allison
b96f20a316 r14190: Coverity bug #33. Missing initialization of pipe_hnd.
Jeremy.
(This used to be commit 144fda3637)
2007-10-10 11:15:15 -05:00
Jeremy Allison
2992ba0690 r14188: Coverity fix #32. Don't deref null.
Jeremy.
(This used to be commit 218c924d91)
2007-10-10 11:15:15 -05:00
Jeremy Allison
cc122aa6ff r14186: Coverity fix #31. Don't deref null.
Jeremy.
(This used to be commit 014a3c8661)
2007-10-10 11:15:15 -05:00
Günther Deschner
9f2e29799e r13864: Some cleanup and the samr set security object function client-side.
Guenther
(This used to be commit 0ae3fddf95)
2007-10-10 11:10:57 -05:00
Gerald Carter
fb5362c069 r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()
macro which sets the freed pointer to NULL.
(This used to be commit b65be8874a)
2007-10-10 11:10:14 -05:00
Jeremy Allison
6791180b81 r13491: Fix bug # 3498 from jason@ncac.gwu.edu. Unsigned comparison
with < 0.
Jeremy.
(This used to be commit 9a08383707)
2007-10-10 11:10:06 -05:00
Gerald Carter
0af1500fc0 r13316: Let the carnage begin....
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed)
2007-10-10 11:06:23 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a78)
2007-10-10 11:05:02 -05:00
Gerald Carter
d77621c425 r11125: remove unused variables
(This used to be commit d404919d92)
2007-10-10 11:05:01 -05:00
Gerald Carter
846d52efae r11124: Commit Chris' fixes for libmsrpc after the rpc_client
rewrite.  His comments:

        I've gotten the libmsrpc code to work with TRUNK.
        I've put the patch at:
        www.uoguelph.ca/~cnicholl/libmsrpc_trunk_v1.patch.gz

        It is from revision 11093.

        I also fixed a minor bug in the svcctl code, the timeout
        parameter for all the control functions was working
        in milliseconds instead of seconds.

Also fixed bug in Makefile when building libmsrpc.a
(This used to be commit d3a52900ec)
2007-10-10 11:05:01 -05:00
Gerald Carter
945abd1cb7 r10005: forgot to remove one object file
(This used to be commit adba19fb48)
2007-10-10 11:03:31 -05:00
Gerald Carter
3c6b0f9655 r10003: in the rush for 10k, I forgot to run add the rest of Chris' libmsrpc files
(This used to be commit 32bebc452d)
2007-10-10 11:03:30 -05:00