1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

14326 Commits

Author SHA1 Message Date
Andrew Tridgell
ddf3c6d5cc This is a critical bug fix for a data corruption bug. If you
maintain another tree then please apply!

On non-X86 machines out byte-order macros fails for one particular
value. If you asked for IVAL() of 0xFFFFFFFF and assigned it to a 64
bit quantity then you got a 63 bit number 0x7FFFFFFFFFFFFFFF rather
than the expected 0xFFFFFFFF. This is due to some rather bizarre and
obscure sign extension rules to do with unsigned chars and arithmetic
operators (basically if you | together two unsigned chars you get a
signed result!)

This affected a byte range lock using the large lockingX format and a
lock of offset 0 and length 0xFFFFFFFF. Microsoft Excel does one of
these locks when opening a .csv file. If the platform you run on does
not then handle locks of length 0x7FFFFFFFFFFFFFFF then the posix lock
fails and the client is given a lockingX failure. This causes the .csv
file to be trunated!!
(This used to be commit 886661c377)
2003-07-31 04:01:32 +00:00
Jeremy Allison
ba12e6bb5f Wrap calls to change_oem_password() in become_root()/unbecome_root() pairs
to allow UNIX password change scripts to work correctly. This is safe as
the old password has been checked as correct before invoking this.
Jeremy.
(This used to be commit 1734d43eb5)
2003-07-31 01:33:44 +00:00
Jeremy Allison
aa7f82c5cc Turn the 'doing_signing' variable on - fix bug where it was only being set
on when signing was mandatory.
Jeremy.
(This used to be commit 7c58673a10)
2003-07-31 00:30:01 +00:00
Jeremy Allison
29ca70cd34 Add a command line option (-S on|off|required) to enable signing on client
connections. Overrides smb.conf parameter if set.
Jeremy.
(This used to be commit 879309671d)
2003-07-30 23:49:29 +00:00
Jeremy Allison
d6ee1d167c Save us from possibly uninitialised variable (caught by gcc).
Jeremy.
(This used to be commit f3f29665bd)
2003-07-30 23:33:56 +00:00
Jeremy Allison
9c49c46948 Fix bug we discovered in W2K client signing on secondary trans2 packets.
Use W2K parameters. tpot please re-test smbclient with your problem
directory.
Jeremy.
(This used to be commit 677d3a3c4c)
2003-07-30 19:00:52 +00:00
Jeremy Allison
5ab2b1e921 Eliminate valgrind error when client gets bad sig on list. Some reformatting.
Jeremy.
(This used to be commit b8f6b83646)
2003-07-30 18:57:37 +00:00
Gerald Carter
c856d9274b add a few more tidy ups. Now onto winbindd
(This used to be commit f8abdd23e1)
2003-07-30 17:37:46 +00:00
Gerald Carter
de1a998622 add support for DsEnumerateDomainTrusted for enumerating all the
trusted domains in a forest.
(This used to be commit c691c7f7d9)
2003-07-30 17:29:00 +00:00
Jeremy Allison
316c77ed0b Don't revert something until you've seen if volker has already fixed it :-).
Jeremy.
(This used to be commit d57d9b99df)
2003-07-30 16:34:14 +00:00
Jeremy Allison
f5799f2db2 Comment out mutex until I get dependencies sorted out...
Jeremy
(This used to be commit 382d1732ca)
2003-07-30 15:30:36 +00:00
Volker Lendecke
9dbc000ecd bin/net needs server_mutex as kerberos_verify now uses it.
Volker
(This used to be commit ee09db891a)
2003-07-30 08:05:34 +00:00
Jeremy Allison
1b89b58475 Put mutex around access of replay cache for krb5 tickets. krb5 replay cache
is not multi-process safe.
Jeremy.
(This used to be commit 9e0534a1b6)
2003-07-29 21:32:36 +00:00
Herb Lewis
edabf75a54 split replace into replace and replace1 to allow setenv to be used by
nsswitch modules. Add required libraries to get rid of undefined
functions for libns_winbind.so and libns_wins.so
(This used to be commit cec5bf5f99)
2003-07-29 20:11:18 +00:00
Jeremy Allison
6070a519c2 Fix bug #226. Stop unmangle of name into a wildcard name from deleting more
than was intended.
Jeremy.
(This used to be commit e2742e0d89)
2003-07-29 19:16:59 +00:00
Alexander Bokovoy
428653ef72 Add NT quotas support. Users allowed now to manage quotas on systems with sysquotas interface detected (Linux at least) using native Windows tools. Also move default quota support for NT quotas to VFS module default_quota. Code by Metze
(This used to be commit e856a96c2c)
2003-07-29 18:07:13 +00:00
Jeremy Allison
79a5d2e31b Finish tridge's patch as referenced here :
make sure we don't allow the creation of directories containing
wildcard characters. I've only put this in mkdir at the moment, but I
suspect this will apply to all places that can create new filenames.

We need to allow the opening of existing filenames that contain
wildcards, but not allow the creation of new ones.

Jeremy.
(This used to be commit 7f111e545d)
2003-07-29 17:34:20 +00:00
Jeremy Allison
b40d1a2a76 Typo on my part. I typed KRB5_KDB_BAD_ENCTYPE when I meant to type KRB5_BAD_ENCTYPE.
Heimdal has the latter, not the former.
Jeremy.
(This used to be commit e8425df77c)
2003-07-29 17:03:51 +00:00
Jim McDonough
15188bcb02 Fix the build on Heimdal. KRB5_KDB_BAD_ENCTYPE doesn't exist on Heimdal, and
it's a different rc than KRB5_BAD_ENCTYPE (which exists on both MIT and
Heimdal).  This will just make the debug show up at level 3 always.

Jeremy, you may want to revisit this, but it's probably not worth the hassle.
(This used to be commit 4ff322ccf9)
2003-07-29 16:34:31 +00:00
Volker Lendecke
7730b658a1 This adds gss-spnego to ntlm_auth. It contains some new spnego support
from Jim McDonough. It is to enable cyrus sasl to provide the
gss-spnego support. For a preliminary patch to cyrus sasl see

http://samba.sernet.de/cyrus-gss-spnego.diff

Volker
(This used to be commit 45cef8f66e)
2003-07-29 15:00:38 +00:00
Tim Potter
4db6b05e13 Typo fix for bug 258.
(This used to be commit a4e342c20c)
2003-07-29 02:34:18 +00:00
Jeremy Allison
05875e573c Improved debug messages whilst trying to track down kerb issues.
Jeremy.
(This used to be commit 29dd71ddea)
2003-07-29 00:31:44 +00:00
Tim Potter
4e4e1de9cb More memory leak fixes from Brett! It turns out PyDict_SetItemString
didn't behave exactly as I thought it did.  If you create an item using a
PyFoo_FromBar function you must decrement the reference to that object
afterwards (or use Py_BuildValue).
(This used to be commit 2a960963fb)
2003-07-29 00:15:23 +00:00
Tim Potter
17c6789df1 Memory leak fixes from Brett A. Funderburg - don't use the connection talloc
context for data that is only needed on a per-call basis.
(This used to be commit 3cb39ddee4)
2003-07-29 00:08:05 +00:00
Tim Potter
84d98dd460 Add debug output api's from lsa/spoolss modules to smb module. Patch
from Brett A. Funderburg.
(This used to be commit 2cedaff044)
2003-07-29 00:05:17 +00:00
John Terpstra
d82199a61b Corrected description of SWAT FLAGS since they have changed as a result of the
cleanup of loadparm and swat.c
(This used to be commit 6956eb9a0b)
2003-07-28 05:49:51 +00:00
John Terpstra
8dea1bb932 Cleanup of loadparm and swat to correctly display all parameters as required.
No change to what is displayed has been made at this time. I do intend to
change the display order before 3.0.0 ships.
(This used to be commit de7d3063d9)
2003-07-28 05:47:15 +00:00
John Terpstra
b4918ea2be Add buttons to Printers View
(This used to be commit 805c33b089)
2003-07-27 19:49:23 +00:00
John Terpstra
d758d693fe Clarified what the SWAT FLAGS mean and what they do.
Note: The comments in this file regarding the FLAGS has been in need of
maintenance for some time.
(This used to be commit a0d2fa0f25)
2003-07-27 17:24:24 +00:00
Andrew Bartlett
5e2235843e Fix comment
(This used to be commit 2c395a3904)
2003-07-27 10:25:44 +00:00
Andrew Bartlett
ed7cb84dea the testsuite lib needs dummyroot too.
(This used to be commit e09a7c767e)
2003-07-27 03:43:41 +00:00
John Terpstra
ba4a111b3e Fix typo.
(This used to be commit 4cf778937e)
2003-07-27 03:43:40 +00:00
Andrew Bartlett
5ab880d684 Use the specified workgroup in 'net ads'. (Defaults to lp_workgroup()).
Andrew Bartlett
(This used to be commit e6cc5ca780)
2003-07-27 03:42:10 +00:00
Andrew Bartlett
5b84b13a1e Allow the stat cache to better handle invalid multibyte strings, by using
strdup_upper().  This function may fail - and we can just drop out of using
the cache in that case.  (Rather than panicing).

This also should get us closer to supporting all of the weird 'longer/shorter'
on uppercase/lowercase.

Andrew Bartlett
(This used to be commit d4c9261725)
2003-07-27 03:40:45 +00:00
Andrew Bartlett
1478bcd847 Try again to fix up 'session request' name exchange. This time we actualy
get the names...

Andrew Bartlett
(This used to be commit 7c9e204f7e)
2003-07-27 03:29:40 +00:00
Andrew Bartlett
abcac3d186 If we strupper_m after the alpha_strcpy() we know that it is less likaly
to contain multibyte charcters, as these should have been stripped.

Andrew Bartlett
(This used to be commit 0f7c1dda22)
2003-07-27 02:43:22 +00:00
Andrew Bartlett
224a9f35b8 When removing an 'unused' function, it helps to remove the 'unused' callers...
Andrew Bartlett
(This used to be commit 605a89493e)
2003-07-27 02:42:22 +00:00
Andrew Bartlett
4b3e0268b5 Use push_ucs2_allocate(), rather than convert_string_allocate() directly.
Remove strdup_upper/strdup_lower from their old file, now that they have
been moved to charcnv.c

Note that string_replace assumes that s is a pstring.  (doco change only)

Andrew Bartlett
(This used to be commit 6c9056029b)
2003-07-27 02:40:06 +00:00
Andrew Bartlett
455bb6de90 Some small fixes to our charset conversion code:
- Treat the NMB names in the 'session request' packet as 'ASCII'.  This means
   that we do not get invalid multibyte from the wire, even if we truncate
   in the conversion.  (Otherwise we panic when we try to strupper_m it).

 - Remove acnv_uxu2(), as it was duplicated by push_ucs2_allocate()
 - Remove acnv_dosu2(), as it is not used.

 - In push_ucs2(), with the STR_UPPER flag, do the case conversion *after*
   the UCS2 conversion, when it we know that the length can't change.  Also
   faster, as we don't need to do another 2 UCS2 conversions.

Andrew Bartlett
(This used to be commit 912035af11)
2003-07-27 02:28:25 +00:00
John Terpstra
422c2467a0 Adding idmap backend man page section.
(This used to be commit c10a0a1a0f)
2003-07-27 01:16:24 +00:00
Jeremy Allison
9fc34cafa2 Ensure all code paths set add_script.
Jeremy.
(This used to be commit 0021c83ff6)
2003-07-27 00:20:45 +00:00
John Terpstra
50548f4ddc Format tidy up.
(This used to be commit 79d6e72af5)
2003-07-26 17:46:47 +00:00
John Terpstra
a2214fc425 Fixes bug #243
(This used to be commit 22d644505f)
2003-07-26 17:09:54 +00:00
John Terpstra
168beb5360 Added buttons to change view mode. Fixes bug #212
(This used to be commit 37d2eed445)
2003-07-26 16:56:38 +00:00
Gerald Carter
2c770dd2d6 remove unnceccsary $; spotted by Lee Taylor
(This used to be commit 5cde975bec)
2003-07-26 15:50:00 +00:00
Gerald Carter
ca4dc16f85 fix typo in debug
(This used to be commit ed61628d8b)
2003-07-26 12:01:35 +00:00
John Terpstra
533982bbb5 Updating missing flags.
(This used to be commit 3b4693c3b2)
2003-07-26 01:57:16 +00:00
Jeremy Allison
0c4358889e Correctly detect an "add user script" - check that *lp_adduser_script() != '\0',
not lp_adduser_script() != NULL.
Jeremy.
(This used to be commit 2eac65ebe7)
2003-07-26 01:21:06 +00:00
Jeremy Allison
559439e1f4 Start the packet signing engine in the kerberos case in the same place
as the ntlmssp case.
Jeremy.
(This used to be commit 79e0bf8298)
2003-07-25 23:43:22 +00:00
Jeremy Allison
4632786cfb W00t! Client smb signing is now working correctly with krb5 and w2k server.
Server code *should* also work (I'll check shortly). May be the odd memory
leak. Problem was we (a) weren't setting signing on in the client krb5 sessionsetup
code (b) we need to ask for a subkey... (c). The client and server need to
ask for local and remote subkeys respectively.
Thanks to Paul Nelson @ Thursby for some sage advice on this :-).
Jeremy.
(This used to be commit 3f9e3b6070)
2003-07-25 23:15:30 +00:00