1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-28 17:47:29 +03:00

4821 Commits

Author SHA1 Message Date
Jeremy Allison
301be8c99b We're not changing last write, but setting this to be FILE_NOTIFY_CHANGE_CREATION
doesn't work. So use FILE_NOTIFY_CHANGE_LAST_WRITE (now seems to reliably fix
bug #6529 - Offline files conflict with Vista and Office 2003.
Jeremy.
2009-07-31 11:19:19 -07:00
Jeremy Allison
fc4e21bdae Tidy up treatment of ctime.
Jeremy.
2009-07-30 14:27:32 -07:00
Jeremy Allison
65165433ec Fix bug #6529 - Offline files conflict with Vista and Office 2003.
We need to send a notify message when a timestamp is changed that
can't be reflected in the underlying POSIX filesystem.
Jeremy.
2009-07-30 13:19:26 -07:00
Jeremy Allison
84bfd7395c Remove the extraneous logic in smb_set_info_standard - we
do the time twiddling logic at the smb_set_file_time level.
Jeremy.
2009-07-30 13:16:40 -07:00
Jeremy Allison
e411ec6a8a SMB_INFO_STANDARD is not a valid info level on set,
and was being read incorrectly anyway. Remove.
Jeremy.
2009-07-30 13:13:23 -07:00
Jeremy Allison
5d05d22999 Added prefer_ipv4 bool parameter to resolve_name().
W2K3 DC's can have IPv6 addresses but won't serve
krb5/ldap or cldap on those addresses. Make sure when
we're asking for DC's we prefer IPv4.
If you have an IPv6-only network this prioritizing code
will be a no-op. And if you have a mixed network then you
need to prioritize IPv4 due to W2K3 DC's.
Jeremy.
2009-07-28 11:51:58 -07:00
Volker Lendecke
5135ebd6f0 Fix a valgrind error in chain_reply
construct_reply() references the request after chain_reply has freed it.
2009-07-27 16:15:54 +02:00
Volker Lendecke
4c6547e8a1 Move 16 bytes from data to r/o text segment 2009-07-25 12:59:20 -04:00
Volker Lendecke
261ae2eb11 First patch for "new VFS" portability 2009-07-25 12:37:17 -04:00
Tim Prouty
f49f3fcb01 s3: Convert a few callers of unix_convert() over to filename_convert()
This patch also changes the unix convert flags to make sure the
correct semantics are preservered for allowing/disallowing wildcards
in the last component of the path.
2009-07-24 18:51:41 -07:00
Tim Prouty
7197ba3abd s3: Remove a few callers of get_full_smb_filename() 2009-07-24 18:51:40 -07:00
Tim Prouty
247a77a422 s3 onefs: Fix the onefs modules after the big refactoring 2009-07-24 18:46:07 -07:00
Tim Prouty
cd5133b112 s3: Simplify rename_internals() by passing in smb_filename structs 2009-07-24 15:10:45 -07:00
Tim Prouty
10324b177e s3: Allow filename_convert() to pass through unix_convert_flags and let the caller know if the path has a wildcard
This also eliminates the need for resolve_dfspath().
2009-07-24 15:10:45 -07:00
Volker Lendecke
6b801d6c4c add my copyright after the VFS rewrite 2009-07-24 13:21:45 -04:00
Volker Lendecke
033185e2a1 Make the smbd VFS typesafe 2009-07-24 11:42:05 -04:00
Volker Lendecke
c116652a30 In chain_reply, copy the subrequests' error to the main request 2009-07-24 17:17:08 +02:00
Volker Lendecke
79fd60dd38 Fix a few uninitialized variable warnings
I know those warnings are bogus, but both Coverity and gcc don't get it.
2009-07-24 10:23:04 -04:00
Volker Lendecke
4b76f279d1 Fix some nonempty blank lines 2009-07-24 02:16:00 +02:00
Tim Prouty
07d3b69b55 s3: Change unix_convert to use an smb_filename struct internally
This allows SMB_VFS_[L]STAT to be called directly.  Additionally, I
changed NTSTATUS result to be named status for consistency.

I also removed the stat_cache_add() from build_stream_path() because
stat_cache_lookup() is never actually called on a file with a stream.
There is no reason why the stat cache couldn't be consulted for
streams in the future.

Jeremy/Volker, please take a look at this one when you get a chance.
2009-07-22 11:48:22 -07:00
Tim Prouty
83284e13f9 s3: Convert some callers of vfs_lstat_smb_fname to SMB_VFS_LSTAT() 2009-07-22 11:48:22 -07:00
Tim Prouty
4b42927ec3 s3: Convert some callers of vfs_stat_smb_fname to SMB_VFS_STAT() 2009-07-22 09:51:17 -07:00
Tim Prouty
605649edc3 s3: plumb smb_filename through some of the trans2 posix_* functions 2009-07-21 12:04:59 -07:00
Tim Prouty
23c703a01e s3: Remove unnecessary callers of get_full_smb_filename
This often times means explicitly denying certain operations on a stream
as they are not supported or don't make sense at a particular level.  At
some point in the future these can be enabled, but for now it's better to
remove ambiguity
2009-07-21 12:04:59 -07:00
Tim Prouty
00e267008d s3: Remove the now unused fname parameter from filename_convert() 2009-07-21 12:04:59 -07:00
Tim Prouty
4860fc4951 s3: Fix RENAME_FLAG_RENAME path to stop calling unix_convert twice 2009-07-21 12:04:59 -07:00
Tim Prouty
78ce9dd471 s3: Remove unnecessary fname argument from callers of filename_convert 2009-07-21 12:04:59 -07:00
Tim Prouty
6b49f28592 s3: Plumb smb_filename through map_open_params_to_ntcreate 2009-07-21 12:04:58 -07:00
Christian Ambach
8b6ec5b82c do not log chdir with level 0 if reason is access denied
this changes the level of logs caused by users trying to access shares
or subdirectories for which they do not have access to in the ACL

this can fill up the samba log even with log level 0 and is more an
expected kind of logs that IMHO should not be logged with such a high
level.

All other errors while chdir() will still be logged with level 0

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
2009-07-21 10:05:21 -07:00
Tim Prouty
8e04c69e02 s3: Add some asserts to the filename util functions
In the smb_filename struct stream_name must equal NULL if there
is no stream name.  These asserts should catch any future offenders
of this invariant early.
2009-07-20 17:26:57 -07:00
Tim Prouty
f4530f6d2a s3: Plumb smb_filename through open_fake_file 2009-07-20 17:26:57 -07:00
Tim Prouty
841efce8b5 s3: Separate out a new file: filename_utils.c
This is to ease the linking pain of everything that links LOCKING_OBJ
2009-07-20 17:26:57 -07:00
Tim Prouty
82c3f505fe s3: Move is_ntfs_stream*() to filename.c 2009-07-20 17:26:57 -07:00
Tim Prouty
5a8d70d465 s3: Change fsp->fsp_name to be an smb_filename struct! 2009-07-20 17:26:56 -07:00
Tim Prouty
635e5e7ff0 s3 onefs oplocks: Replace static fstring with talloc'd dbg_ctx() 2009-07-20 17:26:56 -07:00
Tim Prouty
12a5db45e2 s3: Change file_structs to be allocated with talloc instead of malloc 2009-07-20 17:26:56 -07:00
Jeremy Allison
0bd13fda76 Fix Coverity CID 928. Removed check as this can never be null.
Jeremy.
2009-07-17 21:40:23 -07:00
Jeremy Allison
3036a9c7c1 Fix Coverity CID 929. Potential NULL deref after code refactoring.
Jeremy.
2009-07-17 21:36:55 -07:00
Jeremy Allison
d654782806 Fix coverity CID 930. Pointer check can never be null here.
Jeremy
2009-07-17 21:29:28 -07:00
Jeremy Allison
7254898bc7 Fix coverity CID 931. This check is redundent as smb_fname can
never be null in this function.
Jeremy.
2009-07-17 21:26:16 -07:00
Jeremy Allison
55b4231c77 Move the initialization of smbd_server_conn from smbd/process,
after the accept and fork, to smbd_init_globals(), so it's
done immediately on server startup. This is needed as some
messages are sent to all active smbd processes (including
the master listening daemon). If it gets a message that
forces it to scan it's current connections (ie. conn_find())
then it discovers that sconn->smb1.tcons.Connections dereferences
null (as sconn == NULL in the parent) and crashes. Yes,
I could fix all cases where sconn is used and explicitly
check for NULL but this fix is easier. It means that
the smbd_event_context() is initialized in the master
daemon and then re-initialized after fork, but that
should be being done correctly in every fork call anyway.
Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789
still panics in the reproducible test case for bug
6564, as this is one case where such a message
(MSG_SMB_CONF_UPDATED) is sent to the parent. Metze
please check. This change passes valgrind.
Jeremy.
2009-07-17 17:57:48 -07:00
Jeremy Allison
6a9e003910 Fix bug #6564 - SetPrinter fails (panics) as non root.
Missing become_root()/unbecome_root() around reload_services.
Jeremy.
2009-07-17 17:36:26 -07:00
Jeremy Allison
48a0732147 Fix bug #6551 - win98 clients cannot connect after server upgrade to samba-3.4.0.
The values of vuid and tid were not being correctly updated in the struct smb_request
when passed to chain_reply inside sessionsetupX and tconX.
Jeremy.
2009-07-15 13:59:11 -07:00
Stefan Metzmacher
377a97579b s3:smbd: try to fix a compiler warning on i386 : left shift count >= width of type
metze
2009-07-15 21:04:06 +02:00
Stefan Metzmacher
722cd5944f s3:smbd: add support for SMB2 SetInfo File*Information
metze
2009-07-15 11:56:19 +02:00
Stefan Metzmacher
d85cc986b8 s3:smbd: implement SMB2 GetInfo with Fs*Information
metze
2009-07-15 11:56:18 +02:00
Stefan Metzmacher
9df1c8f2ad s3:smbd: return NT_STATUS_INVALID_INFO_CLASS in SMB2 GetInfo
metze
2009-07-15 11:56:18 +02:00
Stefan Metzmacher
9e2c50971e s3:smbd: check quota access against sec_initial_uid() instead of 0
And return an NTSTATUS mapped from errno. Instead of hardcoded values.

metze
2009-07-15 11:56:17 +02:00
Volker Lendecke
8a17cd810f Make gencache more stable
This provides a compromise between stability and performance: gencache is a
persistent database these days that for performance reasons can not use tdb
transactions for all writes. This patch splits up gencache into gencache.tdb
and gencache_notrans.tdb. gencache_notrans is used with CLEAR_IF_FIRST, writes
to it don't use transactions. By default every 5 minutes and when a program
exits, all entries from _notrans.tdb are transferred to gencache.tdb in one
transaction.
2009-07-15 10:55:20 +02:00
Volker Lendecke
749a508749 Create a talloc_stackframe for each file in wildcard unlink
There might be *many* files to delete
2009-07-14 20:49:06 +02:00