1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

383 Commits

Author SHA1 Message Date
Volker Lendecke
15953b82eb Make [f]get_nt_acl return NTSTATUS
(This used to be commit dcbe1bf942)
2007-11-13 15:47:01 +01:00
Jeremy Allison
86558e0376 Fix bug #5073. Allow "delete readonly = yes" to correctly
override deletion of a file. Fix from David Shaw <dshaw@jabberwocky.com>
Jeremy.
(This used to be commit 5d1d650d19)
2007-11-12 11:39:35 -08:00
Jeremy Allison
73d4079680 Remove the smb_read_error global variable and replace
it with accessor functions. "One global or pstring a day...." :-).
Jeremy.
(This used to be commit d50d14c300)
2007-11-03 15:12:42 -07:00
Jeremy Allison
8f1f2f04c7 Fix some cases where file_set_dosmode was being passed
False instead of NULL. Fix more of the notifications to
be correct for Samba4 RAW-NOTIFY torture (we had missed
one when calling set_ea_dos_attribute().
Jeremy.
(This used to be commit 39d265375c)
2007-10-31 15:45:45 -07:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3c)
2007-10-18 17:40:25 -07:00
Jeremy Allison
e6228e2541 r25309: Volker's fix for bug #4984 - samba4 torture test
to follow. Ensure we don't prepend "./" as a root
directory - this is an invalid pathname for unix_convert().
Jeremy.
(This used to be commit f70ac2e258)
2007-10-10 12:30:58 -05:00
Volker Lendecke
ad97bcf813 r25184: Fix some C++ warnings and an uninitialized variable
(This used to be commit b64df8a3c5)
2007-10-10 12:30:49 -05:00
Jeremy Allison
eacd314057 r25138: More pstring elimination. Add a TALLOC_CTX parameter
to unix_convert().
Jeremy.
(This used to be commit 39c211a702)
2007-10-10 12:30:44 -05:00
Günther Deschner
1a292def31 r25135: Remove one END_PROFILE(SMBntcreateX) from call_nt_transact_create() which
appears to be a leftover. Should fix the build with profiling enabled.

Jeremy, please check.

Guenther
(This used to be commit 98f2e10e3f)
2007-10-10 12:30:43 -05:00
Jeremy Allison
12f61e09d9 r25117: The mega-patch Jerry was waiting for. Remove all pstrings from
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).
Jeremy.
(This used to be commit 7f0db75fb0)
2007-10-10 12:30:41 -05:00
Jeremy Allison
3a9d382164 r25111: Move to talloced pathnames on most code paths.
There are now ony 17 pstrings left in reply.c,
and these will be easy to remove (and I'll be
doing that shortly). Had to fix an interesting
bug in pull_ucs2_base_talloc() when a source
string is not null terminated :-).
Jeremy.
(This used to be commit 0c9a8c4dff)
2007-10-10 12:30:41 -05:00
Jeremy Allison
351eb37a25 r25102: Rewrite msdfs code to use talloced filenames. Passes make test
and make valgrindtest. Final step will be to change srvstr_get_path()
to return talloced memory in the major codepaths.
Jeremy.
(This used to be commit cf6b6f9c3a)
2007-10-10 12:30:40 -05:00
Jeremy Allison
132ee3990a r25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
interface. More development will come on top of this. Remove the
"mangled map" parameter.
Jeremy.
(This used to be commit dee8beba7a)
2007-10-10 12:30:32 -05:00
Volker Lendecke
929e1d9920 r24809: Consolidate the use of temporary talloc contexts.
This adds the two functions talloc_stackframe() and talloc_tos().

 * When a new talloc stackframe is allocated with talloc_stackframe(), then
 * the TALLOC_CTX returned with talloc_tos() is reset to that new
 * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
 * happens: The previous talloc_tos() is restored.
 *
 * This API is designed to be robust in the sense that if someone forgets to
 * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
 * resets the talloc_tos().

The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.

The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.

This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)

So, never do a

tmp_ctx = talloc_init("foo");

anymore, instead, use

tmp_ctx = talloc_stackframe()

:-)

Volker
(This used to be commit 6585ea2cb7)
2007-10-10 12:30:24 -05:00
Volker Lendecke
b578db69e9 r24702: Remove the old API pointers
(This used to be commit 17df313db4)
2007-10-10 12:30:14 -05:00
Volker Lendecke
5993ddf240 r24659: Some formatting changes helping to minimize the 3_2_0 diff
(This used to be commit c5caea43af)
2007-10-10 12:30:13 -05:00
Jeremy Allison
077d5d2e36 r24498: More extra code into a function, reply_openerror.
Jeremy.
(This used to be commit 43ddfb8c91)
2007-10-10 12:29:52 -05:00
Jeremy Allison
606f10945f r24474: Map error value NT_STATUS_OBJECT_NAME_COLLISION
to ERRDOS, ERRfilexists for NTCreateX and NTTransCreate.
Jeremy.
(This used to be commit 5b2316d173)
2007-10-10 12:29:51 -05:00
Volker Lendecke
2ea14d4e98 r24433: Convert reply_ntrename to the new API
(This used to be commit 42b07a52b9)
2007-10-10 12:29:46 -05:00
Volker Lendecke
e0880fa7bd r24403: Remove reply_prep_legacy from send_nttrans_replies
(This used to be commit a6400ca6e2)
2007-10-10 12:29:40 -05:00
Volker Lendecke
f7f176dd0d r24401: Push reply_prep_legacy into send_nt_replies
(This used to be commit 489436a656)
2007-10-10 12:29:40 -05:00
Volker Lendecke
6a5bdb79e1 r24399: Change change_notify_reply to use send_nt_replies_new
(This used to be commit be67bb50ee)
2007-10-10 12:29:40 -05:00
Volker Lendecke
b41b38031f r24398: Convert call_nt_transact_notify_change to the new API
(This used to be commit 607b3ab8bc)
2007-10-10 12:29:40 -05:00
Volker Lendecke
bba684f2c0 r24394: Convert call_nt_transact_rename to the new API
(This used to be commit 189876a664)
2007-10-10 12:29:39 -05:00
Volker Lendecke
4f111b6e78 r24393: Convert call_nt_transact_set_user_quota to the new API
(This used to be commit 4cb60abd4c)
2007-10-10 12:29:39 -05:00
Volker Lendecke
4b485d807e r24391: Convert call_nt_transact_get_user_quota to the new API
(This used to be commit 0e47a6643e)
2007-10-10 12:29:39 -05:00
Volker Lendecke
6624bf7fd2 r24385: Convert call_nt_transact_query_security_desc to the new API
(This used to be commit f44e0aac2b)
2007-10-10 12:29:38 -05:00
Volker Lendecke
ff355558e3 r24384: Convert call_nt_transact_set_security_desc to the new API
(This used to be commit 925ed1e186)
2007-10-10 12:29:38 -05:00
Volker Lendecke
89dfa3883f r24383: Convert call_nt_transact_ioctl to the new API
(This used to be commit 8e6485e078)
2007-10-10 12:29:38 -05:00
Volker Lendecke
89f27bb35b r24382: Remove reply_prep_legacy from call_nt_transact_create
(This used to be commit 73392485f4)
2007-10-10 12:29:37 -05:00
Volker Lendecke
8590265e94 r24381: Push reply_prep_legacy into call_nt_transact_create
(This used to be commit ca18ba96be)
2007-10-10 12:29:37 -05:00
Volker Lendecke
20b3daec50 r24368: Push down reply_prep_legacy one level
Not pretty, but necessary to convert the calls one by one
(This used to be commit 523a463be4)
2007-10-10 12:29:37 -05:00
Volker Lendecke
1b034a8f9e r24367: Push reply_prep_legacy into handle_nttrans
(This used to be commit 8b5e51c266)
2007-10-10 12:29:37 -05:00
Volker Lendecke
1d8e64aece r24361: Push reply_prep_legacy down in reply_nttrans[s]
(This used to be commit d97a2e91d3)
2007-10-10 12:29:36 -05:00
Volker Lendecke
6216cd58c2 r24359: Fix the build
(This used to be commit b2ac1a3ec5)
2007-10-10 12:29:36 -05:00
Volker Lendecke
6bee410431 r24358: Push reply_prep_legacy into reply_nttrans[s]
(This used to be commit 197c231079)
2007-10-10 12:29:36 -05:00
Volker Lendecke
ecb32af916 r24357: Check wct in reply_nttrans[s]
(This used to be commit 9ab87e644e)
2007-10-10 12:29:35 -05:00
Volker Lendecke
2d8e4456cd r24356: Add send_nt_replies_new wrapper
(This used to be commit 8a910d37cc)
2007-10-10 12:29:35 -05:00
Stefan Metzmacher
5cc4dbd449 r24312: revision 24091 removed the 'FORCE'...
metze
(This used to be commit 34d821daf0)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
c25f22562e r24310: we should not call END_PROFILE(SMBntcreateX); twice...
metze
(This used to be commit 7a98e09f2e)
2007-10-10 12:29:27 -05:00
Volker Lendecke
d18b7b1223 r24254: Fix a segfault in r24102
The really pure bugfix would have replaced pparam by *pparam, but we pulled
the fid anyway.

Metze, in line 2421 the FSP_BELONGS_CONN is commented out, is that intended?
The FSCTL_CREATE_OR_GET_OBJECT_ID ioctl did not have it.

Volker
(This used to be commit 2c1376225b)
2007-10-10 12:29:21 -05:00
Volker Lendecke
fe92fdc67d r24145: Fix a comment
(This used to be commit 34a00d8aa9)
2007-10-10 12:29:13 -05:00
Volker Lendecke
6c6fed5e65 r24130: Explicitly pass flags2 to srvstr_push
This is in preparation of the trans2 conversion: srvstr_push should not
look at inbuf directly.
(This used to be commit 5fd7e6a382)
2007-10-10 12:29:09 -05:00
Volker Lendecke
a2d6aa829f r24102: Pass the fid instead of inbuf and an offset to file_fsp.
This removes the buf==NULL condition in file_fsp(), but wherever it is called
we do have a buffer anyway.

Volker
(This used to be commit d70a1f82fe)
2007-10-10 12:29:07 -05:00
Volker Lendecke
4473a5ec54 r24100: Convert reply_ntcancel to the new API
(This used to be commit 6e5f39379f)
2007-10-10 12:29:06 -05:00
Volker Lendecke
ae5da66e23 r24097: Convert reply_ntcreate_and_X_quota to the new API
(This used to be commit 08acadae56)
2007-10-10 12:29:06 -05:00
Volker Lendecke
04dcbbbd68 r24092: Convert do_ntcreate_pipe_open to the new API
nt_open_pipe_new() is a copy of nt_open_pipe(). It will stick for a bit
until do_nt_transact_create_pipe is converted as well.
(This used to be commit 247d6baaed)
2007-10-10 12:29:05 -05:00
Volker Lendecke
d95725370f r24091: Convert reply_ntcreate_and_X to the new API
The routines called will follow
(This used to be commit 28025fc17e)
2007-10-10 12:29:05 -05:00
Volker Lendecke
5e9d12cd30 r24090: Separate parsing in reply_ntcreate_and_X
In particular, check if we have enough parameters
(This used to be commit 7a19b3071e)
2007-10-10 12:29:05 -05:00
Volker Lendecke
cc6a41017c r23997: Check in the infrastructure for getting rid of the global InBuffer/OutBuffer
The complete history of this patch can be found under
http://www.samba.org/~vlendec/inbuf-checkin/.

Jeremy, Jerry: If possible I would like to see this in 3.2.0. I'm only
checking into 3_2 at the moment, as it currently will slow down operations for
all non-converted (i.e. all at this moment) operations, as it will copy the
talloc'ed inbuf over the global InBuffer. It will need quite a bit of effort
to convert everything necessary for the normal operations an XP box does.

I have patches for negprot, session setup, tcon_and_X, open_and_X, close. More
to come, but I would appreciate some help here.

Volker
(This used to be commit 5594af2b20)
2007-10-10 12:28:53 -05:00