Volker Lendecke
16198dc51e
Convert dbwrap_trans_delete to NTSTATUS
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit dead193f46c2b19955ab3e5ac5ba343694f4858a)
2008-04-01 14:04:22 +02:00
Volker Lendecke
fcdfff1cc8
Convert dbwrap_trans_store to NTSTATUS
...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 5f4de856af1abe63b13059bbe1615cb5877770d0)
2008-04-01 14:04:22 +02:00
Stefan Metzmacher
b8dcade819
regdb: let regdb_fetch_keys() handle NULL and failure cases in the same way and return -1
...
metze
(This used to be commit 983fd58805a429792fc8eaa816e2dd908643414e)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
b55942a763
regdb: get the seqnum before the record, to not miss something
...
metze
(This used to be commit c214107bd9bbf9b17936757437ec211d7de3048e)
2008-04-01 14:04:20 +02:00
Stefan Metzmacher
2b21b02c6a
regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
...
This is the fixed version of commit 5c28c74aa06a82559f498373b3d6e9892d5c2cbe.
metze
(This used to be commit 924acd7f695d7514b1a4628468137cf632c8f1f0)
2008-04-01 14:04:20 +02:00
Michael Adam
0bf8ba9f26
registry: reg_deletevalue should return error, when the value does not exist.
...
Michael
(This used to be commit 04b48984bbf84c55bb41a74a11cbcc7358377fed)
2008-03-31 17:22:02 +02:00
Michael Adam
ce0bbc82fd
Revert "regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
...
This reverts commit 4e2be189e97f653b75bd88135a631ce0f42db267.
Metze, this broke the registry (reg_api layer), but I don't yet know
exactly how and why. By the way, the locks there had the purpose of
fetching the seqnum that really matches the data.
This needs some more thought / debugging. But I wanted to have
the tree in a working state again.
Michael
(This used to be commit 5c28c74aa06a82559f498373b3d6e9892d5c2cbe)
2008-03-30 03:05:34 +02:00
Michael Adam
f8fdc36fdb
regdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete|store]()
...
Michael
(This used to be commit 7dcd0c1e539df9ff1768a9c878b6687b9e1bfeac)
2008-03-27 18:14:57 +01:00
Michael Adam
c86d10ae83
regdb: use != 0 instead of == -1 check for transaction_[commit|cancel]
...
Michael
(This used to be commit b6ceeaabae94b86fe79d6a60e497fb472ca23021)
2008-03-27 18:14:57 +01:00
Stefan Metzmacher
5439f5f710
regdb: use db_open_trans()
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit a77b5b91dd439b5965fef17f2b2ff98fefd77dbb)
2008-03-27 18:14:56 +01:00
Stefan Metzmacher
618f22409a
regdb: use regdb->transaction_start(regdb) != 0 consistent
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 093c3bced96c934419af69cc065a240368027dcf)
2008-03-27 18:14:56 +01:00
Stefan Metzmacher
2a95f3f874
regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 4e2be189e97f653b75bd88135a631ce0f42db267)
2008-03-27 18:14:56 +01:00
Stefan Metzmacher
d9de61341c
regdb: use dbwrap_trans_store_int32
...
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 9620696083473e3a98b46dd90b3b4aa287580940)
2008-03-27 18:14:56 +01:00
Volker Lendecke
fac2d8546b
Fix Coverity ID 471
...
(This used to be commit d3b6df67fea0da5ffa962837400ebe07b34a5384)
2008-03-23 18:28:24 +01:00
Volker Lendecke
2e2f1d57b1
Fix Coverity ID 477
...
(This used to be commit f17b1b0fc6340d21f1a2f43aa7eb2e87f851c51f)
2008-03-23 18:28:24 +01:00
Volker Lendecke
988cffe9ca
Fix Coverity ID 478
...
(This used to be commit 5f77938dc4a280b654b8d08656f19a7d04cea8c7)
2008-03-23 18:28:23 +01:00
Michael Adam
178c430821
registry: add reg_init_basic() - init registry with only the db backend.
...
Michael
(This used to be commit 1831042bdcbfe569ae39177058dfe1d914416513)
2008-03-22 02:05:53 +01:00
Michael Adam
4825cef8bc
registry: close registry in exit path in registry_init_smbconf().
...
Michael
(This used to be commit 5aa3141bff35a85dd97e9fd339e19b0fe3a73afc)
2008-03-22 01:54:18 +01:00
Michael Adam
b8a949b566
registry: some whitespace cleanup in init_registry().
...
Michael
(This used to be commit f33095e44ba22f4451a5deeffdd4f9ed3f99ed85)
2008-03-22 01:53:44 +01:00
Michael Adam
88d46f4ea4
registry: remove unneeded talloc stackframe variable.
...
Michael
(This used to be commit 81993db828bf11b13d7ee1f43483968dc6241bcc)
2008-03-22 01:52:03 +01:00
Michael Adam
e12ed5279a
registry: close regdb in error path (and use it) in init_registry().
...
Michael
(This used to be commit 73b325fe7a9d7fd67ac9b99144a3776f5a1a9e15)
2008-03-22 01:49:21 +01:00
Michael Adam
9ec7af58c6
registry: fix registry_init_smbconf() to close the registry at the end.
...
Michael
(This used to be commit f4d87fdbf266a36fbb50dae863ee0784165c2fe1)
2008-03-21 23:50:49 +01:00
Volker Lendecke
1e696c2845
Fix Coverity ID 506
...
(This used to be commit c9add4d59a1615aabc565e323cb19cf7ef4b6b64)
2008-03-21 11:48:09 +01:00
Michael Adam
060f554adc
registry: use available string constant in debug statement.
...
Michael
(This used to be commit 6bac03a2ec6351ab9db457d904b8925c828086e8)
2008-03-20 15:01:52 +01:00
Michael Adam
cef4e1bd9e
registry: in regdb_init, not only complain about INFO/version, store it...
...
Michael
(This used to be commit 27d67365ad03f0a0cd86011758a122a97513b82e)
2008-03-20 15:01:52 +01:00
Michael Adam
4bac0e505f
registry: reformat regdb_init() slightly, breaking long lines.
...
Michael
(This used to be commit 11da885f1e82e7a08fac2bc0ec1515694caa6340)
2008-03-20 15:01:52 +01:00
Michael Adam
13b894b01e
registry: untangle assignment and if-statement in regdb_init().
...
Michael
(This used to be commit 504058df9706ee4e4c2e7fb1b1e41710bce2f87d)
2008-03-20 15:01:52 +01:00
Michael Adam
2f01e055cf
registry: separate initialization of registry data from regdb_init().
...
Leave this to the users (currently registry_init_smbconf() and
init_registry()) to initialize as much of preliminary registry data
as needed.
Michael
(This used to be commit 59fdd30c789ccfd5cff356e459f1653b065b985c)
2008-03-20 15:01:52 +01:00
Michael Adam
8880111466
registry: add a transaction wrapper to init_registry_key_internal().
...
Michael
(This used to be commit 8b9cff84d5c39e6d7c315d87ac2fdf7fc0d4e4c4)
2008-03-20 15:01:52 +01:00
Michael Adam
1f3139df25
registry: refactor creation of subkeys out of init_registry_data().
...
Michael
(This used to be commit 55233f875ebe1d515c65d9322cda69eb52d4c7d5)
2008-03-20 15:01:51 +01:00
Günther Deschner
e8bd75ec73
Bind Group Policy processing closer to the samba registry.
...
Guenther
(This used to be commit e9c56250eb7a2dc4e69962c5b48875834941ccfc)
2008-03-18 21:31:24 +01:00
Marc VanHeyningen
e06aa46b9f
Coverity fixes
...
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-17 20:52:25 +01:00
Michael Adam
6a2a76bc92
registry: untangle assignment and if-clause in init_registry_data().
...
Michael
(This used to be commit 64664d25cf84e5e0f4a4876b2c38c127b310dbc5)
2008-03-17 13:12:47 +01:00
Michael Adam
cc2e3f180b
registry: convert regdb REGISTRY_OPS to named struct initializers.
...
Michael
(This used to be commit 3ea0a0beb47bf91b71d949de5abb797177721dcc)
2008-03-17 08:22:33 +01:00
Michael Adam
9741e07140
registry: use talloc instead of malloc and provide common exit point
...
in regdb_get_secdesc().
Michael
(This used to be commit df848d8eeeb102288a3acb9a0f8a7015e0c6ca6b)
2008-03-17 08:22:33 +01:00
Michael Adam
647432a40c
registry: remove an unused variable from regdb_set_secdesc().
...
Michael
(This used to be commit 76dad05e4ce4b4cb26557bc151359ed9d58d6317)
2008-03-17 08:22:33 +01:00
Michael Adam
18a407de8c
registry: untangle assignments and if statements in regdb_set_secdesc().
...
Michael
(This used to be commit d553b5d72569c1496bfa3de703c9bf15a9a6cb60)
2008-03-17 08:22:33 +01:00
Michael Adam
40e6ec16ee
registry: use talloc_stackframe instead of hand crafted temporary context.
...
Michael
(This used to be commit e4f2c856ec716697af4815491b5ae8ddb263cd51)
2008-03-17 08:22:33 +01:00
Michael Adam
2ce3d4b918
registry: use talloc instead of malloc for tdb data in regdb_store_values().
...
Michael
(This used to be commit 860316cbe70836882bff16b39f0deb5c12cbd1f3)
2008-03-17 08:22:33 +01:00
Michael Adam
ae7f7e44ff
registry: don't use talloc_stackframe() instead of talloc_tos() als temp ctx
...
in regdb_store_values(). Also provide common exit path for
freeing memory.
Michael
(This used to be commit 7454e426f2ea9aa42620ed5bcb34c85797b9e21b)
2008-03-17 08:22:33 +01:00
Michael Adam
ecd7479be2
registry: don't leak to talloc stack in regdb_fetch_keys().
...
Michael
(This used to be commit 3a1d79116b693bc25af1106c9a43ffd275ac3d1e)
2008-03-17 08:22:33 +01:00
Michael Adam
3b250d17d9
registry: explicitly use talloc context instead of talloc_tos()
...
in regdb_fetch_keys().
Michael
(This used to be commit 93ea27a3e23e489a2af3c778684f8a8a4594b567)
2008-03-17 08:22:33 +01:00
Michael Adam
46ea0d333e
registry: don't leak on success path in regdb_store_keys().
...
Michael
(This used to be commit 331d7fd2ea6d8aeb029478a6ab8d4051fa2c03fd)
2008-03-17 08:22:33 +01:00
Michael Adam
a0d4c1e127
registry: allocate tempory data in talloc stack in regdb_store_keys().
...
Michael
(This used to be commit a99b51159a7db5f249ff136cf9ba758d14380a35)
2008-03-17 08:22:33 +01:00
Michael Adam
78adf71669
registry: separate cancel and failur exit paths in regdb_store_keys().
...
Michael
(This used to be commit e1d4a2fa5b5b0f21d1ea4a9dffc326878c9f54b7)
2008-03-17 08:22:33 +01:00
Michael Adam
e64825e620
registry: don't leak memory on transaction fail in regdb_store_keys().
...
Michael
(This used to be commit 9315de404812d89dddcec6ac4ae17c34f5012746)
2008-03-17 08:22:33 +01:00
Michael Adam
ba8607acc1
registry: don't leak (to talloc_tos()) in regdb_store_keys().
...
use talloc_stackframe() and free on error path.
Michael
(This used to be commit 95525772f2791f0fb999fe9f271da5b0fbdc62d8)
2008-03-17 08:22:33 +01:00
Michael Adam
a37811727a
registry: reformat regdb_store_keys_internal(), killing long lines.
...
Michael
(This used to be commit 966b2414cb6efdfe5acb412ed9bdfd7589ee694c)
2008-03-17 08:22:32 +01:00
Michael Adam
a446378e7a
registry: don't leak (to talloc_tos()) in regdb_store_keys_internal().
...
Michael
(This used to be commit 76e4cdc25fc9a7e47fd9a356dc54533b62c5db08)
2008-03-17 08:22:32 +01:00
Michael Adam
8432f7f8cf
registry: reformat init_registry_data() some, killing long lines.
...
Michael
(This used to be commit f357b1ddd3ea552163151f27b4ec70fe0488a0ba)
2008-03-17 08:22:32 +01:00