1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-25 06:04:04 +03:00

2894 Commits

Author SHA1 Message Date
James Peach
5910e397d3 r15446: Tidy up the formatting of locking debug messages and make it more
consistent. Bring oplocks withing the purview of the locking debug
channel.
(This used to be commit e817cfd7d3a42d141198122eada58b5a7ba90e9c)
2007-10-10 11:16:45 -05:00
Jeremy Allison
aca0a3ad3a r15404: Check for WRITE_THOUGH before calling lp_ fn. I hate
extra fn calls.
Jeremy.
(This used to be commit e468e1e5c2dbee29066f0efe4141d8705def5d6f)
2007-10-10 11:16:41 -05:00
Volker Lendecke
23b2f27a54 r15359: Fix typo
(This used to be commit 46d3c7668bdbaaab1b8854617aa7c235f51a74e0)
2007-10-10 11:16:37 -05:00
Jeremy Allison
ec8b810a16 r15293: Don't ever set O_SYNC on open unless "strict sync = yes".
This could be the cause of the perf. problem reported
between 3.0.14a and 3.0.2x. Lufthansa has *wireless*
on their flights to the USA now...  (I'm in heaven ! :-).
Jeremy.
(This used to be commit dbc03125f2643f8ecff8e901cb23fa6408cce011)
2007-10-10 11:16:32 -05:00
Paul Green
31693197be r15283: Oh yeah. The build farm doesn't do much with head. OK, here is the patch to SAMBA_3_0 to declare prototypes for the initialization functions. These are the same changes I just made to head. --paulg
(This used to be commit 17774387ad879b6a72dd1cf406326318add31b04)
2007-10-10 11:16:31 -05:00
Volker Lendecke
1ca61f4748 r15266: Fix bug 3720. I wonder why -O1 compiles did not catch this...
Thanks to Jason Mader for reporting this.

Volker
(This used to be commit 3e616c3272ba76a2d135f7c51ceb44461ad165ad)
2007-10-10 11:16:30 -05:00
Paul Green
e18c9a926f r15196: Update a comment that I found confusing (I confuse easily).
(This used to be commit eb53f01863f8f9d2980d9c2c8d27899dd39e5fa2)
2007-10-10 11:16:28 -05:00
Jeremy Allison
f60111e074 r15138: Teach Samba the difference between exclusive and batch oplocks.
Pass Samba4 oplock test (with kernel oplocks off).
Jeremy.
(This used to be commit 3c260bcce2de76d724279e07dca61eadddfb8782)
2007-10-10 11:16:26 -05:00
Volker Lendecke
335637b2eb r15133: in_server is not used anywhere
(This used to be commit c981bc7f31483e7821b9654eb30d665283aa07d5)
2007-10-10 11:16:25 -05:00
Volker Lendecke
bdbd173e8c r15119: Initialize our global sam sid first, quite a lot of the other initialization
routines further down depend on it.

Fix bug 3696.

Volker
(This used to be commit 6c65cccc83aa7b726e23684f979f1488bed3f751)
2007-10-10 11:16:24 -05:00
Jeremy Allison
6ca1ba3814 r15115: Fix error return on sessionsetup. Ensure no
data blob is added if the logon call failed.
Jeremy.
(This used to be commit 71d0191c313e2106ae2bdef3119b3ff6e591ee1b)
2007-10-10 11:16:24 -05:00
Jeremy Allison
5445694eb9 r15112: Move strict locking default to auto. Fix up the error
return for one of the Samba4 torture tests.
Jeremy.
(This used to be commit 9db6617756ff155eb7549c3c622a9920189e577d)
2007-10-10 11:16:24 -05:00
Volker Lendecke
76e581b983 r15103: Okay, looking closer: Samba4 tdb not exporting u32 is a bug in samba4's
tdb. tdb_open_ex needs it. Can someone from samba4 tell me how this should be
handled?

Thanks,

Volker
(This used to be commit 0a2f1ed5e9012e07ef158666b68994d0961768b6)
2007-10-10 11:16:23 -05:00
Volker Lendecke
4f24046294 r15102: u32 is a tdb-only thing that's not exported by samba4 tdb. Replace by uint32.
Volker
(This used to be commit 0a1665a1b78d063840e42e85229ace5a751e3985)
2007-10-10 11:16:23 -05:00
Jeremy Allison
010c725b36 r15088: Remove all time() and gettimeofday() calls out of the mainline
packet processing code. Only do these when needed (ie. in the
idle timeout code). We drop an unneccessary global here too.
Jeremy.
(This used to be commit 8272a5ab0605fcf95527143c4f909aa1008e5b94)
2007-10-10 11:16:22 -05:00
Jeremy Allison
cc203f3e59 r15084: Try and squeeze more out of the non-read/write code path.
Jeremy.
(This used to be commit 23dcff4d50d1d35b7ddee0d0cb79c16a312f179c)
2007-10-10 11:16:22 -05:00
Jeremy Allison
713eaf1d67 r15083: Using talloc with destructors is nice and all, but in this
case it's in a performace critical path and it *hurts* us.
Go back to plain malloc/free with an explicit destructor
call.
Jeremy.
(This used to be commit 1c99aed563c29e1b3d70939878af747a0660bfec)
2007-10-10 11:16:22 -05:00
Volker Lendecke
262ffd9750 r15035: It seems that many preprocessors do not like comments in macro args..
(This used to be commit efc833dcba052e52c46eeba71a1ebe248be9cb05)
2007-10-10 11:15:58 -05:00
Jeremy Allison
fc13f28417 r15030: On a performace hunt... Remove as many extraneous
memset's as possible.
Jeremy.
(This used to be commit 1217ed392b75aa8bfefa9c3f1ec5fa3bba841ee0)
2007-10-10 11:15:58 -05:00
Jeremy Allison
eecdc6c956 r15022: Fix core dumps on normal server exit.
Jeremy.
(This used to be commit 13c3abf03187f84874b5754b54de5d3fe2dea188)
2007-10-10 11:15:57 -05:00
Jeremy Allison
6c237e04b2 r15020: Fix issue with samba4 netbench torture tester,
it sends break replies to "break to none from level2"
requests and it shouldn't. Just don't log a debug
level zero message.
Jeremy.
(This used to be commit dc6a13da33a031d0c2374b692737dbe9215f0f74)
2007-10-10 11:15:57 -05:00
Jeremy Allison
22dbd67708 r15018: Merge Volker's ipc/trans2/nttrans changes over
into 3.0. Also merge the new POSIX lock code - this
is not enabled unless -DDEVELOPER is defined.
This doesn't yet map onto underlying system POSIX
locks. Updates vfs to allow lock queries.
Jeremy.
(This used to be commit 08e52ead03304ff04229e1bfe544ff40e2564fc7)
2007-10-10 11:15:57 -05:00
Jeremy Allison
c9c502442b r14989: Fix from Mathias Dietz <MDIETZ@de.ibm.com>. EPERM can be
a valid return from getting an xattr. Don't disable if
we get it.
Jeremy.
(This used to be commit 7769b678f22d8ab4aa8aef55966813355bf2ce6d)
2007-10-10 11:15:55 -05:00
Jeremy Allison
876f2deb3a r14986: Fix OS/2 directory delete bug found by kukks.
(Thanks a lot for all your hard work on this).
We were caching the results of *all* directory
scans, not just the results that match the
client wildcard. This actually made no sense,
as only matches on the client wildcard can be
returned to the client and so might need to
be searched for in the cache. This fixes the
directory cache to only cache entries that we
return to the client.
Jeremy.
(This used to be commit c88af597d042390ff11b26fe802b0b10d0faa6ce)
2007-10-10 11:15:55 -05:00
Jeremy Allison
4ee43dbd47 r14954: Fix #3569 based on William Jojo's work. AIX also
has the linear posix locking issue which causes
CLEAR_IF_FIRST to cause performance problems.
As we know we're in a daemon architecture with
long-lived parent we can avoid this in the Samba
case. Add a comment explaining this.
Jeremy.
(This used to be commit 3cd5c3df0d1b98dfa90663973ab13b5d3dbf737e)
2007-10-10 11:15:55 -05:00
James Peach
4fa5559800 r14898: This change is an attempt to improve the quality of the information that
is produced when a process exits abnormally.

First, we coalesce the core dumping code so that we greatly improve our
odds of being able to produce a core file, even in the case of a memory
fault. I've removed duplicates of dump_core() and split it in two to
reduce the amount of work needed to actually do the dump.

Second, we refactor the exit_server code path to always log an explanation
and a stack trace. My goal is to always produce enough log information
for us to be able to explain any server exit, though there is a risk
that this could produce too much log information on a flaky network.

Finally, smbcontrol has gained a smbd fault injection operation to test
the changes above. This is only enabled for developer builds.
(This used to be commit 56bc02d64498eb3faf89f0c5452b9299daea8e95)
2007-10-10 11:15:53 -05:00
Stefan Metzmacher
18e93247aa r14883: add 'smbd:sharedelay' option, so that we can speed up BASE-DENY2 in make test
as done in samba4

metze
(This used to be commit b98dd258a74a1e1b4e967e6176a5a92986d03123)
2007-10-10 11:15:52 -05:00
Gerald Carter
6c9eaa6880 r14855: Various fixes:
* depreacte 'acl group control' after discussion with Jeremy
  and implement functionality as part of 'dos filemode'
* fix winbindd on a non-member server to expand local groups
* prevent code previously only used by smbd from blindly
  turning _NO_WINBINDD back on
(This used to be commit 4ab372f4cab22225716b5c9a9a08f0c1dbc9928d)
2007-10-10 11:15:51 -05:00
Jeremy Allison
872d3cea87 r14849: Fix >= that should be >. Too strict condition
checked by Volker.
Jeremy.
(This used to be commit 9a763da07385bf9af437cab8dd680f2e13fca3c3)
2007-10-10 11:15:50 -05:00
Jeremy Allison
ecc0c18889 r14847: Tell static checkers that exit_server() doesn't
return.
Jeremy.
(This used to be commit 9c5e26a56aaaf1143b43e61d208ddaeb96f2ffcb)
2007-10-10 11:15:50 -05:00
Jeremy Allison
75c965d3a4 r14790: Fix possible null deref. Coverity #277.
Jeremy.
(This used to be commit 2454af392a71989ecddb2dbb17a9217658102523)
2007-10-10 11:15:48 -05:00
Jeremy Allison
1d3fd5201c r14746: Add the Samba4 replacements for opendir/readdir etc. to
Samba3 - with some 64-bit macro madness. Attempt to fix
the broken directory handling in the *BSD-of-the-month
club.
Jeremy.
(This used to be commit fd98427f64f4206c01f16f82fadf24f5863878db)
2007-10-10 11:15:45 -05:00
Volker Lendecke
e487835181 r14695: Patch from Björn Jacke:
- add DMAPI/XDSM support for AIX
- find JFS DMAPI libs on Linux when only they are available

Volker
(This used to be commit b6b72f8c6a03001ae75457c9e7a78e189bea5a3f)
2007-10-10 11:15:44 -05:00
James Peach
a7d1a32b14 r14669: Remove duplicate source caused by running patch(1) once too often.
(This used to be commit 0ebbfc867c71002eaf921f4f4d8aa7d7b78973a7)
2007-10-10 11:15:42 -05:00
James Peach
40d0707827 r14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-based
HSM is interested in. Tested on both IRIX and SLES9.
(This used to be commit 514a767c57f8194547e5b708ad2573ab9a0719c6)
2007-10-10 11:15:42 -05:00
Stefan Metzmacher
250c02554e r14618: add --no-process-group to all server programms
to make the following possible:

timelimit 20000 bin/nmbd -F -S --no-process-group
timelimit 20000 bin/smbd -F -S --no-process-group

this is needed to 'make test' working without losing child processes

metze
(This used to be commit c3a9f30e2a12cc852c9fa3a7d161f5c6ee0694ce)
2007-10-10 11:15:39 -05:00
Jeremy Allison
5067cca077 r14602: Fix another logic bug in new oplock handling. Just
because lck->num_share_modes != 0 doesn't mean that
there *are* other valid share modes. They may be
all marked "UNUSED" or be deferred open entries.
In that case don't downgrade the granted oplock to
level2 needlessly - a client can have an exclusive
oplock in this case. The original code handled this
correctly in the lck->num_share_modes == 0 case but
not in the case where there were no valid share modes
but lck->num_share_modes != 0. I'll clean up my
Samba4 torture tester for this and commit it tomorrow.
Jeremy.
(This used to be commit 306061c93d9181262298516fefd83444f5a65ce5)
2007-10-10 11:15:39 -05:00
James Peach
97ee5b1afa r14600: Refactor capability interface from being IRIX-specific to using only
the POSIX interface. Note that this removes support for inherited
capabilities. This wasn't used, and probably should not be.
(This used to be commit 763f4c01488a96aec000c18bca313da37ed1df1b)
2007-10-10 11:15:39 -05:00
Jeremy Allison
292afdba59 r14596: Fix a logic bug with multiple oplock contention.
The sad thing is the core of this bug fix is just
removing a paranoia "exit_server" call, as the
rest of the logic was already correct :-).

Lots of comments to explain the logic added.

I will look at adding tests to exercise this,
might be possible.

Jeremy.
(This used to be commit c2488db727e1a00f112be7b169de9e6208e311f3)
2007-10-10 11:15:38 -05:00
James Peach
1af229a8f8 r14574: Allow use of sendfile as long as the write cache has not been enabled
on the particular file we are performing I/O on, irrespective of whether
the write cache is globally enabled
(This used to be commit 0809e2cb1dfff1cd0e8631b23b415cb2d8a67312)
2007-10-10 11:15:37 -05:00
Volker Lendecke
49ecd176ee r14559: Oplocks have changed, process_smb can be static again
(This used to be commit 19e9bc03f81d8d000b683cf5c5f478ba25ddeb0d)
2007-10-10 11:15:37 -05:00
Jeremy Allison
f04d5530cc r14460: SMBexit closes by pid and vuid. Tested with smbtorture.
Jeremy.
(This used to be commit 71e81580421225d5b35a25d46a7b6064a826685c)
2007-10-10 11:15:31 -05:00
Jeremy Allison
e6676a9a69 r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
(This used to be commit f65d7afe1977d9d85046732842f9643716c15088)
2007-10-10 11:15:27 -05:00
Jeremy Allison
b5c2c5cd25 r14357: Try and fix Coverity #169 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
 line, and those below, will be ignored--

M    source/smbd/posix_acls.c
(This used to be commit b8397c9f33424e0d1ed3ff849e1c99812f978000)
2007-10-10 11:15:26 -05:00
Jeremy Allison
ed5095a490 r14336: Try and quieten coverity #53 and #54. Make it obvious
we're using -1 as a special size_t case by casting.
Jeremy.
(This used to be commit 415530bd082bf351f5e4c1fd32408f123ed77f85)
2007-10-10 11:15:25 -05:00
Jeremy Allison
ff122b308b r14229: Something Coverity hasn't caught (yet) but I've gotten
sensitive to null derefs. get_timed_events_timeout()
can potentially return NULL. Cope with this.
Jeremy.
(This used to be commit 04838078723613628b298b7a87622df30432cf64)
2007-10-10 11:15:18 -05:00
James Peach
a62c0925e8 r14207: Convert the lp_acl_compatibility() param into an enum.
(This used to be commit 5429c495c538e416010cf44e1d6fb771770a72ae)
2007-10-10 11:15:16 -05:00
Jeremy Allison
5f224c2c26 r14170: Paranioa fix for sesssetup.
Fix Coverity bug #26. Guard against NULL ref.
Jeremy.
(This used to be commit c0f906ac8de850f4566b6b3be4e3c7d245e6e252)
2007-10-10 11:15:15 -05:00
Jeremy Allison
47a11f8a4c r14168: Fix Coverity #219. I think this is a false coverity
warning as it seems to get confused with assignment
and comparison. Clarify the code anyway.
Jeremy.
(This used to be commit 754818f8cc0849bddf84b7a534cd65e8dcd932ac)
2007-10-10 11:15:14 -05:00
Günther Deschner
c077d363a4 r14130: Remove make_server_info_pac alltogether, make_server_info_info3 does
already do what we need.

Guenther
(This used to be commit 773e33c9717ae04f48983ddc49f7619a97523603)
2007-10-10 11:11:14 -05:00