sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-07-27 07:42:04 +03:00
Code Activity
124,052 Commits 62 Branches 1,163 Tags
17fb635532dffb51a2237f1291d215d94e433146
Commit Graph

45 Commits

Author SHA1 Message Date
Douglas Bagnall
c247afbda0 pytests: heed assertEquals deprecation warning en-masse 
TestCase.assertEquals() is an alias for TestCase.assertEqual() and
has been deprecated since Python 2.7.

When we run our tests with in python developer mode (`PYTHONDEVMODE=1
make test`) we get 580 DeprecationWarnings about this.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
 2020-02-07 10:37:37 +00:00
Mathieu Parent
720396f0fb Spelling fix s/informations/information/ 
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
 2019-04-02 01:12:10 +00:00
Joe Guo
8e3c194453 PY3: change shebang to python3 in source4/dsdb dir 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
 2018-12-14 14:40:20 +01:00
Noel Power
55a3817166 s4/dsdb/tests: PY3 port samba4.ldap.passwordsettings test 
* Fix various assertEquals comparing ldb.bytes with string
  when running with PY3
* Fix a couple of tuple assignments to exception (not supported
  in PY3)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2018-12-10 10:38:21 +01:00
Douglas Bagnall
41844d13fe s4/dsdb/pytests: Py3 compatitble except clauses 
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>
 2018-10-25 21:45:58 +02:00
Joe Guo
9f5bbcc10a PEP8: fix E713: test for membership should be 'not in' 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:31 +02:00
Joe Guo
115f2a71b8 PEP8: fix E305: expected 2 blank lines after class or function definition, found 1 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:30 +02:00
Joe Guo
211c9a5f85 PEP8: fix E302: expected 2 blank lines, found 1 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:29 +02:00
Joe Guo
c809a86023 PEP8: fix E261: at least two spaces before inline comment 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:29 +02:00
Joe Guo
562411bd95 PEP8: fix E202: whitespace before ')' 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:27 +02:00
Joe Guo
5d532543ab PEP8: fix E128: continuation line under-indented for visual indent 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:27 +02:00
Joe Guo
bbb9f57603 PEP8: fix E127: continuation line over-indented for visual indent 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:26 +02:00
Joe Guo
5037731e0d PEP8: fix E116: unexpected indentation (comment) 
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-08-24 07:49:26 +02:00
Noel Power
6f30a0b5f1 s4/dsdb/tests: py2/py3 compatability always decode result of b64encode 
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2018-05-12 21:38:17 +02:00
Tim Beale
d0a9e19114 tests: Split out setUp code into separate function for reuse 
Any test that wants to change a password has to set the dSHeuristics
and minPwdAge first in order for the password change to work. The code
that does this is duplicated in several tests. This patch splits it out
into a static method so that the code can be reused rather than
duplicated.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
 2018-05-11 06:01:23 +02:00
Andrew Bartlett
056b2abde6 dsdb: check for dSHeuristics more carefully 
This check would pass if the dSHeuristics was treated as always being
000000000 for searches which is not enough, we must check for a value
of 000000001 (userPassword enabled).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13378

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-04-12 05:15:16 +02:00
Noel Power
a8aab19b90 s3/dsdb: convert print func to be py2/py3 compatible 
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
 2018-03-23 07:28:24 +01:00
Ralph Boehme
fbd16473ec CVE-2018-1057: s4:dsdb/tests: add a test for password change with empty delete 
Note that the request using the clearTextPassword attribute for the
password change is already correctly rejected by the server.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
 2018-03-13 10:24:26 +01:00
Noel Power
0c31d38794 dsdb python tests: convert 'except X, (tuple)' to 'except X as e' 
In addition to converting the except line another line is also added
for each except to extract the tuple contents.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2018-02-28 23:01:41 +01:00
Garming Sam
fec698dbfd tests/passwords: fix a typo 
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Tue Apr 19 07:54:35 CEST 2016 on sn-devel-144
 2016-04-19 07:54:35 +02:00
Garming Sam
a523274fb6 tests/dsdb: Verify that only a new ldb affects reads of userPassword 
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11853

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2016-04-19 04:12:26 +02:00
Jelmer Vernooij
eae1efca41 passwords: Use samba.tests.subunitrun. 
Change-Id: Ib806f63ef412fec264445eefd82146e5140b0bac
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
 2014-11-22 02:23:10 +01:00
Andrew Bartlett
7faa3be453 s4-python Ensure we add the Samba python path first. 
This exact form of the construction is important, and we match on it
in the installation scripts.

Andrew Bartlett
 2011-02-02 15:21:12 +11:00
Jelmer Vernooij
4236ec9d6d Remove unused imports. 2011-01-06 15:21:21 +01:00
Kamen Mazdrashki
2e259de084 s4-dsdb/tests/python: Explicitly pass comamnd line LoadParm() instance to system_session() 
Otherwise system_session() creates a LoadParm() instance
which resets certain global parameters to their defaults
from smb.conf ("log level" for instance)

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Dec 15 15:10:47 CET 2010 on sn-devel-104
 2010-12-15 15:10:47 +01:00
Matthias Dieter Wallnöfer
573389c8cc s4:password_hash LDB module - allow empty ("") passwords 
This seems to have been broken some time ago - till someone on the
mailing list noticed it.

I've also added a testsuite (and some additional SamDB python helpers) which
should prove this.
 2010-12-02 11:51:06 +01:00
Nadezhda Ivanova
0d99a5f27c s4-tests: Modified passwords.py to use samba.tests.delete_force 2010-11-25 01:13:47 +02:00
Nadezhda Ivanova
c252dac1b3 s4-tests: Password tests now use the get_dsheuristics and set_dsheuristics from SamDB. 2010-11-23 11:22:26 +02:00
Nadezhda Ivanova
2c993f0d4e s4-tests: Adapted passwords.py to use set_minPwdAge from SamDB. 
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Mon Nov 22 18:39:06 CET 2010 on sn-devel-104
 2010-11-22 18:39:06 +01:00
Matthias Dieter Wallnöfer
8b7f23d644 s4:dsdb tests - use even more already defined pyldb functions to retrieve NCs 2010-11-19 12:07:06 +01:00
Matthias Dieter Wallnöfer
4c666f3e0a s4:dsdb python tests - use "ldb.domain_dn" 
By inspiration of Nadya's patches
 2010-11-18 17:03:20 +00:00
Matthias Dieter Wallnöfer
4f86f297a2 s4:passwords.py - add a test for the normal "userPassword" behaviour 
Just to make sure that this works now too
 2010-11-11 10:03:40 +01:00
Matthias Dieter Wallnöfer
cc7f390bf9 s4:python tests - fix script names in the help text 2010-11-11 09:12:24 +01:00
Matthias Dieter Wallnöfer
58cfa5a825 s4:passwords.py - test empty password attributes behaviour 
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov  8 12:09:56 UTC 2010 on sn-devel-104
 2010-11-08 12:09:56 +00:00
Matthias Dieter Wallnöfer
acffe25896 s4:passwords.py - add another two failure cases 2010-11-08 11:27:03 +00:00
Matthias Dieter Wallnöfer
83f78a30a0 s4:ldap.py/passwords.py - just use objectclass "user" for users 
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov  4 21:09:00 UTC 2010 on sn-devel-104
 2010-11-04 21:09:00 +00:00
Jelmer Vernooij
0baa1fb4e4 pydsdb: Import testtools before subunit for those that don't have 
testtools installed.

Also, cleanup some imports.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov  3 17:47:55 UTC 2010 on sn-devel-104
 2010-11-03 17:47:54 +00:00
Matthias Dieter Wallnöfer
af3c6a4242 s4:passwords.py - proof the most important extended error codes 2010-08-15 19:42:40 +02:00
Matthias Dieter Wallnöfer
6dc0c07a51 s4:passwords.py - another special password test 
This looks like a password change but it's rather a password set operation.
 2010-08-15 19:42:39 +02:00
Matthias Dieter Wallnöfer
a9b055291c s4:passwords.py - test the error code when there doesn't exist any password yet 
After the creation of a user object we don't have any password yet.
 2010-08-14 18:48:19 +02:00
Matthias Dieter Wallnöfer
c335c5f54a s4:passwords.py - perform testing of wrong old passwords on change operations 2010-08-14 18:48:19 +02:00
Nadezhda Ivanova
d300085868 Changed passwords.py to use the correct account as acl checks now pass. 2010-07-05 00:20:37 +03:00
Matthias Dieter Wallnöfer
ec9fa906c7 s4:dsdb/tests/passwords.py - set and reset the "minPwdAge" properly 
After a patch proposal of Nadya and some reflection I think that it's really
worth to change all tests which need a "0" "minPwdAge" to set it manually and
reset the default afterwards.

So we can finally introduce the default "minPwdAge" on provision.

Patch proposal by: Nadya Ivanova
 2010-07-03 11:28:21 +02:00
Matthias Dieter Wallnöfer
c2e2f783d0 s4:dsdb/tests/python/passwords.py - add the right result codes for user password changes 
They will be enabled once the ACL modules supports it. It was my fault to not
import them earlier.
 2010-07-01 17:23:01 +02:00
Stefan Metzmacher
14f8953aa4 s4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/ 
metze
 2010-06-30 11:10:28 +02:00