sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code
58,645 Commits 60 Branches 1,144 Tags 452 MiB
19e515aac7
Commit Graph

20784 Commits

Author SHA1 Message Date
Jelmer Vernooij
027f6ada63 s4/net: Use d_printf consistently when reporting errors. 2009-12-29 16:26:20 +01:00
Jelmer Vernooij
732a7630e9 Use CommandError exception to deal with problems during net commands. 2009-12-29 16:26:19 +01:00
Jelmer Vernooij
eaf4a9afb2 s4/net: Make pwsettings a net subcommand. 2009-12-29 16:26:19 +01:00
Jelmer Vernooij
8c19cd2dea netcmd: Add some basic tests. 2009-12-29 16:26:19 +01:00
Jelmer Vernooij
9e603dfb95 s4/net: Support parsing arguments in Python commands. 2009-12-29 16:26:19 +01:00
Jelmer Vernooij
9b1a210311 net: Support usage/help of subcommands implemented in Python. 2009-12-29 16:26:19 +01:00
Jelmer Vernooij
c064549e2e net: Support implementing subcommands in python. 2009-12-29 16:26:18 +01:00
Stefan Metzmacher
8b68349442 s4:auth: add auth_get_server_info_principal() prototype to auth.h 
metze
 2009-12-29 12:13:30 +01:00
Stefan Metzmacher
27349a68ea s4:auth: make auth_challenge_may_be_modified() public 
metze
 2009-12-29 12:13:29 +01:00
Stefan Metzmacher
af25fb55c0 s4:auth: remove autogenerated auth/ntlm/auth_proto.h 
metze
 2009-12-29 12:13:23 +01:00
Stefan Metzmacher
8ab62799ed s4:ntlmssp: fix whitespaces in ntlmssp.h 
metze
 2009-12-29 08:18:52 +01:00
Jelmer Vernooij
72d93599d9 python: Remove sys.path line rather than updating it when installing to python system path. 2009-12-27 17:30:59 +01:00
Jelmer Vernooij
ef453c63af py_net/libnet: Remove C++-style comments, add more error checking, move 
initialization of dcerpc subsystem to libnet.
 2009-12-25 14:48:45 +01:00
Kamen Mazdrashki
33699bb1be s4-libnet: Simple test for net.SetPassword() python binding 
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
 2009-12-25 14:15:53 +01:00
Kamen Mazdrashki
20c7c27322 s4-libnet: Python binding for libnet_SetPassword() 
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
 2009-12-25 14:15:42 +01:00
Kamen Mazdrashki
f03e88fa4b s4-net: Fix 'talloc_free with references ...' error 
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
 2009-12-25 14:15:31 +01:00
Stefan Metzmacher
078482ad0e s4:auth: change auth_check_password_send/recv to tevent_req 
metze
 2009-12-24 17:38:34 +01:00
Stefan Metzmacher
577857d351 s4:gensec: change gensec_update_send/recv to tevent_req 
metze
 2009-12-24 17:38:34 +01:00
Stefan Metzmacher
5126b52810 s4:kdc: use the remote and local address from the stream_connection struct 
metze
 2009-12-24 17:38:33 +01:00
Stefan Metzmacher
500f55ca92 s4:smbd: hold tsocket_addresses on the stream_connection 
metze
 2009-12-24 17:38:33 +01:00
Stefan Metzmacher
4e2da423de s4:smb_server: fix mixing socket_address and tsocket_address 
metze
 2009-12-24 17:38:33 +01:00
Stefan Metzmacher
d3ee0f021b s4:lib/socket: add socket_get_{remote|local}_addr() to get a tsocket_address instead of a socket_address 
metze
 2009-12-24 17:38:33 +01:00
Stefan Metzmacher
445baf53a9 s4:lib/socket: add helpers functions to convert between socket_address and tsocket_address 
metze
 2009-12-24 17:38:32 +01:00
Simo Sorce
67d1af4384 s4:cleanups More trailing spaces and tabs 2009-12-23 15:17:56 -05:00
Simo Sorce
da27d4e465 s4:cleanups remove trailing spaces and tabs 2009-12-23 15:09:49 -05:00
Simo Sorce
7e8b042b07 s4:ldb Fix declaration in the middle of the code 2009-12-23 10:33:26 -05:00
Simo Sorce
4cc0bb7d04 s4: Fix the build 2009-12-23 10:28:44 -05:00
Matthieu Patou
8dc636ad67 s4: tests controls parsing and using for ldbadd/ldbedit/ldbmodify 2009-12-23 08:09:19 -05:00
Matthieu Patou
3bd4f6792c s4: make ldbadd/ldbmodify/ldbdelete really use the --controls switch 2009-12-23 08:09:19 -05:00
Andrew Bartlett
585900deb5 s4:gensec Don't give a warning when Windows client connects with NTLM 
We have had the workaround for a long time, but at the time the log
warnings remained.

Andrew Bartlett
 2009-12-22 17:30:05 +11:00
Andrew Bartlett
0809696dbf s4:auth Change 'get_challenge' API to be more like Samba3 
It is just easier to fill in the known to be 8 byte challenge than
stuff about with allocated pointers.

Andrew Bartlett
 2009-12-22 17:29:15 +11:00
Andrew Bartlett
383369e8f2 s4:auth generate the prototype file in the right place 2009-12-22 17:29:13 +11:00
Andrew Bartlett
551ea65c96 Samba4 and LDB requires talloc 2.0.1 
reported by ewoud@kohlvanwijngaarden.nl
 2009-12-22 17:27:03 +11:00
Tim Prouty
fd5350de1f s4 torture: Add RAW-OPLOCK-EXCLUSIVE7 which is similar to BATCH19 2009-12-21 17:27:37 -08:00
Tim Prouty
43a8b49f83 s4 torture: Update raw oplock to use win7 as the baseline for rename oplock break behavior 2009-12-21 17:27:36 -08:00
Tim Prouty
c33988c040 s4 torture: Be more permissive with share modes for oplock testing 
Share modes are tested elsewhere, and there is currently an outstanding
issue about share mode contention for nt-passthrough levels:

http://lists.samba.org/archive/cifs-protocol/2009-December/001227.html
 2009-12-21 17:27:36 -08:00
Tim Prouty
fd0c3a2264 s4 torture: Do a better job of closing open files in RAW-OPLOCK. 2009-12-21 17:27:36 -08:00
Jelmer Vernooij
2a9c22798d param: Fix build on systems without ldb installed. 2009-12-22 01:24:58 +01:00
Jelmer Vernooij
5b9e98a382 provision/pyldb: Avoid linking in static python ldb module. 2009-12-21 23:40:12 +01:00
Jelmer Vernooij
1d9a243d68 ldb_wrap: Fix compilation when using system ldb. 2009-12-21 23:40:12 +01:00
Jelmer Vernooij
c8e62797eb Fix initialisation of TypeObject samba.param.LoadparmService. 
Found by Ricardo Jorge <rvelhote@gmail.com>.
 2009-12-21 23:40:11 +01:00
Andrew Tridgell
0c362597c0 s4-schema: fixed the sorting of schema attributes 
another case of unsigned int subtracting breaking sorts. This one
surfaced now as attributeID_id now can be larger than 2^31
 2009-12-21 23:45:23 +11:00
Andrew Tridgell
ec7dc6a619 s4-torture: update uuid_compare test for new behaviour 2009-12-21 23:45:22 +11:00
Kamen Mazdrashki
ad35153ef4 s4-drs: Implement constraints on ATTID values in prefixMap 
Ref: MS-ADTS, 3.1.1.2.6 ATTRTYP

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:45:18 +11:00
Kamen Mazdrashki
911cefd48b s4-tort: Test handling of different ATTID values in prefixMap interface. 
It turns out ATTID values are separated in ranges.
Ref: MS-ADTS, 3.1.1.2.6 ATTRTYP

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:45:12 +11:00
Nadezhda Ivanova
35b8808b94 Adapted acl module to skip checks if as_system control is provided. 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:45:06 +11:00
Kamen Mazdrashki
9f6c81874f s4-drs: Save prefix map using LDB_CONTROL_AS_SYSTEM control 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:45:00 +11:00
Kamen Mazdrashki
7685bbbc4e s4-dsdb-util: Execute ldb_request using LDB_CONTROL_AS_SYSTEM 
This function is intended to be used when data needs
to be modified skipping access checks.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:53 +11:00
Kamen Mazdrashki
11e2c5777d s4-dsdb-util: Utility function to process ldb_request in transaction 
This function is to be used later for manually crafted
ldb_requests from within dsdb layer

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:47 +11:00
Kamen Mazdrashki
516316b107 s4-schema: Implement msDS-IntId attribute generation 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:41 +11:00
Kamen Mazdrashki
a409c0f037 s4-schema: Constraints on msDS-IntId attribute 
This attribute can not be modified on existing schema object.

msDS-IntId is not allowed during attribute creation also.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:36 +11:00
Kamen Mazdrashki
4e8ad284f5 s4-schema: Set ATTID in schema cache from "msDS-IntId" 
According to http://msdn.microsoft.com/en-us/library/cc223224%28PROT.13%29.aspx
some Attributes OIDs may not use prefixMap.
Setting ATTID in Schema Cache here should work, although
this code snippet should be moved in separate function.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:29 +11:00
Kamen Mazdrashki
14bac3a3e6 Revert "s4-drs: cope with bogus empty attributes from w2k8-r2" 
This reverts commit 1287c1d115.

Next patch should fix the "not recognized ATTIDs" problem

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:19 +11:00
Kamen Mazdrashki
ee48f583b5 s4-tort: Tests for "msDS-IntId" attribute implemented 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:13 +11:00
Kamen Mazdrashki
c113be8526 s4-tort: Move Schema tests from ldap.py into separate module 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:44:05 +11:00
Kamen Mazdrashki
d9606d64dd s4-drs: Fix bug - prefixMap is not updated when adding new OIDs. 
The bug is that prefixMap is updated only memory when
adding new Classs/Attribute that has and OID not in
prefixMap already.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:43:51 +11:00
Kamen Mazdrashki
03a1451bbc s4-drstest: Don't remove temp LDB so it can be reviewed if necessary 
This test makes temp directory which is not removed
so why not just leave LDB also.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-21 23:43:17 +11:00
Andrew Tridgell
452fc0d6f4 s4-repl: give a reason why the prepare commit failed 2009-12-21 23:41:09 +11:00
Andrew Tridgell
92d75a4bfb s4-kcc: don't crash with a NULL ntds connection list 2009-12-21 23:41:09 +11:00
Andrew Tridgell
60acce584b s4-repl: only try to replicate for NCs that we are a master for 2009-12-21 23:41:09 +11:00
Andrew Tridgell
87f28cc267 s4-torture: another unsigned comparison bug 2009-12-21 23:41:08 +11:00
Andrew Tridgell
ec74ffa8f0 s4-schema: a unsigned comparison bug in the schema code 2009-12-21 23:41:08 +11:00
Andrew Tridgell
d3708109a1 s4-drs: another two unsigned comparison bugs 2009-12-21 23:41:07 +11:00
Andrew Tridgell
2a4a159a84 s4-repl: lower debug level of a common message 2009-12-21 23:41:07 +11:00
Andrew Tridgell
47560bfda9 s4-dsdb: don't use a non-constant format string for a printf format 2009-12-21 23:41:06 +11:00
Andrew Tridgell
a070119de3 s4-dsdb: added DSDB_MODIFY_RELAX flag to the dsdb_module_*() calls 2009-12-21 23:41:06 +11:00
Andrew Tridgell
9d56f656d4 s4-dsdb: added dsdb_get_extended_dn_uint64() 2009-12-21 23:41:05 +11:00
Andrew Tridgell
e89a2db4f2 s4-dsdb: use varargs expression in dsdb_module_search() 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-21 23:41:05 +11:00
Andrew Tridgell
2c88ffb8f1 s4-dsdb: added two new dsdb_get_extended_dn_*() helper functions 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-21 23:41:04 +11:00
Andrew Tridgell
dbda2c2db5 s4-provision: added a note about where invocationIDs come from 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-21 23:41:04 +11:00
Andrew Tridgell
882768c878 s4-dsdb: give us an invocationID when in standalone mode 
To allow us to use the repl_meta_data module in standalone mode (and
thus not have two module stacks to test), we need a invocationID
stored somewhere when standalone. This creates a random one, and
stores it in @SAMBA_DSDB.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-21 23:41:04 +11:00
Stefan Metzmacher
fcbe8f0c80 s4:kdc: setup the local and remote tsocket_address at accept time 
metze
 2009-12-19 18:24:26 +01:00
Stefan Metzmacher
4dc958c7c8 s4:kdc: convert UDP based communication to tdgram_context 
metze
 2009-12-19 18:24:26 +01:00
Zachary Loafman
daa561d75b s4 torture: Add test to show archive bit behavior with directories 
Signed-off-by: Tim Prouty <tprouty@samba.org>
 2009-12-18 10:52:45 -08:00
Tim Prouty
9b869230a7 s4 torture: Fix RAW-STREAMS-DELETE to pass against samba3 2009-12-18 10:52:45 -08:00
Nadezhda Ivanova
ea365af4f5 Added freeing a successful req so it doesnt croud the ldb context 2009-12-18 17:57:08 +02:00
Nadezhda Ivanova
39616c0ea2 Added oid for AS_SYSTEM control, used to bypass access checks for system operations. 2009-12-18 15:40:11 +02:00
Andrew Tridgell
19cdcdec09 s4-dsdb: stop warnings about unknown struct GUID in prototypes 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 21:03:40 +11:00
Andrew Tridgell
cb841c363a s4-ldb: fixed a valgrind error in ldbtest 
we were using msg->dn after the ldb it contained had been freed

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 21:03:40 +11:00
Andrew Tridgell
5d7805b07f s4-dsdb: greatly simplify the subtree_delete module 
We can use dsdb_module_search() to make this much simpler

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 21:03:40 +11:00
Andrew Tridgell
b3c69e76ec s4-dsdb: declare ldb_dn_update_components() 2009-12-18 21:03:39 +11:00
Andrew Tridgell
82bf0d8bc6 s4-dsdb: added ldb_dn_update_components() 
This is used to udpate just the DN components of a ldb_dn, leaving the
other extended fields alone. It is needed to prevent linked attribute
updates from removing other extended components.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 21:03:39 +11:00
Andrew Tridgell
db76e65318 s4-dsdb: fixed the sort in dsdb_find_nc_root() 2009-12-18 21:03:39 +11:00
Andrew Tridgell
f392ae5169 s4-ldb: display msDS-OptionalFeatureGUID as a GUID 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 21:03:39 +11:00
Andrew Tridgell
811b4054f9 s4-scripts: add a enablerecyclebin script 
This can be used to enable the recyclebin on a windows box. Once we
properly implement this feature in samba we will use this to enable
the feature on ourselves as well.
 2009-12-18 21:03:39 +11:00
Andrew Tridgell
20869a0bf0 s4-ldb: canonicalise the message on ldb_add 
This canonicalise avoids a problem with an add that has multiple
elements with the same el->name. That is allowed by MS servers, and by
ldb, but it breaks things like the tdb backend and the repl_meta_data
RPMD handling.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 21:03:39 +11:00
Brendan Powers
7cb858e151 s4-dsdb: Add a test for adding, deleting, and appending a posixAccount objectClass to a user 
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 14:27:44 +11:00
Brendan Powers
08060068bf s4-dsdb: fix handling of AUX classes in objectclass_sort 
This is done by sorting the classes by subClass_order, which will
check if the last structural class is valid to add (in
objectclass_do_add instead checking the last class in the list).

They were being sorted by building a class tree, and adding the
classes to the list in that order. However, AUX classes usually don't
fit into that tree, so LDB_ERR_OBJECT_CLASS_VIOLATION was returned. I
have changed the behavior to sort the classes by subClass_order
instead.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 14:27:44 +11:00
Brendan Powers
8b88925654 s4-dsdb: return an error if samAccountName is not specified when creating a user. 
Makes sure samAccountName has been specified before adding a
user. This happened while I was trying to add a user with the
posixAccount objectclass. I forgot to specify the user objectClass,
and samba segfaulted. It now returns LDB_ERR_CONSTRAINT_VIOLATION.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 14:27:43 +11:00
Brendan Powers
d99084ffdb s4-dsdb: Move get_last_structural class from descriptor.c to util.c 
It can now also be used by objectclass.c

get_last_structural_class now ignores AUX classes, because they are
not structural

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 14:27:43 +11:00
Brendan Powers
2ad086e7f6 s4-dsdb: Add a check to prevent acl_modify from debuging a NULL message 
Check to see if there were any messages passed to acl_modify before
debugging the first one. I think I caused this by some malformed
LDIF.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2009-12-18 14:27:43 +11:00
Andrew Bartlett
c3d1e5ca0c s4:provision Give a more useful error message in guess_names 
The problem here is that as we start to get 'real users' they still
decide to do silly things, like load empty but existing smb.conf
files.  Let's give them a better chance to discover what they did
wrong.

Andrew Bartlett
 2009-12-18 14:27:43 +11:00
Tim Prouty
cfbf62dbfd s4 torture: RAW-STREAMS-NAMES Make sure the create time of the streams are different from the base file 2009-12-17 18:13:54 -08:00
Tim Prouty
c3582f923e s4 torture: Add RAW-STREAMS-RENAME3 to show error when trying to overwrite a stream with an open handle 
A normal file overwrite in this case would return NT_STATUS_ACCESS_DENIED,
but if a stream is the target NT_STATUS_INVALID_PARAMETER is returned.
 2009-12-17 18:13:48 -08:00
Tim Prouty
f8bb5a60e7 s4 torture: Parameterize streams delete behavior rather than commenting out the check. 2009-12-17 17:58:35 -08:00
Tim Prouty
f02206d933 s4 torture: RAW-STREAMS-CREATEDISP Use a normal deny mode 2009-12-17 17:58:35 -08:00
Tim Prouty
5c13a90abe s4 torture: close handle instead of using exit 2009-12-17 17:58:34 -08:00
Matthias Dieter Wallnöfer
bbec305135 s4:"samdb_set_password" - remove delete instructions 
They won't work when the LDB change is done using "samdb_replace"
(consider "samr_password.c" functions).

I think this has been a relict which has been useful before the "password_hash"
module existed. Basically it itself does now the updates.
 2009-12-17 20:00:19 +01:00
Günther Deschner
dc4c411242 s4-smbtorture: skip GetAliasMembership against s4. 
It returns NT_STATUS_INTERNAL_DB_CORRUPTION for unknown sids and I could not
figure out why.

Guenther
 2009-12-17 18:05:36 +01:00
Nadezhda Ivanova
c0883fb451 Fixed incorrect checking of PRINCIPAL_SELF permissions. 
If an ace has the PRINCIPAL_SELF as trustee, this sid has to be replaced with
the onjectSid of the object being checked. PRINCIPAL_SELF is the way to grant rights
to an account over itself.
 2009-12-17 17:25:11 +02:00
Günther Deschner
619ad0c6ec s4-smbtorture: add a samr_GetAliasMembership test to RPC-SAMR. 
Guenther
 2009-12-17 15:40:42 +01:00
Matthias Dieter Wallnöfer
1d0f364fad s4:dsdb/common/util - make NTTIME attribute wrappers use a "const" message 
There is no reason to have the message non-const here.
 2009-12-17 12:43:10 +01:00
Günther Deschner
a9689bb755 s4-smbtorture: fix smbtorture after setprinter IDL fixes. 
Guenther
 2009-12-17 10:43:32 +01:00
brendan powers
0708b2a0c9 s4-ntvfs: check if pvfs is NULL in pvfs_logoff 
pvfs can be NULL if the directory a share points to does not exist. In
this case, there would be no open files, so it is safe to just return
from the function.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-17 11:48:39 +11:00
Stefan Metzmacher
fae70e1f54 s4:gensec: allow clearing local and remote address by passing NULL 
metze
 2009-12-16 20:34:15 +01:00
Andreas Schneider
c457d54434 s4-gensec: Remove obsolete socket_address vars and fns. 2009-12-16 20:28:39 +01:00
Andreas Schneider
1e5488859a s4-gensec: Replace gensec_get_peer_addr with new tsocket based fn. 2009-12-16 20:28:38 +01:00
Andreas Schneider
ac2d31e24c s4-gensec: Replace gensec_set_peer_addr with new tsocket based fn. 2009-12-16 20:28:38 +01:00
Andreas Schneider
8ca88042f0 s4-gensec: Replace gensec_get_my_addr with new tsocket based fn. 2009-12-16 20:28:38 +01:00
Andreas Schneider
226a9db2d9 s4-gensec: Replace gensec_set_my_addr() with new tsocket based fn. 2009-12-16 20:28:38 +01:00
Andreas Schneider
743e6363d5 s4-gensec: Added remote and local setter/getter using tsocket. 2009-12-16 20:28:37 +01:00
Andrew Tridgell
8d3fc23157 s4-dsdb: also mark the relax control non-critical when done 2009-12-16 20:56:24 +11:00
Andrew Tridgell
558a38671a s4-dsdb: it is a better pattern to mark a control as done than remove it 
removing a control means it can't be seen by any other modules, which
is usually not what is wanted. Better to just mark it non-critical,
which means anyone else who wants to look at it can, but if nobody
does its not an error.
 2009-12-16 20:56:24 +11:00
Andrew Tridgell
41e403adb0 s4-dsdb: when the SD_FLAGS control is set, don't remove nTSecurityDescriptor 2009-12-16 20:56:24 +11:00
Andrew Tridgell
934bb28ef3 s4-dsdb: don't actually remove the sd_flags control, just mark it non-critical 
For controls that need to be seen by more than one module, it is best
to just mark them non-critical when handled, instead of removing
them. Otherwise lower modules can't see them.

In this case we want the operational module to see the SD_FLAGS
control
 2009-12-16 20:56:24 +11:00
Andrew Tridgell
9955756314 s4-ldb: show the OID of any unhandled critical controls 
It isn't very useful just saying that a control is not supported,
without saying which one is the problem

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:23 +11:00
Andrew Tridgell
f8320b3559 s4-ldb: fixed a transaction error on prepare_commit 
when a prepare commit fails, we need to give a cancel to all modules,
not a commit!

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:23 +11:00
Andrew Tridgell
e14c72877f s4-ldb: added --show-deactivated-link command line option 
this adds the SHOW_DEACTIVATED_LINK control
 2009-12-16 20:56:23 +11:00
Andrew Tridgell
6c2125572c s4-dsdb: added dsdb_get_deleted_objects_dn() 
This is based on the code from Eduardo Lima <eduardoll@gmail.com>, but
uses the new helper functions added in the last couple of commits

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:22 +11:00
Andrew Tridgell
3c1f18c5e2 s4-dsdb: added dsdb_find_nc_root() 
This is based on the function of the same name from Eduardo Lima
<eduardoll@gmail.com>, but using ldb_dn_compare, to give us
comparisons consistent with what the rest of the code uses.

We will use this function in combination with dsdb_wellknown_dn() to
find the Deleted Objects container for any object.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:22 +11:00
Andrew Tridgell
7d0fdcae1e s4-dsdb: added dsdb_wellknown_dn() 
This finds a wellknown object given its GUID

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:22 +11:00
Andrew Tridgell
8a74633eaa s4-dsdb: added a dsdb_module_rename() call 
This will be used by the replmd_delete() code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:21 +11:00
Andrew Tridgell
9fa1f96172 s4-dsdb: added dsdb_module_modify() 
This is used to do a sync modify in a module

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:21 +11:00
Andrew Tridgell
4b970c00ae s4-dsdb: fixed dsdb_module_dn_by_guid() 
needs to ask for the DN in storage format, plus fix compilation errors
 2009-12-16 20:56:21 +11:00
Andrew Tridgell
cd4574ff84 s4-dsdb: dsdb_flags should be unsigned 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:21 +11:00
Andrew Tridgell
57b10b664b s4-dsdb: rename dsdb_module_search_handle_flags to dsdb_request_add_controls 
This function will be used for non-search controls, like relax
 2009-12-16 20:56:21 +11:00
Andrew Tridgell
951592687a s4-dsdb: added dsdb_module_dn_by_guid() 
This finds a DN given a GUID, searching below the current module in
the module stack.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:20 +11:00
Andrew Tridgell
32995e84a2 s4-dsdb: use dsdb_dn_is_deleted_val() 
This also moves the check to before we parse the DN, which saves some
unnecessary work

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:20 +11:00
Andrew Tridgell
152f415ba8 s4-dsdb: added dsdb_dn_is_deleted_val() 
This is used to determine if a extedned DN has the 'DELETED=1'
component

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2009-12-16 20:56:20 +11:00
Andrew Tridgell
d31b6360d6 s4-ntvfs: try to fix bug 6989 
bug 6989 is a rare crash that has occurred in production. My best
guess as to the cause is the talloc_free() not being specific enough
as to which parent needs to be freed.
 2009-12-16 20:56:20 +11:00
Matthias Dieter Wallnöfer
e22e336f41 s4:drsuapi/getncchanges.c - Update the list of operational attributes 
- Reorder them as specified in "operational.c"
- Add also the lan manager hash password attribute
 2009-12-16 09:45:22 +01:00
Günther Deschner
308b50a7bb s4-smbtorture: run GetPrinterDriver2 tests against each printer's driver. 
Guenther
 2009-12-16 01:13:43 +01:00
Andreas Schneider
b55d07615b s4-kdc: Migrate to tsocket_address. 2009-12-15 23:34:23 +01:00
Volker Lendecke
4a19adadcc smbtorture4: Add rpc-samba3-getaliasmembership-0 2009-12-15 12:28:16 -08:00
Nadezhda Ivanova
4330efe0f2 Removed ldb_modify_ctrl from ldb, implemented as a static in ldap_backend. 2009-12-15 20:29:20 +02:00
Aravind Srinivasan
b85f6f63e6 s4 torture: Add new RAW-SEARCH test to explore strange max count behavior 
Signed-off-by: Tim Prouty <tprouty@samba.org>
 2009-12-15 09:51:36 -08:00
Aravind Srinivasan
8ba02d9ed9 s4 torture: Update RAW-QFILEINFO to only test info levels that are supported by the server 
Signed-off-by: Tim Prouty <tprouty@samba.org>
 2009-12-15 09:40:05 -08:00
Zach Loafman
5930f770d2 s4 torture: Convert RAW-OPEN to suite form 2009-12-15 09:13:24 -08:00
Tim Prouty
d732fb43a6 s4 torture: Add SHARE_DELETE to create_directory_handle 
Tests explicitly checking share modes should open the dir/file
with the share mode they want to test.
 2009-12-15 09:13:24 -08:00
Brian Lu
f346079083 s4:tls: fix the build on Solaris 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2009-12-15 12:56:50 +01:00
Nadezhda Ivanova
4deaa84ce4 Fixed a problem with duplicate values of allowedAttributesEffective. 2009-12-15 12:02:20 +02:00
Matthieu Patou
ef5508bc78 s4: rename res/res2 to something more explicit 2009-12-15 10:04:05 +11:00
Matthieu Patou
d2ec67eb53 s4: upgradeprovision handle renaming and knownobjects 2009-12-15 10:04:05 +11:00
Matthieu Patou
fb85977d7c s4: upgradeprovision rename also when there is a mismatch on the case of name attribute 
Renaming not only helps when name attribute is not here
  it also helps when the case is not the good one. So
  in order to avoid problem and have as much as possible similar provision
  we should use the rename whenever a name difference appear.
 2009-12-15 10:04:04 +11:00
Matthieu Patou
3357319620 s4: reorder action to permit old provision to be correctly upgraded 2009-12-15 10:04:04 +11:00
Endi Sukma Dewata
f871de7def s4:provision - Remap conflicting thumbnailPhoto and thumbnailLogo OID's. 2009-12-15 10:04:04 +11:00
Andrew Tridgell
9260396bbc s4-dsdb: added REVEAL_INTERNALS flag to dsdb_module_search_handle_flags() 2009-12-14 22:29:58 +11:00
Andrew Tridgell
7f6b524bf6 s4-devel: support vampire_ad.sh with no initial smb.conf 2009-12-14 22:29:58 +11:00
Andrew Tridgell
b11b22752a s4-loadparm: call reload_charcnv() also for a missing smb.conf 
bin/net vampire with a missing smb.conf would segfault as the iconv
convenience pointer had not been setup.
 2009-12-14 22:29:58 +11:00
Andrew Tridgell
7f16da7473 s4-dsdb: return a zero guid on error in samdb_result_guid() 2009-12-14 22:29:58 +11:00
Andrew Tridgell
bb009412d3 heimdal: work around differences between GNU and XSI strerror_r() 
This is a fairly ugly workaround, but then again, strerror_r() is a
very ugly mess.
 2009-12-14 22:29:57 +11:00
Andrew Tridgell
665e57f956 s4-dsdb: use the reveal control to hide/show extended DN components 
When reveal is set, then we show deleted linked attributes and all
linkked attribute components. When not set we show a normal extended
DN.
 2009-12-14 22:29:57 +11:00
Andrew Tridgell
e3c2309dcd s4-ldb: added new ldb_dn extended components for linked attributes 
These will store linked attribute replication meta data
 2009-12-14 22:29:57 +11:00
Andrew Tridgell
0d76df9953 s4-ldb: added a function to filter extended components of a ldb_dn 
We need to be able to filter out components that should not be exposed
to users
 2009-12-14 22:29:57 +11:00
Andrew Tridgell
725e25a206 s4-ldb: added a new "reveal" control 
This control will allow inspection of internal ldb values, which would
normally be stripped before being presented to users. The first use
will be stripping linked attribute meta data extended components.
 2009-12-14 22:29:57 +11:00
Andrew Tridgell
56b90acbf6 s4-ldb: sort the linearized extended DN by component name 
This will make life easier when handling deleted linked attributes
 2009-12-14 22:29:57 +11:00
Matthieu Patou
155bdea7b2 torture: add new tests for dfsblobs 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2009-12-14 10:58:32 +01:00
Günther Deschner
801fbd0569 s4-smbtorture: check whether a returned buffer size is a multiple of 4 in RPC-SPOOLSS. 
This gives a good indication where our IDL (and the s3 spoolss implementation) is still wrong.

Guenther
 2009-12-14 10:37:41 +01:00
Matthias Dieter Wallnöfer
f8c34c4df1 s4:"samdb_set_password_sid" - clean up created objects correctly 
- We should clean up such "helper" objects created in this function to don't
  have them around until "mem_ctx" is destroyed
- Remove a from my view pointless comment "This is a password set, not change"
  since an external argument "user_change" decides this ("modify" or "(re)set")
 2009-12-13 16:13:34 +01:00
Matthias Dieter Wallnöfer
1788abba14 s4:operational LDB module - cosmetic - reorder an attribute list 
This matches the default handling order in the "password_hash" module (it's nice
to have this consistent).
 2009-12-12 17:59:05 +01:00
Matthias Dieter Wallnöfer
5767b1dacc s4:utils/oLschema2ldif.c - remove (now) unused variables 2009-12-11 20:20:02 +01:00
Matthias Dieter Wallnöfer
31321ac868 s4:libnet/libnet_become_dc - Fix a small glitch in "becomeDC_drsuapi1_add_entry_send" 
We shouldn't use the now uninitialised "status" variable anymore.
 2009-12-11 11:19:32 +01:00
Günther Deschner
dc71d1c29d s4-smbtorture: add more spoolss_EnumPrinterKey tests for local NDR test. 
Guenther
 2009-12-10 22:49:15 +01:00
Günther Deschner
ce33967f4a s4-smbtorture: fix and extend enum printerkey test. 
Guenther
 2009-12-10 17:48:50 +01:00
Nadezhda Ivanova
56b754e09a Implementation of sDRightsEffective, allowedAttributesEffective and allowedChildClassesEffective. 
Behavior as documented in WSPP and tested. Needs optimisation though.
 2009-12-10 15:49:53 +02:00
Andrew Tridgell
c59372b0b8 s4-ldb: fixed 2 bugs in ldb_dn_set_extended_component() 
The first bug was that setting a component twice could cause it to
appear twice in the DN.

The second bug was that using an existing ldb_val from a previous call
of ldb_dn_get_extended_component() as an argument to
ldb_dn_set_extended_component() would cause a valgrind error (as the
array the val pointed into will change).
 2009-12-10 17:51:30 +11:00
Andrew Tridgell
62dc7f6b2d s4-libcli: GUID_from_ndr_blob() is strict about the blob size 
We need to create a blob of the right length
 2009-12-10 17:51:30 +11:00
Andrew Tridgell
c7c97b61ae s4-schema: use GUID_to_ndr_blob() 2009-12-10 17:51:29 +11:00
Andrew Tridgell
d35b7d0aa4 s4-schema: use binsearch.h 2009-12-10 17:51:29 +11:00
Andrew Tridgell
261ba40e77 s4-dsdb: use GUID_to_ndr_blob() 2009-12-10 17:51:29 +11:00
Andrew Tridgell
215cc5a9ed s4-ldb: use GUID_to_ndr_blob() 2009-12-10 17:51:29 +11:00
Andrew Tridgell
982228605f s4-libnet: use GUID_to_ndr_blob() 2009-12-10 17:51:28 +11:00
Andrew Tridgell
b4ea96ecd9 s4-libcli: use GUID_to_ndr_blob() 2009-12-10 17:51:28 +11:00
Andrew Tridgell
33cbe9c631 s4-server: use GUID_to_ndr_blob() in cldap and smb servers 2009-12-10 17:51:28 +11:00
Andrew Tridgell
2493776f59 s4-ldb: simplify ldif handlers using new GUID functions 2009-12-10 17:51:27 +11:00
Andrew Tridgell
d337cefa92 s4-dsdb: simplify samdb_result_guid() 2009-12-10 17:51:27 +11:00
Andrew Tridgell
56b887e5b9 s4-dsdb: simplify linked attributes code using GUID functions 2009-12-10 17:51:27 +11:00
Andrew Tridgell
81bc561330 s4-dsdb: simplify schema code using new GUID functions 2009-12-10 17:51:27 +11:00
Andrew Tridgell
f01ea8bf58 s4-smb2: use new GUID function in smb2 negprot 2009-12-10 17:51:27 +11:00
Andrew Tridgell
498f2b879a s4-libcli: use new GUID functions in libcli 2009-12-10 17:51:26 +11:00
Andrew Tridgell
08e8988bd8 s4-dsdb: use GUID_from_ndr_blob() to create dsdb_get_extended_dn_guid() 2009-12-10 17:51:26 +11:00
Günther Deschner
d2f13dd688 s4-smbtorture: enhance spoolss_EnumPrinterKey torture test. 
This demonstrates that s3 still does not have that call implemented correctly.

Guenther
 2009-12-09 15:34:45 +01:00
Andrew Tridgell
0fca76e577 s4-dsdb: added dsdb_functional_level() helper function 2009-12-09 18:18:26 +11:00
Andrew Tridgell
732c701c52 s4-drs: ensure we fill in ncRoot_dn in getncchanges 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-09 18:18:26 +11:00
Andrew Tridgell
16eb25b35b s4-drs: use parentGUID attribute in getncchanges 
Now that parentGUID is reliable again, use it instead
of building our own

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-09 18:18:25 +11:00
Andrew Tridgell
4bb2958f16 s4-ldb: fixed nested searches inside ldb modules 
We need to keep a search count in ltdb to allow for nesting
of searches inside a module

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2009-12-09 18:18:25 +11:00
Andrew Tridgell
e5a478d3a2 s4-ldb: added a missing ltdb_unlock_read() 2009-12-09 18:18:25 +11:00
Andrew Tridgell
33976711e3 s4-dsdb: use dsdb_module_search_dn in repl_meta_data 
This allows us to search below the current module. That
will be important when we start using the results of this
search to get the linked attributes meta data right
 2009-12-09 18:18:25 +11:00
Andrew Tridgell
707cd30cda s4-dsdb: fixed steal of parentGUID for empty msg 
msg->elements could be NULL before we add parentGUID
 2009-12-09 18:18:25 +11:00
Andrew Bartlett
18530985ec s4: On the way to alpha11 2009-12-09 11:52:41 +11:00
Andrew Bartlett
100e249c79 This is alpha10 2009-12-09 00:16:17 +11:00
Stefan Metzmacher
dd650edff2 s4:selftest: skip SMB2-ACLS for now 
metze
 2009-12-08 13:50:16 +01:00
Stefan Metzmacher
33ecfb05a4 s4:selftest: run RAW-STREAMS again 
metze
 2009-12-08 13:50:16 +01:00
Stefan Metzmacher
d3d2e3988f RAW-STREAMS: convert failing tests to torture api 
This is needed as we want to mark failing tests as
known failures.

metze
 2009-12-08 13:50:15 +01:00
Günther Deschner
5e8e5dfe88 s4-smbtorture: make level 8 the reference for PrinterDriverEnum test. 
Guenther
 2009-12-08 11:51:09 +01:00
Günther Deschner
35c067782b s4-smbtorture: fill in COMPARE_STRING_ARRAY macro in spoolss driver test. 
Guenther
 2009-12-08 10:37:13 +01:00
Stefan Metzmacher
ed5c3372de s4:selftest: use ${selftest_prefix} instead of hardcoded st/ 
metze
 2009-12-08 09:19:35 +01:00
Andrew Tridgell
52083a8547 s4-selftest: show the test summary at the end of 'make test' in the build farm 
This should make it easier to see what tests are failing with what
parameters
 2009-12-08 15:59:10 +11:00
Andrew Tridgell
29c87ef830 s4-heimdal: fixed a use-after-free heimdal bug 
This caused samba4kinit to segfault on some systems
 2009-12-08 15:16:13 +11:00
Andrew Tridgell
cc9d4d5181 s4-drs: use -r to ldbdel in unvampire devel script 
This ensures we delete any nTDSConnection objects
 2009-12-08 14:43:50 +11:00