sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Code
74,394 Commits 60 Branches 1,144 Tags 452 MiB
1aae898908
Commit Graph

3408 Commits

Author SHA1 Message Date
Volker Lendecke
06eec02e74 s3: Use cli_connect_nb in remote_password_change 2011-05-28 20:50:10 +02:00
Volker Lendecke
57ae32794f s3: Add called name_type param to cli_connect_nb 2011-05-28 20:50:09 +02:00
Volker Lendecke
c430b57ce4 s3: Fix a type-punned warning 2011-05-28 20:50:09 +02:00
Volker Lendecke
1173a4f83d s3: Fix some nonemtpy blank lines 2011-05-28 20:50:09 +02:00
Volker Lendecke
6bf5d9a61f s3: Fix smbsock_connect 
If all connection attempts fail, return immediately. Plain bug.
 2011-05-28 16:57:24 +02:00
Volker Lendecke
1c11186837 s3: Use cli_connect_nb in cli_start_connection 2011-05-28 10:29:53 +02:00
Volker Lendecke
defcd409a3 s3: Add cli_connect_nb 
This builds up a cli_state until after the netbios session setup. It makes use
of smbsock_connect, so it connects to 139 and 445 simultaneously. This improves
the connection to Windows 2008 which does not listen on *SMBSERVER anymore.
 2011-05-28 10:29:53 +02:00
Volker Lendecke
18ec1dab59 s3: Remove unused cli_get_nt_error 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 16:54:21 CEST 2011 on sn-devel-104
 2011-05-23 16:54:21 +02:00
Volker Lendecke
502a9924ca s3: Remove unused cli_set_nt_error 2011-05-23 15:45:37 +02:00
Volker Lendecke
fddb944a04 s3: Remove unused cli_reset_error 2011-05-23 15:45:37 +02:00
Volker Lendecke
e77da2f408 s3: Remove a reference to cli->inbuf 
This is only used for utf16 alignment calculations, "rdata" is aligned the
same way as cli->inbuf is.
 2011-05-23 15:45:37 +02:00
Volker Lendecke
b1a7bdb93c s3: Remove two false references to cli->inbuf 2011-05-23 15:45:37 +02:00
Volker Lendecke
9514f96856 s3: Fix a leftover from fstring removal in cli_state 
Jeremy, please check!
 2011-05-23 15:45:36 +02:00
Volker Lendecke
28d7282738 s3: Remove unused cli_[en|de]crypt_message 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 12:15:33 CEST 2011 on sn-devel-104
 2011-05-23 12:15:33 +02:00
Volker Lendecke
1a393b7cd6 s3: Directly call common_encrypt_buffer in cli_smb_req_iov_send 2011-05-23 11:06:08 +02:00
Volker Lendecke
df0e33008e s3: Remove cli_send/receive_smb 
A moment of silence is due here, R.I.P.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 22 22:17:12 CEST 2011 on sn-devel-104
 2011-05-22 22:17:12 +02:00
Volker Lendecke
feb1d9fef3 s3: Remove clistr_align_out 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 21 23:31:12 CEST 2011 on sn-devel-104
 2011-05-21 23:31:12 +02:00
Volker Lendecke
dca321f62b s3: Remove unused cli_setup_bcc 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 21 21:24:13 CEST 2011 on sn-devel-104
 2011-05-21 21:24:13 +02:00
Jeremy Allison
4360c5bf27 Patch for bug #8156 - net ads join fails to use the user's kerberos ticket. 
If kerberos_get_realm_from_hostname() or kerberos_get_default_realm_from_ccache() fails due to
 a misconfigured krb5.conf, try the "realm =" from smb.conf as a fallcback before going back to
 NTLMSSP (which we'll do anyway).

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat May 21 00:58:09 CEST 2011 on sn-devel-104
 2011-05-21 00:58:09 +02:00
Jeremy Allison
e0b2f6bd26 The "workgroup" parameter is not used at all in cli_session_setup_kerberos(). Remove it. 2011-05-20 23:49:04 +02:00
Volker Lendecke
d432c7e278 s3: Remove unused cli_setup_packet() 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri May 20 10:51:36 CEST 2011 on sn-devel-104
 2011-05-20 10:51:36 +02:00
Volker Lendecke
0645deb1b4 s3: Do central cli_set_error 2011-05-19 17:31:30 +02:00
Volker Lendecke
bc7df52653 s3: Remove the use of cli->inbuf/outbuf from cli_session_request 2011-05-19 13:46:47 +02:00
Volker Lendecke
efbed2ce90 s3: Add sync read_smb 2011-05-19 13:46:47 +02:00
Volker Lendecke
e7e43ba6a1 s3: Make read_smb_send/recv public 2011-05-19 13:46:47 +02:00
Andrew Bartlett
da662b82b8 s3-lib Replace StrnCaseCmp() with strncasecmp_m() 
strncasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
 2011-05-18 16:12:08 +02:00
Andrew Bartlett
c615ebed6e s3-lib Replace StrCaseCmp() with strcasecmp_m() 
strcasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
 2011-05-18 16:12:08 +02:00
Björn Baumbach
6552ed64c1 s3-libsmb/passchange.c: Fix cli_errstr() usage (part of bug #7864) 
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-05-18 10:50:57 +02:00
Christian Ambach
20179bb550 s3:libsmb convert user-specified domain to uppercase 
with client ntlmv2 auth = yes, there is a small difference between
using smbclient -U user\domain and smbclient -U user -W domain
if domain is provided in lowercase

using -W will uppercase the given parameter, while picking the
domain name from -U will not convert it to uppercase and this
leads to failing NTLMv2 authentication

with this patch, there is no difference between
smbclient -U domain\user and smbclient -U user -W domain any more

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Mon May 16 11:42:55 CEST 2011 on sn-devel-104
 2011-05-16 11:42:55 +02:00
Volker Lendecke
30be9fe554 s3: Make&use set_socket_addr_v4 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 14 18:57:57 CEST 2011 on sn-devel-104
 2011-05-14 18:57:57 +02:00
Volker Lendecke
f1cdce6c13 s3: Paranoia in smbsock_connect_state_destructor 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 14 14:19:01 CEST 2011 on sn-devel-104
 2011-05-14 14:19:00 +02:00
Volker Lendecke
06a2ff5796 s3: Use tevent_req_ntstatus properly in a few places 2011-05-10 12:10:25 +02:00
Rusty Russell
87e3542174 async_smb.c: convert cli->timeout properly 
I have a test failure on my 32-bit Ubuntu system, in that
samba3.smbtorture_s3.plain(s3dc).LOCK9 immediately times out (rather than
waiting 5 seconds for the child).

Debugging revealed this code: timeout is in ms and is set to > 1000 in
various places.  The code dates from 2002, and other perturbations didn't
reveal why it breaks now, but fix it anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue May 10 12:09:07 CEST 2011 on sn-devel-104
 2011-05-10 12:09:07 +02:00
Rusty Russell
7deeacae2b gencache: don't use CLEAR_IF_FIRST as fallback. 
CLEAR_IF_FIRST only works if *all* openers use that flag.

So just truncate the file: it's racy, but that's what we're doing anyway.

We'd really need a TDB_OPENCHECK_OR_CLEAR flag to do this properly (or in
TDB2, a open hook at the right point).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2011-04-19 12:06:05 +09:30
Volker Lendecke
622faa2687 s3: Fix including libsmb/proto.h without prior ads.h 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May  7 11:38:11 CEST 2011 on sn-devel-104
 2011-05-07 11:38:11 +02:00
Günther Deschner
1e208a7057 s3-includes: no need to globally include libads/ads_status.h. 
Guenther
 2011-05-06 16:37:22 +02:00
Günther Deschner
675573d54b s3-includes: finally only include client.h when libsmb is used. 
Guenther
 2011-05-06 16:37:22 +02:00
Günther Deschner
27022587e3 s3-libsmb: move protos to libsmb/proto.h 
Guenther
 2011-05-06 16:37:18 +02:00
Günther Deschner
d8cfca3a9b s3: only include tdb headers where needed. 
Guenther
 2011-05-06 10:48:10 +02:00
Andrew Bartlett
e3b858496f libcli/smb Move cifs posix helper functions and headers in common 
unix_perms_to_wire() was a duplicate symbol in the top level build.

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Andrew Bartlett
db74cad1c6 libcli/util Move NTSTATUS table to the top level 2011-05-06 07:51:24 +02:00
Andrew Bartlett
344eb08ee4 nterr: Add mem_ctx for return string from get_nt_error_c_code() 
It is clearer to avoid the implicit return on talloc_tos()

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Andrew Bartlett
f1ec28827f libcli/util Merge ntstatus_to_dos() ntstatus_to_werror() to the top level 
This takes the Samba4 version, with the NT_STATUS_IS_DOS() check.
This will be used in smbd/error.c shortly.

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Andrew Bartlett
865a937671 errors: Merge ntstatus -> DOS error table between Samba3 and Samba4. 
They are now identical

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Jeremy Allison
7d6ebe0de7 More const fixes. Remove CONST_DISCARD. 2011-05-06 01:44:07 +02:00
Jeremy Allison
02af307585 More simple const fixes. 2011-05-05 23:56:07 +02:00
Jeremy Allison
e131c94ac1 More const fixes for compiler warnings from the waf build. 2011-05-05 23:56:07 +02:00
Jeremy Allison
4f41be356a Fix many const compiler warnings. 2011-05-05 10:41:59 -07:00
Günther Deschner
ea8960448d s3-libsmb: run minimal_includes.pl. 
Guenther
 2011-05-05 02:05:27 +02:00
Jeremy Allison
a3e913ae8b Add in bufflen limit when storing NetBIOS names. Remove safe_strcpy. 2011-05-04 12:12:15 -07:00
Jeremy Allison
0c464df22b Change safe_strcpy_base to strlcpy_base. Note the size doesn't change here as the original macro auto-added the -1. 2011-05-04 12:12:14 -07:00
Volker Lendecke
7febcb5ffe s3: Filter out duplicates in name_query() 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 00:03:47 CEST 2011 on sn-devel-104
 2011-05-04 00:03:47 +02:00
Volker Lendecke
8da8c36b53 s3: Tune broadcast namequeries for unique names 
If we get a unique name via a broadcast query, there's no point in waiting the
full timeout. A unique name is just what its name says: unique. No point in
waiting longer.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May  3 00:57:24 CEST 2011 on sn-devel-104
 2011-05-03 00:57:24 +02:00
Stefan Metzmacher
76b3867547 s3:libsmb/nterr: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE 
metze
 2011-05-02 13:58:23 +02:00
Volker Lendecke
d87427973c s3: Make name_resolve_bcast return sockaddr_storage 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 20:40:46 CEST 2011 on sn-devel-104
 2011-04-30 20:40:46 +02:00
Volker Lendecke
020b691cf8 s3: Remove ip_sevice from get_ipc_connect_master_ip 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 30 18:16:28 CEST 2011 on sn-devel-104
 2011-04-30 18:16:28 +02:00
Jeremy Allison
de87f549b7 Add POSIX O_RDONLY test of a directory for bug #8112 - POSIX extension opens of a directory are denied with EISDIR. 
Don't strip access bits from wire flags when opening a directory.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 30 02:21:24 CEST 2011 on sn-devel-104
 2011-04-30 02:21:24 +02:00
Günther Deschner
50883cfeb4 s3-tevent: only include ../lib/util/tevent wrappers where needed. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
 2011-04-29 14:00:30 +02:00
Andrew Bartlett
0520da2bbe s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
0eca33bbf6 s3-smb Use FILE_ATTRIBUTE_DIRECTORY intead of aDIR 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
0a3c84b554 s3-smb Use FILE_ATTRIBUTE_SYSTEM intead of aSYSTEM 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:13 +10:00
Andrew Bartlett
317e19aeb3 s3-smb Use FILE_ATTRIBUTE_HIDDEN intead of aHIDDEN 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:12 +10:00
Andrew Bartlett
7f66ebde2e s3-smb Use FILE_ATTRIBUTE_READONLY intead of aRONLY 
This means we use just one constant for this file attribute.

Andrew Bartlett
 2011-04-29 16:38:12 +10:00
Andrew Bartlett
818ec32d0c s3-libads Pass a struct sockaddr_storage to cldap routines 
This avoids these routines doing a DNS lookup that has already been
done, and ensures that the emulated DNS lookup isn't thrown away.

Andrew Bartlett
 2011-04-28 05:30:20 +02:00
Jeremy Allison
240465f96e Remove another fstring in this code. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 28 03:15:32 CEST 2011 on sn-devel-104
 2011-04-28 03:15:32 +02:00
Jeremy Allison
af599b3d90 Fixup (C) - we've both worked lots on this :-). 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 27 21:56:29 CEST 2011 on sn-devel-104
 2011-04-27 21:56:29 +02:00
Jeremy Allison
1815f0298f Remove fstrings from client struct. Properly talloc strings (ensuring we never end up with a NULL pointer). 2011-04-27 12:06:25 -07:00
Andrew Bartlett
e130dec97b s3-libsmb Use 'resolv:hosts file' as a DNS emulation when specified. 
This allows make test to operate without making real DNS calls.

Andrew Bartlett
 2011-04-27 11:40:18 +10:00
Volker Lendecke
e81ea8a291 s3: Make cli_session_setup_lanman2 async 
Signed-off-by: Jeremy Allison <jra@samba.org>

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Apr 27 00:25:35 CEST 2011 on sn-devel-104
 2011-04-27 00:25:34 +02:00
Volker Lendecke
531628e558 s3: Make cli_session_setup_nt1 async 
Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-26 12:22:55 -07:00
Volker Lendecke
40e2ee9cb6 s3: Make plaintext session setup async 
Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-26 12:22:55 -07:00
Volker Lendecke
ca9ac7c4c7 s3: Remove cli_write 
Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-26 12:22:55 -07:00
Volker Lendecke
0226428eb9 s3: Use cli_writeall instead of cli_write 
Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-26 12:22:55 -07:00
Volker Lendecke
d018fccb70 s3: Add cli_writeall 
Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-26 12:22:55 -07:00
Volker Lendecke
80c395aef4 s3: Remove unused code 
This is done in name_query_send these days

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 25 19:24:58 CEST 2011 on sn-devel-104
 2011-04-25 19:24:58 +02:00
Volker Lendecke
a3d35ac44b s3: Move setting the name_query timeout 
An async caller might want a different timeout behaviour
 2011-04-25 18:39:20 +02:00
Volker Lendecke
b61c38fde6 s3: Fix some typos in dsgetdcname 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 25 12:35:30 CEST 2011 on sn-devel-104
 2011-04-25 12:35:30 +02:00
Volker Lendecke
60e8e33414 s3: "port" is not used in dsgetdcname 
Günther, please check!
 2011-04-25 11:47:27 +02:00
Volker Lendecke
23a6af46c8 s3: Add a 10-second timeout for the 445 or netbios connection to a DC 2011-04-25 09:50:32 +02:00
Stefan Metzmacher
75ad180379 s3:libsmb: make use of BVAL() and remove ugly LARGE_SMB_OFF_T ifdef's 
We rely on uint64_t for a long time now...

metze
 2011-04-23 10:37:49 +02:00
Volker Lendecke
726fa732fa s3: Fix Coverity ID 2325, RESOURCE_LEAK 2011-04-22 10:06:36 +02:00
Andrew Bartlett
0e5482c791 libcli/auth: Move more kerberos wrapping in common 
These functions are required to get the krb5 PAC parsing and
verfication in common.

Andrew Bartlett
 2011-04-20 04:31:07 +02:00
Volker Lendecke
ca5dcf2412 s3: guest sesssetup is only 13 words 
(cherry picked from commit 69650a2aaa8649570261df7efccb35ad76d7cfc1)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 16 16:20:08 CEST 2011 on sn-devel-104
 2011-04-16 16:20:08 +02:00
Volker Lendecke
10a552a957 s3: Use tevent_req_nterror properly in a few places 2011-04-16 15:34:58 +02:00
Andrew Bartlett
4ba1375526 libcli/auth Move krb5 wrapper functions from s3 into common 
This requires a small rework of the build system to ensure that the
correct #define statements are made in both the s3 and top level
builds.  We now define the various HAVE_ macros in config.h at all
times, using heimdal_build/wscript_configure when that is in use.

Andrew Bartlett
 2011-04-14 16:38:26 +10:00
Günther Deschner
9824e2e5ee s3-rpc_client: add and use rpc_client/rpc_client.h. 
Guenther
 2011-04-13 22:23:59 +02:00
Volker Lendecke
e53dfebba0 s3: Remove some unused code 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr  3 18:32:51 CEST 2011 on sn-devel-104
 2011-04-03 18:32:51 +02:00
Larry Reid
76f7c2a254 Fix for servers that don't put a path separator at the end of the service. 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr  3 10:33:42 CEST 2011 on sn-devel-104
 2011-04-03 10:33:42 +02:00
Günther Deschner
b1e3b9d7c1 s3: only include ntioctl.h where needed. 
Guenther
 2011-03-30 01:13:10 +02:00
Günther Deschner
ab36d597e7 s3-messages: make ndr_messaging.h part of messages.h. 
Guenther
 2011-03-30 01:13:09 +02:00
Günther Deschner
b2af281e50 s3-messages: only include messages.h where needed. 
Guenther
 2011-03-30 01:13:09 +02:00
Günther Deschner
2473c2fb1b s3-libsmb: put namequery headers to nmblib.h 
We might find a better name for it and merge other namequery related things as
well here...

Guenther
 2011-03-30 01:13:09 +02:00
Günther Deschner
2f36ef7225 s3-passdb: add passdb.h where needed. 
Guenther
 2011-03-30 01:13:07 +02:00
Günther Deschner
0e771263ee s3-includes: only include system/filesys.h when needed. 
Guenther
 2011-03-30 01:13:07 +02:00
Günther Deschner
99f4a64543 s3-trans2: only include trans2.h where needed. 
Guenther
 2011-03-30 01:13:06 +02:00
Günther Deschner
d85f140826 s3-winbind: remove global inclusion of libwbclient. 
Guenther
 2011-03-30 01:13:06 +02:00
Günther Deschner
52ff0dde37 s3-libsmb: remove duplicate NTSTATUS variable. 
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 29 17:00:26 CEST 2011 on sn-devel-104
 2011-03-29 17:00:26 +02:00
Jeremy Allison
52602e4f5a Fix inspired by work done by David Disseldorp for bug #8040 - smbclient segfaults when a Cyrillic netbios name or workgroup is configured. 
Change msrpc_gen to return NTSTATUS and ensure everywhere this is
used it is correctly checked to return that status.

Jeremy.
 2011-03-28 23:12:07 +02:00
Volker Lendecke
592c669d9d s3: Convert cli_raw_tcon to cli_smb 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 19:50:21 CEST 2011 on sn-devel-104
 2011-03-27 19:50:21 +02:00
Volker Lendecke
ffef3aa809 s3: Replace cli_negprot_sendsync() by cli_negprot_send() 2011-03-27 19:04:11 +02:00
Volker Lendecke
5d9075c049 s3: Remove a use of cli_send_smb 2011-03-27 19:04:10 +02:00
Volker Lendecke
fc4095436f s3: Fix Coverity ID 2326, CHECKED_RETURN 2011-03-26 13:37:40 +01:00
Andrew Tridgell
2588e71809 s3-libsmb: work our correct length for EA strings 2011-03-25 04:37:06 +01:00
Andrew Tridgell
4d47493368 s3-dfs: removed the last user of sec_len==-1 in pull_*_base_talloc() 
hopefully there aren't any others lurking in the code
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
980064b76d lib: remove unused pieces of string_wrappers.h 2011-03-25 04:37:06 +01:00
Volker Lendecke
155c4fbc10 s3: Fix some errno assignments in SMBC_opendir_ctx 
Do the assignment as the last action to make sure it's not overwritten

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 24 17:31:57 CET 2011 on sn-devel-104
 2011-03-24 17:31:57 +01:00
Volker Lendecke
9db92bb7f9 s3: Fix Coverity ID 2325: RESOURCE_LEAK 2011-03-24 16:05:53 +01:00
Andrew Tridgell
15e84a9a09 charcnv: removed the allow_badcharcnv and allow_bad_conv options to convert_string*() 
we shouldn't accept bad multi-byte strings, it just hides problems

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
 2011-03-24 01:47:26 +01:00
Andrew Bartlett
1d22c3919d s3-safe_str: Futher simplify the macros by removing indirection 
Now that we don't need to pass in the function name and string,
another level of indirection can be safely removed, and the operation
of these macros made much clearer.

Andrew Bartlett
 2011-03-23 12:49:39 +11:00
Andrew Bartlett
1923b78209 s3-lib Remove the clobber_region() code. 
This code wrote to the full buffer in fstrcpy(), pstrcpy() and other
fixed-length string manipulation functions.

The hope of this code was to find out at run time if we were mixing up
pstring and fstring etc, and to record where this came from.  It has a
runtime performance impact (particularly if compiled with
--enable-developer).

It is being removed because of the complexity it adds, and the
distinct lack of bugs that this complexity has been credited in
finding.

The macro-based compile-time checking of string sizes remains.

Andrew Bartlett
 2011-03-23 12:49:39 +11:00
Günther Deschner
3aa9d3005a s3-build: only include asn1 headers where actually needed. 
Guenther
 2011-03-16 23:46:18 +01:00
Volker Lendecke
4f46ad96f2 s3: Fix Coverity ID 2147, FORWARD_NULL 
How could this ever have worked???
 2011-03-16 22:07:24 +01:00
Günther Deschner
1ce4d2d83a s3-msdfs: avoid global inclusion of msdfs.h. 
Guenther
 2011-03-16 16:56:46 +01:00
Günther Deschner
fad0112373 s3-build: stop including ldap and lber headers everywhere in the code. 
Instead use new header smb_ldap.h where all LDAP API related things are handled,
while smbldap.h only deals with our smbldap_X() API.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104
 2011-03-16 10:54:50 +01:00
Günther Deschner
d19ea55e9e s3-includes: avoid global include of gssapi headers. 
Guenther
 2011-03-16 10:11:16 +01:00
Günther Deschner
6c8d802391 s3-libsmb: move smb encryption structs into own header. 
Guenther
 2011-03-16 10:11:16 +01:00
Günther Deschner
7a91282c9f s3-libsmb: only include rap client when needed. 
Guenther
 2011-03-15 21:16:35 +01:00
Volker Lendecke
e818090e24 s3: Fix bug 8009 - net rap session cannot get username 
Looking in [MS-RAP].pdf - these strings are always 4 bytes as an
offset in the rparam area, the string length is the size in the rdata area.
Se we must always return we have consumed 4 param bytes.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Mar 14 20:09:09 CET 2011 on sn-devel-104
 2011-03-14 20:09:09 +01:00
Volker Lendecke
f84d439ff6 Revert "s3: Fix bug 8009" 
This reverts commit 1829891391.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 13 10:33:25 CET 2011 on sn-devel-104
 2011-03-13 10:33:25 +01:00
Volker Lendecke
1829891391 s3: Fix bug 8009 
Jeremy, please check!

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar 12 11:39:41 CET 2011 on sn-devel-104
 2011-03-12 11:39:41 +01:00
Volker Lendecke
181b23ceed nsswitch: wbcFreeMemory deals fine with NULL 2011-03-05 14:29:32 +01:00
Günther Deschner
ef87f970b3 s3-nterr: use strcasecmp in nt_status_string_to_code(). 
Guenther
 2011-03-04 01:18:42 +01:00
Günther Deschner
d367777352 s3-nterr: within nt_errstr() compare codes using NT_STATUS_V(). 
This is to avoid future very special NT_STATUS_EQUAL semantics within s4.

Guenther
 2011-03-04 01:18:42 +01:00
Günther Deschner
199809b3cc nterr: make sure both nt_err_desc structs are the same. 
Guenther
 2011-03-04 01:18:42 +01:00
Günther Deschner
45710a05c5 nterr: make sure both nt_errs structs are the same. 
Guenther
 2011-03-04 01:18:42 +01:00
Günther Deschner
c1089c130b s3-nterr: make nt_err_desc static const. 
Guenther
 2011-03-04 01:18:42 +01:00
Günther Deschner
cb8c0e1776 nterr: remove space indents (use tabs instead), following coding standards. 
Guenther
 2011-03-04 01:18:41 +01:00
Günther Deschner
2f46942e08 nterr: remove trailing whitespace. 
Guenther
 2011-03-04 01:18:41 +01:00
Andrew Bartlett
243abcb0af s3-build __FUNCTION__ is always available, always use it 
This avoids duplication between FUNCTION_NAME and __FUNCTION__
 2011-03-01 02:13:22 +01:00
Andreas Schneider
bf18403c81 s3-rpc_client: Move client pipe functions to own header. 2011-02-28 18:15:04 +01:00
Stefan Metzmacher
7eedf69bc9 s3: Remove unused receive_packet 2011-02-28 16:40:19 +01:00
Volker Lendecke
fec0baacb6 s3: Make is_zero_addr take a sockaddr_storage 
All callers had to cast this anyway

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 27 11:02:53 CET 2011 on sn-devel-104
 2011-02-27 11:02:53 +01:00
Günther Deschner
313db81ad3 s3-errormap: move (unused) map_nt_error_from_wbcErr out of errormap. 
Guenther
 2011-02-25 01:08:41 +01:00
Christian Ambach
051611256b s3:libsmb only log a dead connection if it was not closed 
in case the cli was closed before (e.g. via a dropped ip message)
it can be expected that the read here returns with an error and so
we should not log that a connection is dead when it was closed before

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 23 16:51:03 CET 2011 on sn-devel-104
 2011-02-23 16:51:03 +01:00
Andrew Bartlett
1ad8e5229f lib/util/charset Add back setlocale(), but only when called from binaries 
When called from a library, we don't want to call this, as we may
overwrite some of our calling program's context.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 18 09:29:35 CET 2011 on sn-devel-104
 2011-02-18 09:29:35 +01:00
Volker Lendecke
64c63a3e1c s3: Fix a C++ warning 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Feb 14 21:44:55 CET 2011 on sn-devel-104
 2011-02-14 21:44:55 +01:00
Günther Deschner
e4bf69285b s3-libsmb: fix ifdef check in ads_dc_name. 
We are accessing an LDAP structure here, so we better check that LDAP support
was there as well as Kerberos support.

Guenther
 2011-02-11 12:22:41 +01:00
Günther Deschner
65bb6b3524 s3: move some stuff out of smb.h to better locations. 
Guenther
 2011-02-09 22:51:23 +01:00
Jeremy Allison
c377b0e718 Fix up some buildfarm warnings. 2011-02-09 21:21:04 +01:00
Jeremy Allison
344e4cd280 Don't use asprintf in this library - breaks the build on many systems. Fake with malloc/memcpy. 2011-02-09 21:21:04 +01:00
Günther Deschner
fcaba0fb59 s3-libsmb: prefer dcerpc_lsa_X functions. 
Guenther
 2011-02-02 19:02:23 +01:00
Stefan Metzmacher
e2e426588b s3:libsmb: display NT_STATUS_RPC_SEC_PKG_ERROR in error strings 
metze
 2011-01-30 17:36:21 +01:00
Volker Lendecke
a042617e97 s3: Remove an unneeded check 
In many other places we already assume that if asprintf returns !=-1 then the
result is allocated.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 29 15:00:09 CET 2011 on sn-devel-104
 2011-01-29 15:00:09 +01:00
Jeremy Allison
bb358ecd5a From Metze - make sure we're using the same string length for the hash. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 18:32:15 CET 2011 on sn-devel-104
 2011-01-26 18:32:15 +01:00
Jeremy Allison
44732734cc Fix bug #7863 - Unlink may unlink wrong file when hardlinks are involved. 
Do this by keeping a linked list of delete on close tokens, one for
each filename that identifies a path to the dev/inode. Use the
jenkins hash of the pathname to identify the correct token.
 2011-01-25 14:23:19 -08:00
Jeremy Allison
b97f1ce68a Add name_hash into the share mode entry struct (as yet only use for renames to identify a specific path). 2011-01-25 14:01:52 -08:00
Volker Lendecke
058de59a8e s3: Fix connecting to port-139 only servers 
When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104
 2011-01-22 17:42:41 +01:00
Volker Lendecke
c7a5933e4b s3: Remove some unused code 2011-01-17 08:03:43 +01:00
Volker Lendecke
6f3e11088c s3: Convert cli_lock64 to cli_smb 2011-01-17 08:03:43 +01:00
Volker Lendecke
dd2f234412 s3: Convert cli_lock to use cli_locktype 2011-01-17 08:03:43 +01:00
Volker Lendecke
0e2854f743 s3: Convert cli_locktype to cli_smb 2011-01-17 08:03:43 +01:00
Volker Lendecke
7b054ecaed s3: Make passing up "result_parent" from cli_smb optional 2011-01-17 08:03:43 +01:00
Volker Lendecke
b33f1147a6 s3: Remove unused cli_send_keepalive 2011-01-17 08:03:42 +01:00
Volker Lendecke
6e684c8460 s3: Remove unused cli_send/receive_trans 2011-01-17 08:03:42 +01:00
Volker Lendecke
8ac68fc3cb s3: Convert cli_api to cli_trans 2011-01-17 08:03:42 +01:00
Volker Lendecke
cb412d22eb s3: Make cli_setpathinfo_basic use cli_setpathinfo 2011-01-17 08:03:42 +01:00
Volker Lendecke
21d5485e06 s3: Add cli_setpathinfo 2011-01-17 08:03:42 +01:00
Volker Lendecke
2068b96dce s3: Rename cli_setpathinfo->cli_setpathinfo_basic 2011-01-17 08:03:42 +01:00
Volker Lendecke
2d44a0583b s3: Remove unused cli_send/receive_nt_trans 2011-01-17 08:03:42 +01:00
Volker Lendecke
5dee39b5bf s3: Move dump_ntquota* to smbcquotas.c 2011-01-17 08:03:41 +01:00
Volker Lendecke
a1f541723d s3: Convert cli_set_fs_quota_info to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
797c027cc8 s3: Convert cli_get_fs_quota_info to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
483e0447f5 s3: Convert cli_list_user_quota to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
eb7db50f60 s3: Convert cli_set_user_quota to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
e2a96711d7 s3: Convert cli_get_user_quota to cli_trans 2011-01-17 08:03:41 +01:00
Volker Lendecke
bc5554bdcc s3: Fix some nonempty blank lines 2011-01-17 08:03:40 +01:00
Volker Lendecke
674dcd68a6 s3: Remove cli_send_trans from cli_qpathinfo_alt_name 2011-01-17 08:03:40 +01:00
Volker Lendecke
fc8bfeea31 s3: Remove cli_send_trans from cli_oem_change_password 2011-01-17 08:03:40 +01:00
Volker Lendecke
50b3458261 s3: Convert cli_set_secdesc to cli_trans 2011-01-15 16:34:35 +01:00
Volker Lendecke
4fc5699a79 s3: Fix some nonempty blank lines 2011-01-15 16:34:35 +01:00
Günther Deschner
44e048f7a8 s3-libsmbclient: prefer dcerpc_srvsvc_X functions. 
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-01-13 14:11:55 +01:00
Volker Lendecke
8c6b0b61e5 s3: Fix some nonempty blank lines 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 12 19:04:25 CET 2011 on sn-devel-104
 2011-01-12 19:04:24 +01:00
Volker Lendecke
35f08a2958 s3: Remove a pointless else 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 12 11:12:56 CET 2011 on sn-devel-104
 2011-01-12 11:12:56 +01:00
Volker Lendecke
342bb471dc s3: Remove superfluous ; 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 10 15:26:50 CET 2011 on sn-devel-104
 2011-01-10 15:26:50 +01:00
Volker Lendecke
b57721faaf s3: Convert enc_blob_send_receive to cli_trans() 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan  9 11:40:04 CET 2011 on sn-devel-104
 2011-01-09 11:40:04 +01:00
Volker Lendecke
3274d80ffd s3: Fix two incompatible pointer type warnings on Solaris 2011-01-09 10:21:41 +01:00
Günther Deschner
3294ccbb6d netlogon: move netlogon helpers to ../libcli/netlogon. 
Guenther
 2011-01-07 15:02:24 +01:00
Volker Lendecke
3e0915f271 s3: Make nmbd socket dir configurable 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan  7 14:14:19 CET 2011 on sn-devel-104
 2011-01-07 14:14:19 +01:00
Volker Lendecke
2672101cc4 s3: Remove some unused code 2011-01-07 13:28:07 +01:00
Volker Lendecke
dab6a35f4c s3: Limit the number of unexpected clients to 200 
DoS protection like the max winbind clients. Settable by
nmbd:unexpected_clients
 2011-01-07 13:28:07 +01:00
Volker Lendecke
0cff82e054 s3: Limit the number of unexpected packets per client to 10 
Non-reading clients could maliciously make nmbd allocate memory
 2011-01-07 13:28:07 +01:00
Volker Lendecke
b4041b59b2 s3: Use the new nbt_getdc in dsgetdcname() 2011-01-07 13:28:06 +01:00
Volker Lendecke
f9520008df s3: Add nbt_getdc 
This is a getdc version that uses /tmp/.nmbd/unexpected
 2011-01-07 13:28:06 +01:00
Volker Lendecke
1137cf8e6f s3: Fix a valgrind error 2011-01-07 13:28:06 +01:00
Volker Lendecke
126b1806b8 s3: Factor out parse_getdc_response 2011-01-07 13:28:06 +01:00
Volker Lendecke
0376d03e6d s3: Lift my_mailslot from prep_getdc_request 2011-01-07 13:28:05 +01:00
Volker Lendecke
6ba4bddb61 s3: Make name_query use /tmp/.nmbd/unexpected 2011-01-07 13:28:05 +01:00
Volker Lendecke
a32f021d66 s3: Make node_status_query use /tmp/.nmbd/unexpected 2011-01-07 13:28:04 +01:00
Volker Lendecke
77a9b0e265 s3: Add nb_trans_send/recv 
This does an async port 137 transaction: It connects to /tmp/.nmbd/unexpected,
sends out the query and then waits for a reply on both the socket as well as
data from /tmp/.nmbd/unexpected. Every packet is passed through a validator. If
that returns true, the packet received is finally accepted.
 2011-01-07 13:28:04 +01:00
Volker Lendecke
cbd5e4e16b s3: Add sock_packet_read 
Read packets from both a socket and from /tmp/.nmbd/unexpected simultaneously
 2011-01-07 13:28:04 +01:00
Volker Lendecke
d801d4da2d s3: Add packet_trn_id() 2011-01-07 13:28:04 +01:00
Volker Lendecke
b2c62d639d s3: Basic infrastructure for /tmp/.nmbd/unexpected 
This provides the framework to replace the unexpected.tdb file. Nmbd will
listen on /tmp/.nmbd/unexpected. A client interested in unexpected packets
connects there. It sends a nb_packet_query plus a potential mailslot name for
dgram packets. It waits for a single ack byte to avoid races. After that has
happened, nmbd will pass down all matching packets through that socket.

nb_packet_server_create and nb_packet_dispatch are the nmbd routines,
nb_packet_reader_send/recv and nb_packet_read_send/recv are the client ones.
 2011-01-07 13:28:03 +01:00
Volker Lendecke
593c004b74 s3: Fix a memleak in receive_getdc_response 
It's the free_packet() that was missing. On the way, I've changed the
"return false;" to a "goto fail;", which makes the patch a bit larger.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan  2 14:27:56 CET 2011 on sn-devel-104
 2011-01-02 14:27:56 +01:00
Jeremy Allison
9d754da112 Fix memory leak I introduced when refactoring unexpected packet code. 
Found by Volker.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sun Jan  2 06:11:13 CET 2011 on sn-devel-104
 2011-01-02 06:11:13 +01:00
Volker Lendecke
9ccef4e62b s3: Remove unused mem_ctx arg from set_getdc_request 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan  1 23:00:24 CET 2011 on sn-devel-104
 2011-01-01 23:00:24 +01:00
Volker Lendecke
b2ba2b956e s3: Factor out prep_getdc_request 2011-01-01 22:14:19 +01:00
Volker Lendecke
e0abc5c15f s3: cli_send_mailslot -> cli_prep_mailslot 2011-01-01 22:14:19 +01:00
Volker Lendecke
bb6da9f06c s3: Fix some nonempty blank lines 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan  1 16:03:23 CET 2011 on sn-devel-104
 2011-01-01 16:03:23 +01:00
Volker Lendecke
659bb646e4 s3: Add some const to receive_getdc_response 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Dec 31 14:48:57 CET 2010 on sn-devel-104
 2010-12-31 14:48:57 +01:00
Volker Lendecke
ba15b7af07 s3: Add some const to send_getdc_request 2010-12-31 14:02:04 +01:00