1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

11884 Commits

Author SHA1 Message Date
Tim Potter
1bc691069b Don't trash the values of CFLAGS and LIBS while engaged in Kerberos
detection.  On Solaris 9 extra libraries -lber and -lresolv are
required for Kerberos tests.  We used to have an extra check for
-lresolv only but I think the correct solution is not to forget about it
in the first place.

This should fix bug #125 although I don't have access to a
system to test it out on.
(This used to be commit 4ddfab4a57)
2003-06-25 01:33:27 +00:00
Jeremy Allison
911fbd5cdb More debugs for this... (these should have been here already !).
Jeremy.
(This used to be commit a118648d95)
2003-06-25 00:28:46 +00:00
Jeremy Allison
dba0005a9d More instrumentation tracking down this bug...
Jeremy.
(This used to be commit 705915d9f7)
2003-06-25 00:11:38 +00:00
Jeremy Allison
b5e2d8db28 Start to instrument this code as I try and track down a nasty bug that
causes mapping to dissapear...
Jeremy.
(This used to be commit bdffc81c9d)
2003-06-25 00:02:17 +00:00
Jeremy Allison
45f472ba21 Sequence number was not getting updated with ldap hack. Only a bug in this
branch.
Jeremy.
(This used to be commit 19629b41cb)
2003-06-24 23:07:26 +00:00
Jeremy Allison
11e6203896 Explain why winbindd is exiting.
Jeremy.
(This used to be commit a411923aa2)
2003-06-24 20:54:32 +00:00
Andrew Bartlett
137265b806 Fix pdb_ldap segfaults, and wrong default values for ldapsam_compat.
Reviewed by vl, metze.

Andrew Bartlett
(This used to be commit 9804ad458a)
2003-06-24 14:23:34 +00:00
Simo Sorce
a34ba41ae5 do not forget the include file :-)
(This used to be commit 73e13b9baf)
2003-06-24 14:02:57 +00:00
Simo Sorce
52826c034e add tdb backup function separation and winbind idmap upgrade code form
pre-2.2.4 tdb database format.

tx volker for your work on this
(This used to be commit 2bdbeb9e97)
2003-06-24 14:02:21 +00:00
Tim Potter
52e4b4d5ab More tuning of Kerberos detection - don't fall through to detect kerberos libs
when we have already decided that we can't do it.
(This used to be commit db792ed530)
2003-06-24 07:46:26 +00:00
Tim Potter
200af4e84c More sensible behaviour for bug 152. If we don't have krb5.h and were explicitly
configured using --with-ads then give an error, otherwise fall back to compiling
without ADS.

Tested on redhat 8.0 with and without MIT kerberos packages installed.  Metze,
let me know if this is working OK for you now!
(This used to be commit 7ea81535b8)
2003-06-24 05:31:08 +00:00
Jeremy Allison
98689251bb Fixes from Martin Dorey <mdorey@bluearc.com> to only ask for and change
the requested parts of the ACL.
Jeremy.
(This used to be commit c35a88201c)
2003-06-24 01:09:36 +00:00
Jeremy Allison
4f99186f6b Move the map acl inherit parameter into the protocol section.
Jeremy.
(This used to be commit 076d9a3c9b)
2003-06-24 00:58:54 +00:00
Jeremy Allison
951710b60d Fixed the merge_default_aces() code to work correctly with inheritance.
Hopefully will fix jcmd bugs :-).
Jeremy.
(This used to be commit 482e6c79ed)
2003-06-23 20:24:08 +00:00
Gerald Carter
f36c96d59c * s/get_dc_name/rpc_dc_name/g (revert a previous change)
* move back to qsort() for sorting IP address in get_dc_list()

* remove dc_name_cache in cm_get_dc_name() since it slowed
  things down more than it helped.  I've made a note of where
  to add in the negative connection cache in the ads code.
  Will come back to that.

* fix rpcclient to use PRINTER_ALL_ACCESS for set printer (instead
  of MAX_ALLOWED)

* only enumerate domain local groups in our domain

* simplify ldap search for seqnum in winbindd's rpc backend
(This used to be commit f8cab8635b)
2003-06-23 19:05:23 +00:00
Gerald Carter
d21358308a wrap group enuemration in brcome/unbecome_root() (bug #110)
(This used to be commit 3918fffc7f)
2003-06-23 18:29:09 +00:00
Gerald Carter
7356d558ff fix typo (bug #170)
(This used to be commit d376b67de9)
2003-06-23 18:27:59 +00:00
Gerald Carter
fb82535d1f fix bug #178; available space in devmode should be int
(This used to be commit 944480b89a)
2003-06-23 17:47:25 +00:00
Andrew Tridgell
fd87564eec lp_security() is a function not an integer
(This used to be commit 71907f32ba)
2003-06-23 06:38:19 +00:00
Tim Potter
ab1ccfc487 Change AC_MSG_ERROR() in krb5.h detection code to AC_MSG_WARN()
until I repair my destroyed development system and check in a proper
fix for this.
(This used to be commit efad5dab52)
2003-06-23 05:32:16 +00:00
Gerald Carter
81d8eefc0d * set domain->last_status = NT_STATUS_SERVER_DISABLED on an ads_connect() failure
* Fix code to use winbind_rpc methods for trusted mixed mode or NT4 domains
  ( does no one ever test this? )
* add in LDAP code to get the sequence number for rpc based seqnum update.
  ( this is needed if the DC is upgraded and samba is not reconfigured
    to use security = ads; it's not pretty but it works (from app_head) )
* fix bug that caused us to enumerate domain local groups in domains
  other than our own
(This used to be commit 14f2cd139a)
2003-06-23 05:10:07 +00:00
Tim Potter
5f1ff72f7d Produce an error if Active Directory support is requested and we don't
have krb5.h

Should fix bug 152.
(This used to be commit 82d3dd757b)
2003-06-23 01:27:17 +00:00
Tim Potter
5779e6d15e Repair indentation in autoconf Kerberos detection code. This should
make it easier to understand/debug.
(This used to be commit 86b6ff134c)
2003-06-23 01:05:31 +00:00
Simo Sorce
f5974dfaae Found out a good number of NT_STATUS_IS_ERR used the wrong way.
As abartlet rememberd me NT_STATUS_IS_ERR != !NT_STATUS_IS_OK

This patch will cure the problem.
Working on this one I found 16 functions where I think NT_STATUS_IS_ERR() is
used correctly, but I'm not 100% sure, coders should check the use of
NT_STATUS_IS_ERR() in samba is ok now.

Simo.
(This used to be commit c501e84d41)
2003-06-22 10:09:52 +00:00
Andrew Bartlett
4830a87845 (fixing bug in my last commit)
This isn't C++ - start your code *after* all the variables are declared...

Andrew Bartlett
(This used to be commit b7760faedc)
2003-06-21 23:35:12 +00:00
Volker Lendecke
cc59bbfdea Fix memory leak. secrets_fetch allocates memory.
Volker
(This used to be commit 2ec8d1ff88)
2003-06-21 14:28:18 +00:00
Andrew Bartlett
668a9af94e This removes the StrCaseCmp() stuff from 'net idmap' and 'net
groupmap'.  The correct way to implement this stuff is via a function
table, as exampled in all the other parts of 'net'.

This also moves the idmap code into a new file.  Volker, is this your
code?  You might want to put your name on it.

Andrew Bartlett
(This used to be commit 477f2d9e39)
2003-06-21 08:35:30 +00:00
Andrew Bartlett
68f1ca6247 This patch fixes some issues with idmap_tdb as raised by bug #181
The idea here is to eliminate the need to *set* the 'HWM' (High Water
Mark) in the tdb.  Instead, each caller wanting to add an item to the
TDB uses the fact that an insert will *fail* if entry already exists.

More importantly, this means that we don't need to know the value of the
idmap uid/gid values when setting arbitrary entries, which can occur on
an smb.conf without such values specified.

Then all we need to do is loop until we get an id that will insert.
This means that the HWM does not need to be accurate, and we can have
IDs allocates safely above the HWM.

Setting the HWM to an arbitrary value was racy in the past - now we
don't even do it.

This patch also adds paranoia in reading the tdb - both the entry, and
it's reverse entry must be present.  This means that we don't need to
'clean up' after an abnormal failure (which would probably fail too),
instead we rely on readers to ignore the half-completed entry.  The way
this is done will allow SIDs to then allocated an ID when things are
normal again.

Andrew Bartlett
(This used to be commit 74709e159c)
2003-06-21 08:31:18 +00:00
Andrew Bartlett
3f5dc14457 Always initialize.
(This used to be commit 75081860af)
2003-06-21 07:54:03 +00:00
Gerald Carter
93bcb9963b merge of the netsamlogon caching code from APPLIANCE_HEAD
This replaces the universal group caching code (was originally
based on that code).  Only applies to the the RPC code.

One comment: domain local groups don't show up in 'getent group'
that's easy to fix.

Code has been tested against 2k domain but doesn't change anything
with respect to NT4 domains.

netsamlogon caching works pretty much like the universal group
caching code did but has had much more testing and puts winbind
mostly back in sync between branches.
(This used to be commit aac01dc7bc)
2003-06-21 04:05:01 +00:00
Andrew Bartlett
f70cc4cdc1 This patch works towards to goal of common code shared between idmap_ldap
and pdb_ldap.

So far, it's just a function rename, so that the next patch can be a very
simple matter of copying functions, without worrying about what changed
in the process.

Also removes the 'static' pointers for the rebind procedures, replacing them
with a linked list of value/key lookups.  (Only needed on older LDAP client
libs)

Andrew Bartlett
(This used to be commit f93167a7e1)
2003-06-21 00:45:03 +00:00
Jeremy Allison
deef8647c7 Fixed sorting algorithm to prevent problems with W2K clients.
Jeremy.
(This used to be commit fa8ca20ed4)
2003-06-20 20:07:13 +00:00
Jim McDonough
480918598b Fix bug #136. Add message about erroneous empty "passdb backend" parameter.
(This used to be commit 897125a9db)
2003-06-20 17:41:04 +00:00
Jim McDonough
187ef2eb2a Fix bug #136: "passdb backend = " caused smbd to segfault.
Instead, spit out an error message.
(This used to be commit 22f083b227)
2003-06-20 17:39:53 +00:00
Steve French
d1fafca608 Fix mount options for ro, dir_mode, file_mode
(This used to be commit 7e7cf0dd98)
2003-06-20 16:41:41 +00:00
Andrew Tridgell
85cc64731c fixed a bug found by volker
when we are traversing a readonly dababase we should not try to
cleanup the pending-delete records
(This used to be commit f327c06108)
2003-06-20 14:48:36 +00:00
Tim Potter
d7dfff92c1 The default action for AC_CHECK_LIB is to add the library to $LIBS so
this doesn't need to be done explicitly in the Kerberos checks.

Also there was a duplicate AC_CHECK_LIB(resolv, dn_expand) which is done
early on in the configure process.
(This used to be commit fa66e2e1e1)
2003-06-20 06:41:56 +00:00
Tim Potter
5e37c04c03 Back out some of the changes to nsstest. I've kept the NULL pointer
dereference bugfixes but left out the gethostbyname (wins) tests pending
a nicer way to integrate it.
(This used to be commit a7e67aaffe)
2003-06-20 02:31:15 +00:00
Jeremy Allison
be61fcef60 Missed initial param, typo.
Jeremy.
(This used to be commit 036a551b10)
2003-06-20 01:42:13 +00:00
Jeremy Allison
9251afe35b Mapping of Windows ACL inheritance and protected bits onto extended attributes
if available. Adds new parameter "map acl inheritance" (docs coming soon)
off by default. Allows W2K acl inheritance dialogs to work correctly on
POSIX acls.
Jeremy.
(This used to be commit a83595e80a)
2003-06-20 01:12:20 +00:00
Jelmer Vernooij
6605fec5dc Add installmodules to install
(This used to be commit 33e8dd8843)
2003-06-18 15:54:21 +00:00
Simo Sorce
75a5c0b307 Ok, this patch removes the privilege stuff we had in, unused, for some time.
The code was nice, but put in the wrong place (group mapping) and not
supported by most of the code, thus useless.

We will put back most of the code when our infrastructure will be changed
so that privileges actually really make sense to be set.

This is a first patch of a set to enhance all our mapping code cleaness and
stability towards a sane next beta for 3.0 code base

Simo.
(This used to be commit e341e7c49f)
2003-06-18 15:24:10 +00:00
Jim McDonough
c364128212 Remove the -A option of wbinfo, leaving only the long version,
--set-auth-user.  There was enough confusion, as in bug #158,
when a user accidentally typed -A instead of -a, and would get themselves
stuck with a non-working winbind.

I've made the changes to docs/docbook/manpages/wbinfo.xml, but I'm not
sure what to do beyond that.  Is checking that in enough?
(This used to be commit 70fe85e469)
2003-06-18 14:20:23 +00:00
Volker Lendecke
4a33bc9c73 There's nothing particularly secret in idmap.tdb, so create it with
0644 as the other databases.

Volker
(This used to be commit 5849053930)
2003-06-18 13:28:37 +00:00
Volker Lendecke
e6fd597fce And some more memory leaks in mapping.c and pdb_tdb.c. tdb_nextkey
mallocs its key, so we should free it after use.

Volker
(This used to be commit 9750799ba2)
2003-06-18 12:00:52 +00:00
Volker Lendecke
e48ebd09ff Better panic cleanly than segfault later when no sid can be found and created.
Everybody who calls get_global_sam_sid expects this to return non-NULL, and
there are way too many places where this is called.

Volker
(This used to be commit 2dfa896e6f)
2003-06-18 08:42:04 +00:00
Volker Lendecke
1eb6447727 And more other memory leaks. One new (idmap) and one ancient (groupdb).
Volker
(This used to be commit 2392f460ae)
2003-06-17 12:31:02 +00:00
Volker Lendecke
9606397ab1 Fix a memory leak in pdb_tdb.c.
Simo, I remember you complaining about a memleak there, could it be
this one, or did you resolve it at that time?

Volker
(This used to be commit c660595ded)
2003-06-17 12:03:48 +00:00
Jelmer Vernooij
c0e24984f0 Make static (patch from metze)
(This used to be commit 908b16cc2a)
2003-06-17 10:48:06 +00:00
Jelmer Vernooij
b9bf3252bf Fix building idmap_winbind as shared module
(This used to be commit 2556037796)
2003-06-17 10:41:08 +00:00