1
0
mirror of https://github.com/samba-team/samba.git synced 2025-11-30 20:23:49 +03:00
Commit Graph

25 Commits

Author SHA1 Message Date
Volker Lendecke
407136abdf current_user is not used in vfs_aixacl2.c 2008-06-19 15:53:43 +02:00
Volker Lendecke
90d7bc6da3 AIX build fixes from William Jojo -- thanks
(cherry picked from commit cb91a47576)
2008-06-12 13:17:44 +02:00
Jeremy Allison
f487f742cb Yay ! Remove a VFS entry. Removed the set_nt_acl() call,
this can only be done via fset_nt_acl() using an open
file/directory handle. I'd like to do the same with
get_nt_acl() but am concerned about efficiency
problems with "hide unreadable/hide unwritable" when
doing a directory listing (this would mean opening
every file in the dir on list).
Moving closer to rationalizing the ACL model and
maybe moving the POSIX calls into a posix_acl VFS
module rather than having them as first class citizens
of the VFS.
Jeremy.
2008-05-08 18:09:07 -07:00
Michael Adam
9296e93588 Remove redundant parameter fd from SMB_VFS_SYS_ACL_SET_FD().
Michael
2008-01-08 01:54:19 +01:00
Michael Adam
42663e8736 Remove redundant parameter fd from SMB_VFS_SYS_ACL_GET_FD().
Michael
2008-01-07 23:54:07 +01:00
Michael Adam
4f2d139a18 Remove superfluous parameter fd from SMB_VFS_FSET_NT_ACL().
Michael
2008-01-06 23:08:00 +01:00
Michael Adam
c0c7c1223d Remove superfluous fd parameter from SMB_VFS_FGET_NT_ACL().
Michael
2008-01-06 23:07:59 +01:00
Michael Adam
36e2a814ba Prepare the aix2 acl module for the api change in get_nt_acl().
This makes both of aixjfs2_[f]get_nt_acl() more specific,
eliminating the need for aixjfs2_get_nt_acl_common().

Michael
2007-12-19 23:08:00 +01:00
Michael Adam
40a1438e17 Change aixjfs2_get_nfs4_acl() to take file name instead of fsp.
In preparation of the api change in api change in get_nt_acl().

Michael
2007-12-19 23:08:00 +01:00
Michael Adam
7afeb1c6cb Split smb_get_nt_acl_nfs4 into two (f- and non-f-variant).
This is the next step in preparation of a get_nt_acl prototype change.

Michael
2007-12-19 23:07:57 +01:00
Michael Adam
50c82cc145 Split get_nt_acl() into two functions: fsp- and non-fsp variant.
Replace smbd/posix_acls.c:get_nt_acl() by two funcions:
posix_get_nt_acl() and posix_fget_nt_acl(). The first
takes a connection struct and a file name instead of a
files_struct pointer. This is in preparation of changing
the vfs api for SMB_VFS_GET_NT_ACL.

Michael
2007-12-19 23:07:56 +01:00
Volker Lendecke
dcbe1bf942 Make [f]get_nt_acl return NTSTATUS 2007-11-13 15:47:01 +01:00
Jeremy Allison
f35a266b3c RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
2007-10-18 17:40:25 -07:00
Volker Lendecke
6585ea2cb7 r24809: Consolidate the use of temporary talloc contexts.
This adds the two functions talloc_stackframe() and talloc_tos().

 * When a new talloc stackframe is allocated with talloc_stackframe(), then
 * the TALLOC_CTX returned with talloc_tos() is reset to that new
 * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
 * happens: The previous talloc_tos() is restored.
 *
 * This API is designed to be robust in the sense that if someone forgets to
 * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
 * resets the talloc_tos().

The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.

The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.

This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)

So, never do a

tmp_ctx = talloc_init("foo");

anymore, instead, use

tmp_ctx = talloc_stackframe()

:-)

Volker
2007-10-10 12:30:24 -05:00
Andrew Tridgell
87c91e4362 r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
Jeremy Allison
407e6e695b r23779: Change from v2 or later to v3 or later.
Jeremy.
2007-10-10 12:28:20 -05:00
Jeremy Allison
fc6899a550 r23620: Convert set_nt_acl to return NTSTATUS. Also fix the chown
return to correctly return NT_STATUS_INVALID_OWNER if it
should be disallowed. Matches better what W2K3R3 does.

NFSv4 ACL module owners, please examine these changes.

Jeremy.
2007-10-10 12:23:37 -05:00
Jeremy Allison
f6fa3080fe r22542: Move over to using the _strict varients of the talloc
calls. No functional changes. Looks bigger than it is :-).
Jeremy.
2007-10-10 12:19:44 -05:00
Herb Lewis
c60687db11 r20261: merge 20260 from samba_3_0_24
clean up a bunch of no previous prototype warnings
2007-10-10 12:16:37 -05:00
Jim McDonough
fa656ce34e r19826: Fix typo 2007-10-10 12:16:00 -05:00
Jeremy Allison
a52fa21895 r18603: Add in the NFSv4 ACL mapping code from IBM.
Sorry for the delay :-).
Jeremy.
2007-10-10 11:51:59 -05:00
Jeremy Allison
330899ec30 r17367: Reverting the ab code. Note I'm not saying this
code is wrong or bad or anything, just that it
needs to be discussed & reviewed on the samba-technical
list before we add a platform-specific NFSv4 mapping.
That way lies a lot of future pain :-).
Jeremy.
2007-10-10 11:38:29 -05:00
Alexander Bokovoy
c085355c32 r17358: Re-add JFS2 NFS4 ACLs support, move readme for it into AIX-specific examples directory. 2007-10-10 11:38:28 -05:00
Alexander Bokovoy
5b1db01514 r17354: Revert -r 17353 per Volker request while gpfs compatibility layer code will be released. 2007-10-10 11:38:27 -05:00
Alexander Bokovoy
72312cb2e2 r17353: Add support for JFS2 NFS4/AIXC and GPFS acls based on NFSv4 ACLs. 2007-10-10 11:38:27 -05:00