sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-06 13:18:07 +03:00
Code
82,983 Commits 60 Branches 1,144 Tags 452 MiB
1fa730deba
Commit Graph

790 Commits

Author SHA1 Message Date
Stefan Metzmacher
1a0ce02a23 smbXcli: also notify chained requests about broken connections 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
4d8e151779 smbXcli: simplify smb1cli_req_chain_submit() 
We should hang everything on the first request in the chain,
as that's the one that gets added to the pending array.

metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
e2912fa853 smbXcli: remove unused smb1cli_have_andx_command() 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
fee3a0a657 smbXcli: reorder smb1cli_conn_dispatch_incoming() to avoid too much nesting 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
0f194e35a6 smbXcli: rework smb1cli_req_recv() to expose an iov with 3 elements 
Each smb1cli_req has 3 iov elements
[SMB HDR, SMB Parameter Block, SMB Data Block].

The 'inbuf' is still exposed if the caller requires it
(until we fix all legacy callers).

The can now pass an array of expected [status,wct] combinations,
instead of just one expected min_wct.

metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
ce224f4d25 smbXcli: use smb1cli_inbuf_parse_chain() and remember more details per chain response 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
7c5651c3f6 smbXcli: add smb1cli_inbuf_parse_chain() 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
94cb738dd4 smbXcli: pass hdr to smb1cli_pull_raw_error() 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
4529395d3c smbXcli: add state->smb1.recv_{cmd,status,iov} 
In the following commits we will need to remember a few more things.

metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
5e7cf194d2 smbXcli: split out a smb1cli_req_flags() function 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
2a570e6305 smbXcli: set message id to UINT64_MAX for BREAK in smb2cli_req_create() 
This way the caller can register an oplock handler.

Note that smb2cli_req_compound_submit() will overwrite this
if a request is send over the wire.

metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
349977e1a0 s3:smb2cli: replace smb2cli_base.c code with the more generic smbXcli_base.c code 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
84806eceb2 smbXcli: rework smb2cli_req to smbXcli_conn/smbXcli_req 
metze
 2011-11-24 19:02:30 +01:00
Stefan Metzmacher
21b5f1c185 libcli/smb: copy smb2cli_req_* code to smbXcli_base.c 
metze
 2011-11-24 19:02:29 +01:00
Stefan Metzmacher
26892a9783 smbXcli: rework smbXcli_base.c to use smbXcli_conn/smbXcli_req 
This splits the low level smb code from 'struct cli_state'
and makes it much more generic and useful for testing.

metze
 2011-11-24 19:02:29 +01:00
Stefan Metzmacher
012dee3803 smbXcli: cp source3/libsmb/async_smb.c libcli/smb/smbXcli_base.c 
metze
 2011-11-24 19:02:29 +01:00
Christian Ambach
53ad886f75 security: add local authority well-known SIDs 
add the S-1-2 well-known SID family

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Nov 24 19:01:08 CET 2011 on sn-devel-104
 2011-11-24 19:01:08 +01:00
Matthias Dieter Wallnöfer
4cafcf0e6b libcli/cldap/cldap.c - remove outdated comment 
Reviewed-by: metze

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 10 20:32:08 CET 2011 on sn-devel-104
 2011-11-10 20:32:08 +01:00
Stefan Metzmacher
17f1a97a61 libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593) 
After a calling any wrapper of tevent_req_notify_callback(),
e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(),
a function has to return immediately otherwise it is very likely to
crash, unless in calls tevent_req_defer_callback() before.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 16:31:59 CET 2011 on sn-devel-104
 2011-11-10 16:31:59 +01:00
Günther Deschner
6e67073900 waf: convert NDR_NBT into shared library. 
Guenther
 2011-11-03 18:35:09 +01:00
Günther Deschner
768b42f334 nbt: move netlogon_samlogon_response into librpc/ndr/ndr_nbt.h. 
Guenther
 2011-11-03 18:35:08 +01:00
Günther Deschner
0de2bf97ff nbt: move nbt_string ndr functions to ndr/ndr_nbt.c helper. 
Guenther
 2011-11-03 18:35:08 +01:00
Günther Deschner
72879f491f nbt: merge in LIBCLI_NDR_NETLOGON helper into NDR_NBT. 
Guenther
 2011-11-03 18:35:08 +01:00
Günther Deschner
2417ea4923 librpc: remove nbt dependency to svcctl. 
Guenther
 2011-11-03 18:35:08 +01:00
Günther Deschner
2ecd50116c librpc: remove nbt dependency to samr. 
Guenther
 2011-11-03 18:35:08 +01:00
Stefan Metzmacher
22344f3e03 libcli/smb: use the same values for SMB_SIGNING_* as the source3 code uses 
The source3 code currently uses:
 #define Undefined (-1)
 #define False false
 #define True true
 #define Required (3)

In order to make the rewrite easier we should match the values.

metze
 2011-11-03 16:55:12 +01:00
Stefan Metzmacher
812c3dc80a libcli/smb: remove unused SMB_SIGNING_SUPPORTED 
metze
 2011-11-03 16:55:12 +01:00
Stefan Metzmacher
a4ac06a4be libcli/smb: add SMB_SIGNING_IF_REQUIRED as replacement for SMB_SIGNING_SUPPORTED 
metze
 2011-11-03 16:55:12 +01:00
Stefan Metzmacher
feace943d5 libcli/smb: SMB_SIGNING_AUTO is no longer used 
metze
 2011-11-03 16:55:12 +01:00
Stefan Metzmacher
18205ac7ad libcli/smb: add SMB_SIGNING_DEFAULT 
metze
 2011-11-03 16:55:11 +01:00
Stefan Metzmacher
5f520e7717 libcli/smb: add smb_buffer_oob() helper 
A copy of trans_oob().

metze
 2011-10-26 15:33:30 +02:00
Stefan Metzmacher
0d9bd56afb libcli/smb: merge NEGOTIATE_SECURITY_* flags to smb_constants.h 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 11:27:12 CEST 2011 on sn-devel-104
 2011-10-26 11:27:12 +02:00
Stefan Metzmacher
1fa7300037 libcli/smb: move smb_signing.[ch] to the toplevel 
metze
 2011-10-25 01:47:21 +02:00
Stefan Metzmacher
d76758ab9f libcli/smb: remove unused includes from read_smb.h 
metze
 2011-10-25 00:24:07 +02:00
Stefan Metzmacher
f3c25bc6a5 libcli/smb: merge LOCKING_ANDX_* and OPLOCK_* defines to smb_constants.h 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 17:46:47 CEST 2011 on sn-devel-104
 2011-10-24 17:46:47 +02:00
Stefan Metzmacher
ec7cc700b2 libcli/smb: move more defines to smb_constants.h 
metze
 2011-10-24 16:10:36 +02:00
Stefan Metzmacher
6fef69562b libcli/smb: move CAP_* defines to smb_constants.h 
metze
 2011-10-24 16:10:36 +02:00
Andrew Bartlett
59e838a1c4 libcli/smb Move smb_seal.h include to files that use it. 
This is required because at the moment, smb_seal.h includes references to gssapi structures
and this causes issues with header dependencies on subsystems that otherwise do not need
a gssapi dependency.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-10-24 13:56:52 +02:00
Stefan Metzmacher
7ebd4337ac libcli/smb: move source3/libsmb/read_smb.* to the toplevel 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 24 10:18:06 CEST 2011 on sn-devel-104
 2011-10-24 10:18:06 +02:00
Matthieu Patou
4d2d33ee09 libcli-cldap: avoid the case local == remote == NULL 2011-10-21 22:29:09 +02:00
Stefan Metzmacher
66530e9149 libcli/cldap: make sure the local and remote address family matches 
metze

Signed-off-by: Matthieu Patou <mat@matws.net>
 2011-10-21 22:29:09 +02:00
Günther Deschner
80741d98d8 libcli: remove unneeded com_err.h and fix the build here. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct 21 15:52:36 CEST 2011 on sn-devel-104
 2011-10-21 15:52:36 +02:00
Stefan Metzmacher
75d146d3ed libcli/smb: move smb_seal.c to the toplevel 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Oct 21 10:22:39 CEST 2011 on sn-devel-104
 2011-10-21 10:22:39 +02:00
Stefan Metzmacher
e03b312b12 libcli/smb: add smb_setlen_[nbt|tcp] macros 
metze
 2011-10-21 08:42:59 +02:00
Stefan Metzmacher
32938ce60d libcli/smb: move some common defines to smb_constants.h 
metze
 2011-10-21 08:42:59 +02:00
Amitay Isaacs
51855de633 werror: Added missing DNS error codes 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-10-20 05:53:05 +02:00
Stefan Metzmacher
cd22763440 libcli/smb: add smb_[set]len_[nbt|tcp]() macros 
metze
 2011-10-19 15:44:29 +02:00
David Disseldorp
b711de287f libcli: Move smb2 fsctl fn defs into common code 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-10-19 15:44:29 +02:00
David Disseldorp
d5ea379428 s3: Remove duplicate fsctl function definitions 
Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-10-19 15:44:29 +02:00
David Disseldorp
281fc93c6b libcli: move ioctl function field defs to smb_constants 
Currently there are a lot of duplicate ioctl function field definitions
between source3 and source4.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-10-19 15:44:29 +02:00
Andrew Bartlett
0c6e4adcb2 ntlmssp: Move ntlmssp code to auth/ntlmssp 
This brings in the code from both libcli/auth and
source4/auth/ntlmssp.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
 2011-10-18 13:13:31 +11:00
Andrew Bartlett
01c934c81e lib/util: Add back control of mmap and hash size in tdb for top level build 
This passes down a struct loadparm_context to allow these
parameters to be checked.  This may be s3 or s4 context, allowing the
#if _SAMBA_BUILD_ macro to go away safely.

Andrew Bartlett
 2011-10-13 14:06:07 +02:00
Andrew Bartlett
5603dab647 libcli/auth: Provide a struct loadparm_context to schannel calls 
This will allow us to pass this down to the tdb_wrap layer.

Andrew Bartlett
 2011-10-13 14:06:07 +02:00
Andrew Bartlett
26de383c42 libcli/smb Move CSC_POLICY_* definition to smb_constants.h 
This removes the duplicate definition between smb.h and lib/param/loadparm.c
which in turn allows this file to be compiled with the s3 includes.h

Andrew Bartlett
 2011-10-11 13:41:34 +11:00
Andrew Bartlett
b21b012756 lib/param move source4 param code to the top level 
This is done so that the lpcfg_ functions are available across the whole
build, either with the struct loadparm_context loaded from an smb.conf directly
or as a wrapper around the source3 param code.

This is not the final, merged loadparm, but simply one step to make
it easier to solve other problems while we make our slow progress
on this difficult problem.

Andrew Bartlett
 2011-10-11 13:41:34 +11:00
Stefan Metzmacher
b787b6e1bd libcli/cldap: don't pass tevent_context to cldap_socket_init() 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 10 23:23:07 CEST 2011 on sn-devel-104
 2011-10-10 23:23:07 +02:00
Stefan Metzmacher
af24591a20 libcli/cldap: make use of explicit tevent_contexts 
metze
 2011-10-10 21:50:26 +02:00
Stefan Metzmacher
5a7a1b35be libcli/cldap: pass tevent_context to cldap_search_send() 
metze
 2011-10-10 21:50:26 +02:00
Stefan Metzmacher
2cd76b0931 libcli/cldap: pass tevent_context to cldap_netlogon_send() 
metze
 2011-10-10 21:50:26 +02:00
Stefan Metzmacher
3ed85d7c69 libcli/cldap: pass tevent_context to cldap_set_incoming_handler() 
metze
 2011-10-10 21:50:26 +02:00
Andrew Bartlett
36b2227eca ldb: use ldb directly rather than via a copy 
This avoids needing to manually sync the two files, which due to the
top level build must be API compatible at all times anyway.

The most important recent change was:

commit e3b76bd620
Author: Andrew Tridgell <tridge@samba.org>
Date:   Thu Jul 28 15:51:31 2011 +1000

    ldb: fixed a search expression parse bug

However, as we always control the search expression in the callers to
this code, no backport to other releases is required.

Andrew Bartlett
 2011-10-07 17:45:20 +11:00
Andrew Bartlett
055f017b36 build: Reduce build systems to just top level waf and autoconf 
The s3-waf build system is a key component of the top level build, but
with this commit is is no longer available directly.  This reduces the
number of build system combinations in master as we prepare for the
Samba 4.0 release.

Andrew Bartlett
 2011-10-07 17:42:03 +11:00
Jelmer Vernooij
3358239a57 smb_unix_ext.h: Protect against multiple inclusion. 2011-09-28 12:05:54 +02:00
Jelmer Vernooij
2660a465c3 Install headers included by smb_common.h. 2011-09-28 11:32:36 +02:00
Kai Blin
df88e66250 errormap: Add unix_to_werror() function 
While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.

Signed-off-by: Kai Blin <kai@samba.org>
 2011-09-28 02:02:35 +02:00
Kai Blin
8eb80a9d83 libcli/smb: Get rid of set but unused variable 2011-09-24 21:46:05 -07:00
Jeremy Allison
e99a18cdc0 Remove extraneous debug code. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Sep 22 00:22:12 CEST 2011 on sn-devel-104
 2011-09-22 00:22:12 +02:00
Jeremy Allison
d89bbe9b0a Fix bug #8474 - SMB2 create doesn't cope with an Apple client using NULL blob in create 
Cope with zero length data_offset and data_length values.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Sep 21 22:12:40 CEST 2011 on sn-devel-104
 2011-09-21 22:12:40 +02:00
Stefan Metzmacher
62d4a317f9 libcli/smb: add SMB2_DIALECT_REVISION_222 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Sep 16 19:51:47 CEST 2011 on sn-devel-104
 2011-09-16 19:51:47 +02:00
Stefan Metzmacher
f6217aa7d1 libcli/smb: add PROTOCOL_SMB2_22 
metze
 2011-09-16 16:44:14 +02:00
Stefan Metzmacher
d727fcc867 libcli/auth: add some const to SMBNTencrypt_hash() and SMBNTencrypt() 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Sep 14 19:49:24 CEST 2011 on sn-devel-104
 2011-09-14 19:49:24 +02:00
Stefan Metzmacher
258ffddf1c libcli/smb: s/FLAGS2_UNKNOWN_BIT4/FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Sep 10 00:34:50 CEST 2011 on sn-devel-104
 2011-09-10 00:34:50 +02:00
Stefan Metzmacher
dd3c1b740c smb2_constants: add SMB2_WRITEFLAG_WRITE_THROUGH define 
metze
 2011-09-06 15:28:00 +02:00
Stefan Metzmacher
d7eb4a4c85 libcli/smb: add PROTOCOL_SMB2_10 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Sep  5 14:57:06 CEST 2011 on sn-devel-104
 2011-09-05 14:57:06 +02:00
Stefan Metzmacher
7fd075f91b libcli/smb: remove PROTOCOL_SMB2 alias of PROTOCOL_SMB2_02 
metze
 2011-09-05 13:25:01 +02:00
Stefan Metzmacher
0ed0a66956 libcli/smb: move smb2_signing.c to the toplevel 
metze
 2011-09-05 13:17:32 +02:00
Stefan Metzmacher
480a031c5b smb2_constants: add SMB2_HDR_CREDIT_CHARGE 
SMB2_HDR_EPOCH was never used and SMB 2.10 uses it as
SMB2_HDR_CREDIT_CHARGE.

We keep SMB2_HDR_EPOCH as alias for now, until all callers
are fixed.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Aug 30 23:49:56 CEST 2011 on sn-devel-104
 2011-08-30 23:49:56 +02:00
Michael Adam
a3538b92d3 werror: remove duplicate definition of WERR_INVALID_OWNER 
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Aug 26 01:23:52 CEST 2011 on sn-devel-104
 2011-08-26 01:23:52 +02:00
Jelmer Vernooij
97afeaceda smb_common: Fix include paths. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Aug 18 16:54:01 CEST 2011 on sn-devel-104
 2011-08-18 16:54:01 +02:00
Jelmer Vernooij
f0d15e8ffa smb_common: Install some more headers. 2011-08-18 13:43:42 +02:00
Volker Lendecke
fe66abd6ff Adapt del_sid_from_array to Samba coding style 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Aug 17 16:46:24 CEST 2011 on sn-devel-104
 2011-08-17 16:46:24 +02:00
Volker Lendecke
e5a6d4cdb6 Fix a typo 2011-08-17 14:11:03 +02:00
Volker Lendecke
28b237b2cc Remove unused "sid_equal" 2011-08-17 12:30:08 +02:00
Volker Lendecke
8fd5e0ff2e Replace calls to sid_equal with calls to dom_sid_equal 2011-08-17 12:30:08 +02:00
Jelmer Vernooij
f8ec7f6cb1 pytalloc: Use consistent prefix for functions, add ABI file. 2011-08-10 15:36:21 +02:00
Andrew Bartlett
af5f494bd2 build: provide tevent-util as a public library 
This is needed so that OpenChange can get at _tevent_req_nterr(), which is referenced
by generated PIDL output.

Andrew Bartlett
 2011-08-08 13:34:06 +02:00
Andrew Bartlett
fec25c3a62 ntlmssp: Add ntlmssp_blob_matches_magic() 
This avoids having the same check in 3 different parts of the code

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Aug  3 12:45:04 CEST 2011 on sn-devel-104
 2011-08-03 12:45:04 +02:00
Andrew Bartlett
d3fe48ba48 gensec: Remove mem_ctx from calls that do not return memory 
Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-08-03 18:48:01 +10:00
Jelmer Vernooij
23cbfef542 cli_smb_common: Lowercase name. 2011-07-26 13:31:08 +02:00
Jelmer Vernooij
08785dd73d cli_cldap: Lowercase name. 2011-07-26 13:31:08 +02:00
Stefan Metzmacher
82413e829e libcli/security: add some const to marshall_sec_desc[_buf]() 
metze
 2011-07-23 09:55:54 +02:00
Stefan Metzmacher
86fb61a4aa libcli/smb: add NBSS message types 
metze
 2011-07-12 09:44:04 +02:00
Stefan Metzmacher
cc2a5d23ae libcli/smb: add PROTOCOL_SMB2_02 constant 
metze
 2011-07-12 08:17:59 +02:00
Björn Baumbach
6db705d6fc libcli: remove duplicate of #define NT_STATUS_NO_SUCH_JOB 
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jul  7 20:29:13 CEST 2011 on sn-devel-104
 2011-07-07 20:29:13 +02:00
Andrew Bartlett
7891848357 libcli/smb move FILE_TYPE constants in common 
This allows us to remove another _SAMBA_BUILD_ conditional

Andrew Bartlett
 2011-07-06 05:32:59 +02:00
Andrew Bartlett
6543987139 libcli/smb move enum protocol_types to a common header 2011-07-06 05:32:51 +02:00
Andrew Bartlett
8b99c2063a build: Add missing depencency on NDR_NBT 2011-07-05 12:41:05 +10:00
Volker Lendecke
61d0afeab3 s3: Add STATUS_STOPPED_ON_SYMLINK error code 2011-07-03 11:31:28 +02:00
Volker Lendecke
21b30d52f5 Add NT_STATUS_IO_REPARSE_TAG_NOT_HANDLED 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jun 24 22:36:50 CEST 2011 on sn-devel-104
 2011-06-24 22:36:50 +02:00
Volker Lendecke
61ad606016 Add NT_STATUS_IO_REPARSE_DATA_INVALID 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jun 24 17:58:00 CEST 2011 on sn-devel-104
 2011-06-24 17:58:00 +02:00
Andrew Bartlett
5db74b9607 lib/util Remove samba-util-common! 
All of this code is now in common, so we don't need the second
'-common' library any more!

Andrew Bartlett
 2011-06-21 09:36:22 +10:00
Volker Lendecke
f0ff6f390a Use tevent_req_oom 
This fixes a few Coverity errors
 2011-06-20 12:33:24 +02:00
Rusty Russell
58f7cda1bc tdb_compat: use tdb_errorstr_compat() 
Since TDB2 functions return the error directly, tdb_errorstr() taken an
error code, not the tdb as it does in TDB1.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2011-06-20 11:18:35 +02:00
Rusty Russell
0e4c358e27 tdb_compat.h: divert every tdb build and includes to tdb_compat 
We change all the headers and wscript files to use tdb_compat; this
means we have one place to decide whether to use TDB1 or TDB2.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2011-06-20 11:18:34 +02:00
Andrew Bartlett
a1f04e8abc libcli/util Rename common map_nt_error_from_unix to avoid duplicate symbol 
The two error tables need to be combined, but for now seperate the names.

(As the common parts of the tree now use the _common function,
errmap_unix.c must be included in the s3 autoconf build).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jun 20 08:12:03 CEST 2011 on sn-devel-104
 2011-06-20 08:12:03 +02:00
Andrew Bartlett
018f4a5889 libcli/util Bring samba4 unix -> nt_status code in common. 
Due to library link orders, this is already the function that is being
used.  However we still need to sort out the duplicate symbol issues,
probably by renaming things.

Andrew Bartlett
 2011-06-20 14:36:06 +10:00
Volker Lendecke
36e674c134 s3: Allow NULL sd_size in make_sec_desc 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jun 18 22:26:15 CEST 2011 on sn-devel-104
 2011-06-18 22:26:15 +02:00
Andrew Tridgell
b341979adb util: moved nt_errstr() into common code 
this brings nt_errstr() into common code, using the new
talloc_stackframe_exists() to ensure that we only allocate an error
string using talloc_tos() if a talloc stackframe does currently
exists. This makes it safe to use in external libraries

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-06-17 17:08:59 +10:00
Andrew Bartlett
1233ba7bf3 libclu/util: Move get_friendly_nt_error_msg() in common. 
Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-06-17 17:08:59 +10:00
Günther Deschner
faf73c72af libcli/smbreadline/smbreadline.h: fix licence/copyright 
Guenther
 2011-06-10 15:11:43 +02:00
Günther Deschner
a49c1b7019 libcli/security/secdesc.h: fix licence/copyright 
Guenther
 2011-06-10 15:11:40 +02:00
Günther Deschner
d41519f99e libcli/nbt/nbt_proto.h: fix licence/copyright 
Guenther
 2011-06-10 15:11:37 +02:00
Günther Deschner
218273841c libcli/ldap/ldap_ndr.h: fix licence/copyright 
Guenther
 2011-06-10 15:11:34 +02:00
Günther Deschner
f04b673aba libcli/auth/msrpc_parse.h: fix licence/copyright 
Guenther
 2011-06-10 15:11:30 +02:00
Andrew Bartlett
6bf88222cc libcli/util Remove prototype for ntstatus_dos_equal() 
This was removed recently.
 2011-06-06 15:02:38 +10:00
Andrew Tridgell
40dc94a53f s4-ipv6: update callers to load_interface_list() 2011-06-06 12:26:10 +10:00
Rusty Russell
c29069e079 libcli/cldap/cldap.c: don't hand huge values to tevent_timeval_add usecs 
state->request.delay is two million here, resulting in an invalid timeval.
Since tevent doesn't have a convenient wrapper to add arbitrary usecs,
do the arithmetic here (it's the sole caller of this function).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2011-06-01 10:38:47 +02:00
Volker Lendecke
b9a727c5f1 Tiny simplification to dom_sid_string_buf 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 31 23:16:31 CEST 2011 on sn-devel-104
 2011-05-31 23:16:31 +02:00
Andrew Bartlett
c004a932c4 libcli/util Remove ntstatus_check_dos_mapping 
This has been set to true since the global loadparm was removed in
2008, and removes an #ifdef SAMBA_BUILD == 4

Andrew Bartlett
 2011-05-31 15:10:20 +10:00
Andrew Bartlett
381423b1bd libcli/security: move secdesc.c to the top level libcli/security 
This code does not rely on lp_ or other source3 only functions, so can
be part of the common library.

Andrew Bartlett
 2011-05-31 00:32:07 +02:00
Andrew Bartlett
8d7be8af79 build: Make util_reg subsystem in libcli/registry a library 2011-05-18 16:12:08 +02:00
Andrew Bartlett
2fc342c20a waf-build: Add more libraries to avoid duplicate symbols 
The new source of duplicates is calling libnetapi from inside smbtorture.

Andrew Bartlett
 2011-05-18 16:12:07 +02:00
Günther Deschner
18d3b85c40 libcli/auth/krb5_wrap: correctly use discard_const(). 
Jeremy, please check.

Guenther
 2011-05-13 00:11:41 +02:00
Michael Adam
cd1d75c7a4 libcli/auth/smbencrypt: in E_deshash, use talloc_stackframe instead of "#if _SAMBA_BUILD_ == 3" and talloc_tos() 
talloc_stackframe() is used in other shared components already,
and if the stack is a talloc_pool, then in most cases, it should
also not be more expensive than directly using talloc_tos().

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 12 12:52:02 CEST 2011 on sn-devel-104
 2011-05-12 12:52:02 +02:00
Michael Adam
75f289d30e libcli/auth: fix "no talloc stackframe around" message from the samba4.blackbox.kinit test 
create_kerberos_key_from_string_direct() used talloc_tos() directly.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
 2011-05-10 21:59:38 +02:00
Andrew Bartlett
22cb631b4f s4-interfaces Rename interfaces code so not to conflict with source3/ 
The iface_count, iface_n_bcast, and load_interfaces functions
conflicted with functions of the same name in source3, so the source4
functions were renamed.  Hopefully we can actually wrap one around the
other in future.

Andrew Bartlett
 2011-05-08 12:57:04 +02:00
Günther Deschner
03b9a9938b libcli/security: fix build warning, cr_descr_log_acl() is not used currently. 
Guenther
 2011-05-06 10:48:11 +02:00
Andrew Bartlett
e3b858496f libcli/smb Move cifs posix helper functions and headers in common 
unix_perms_to_wire() was a duplicate symbol in the top level build.

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Andrew Bartlett
cad704e836 errors: Remove unused unix_to_werror() 2011-05-06 07:51:24 +02:00
Andrew Bartlett
db74cad1c6 libcli/util Move NTSTATUS table to the top level 2011-05-06 07:51:24 +02:00
Andrew Bartlett
344eb08ee4 nterr: Add mem_ctx for return string from get_nt_error_c_code() 
It is clearer to avoid the implicit return on talloc_tos()

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Andrew Bartlett
f1ec28827f libcli/util Merge ntstatus_to_dos() ntstatus_to_werror() to the top level 
This takes the Samba4 version, with the NT_STATUS_IS_DOS() check.
This will be used in smbd/error.c shortly.

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Andrew Bartlett
1475013963 lib/util Move source3 tdb_wrap_open() into the common code. 
This #if _SAMBA_BUILD == 3 is very unfortunate, as it means that in
the top level build, these options are not available for these
databases.  However, having two different tdb_wrap lists is a worse
fate, so this will do for now.

Andrew Bartlett
 2011-05-06 07:51:24 +02:00
Jeremy Allison
7d6ebe0de7 More const fixes. Remove CONST_DISCARD. 2011-05-06 01:44:07 +02:00
Jeremy Allison
df023b8657 Tidy up some missing checks for NULL in strlcpy. 2011-05-04 12:12:15 -07:00
Jeremy Allison
017e0c8d95 Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1. 2011-05-04 12:12:13 -07:00
Andrew Bartlett
7261a9b9f7 s4-libcli Remove resolve_name() as it conflicts with Samba3. 
This was just a wrapper around resolve_name_ex(), so just call that
instead.

Andrew Bartlett
 2011-05-03 07:37:07 +02:00
Günther Deschner
89ceb48978 libcli/named_pipe_auth: add forward declaration in npa_tstream.h. 
Guenther
 2011-05-02 15:03:43 +02:00
Stefan Metzmacher
aae1f86952 libcli/util/ntstatus: NO_S4U_PROT_SUPPORT and CROSSREALM_DELEGATION_FAILURE 
metze
 2011-05-02 13:58:22 +02:00
Andrew Bartlett
f96793142d build: put doserr.c into it's own subsystem, so it's no longer a duplicate 
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Apr 29 10:00:32 CEST 2011 on sn-devel-104
 2011-04-29 10:00:32 +02:00
Andrew Bartlett
6021af4fd3 libcli/smb Move attrib_string in common 2011-04-29 16:38:14 +10:00
Andrew Bartlett
9f75b7cbb3 libcli/smb Move FILE_ATTRIBUTE defines to the top level 2011-04-29 16:38:12 +10:00
Andrew Bartlett
f0ce322c77 auth/kerberos Move all the PAC handling functions to auth/kerberos 2011-04-27 11:56:48 +10:00
Andrew Bartlett
6ec4306f8c auth/kerberos: Create common helper to get the verified PAC from GSSAPI 
This only works for Heimdal and MIT Krb5 1.8, other versions will get
an ACCESS_DEINED error.

We no longer manually verify any details of the PAC in Samba for
GSSAPI logins, as we never had the information to do it properly, and
it is better to have the GSSAPI library handle it.

Andrew Bartlett
 2011-04-27 11:56:48 +10:00
Andrew Bartlett
e04bab4a19 libcli/auth Move Samba4's gssapi_error_string from GENSEC to libcli/auth 
This will allow the GSSAPI PAC fetch code to use it.

Andrew Bartlett
 2011-04-27 11:21:37 +10:00
Andrew Bartlett
0840d5bb8b libcli/auth Allow parsing of a PAC that is already verified. 
By making the verification parameters optional, we can parse a PAC
that is already verified.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Apr 26 10:06:59 CEST 2011 on sn-devel-104
 2011-04-26 10:06:58 +02:00
Andrew Bartlett
c18954775e libcli/dns Improve dns_hosts_file, using Samba3's struct dns_rr_srv 
By reworking the 'fake DNS' file to use struct dns_rr_srv it should be
possible to emulate that resolver layer as well as the Samba4
sockaddr_storage* based layer.  This will then give us a common DNS
emulation for 'make test'.

Andrew Bartlett
 2011-04-26 17:16:34 +10:00
Jelmer Vernooij
93179239eb Add missing dependency on com_err. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Apr 23 16:53:03 CEST 2011 on sn-devel-104
 2011-04-23 16:53:03 +02:00
Andrew Bartlett
f28f5db15a libcli/auth Move PAC parsing and verification in common. 
This uses the source3 PAC code (originally from Samba4) with some
small changes to restore functionality needed by the torture tests,
and to have a common API.

Andrew Bartlett
 2011-04-20 04:31:07 +02:00
Andrew Bartlett
0e5482c791 libcli/auth: Move more kerberos wrapping in common 
These functions are required to get the krb5 PAC parsing and
verfication in common.

Andrew Bartlett
 2011-04-20 04:31:07 +02:00
Andrew Bartlett
32c12cc279 libcli/auth Fix compile on hosts without krb5 
Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 14 11:08:49 CEST 2011 on sn-devel-104
 2011-04-14 11:08:49 +02:00
Andrew Bartlett
4ba1375526 libcli/auth Move krb5 wrapper functions from s3 into common 
This requires a small rework of the build system to ensure that the
correct #define statements are made in both the s3 and top level
builds.  We now define the various HAVE_ macros in config.h at all
times, using heimdal_build/wscript_configure when that is in use.

Andrew Bartlett
 2011-04-14 16:38:26 +10:00
Andrew Bartlett
35fca85660 libcli/ldap Re-add ldap_ndr.h as a public header 
as noticed by Brad Hards

Andrew Bartlett
 2011-04-14 12:22:59 +10:00
Christian Ambach
96a49d23a4 libcli: allow exclusion of netbios name in NTLMV2 blob 
when no hostname is given, leave away the MsvAvNbComputerName part
of the ntlmv2 blob

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-04-14 01:32:22 +02:00
Volker Lendecke
d4c693df98 Add dom_sid_parse_endp 
This returns a pointer to the first non-parsed character, along the lines of
strtoul for example.

Signed-off-by: Jeremy Allison <jra@samba.org>
 2011-04-13 14:13:24 -07:00
Volker Lendecke
111f4ec8b7 s3: Use talloc_tos() in the S3 build 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 13 09:30:55 CEST 2011 on sn-devel-104
 2011-04-13 09:30:55 +02:00
Andrew Bartlett
bf431fbedb libcli/auth Use convert_string_error to check LM hash calculation. 
This allows us to know if the LM hash was built correctly or not.

NOTE: talloc_tos() is not available in the common code at this time.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-04-13 14:47:08 +10:00
Andrew Bartlett
5694ba507c libcli/ldap pull LIBCLI_LDAP_MESSAGE and LIBCLI_LDAP_NDR into a library 
This reduces symbol duplication

Andrew Bartlett
 2011-04-13 11:47:36 +10:00
Günther Deschner
9c6f78aae1 s3: add some forward declarations. 
Guenther
 2011-04-12 12:20:43 +02:00
Andrew Tridgell
5adf85e6af tstream: make npa_tstream a private library 
this prevents symbol duplication of the npa_tstream symbols

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-04-06 08:12:19 +02:00
Andrew Tridgell
a8da13cd5c lib: make asn1_util a private library 
this prevents symbol duplication of the asn1 symbols in the service
and ntvfs subsystems

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-04-06 08:12:19 +02:00
Andrew Bartlett
457c665be2 libcli/nbt Cope with blank lines in DNS hosts file 2011-04-06 12:34:57 +10:00
Andrew Bartlett
663dc94e63 auth: Move auth_session_info into IDL 
This changes auth_session_info_transport to just be a wrapper, rather
than a copy that has to be kept in sync.

As auth_session_info was already wrapped in python, this required
changes to the existing pyauth wrapper and it's users.

Andrew Bartlett
 2011-04-05 23:46:04 +02:00
Günther Deschner
0a250f4946 registry: create and use shared libcli/registry/util_reg.h header. 
Guenther
 2011-03-30 01:13:07 +02:00
Jeremy Allison
0c5214e2eb Ensure convert_string_XXX is always called with a valid converted_size pointer. 
Preparation for cleaning up this API.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 29 21:01:49 CEST 2011 on sn-devel-104
 2011-03-29 21:01:49 +02:00
Jeremy Allison
52602e4f5a Fix inspired by work done by David Disseldorp for bug #8040 - smbclient segfaults when a Cyrillic netbios name or workgroup is configured. 
Change msrpc_gen to return NTSTATUS and ensure everywhere this is
used it is correctly checked to return that status.

Jeremy.
 2011-03-28 23:12:07 +02:00
Volker Lendecke
8db0374251 s3: Fix Coverity ID 682: NEGATIVE_RETURNS 2011-03-27 22:22:10 +02:00
Andrew Tridgell
5a20325c86 libcli: created smb_constants.h 
this starts the (long!) process of moving some of the SMB constants
into common files. This just moves the FLAGS2_ defines, which are
needed for common string routines (for FLAGS2_UNICODE_STRINGS)
 2011-03-25 04:37:06 +01:00
Andrew Tridgell
15e84a9a09 charcnv: removed the allow_badcharcnv and allow_bad_conv options to convert_string*() 
we shouldn't accept bad multi-byte strings, it just hides problems

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
 2011-03-24 01:47:26 +01:00
Stefan Metzmacher
4928d66fc2 libcli/security: make sure that we don't grant SEC_STD_DELETE to the owner by default 
In the file server SEC_STD_DELETE is granted on the file/directory
or by FILE_DELETE_CHILD on the parent directory.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Mar 21 23:25:05 CET 2011 on sn-devel-104
 2011-03-21 23:25:05 +01:00
Matthieu Patou
d772b8e780 ldapcli: allocate control value on the control object not on the control container 2011-03-20 11:27:25 +01:00
Jelmer Vernooij
fa387825e2 libcli/: Fix prototypes for all functions. 2011-03-19 03:20:05 +01:00
Günther Deschner
e1f84330ba libcli/security: move display_sec headers to own header file and add to 
security.h grouping header.

Guenther
 2011-03-16 10:11:08 +01:00
Andrew Tridgell
73e7b72936 libcli: openchange doesn't need these headers any more 
thanks to Simo for pointing this out

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Mar 16 00:25:10 CET 2011 on sn-devel-104
 2011-03-16 00:25:10 +01:00
Andrew Tridgell
b2b41a5087 libcli: protect access_check.h against double inclusion 
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 15 05:07:01 CET 2011 on sn-devel-104
 2011-03-15 05:07:01 +01:00
Andrew Tridgell
6c6ab50a40 waf: build substituted public headers in build tree 
the bin/default/include/public directory will contain headers that are
ready to install
 2011-03-15 12:22:19 +11:00
Volker Lendecke
16b007c223 Quite some callers of sid_split_rid do not care about the rid 2011-03-10 18:48:34 +01:00
Volker Lendecke
be3e851fea Fix some nonempty blank lines 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Mar  5 15:16:02 CET 2011 on sn-devel-104
 2011-03-05 15:16:02 +01:00
Volker Lendecke
70517477f8 Add dom_sid_string_buf 
This prints into a fixed buffer with the same overflow semantics as snprintf
has: Return required string length, regardless of whether it fit or not.
 2011-03-03 22:08:49 +01:00
Andrew Bartlett
86aa05e860 libcli/security Add unix_token and unix_info to auth_session_info too 
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar  1 07:13:43 CET 2011 on sn-devel-104
 2011-03-01 07:13:43 +01:00
Volker Lendecke
f7bd09665a libcli: Eliminate select from smb_readline_replacement 2011-02-28 16:40:20 +01:00
Matthias Dieter Wallnöfer
22c407d8bd libcli/nbt/wscript_build - fix build of "lmhosts" 
Needs also the "talloc" dependency.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Feb 25 11:01:31 CET 2011 on sn-devel-104
 2011-02-25 11:01:31 +01:00
Jeremy Allison
ed3ae87830 Implement the SMB2 close flag SMB2_CLOSE_FLAGS_FULL_INFORMATION (and move definition to correct place). 
Thanks to Nick Meier @ Microsoft for finding this @ Connectathon.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 25 00:40:52 CET 2011 on sn-devel-104
 2011-02-25 00:40:52 +01:00
Andrew Tridgell
11a97d60d9 build: moved util_reg.c into a common subsystem 
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb 24 05:53:52 CET 2011 on sn-devel-104
 2011-02-24 05:53:52 +01:00
Andrew Tridgell
74947964d9 build: moved spnego_parse.c into a common subsystem 2011-02-24 15:08:50 +11:00
Andrew Tridgell
52fe20c310 build: moved lmhosts.c into a common subsystem 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-24 11:57:48 +11:00
Andrew Tridgell
8dbe665a0c build: moved schannel_sign.c into a shared COMMON_SCHANNEL subsystem 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-24 11:57:48 +11:00
Andrew Tridgell
d37a55548b build: moved libcli/auth/ntlmssp*.c into a common libcliauth.so library 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-24 11:57:48 +11:00
Andrew Bartlett
e3821f2c40 s4-auth Move libcli/security/session.c to the top level 
This code is now useful in common, as the elements of the
auth_session_info structure have now been defined in common IDL.

Andrew Bartlett
 2011-02-22 16:20:11 +11:00
Andrew Tridgell
9aa85b6e30 s3-waf: use common libcli/nbt build rules 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-22 02:51:09 +01:00
Andrew Tridgell
efc932112c libcli/nbt: allow use of the waf build for nbt in source3 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-22 02:51:09 +01:00
Matthias Dieter Wallnöfer
d2b336ae31 libcli/security/security_descriptor.c - fix three wrong counter variables 
These strictly need to be "uint32_t" since "acl*->num_aces" has been
defined by this type.

This counter patchset has been reviewed by Andrew Bartlett.
 2011-02-21 10:46:40 +01:00
Matthias Dieter Wallnöfer
618c11cc15 libcli/security/privileges.c - fix wrong counter type 
This strictly needs to be from type "uint32_t" since "privset->count"
is defined with this type.
 2011-02-21 10:43:43 +01:00
Matthias Dieter Wallnöfer
e7659fa802 libcli/security/privileges.c - fix the counting of privileges 
Since the privileges are always counted with a signed integer, there is no
reason to specify the upper limit with a "uint32_t".
 2011-02-21 10:43:43 +01:00
Matthias Dieter Wallnöfer
a2ded04973 libcli/security/sddl.c - fix wrong counter type 
This strictly needs to be from type "uint32_t" since "acl->num_aces" is
defined of this type.
 2011-02-21 10:43:43 +01:00
Matthias Dieter Wallnöfer
055857a8d4 libcli/security/display_sec.c - fix wrong counter type 
This strictly needs to be of type "uint32_t" due to
"sec_acl->num_aces" which is of type "uint32_t".
 2011-02-21 10:43:43 +01:00
Andrew Tridgell
5debcb1027 idl: naming a structure 'VERSION' is not a good idea! 
this renames it to ntlmssp_VERSION

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-17 00:55:23 +01:00
Matthias Dieter Wallnöfer
6bfaa4c109 libcli/security - fix two output format specifiers 2011-02-15 11:19:37 +01:00
Günther Deschner
3e9faf7efd libcli/auth: fix PAM_ERRORS subsystem build. 
(waf-)god knows why, without this (fake) dependency, ./configure && make fails
while including replace.h while ./configure.developer && make succeeds...

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Feb 11 23:50:40 CET 2011 on sn-devel-104
 2011-02-11 23:50:40 +01:00
Nadezhda Ivanova
c3f6cc9993 security: Fixed some handling of ACEs with INHERITED flag provided by the user 
Some tests showed that these ACEs are not removed if the DACL_PROTECTED flag is provided at the same time.
This is not documented but tests prove it and it has been observerd in deployment.
 2011-02-10 12:43:58 +02:00
Andrew Tridgell
8dc92c8f71 ldb: use #include <ldb.h> for ldb 
thi ensures we are using the header corresponding to the version of
ldb we're linking against. Otherwise we could use the system ldb for
link and the in-tree one for include

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-02-10 06:51:07 +01:00
Andrew Bartlett
d66150c14d libcli/named_pipe_auth Change from 'info3' to auth_session_info_transport 
This changes the structure being used to convey the current user state
from the netlogon-derived 'netr_SamInfo3' structure to a purpose-built
structure that matches the internals of the Samba auth subsystem and
contains the final group list, as well as the final privilege set and
session key.

These previously had to be re-created on the server side of the pipe
each time.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-02-10 06:51:06 +01:00
Andrew Bartlett
543ef3b5bf libcli/named_pipe_auth Remove support for unused levels 0-2. 
The only client and server for this code uses level 3 exclusively.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-02-10 06:51:06 +01:00
Günther Deschner
34722c72f6 pam: share pam errors in a common location. 
Guenther
 2011-02-08 14:05:36 +01:00
Jelmer Vernooij
242797aca9 pysecurity: Add missing dependency on pytalloc-util. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Feb  8 13:16:43 CET 2011 on sn-devel-104
 2011-02-08 13:16:43 +01:00
Volker Lendecke
1d58fcc925 libcli/security: Make add_sid_to_array_unique use a uin32_t counter 
Logical consequence of the previous commit

Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb  7 19:24:19 CET 2011 on sn-devel-104
 2011-02-07 19:24:19 +01:00
Volker Lendecke
91a56b420a libcli/security: Make del_sid_from_array take a uint32_t 
This aligns it with add_sid_to_array

Signed-off-by: Michael Adam <obnox@samba.org>
 2011-02-07 18:37:43 +01:00
Stefan Metzmacher
24acddf806 libcli/util: add NT_STATUS_RPC_SEC_PKG_ERROR define 
metze
 2011-01-30 17:36:20 +01:00
Kai Blin
278c6f8fc5 errormap: Add unix_to_werror() function 
While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.

Signed-off-by: Kai Blin <kai@samba.org>

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Jan 26 23:07:24 CET 2011 on sn-devel-104
 2011-01-26 23:07:24 +01:00
Stefan Metzmacher
0dc1eee0b8 libcli/ldap: use lib/ldb_compat.h for the s3 build 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 24 14:55:50 CET 2011 on sn-devel-104
 2011-01-24 14:55:50 +01:00
Andrew Bartlett
084b4e235e libcli/auth move ntlmssp_wrap() and ntlmssp_unwrap() into common code. 
The idea here is to allow the source3/libads/sasl.c code to call this
instead of the lower level ntlmssp_* functions.

Andrew Bartlett
 2011-01-20 23:44:05 +01:00
Nadezhda Ivanova
fed925079b s4-security: Fixed incorrect inheritance of IO flagged ACES 
They should be inherited without the IO flag unless they contain generic information.
 2011-01-18 15:08:17 +01:00
Andrew Bartlett
012e570416 libcli/security Add python bindings for se_access_check 
Andrew Bartlett
 2011-01-14 16:39:32 +11:00
Nadezhda Ivanova
961f503f0d security: Fixed incorrect indentation in create_descriptor.c 
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Thu Jan 13 15:53:16 CET 2011 on sn-devel-104
 2011-01-13 15:53:16 +01:00
Nadezhda Ivanova
980f68a6f2 security: Fixed bugs in expansion of generic information ACEs 
When an ACE gontaining GA, GE, GR, GW, CO or CG is provided by a user or inherited
the final SD actually has to have 2 ACEs, one is an effective expanded one, and the
original one with IO flag added.
 2011-01-11 12:20:43 +02:00
Günther Deschner
45227e96c2 libcli/security: fix sid_type_lookup(). 
It *always* returned "SID *TYPE* is INVALID".

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 10 12:47:00 CET 2011 on sn-devel-104
 2011-01-10 12:47:00 +01:00
Günther Deschner
3294ccbb6d netlogon: move netlogon helpers to ../libcli/netlogon. 
Guenther
 2011-01-07 15:02:24 +01:00
Stefan Metzmacher
e22c4c5632 libcli/auth: add netsec_outgoing_sig_size() 
The size of the signature blob depends on the used
algorithm.

metze
 2011-01-03 16:44:28 +01:00
Volker Lendecke
41179c2538 Fix a valgrind error 
Thanks to Tridge for the hint.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan  2 10:58:51 CET 2011 on sn-devel-104
 2011-01-02 10:58:51 +01:00
Jelmer Vernooij
5792fa90ac s4-python: Only set BASETYPE flag if subclassing is supported. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Jan  1 03:39:58 CET 2011 on sn-devel-104
 2011-01-01 03:39:58 +01:00
Jelmer Vernooij
f5fe9c32ef s4-python: Add more prototypes. 2011-01-01 02:54:05 +01:00
Matthias Dieter Wallnöfer
13fa6743d8 s3/s4:auth SPNEGO - adaptions for the removed "const" from OIDs 
This is needed in order to suppress warnings.
 2010-12-21 15:10:37 +11:00
Günther Deschner
10eaad2977 libcli/security: remove unused variable. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Dec 17 13:56:27 CET 2010 on sn-devel-104
 2010-12-17 13:56:27 +01:00
Andrew Bartlett
4a4d8e4b0f libcli/security Add sid_blob_parse() to directly parse a binary SID blob 2010-12-16 15:54:30 +11:00
Stefan Metzmacher
aac0c58e04 libcli/echo: fix off by 1 crash bug 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Dec 11 13:48:54 CET 2010 on sn-devel-104
 2010-12-11 13:48:54 +01:00
Stefan Metzmacher
b6fef94ec1 libcli/echo: lowercase testsuite names 
metze
 2010-12-11 11:06:56 +01:00
Kai Blin
1f2518df5a s4 libcli: Add libcli_echo lib and torture test 
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Thu Dec  9 23:57:03 CET 2010 on sn-devel-104
 2010-12-09 23:57:03 +01:00
Andrew Bartlett
a21cb5a0a1 libcli/auth bring ADS_IGNORE_PRINCIPAL in common 2010-12-08 08:55:04 +01:00
Stefan Metzmacher
15c33ada6b libcli/auth: let spnego_write_mech_types() check the asn1_load() return 
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Dec  7 18:23:41 CET 2010 on sn-devel-104
 2010-12-07 18:23:41 +01:00
Matthias Dieter Wallnöfer
93d85ca5fd s4:fix some shadowed declaration warnings on Solaris by renaming the symbols 2010-12-06 11:28:58 +01:00
Jeremy Allison
75508cea4a Turns out there are lots of places in S3 where token passed in 
here can be NULL (become_root() sets the current security token to
NULL for example). Ensure we don't crash.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Dec  2 03:26:03 CET 2010 on sn-devel-104
 2010-12-02 03:26:03 +01:00
Matthias Dieter Wallnöfer
3035fe041f libcli/security/object_tree.c - remove unreachable statement 2010-11-29 14:48:12 +01:00
Arnaud Faucher
2ac5cedb71 Avoid the use of PyAPI_DATA, which is for internal Python API's. 
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Nov 22 00:52:56 CET 2010 on sn-devel-104
 2010-11-22 00:52:56 +01:00
Andrew Tridgell
9a744c634f s4-doserr: telling our users to "see Windows help" doesn't seem right 2010-11-17 23:55:39 +11:00
Volker Lendecke
eb769f2234 raw.h is only needed in the S4 build 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Nov  9 14:49:14 UTC 2010 on sn-devel-104
 2010-11-09 14:49:14 +00:00
Kamen Mazdrashki
717b1158a6 idl: Use DRSUAPI_ATTID_ prefix instead of DRSUAPI_ATTRIBUTE_ for ATTID values 
Those values are actually ATTID values and such, they are used
for ATTIDs for Attributes, Classes and Syntaxes.
 2010-10-31 23:54:04 +00:00
Jelmer Vernooij
3deece5591 s4: Remove the old perl/m4/make/mk-based build system. 
The new waf-based build system now has all the same functionality, and
the old build system has been broken for quite some time.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 31 02:01:44 UTC 2010 on sn-devel-104
 2010-10-31 02:01:44 +00:00
Andrew Tridgell
eb0005dfca s4-tdb: make tdb-wrap into a private library 
this prevents double linking of the tdb wrap code
 2010-10-30 23:49:01 +11:00
Jelmer Vernooij
a74e8be6d1 waf: Stop automaticaly changing dashes to underscores in library names. 2010-10-26 10:17:18 -07:00
Jelmer Vernooij
8cf61377aa waf: Remove lib prefix from libraries manually. 2010-10-26 10:17:17 -07:00
Jelmer Vernooij
d9cbcdd410 s4: Drop duplicate 'lib' prefix for private libraries. 2010-10-26 10:17:16 -07:00
Andrew Bartlett
14686e4b5a libcli/security Remove unused sec_acl_equal() 
This was orphaned by changing sec_desc_equal() to the stricter
security_descriptor_equal() by
f4195183a4 in 2009.

(The difference here was that sec_acl_equal allowed for equivilent ordering.  I've checked the callers, and this function is only used to skip actual ACL sets, or to reference a cache, so this seems

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Oct 24 22:21:23 UTC 2010 on sn-devel-104
 2010-10-24 22:21:23 +00:00
Jelmer Vernooij
599afb0651 s4: Rename LIBCLI_NBT -> cli_nbt. 2010-10-24 00:20:04 +00:00
Jelmer Vernooij
5224de3f74 s4: Rename LIBCLI_LDAP to libcli_ldap. 2010-10-24 00:20:04 +00:00
Jelmer Vernooij
833480d3ad s4: Rename LIBSAMBA-* to libsamba-* 2010-10-24 00:20:04 +00:00
Jelmer Vernooij
ca16d805bd s4: Rename LIBSECURITY{_SESSION,} to libsecurity{_session,} 2010-10-24 00:20:04 +00:00
Jelmer Vernooij
9065f9644b s4: Rename LIBNETIF to libnetif. 2010-10-23 22:24:06 +00:00
Matthias Dieter Wallnöfer
18103d34e2 create_descriptor.c - fix comment 
The location in MS-DTYPE changed.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 23 21:33:46 UTC 2010 on sn-devel-104
 2010-10-23 21:33:45 +00:00
Kai Blin
eeac222398 s4 dns: Import DNS win32 error codes from MS-ERREF 2010-10-23 10:17:05 +00:00
Jeremy Allison
3e79cd6856 Fix const warning. Allocate off NULL as we always talloc_free(). 2010-10-22 17:33:03 +00:00