11 Commits

Author	SHA1	Message	Date
Jeremy Allison	bda0f03fb3	Convert in_transaction to a bool. Add the same fix Volker ... used for tdb_traverse() to tdb_traverse_read(). Jeremy.	2008-05-20 14:18:58 -07:00
Volker Lendecke	80e700e3bd	Fix nesting tdb_traverse in a transaction ... Calling tdb_traverse inside a transaction led to the transaction lock being held indefinitely. This was caused by the tdb_transaction_lock/unlock inside tdb_traverse: The transaction code holds the global lock at offset TRANSACTION_LOCK. The call to tdb_transaction_lock does nothing because the transaction_lock is already being held. tdb_transaction_unlock inside tdb_wrap resets tdb->have_transaction_lock but does not release the kernel-level fcntl lock. transaction_commit later on does not release that fcntl lock either, because tdb->have_transaction_lock was already reset by tdb_transaction(). This patch does fix that problem for me. An alternative would be to make tdb->have_transaction_lock a counter that can cope with proper nesting, maybe in other places as well. Volker	2008-05-20 21:59:44 +02:00
Jeremy Allison	c6609c042b	Sync tdb with the tdb changes in ctdb. Spoke to tridge about ... this. Fixes insidious problem with order n^2 freelist merging. Jeremy.	2008-01-11 15:08:37 -08:00
Volker Lendecke	223352e323	Add a warning for a potential bug I've run into	2007-11-28 09:45:40 -08:00
Jeremy Allison	ab11c00557	Keep the tdb code in sync with Samba4. ... Mainly this is the svn changes : ------------------------------------------------------------------------ r23238 | tridge | 2007-05-30 01:15:49 -0700 (Wed, 30 May 2007) | 6 lines merged transaction lock changes from ctdb this ensures that having the global lock also implies the transaction lock ------------------------------------------------------------------------ r22832 | tridge | 2007-05-13 18:00:06 -0700 (Sun, 13 May 2007) | 3 lines merged the latest tdb changes from ctdb to Samba4 Jeremy.	2007-11-06 22:57:35 -08:00
Jelmer Vernooij	26d1430283	r24340: Use standard data type uint32_t rather than tdb-specific u32.	2007-10-10 12:29:30 -05:00
Andrew Tridgell	c676a97114	r23798: updated old Temple Place FSF addresses to new URL	2007-10-10 12:28:26 -05:00
Andrew Tridgell	1b78cace50	r23790: LGPLv3+ conversion for our LGPLv2+ library code	2007-10-10 12:28:25 -05:00
Jeremy Allison	bf951e3d7f	r23371: Fix the misleading comment I added - it really *should* ... say "locks chain and returned record", not "and returns record" Jeremy.	2007-10-10 12:23:11 -05:00
Jeremy Allison	d0b6456763	r23370: Traverse in tdb wasn't consistently using the ... travlocks.lock_rw for lock read/write types, it was sometimes using it (tdb_next_lock) and sometimes explicitly using F_WRLCK instead. Change this to consistently use travlocks.lock_rw only. I'm pretty sure about this fix (else I woudn't be checking this in :-) but tridge and Volker please review. Jeremy.	2007-10-10 12:23:10 -05:00
Stefan Metzmacher	c7def92a9c	r22249: move tdb code to lib/tdb/ as in samba4 ... metze	2007-10-10 12:19:22 -05:00