1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-18 19:17:08 +03:00

198 Commits

Author SHA1 Message Date
Tim Prouty
6b189dabc5 Cleanup size_t return values in callers of convert_string_allocate
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
2008-05-20 22:40:13 +02:00
Volker Lendecke
d3c31aa36c Fix bug 5375
Thanks to Moskvin for testing
2008-04-07 10:20:39 +02:00
Volker Lendecke
ad37b7b0ae Fix some warnings
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
2008-02-25 16:09:26 +01:00
Karolin Seeger
2bec0a1fb7 Fix some typos.
Karolin
2008-02-08 10:05:32 +01:00
Volker Lendecke
feddc1447d str_list_free is not needed anymore 2008-02-04 21:05:41 +01:00
Volker Lendecke
e2c9fc4cf5 Always pass a TALLOC_CTX to str_list_make and str_list_copy 2008-02-04 20:57:49 +01:00
Volker Lendecke
d471dd4adb Simplify str_list_xxx 2008-02-04 20:05:26 +01:00
Kai Blin
ab0ee6e9a6 util_str: Don't return memory from talloc_tos(), use mem_ctx instead. 2008-01-19 02:20:16 +01:00
Jeremy Allison
329b924cba Fixup hot paths - add macro for toupper (c < 0x80).
This now matches 3.0.x on my micro-tests.
Jeremy.
2008-01-09 17:32:26 -08:00
Volker Lendecke
86d9412611 Remove next_token_nr_talloc and its associated global
Only client.c and clitar.c used this, I think they should carry the static
themselves. Also move the a bit funny routine toktocliplist to clitar.c, the
only place where it is used.
2007-12-21 09:58:20 +01:00
Jeremy Allison
ec003f3936 Remove next_token - all uses must now be next_token_talloc.
No more temptations to use static length strings.
Jeremy.
2007-12-07 17:32:32 -08:00
Jeremy Allison
4c32a22ac5 Don't build rpctorture anymore - not maintained. Just remove.
Remove all vestiges of pstring (except for smbctool as noted
in previous commit).
Jeremy
2007-12-07 12:26:32 -08:00
Jeremy Allison
46b67fd82c Remove pstrings completely except for smbctool (what does this do ?).
Don't build this for now.
Jeremy.
2007-12-07 12:02:44 -08:00
Volker Lendecke
31d0a846db Remove some globals 2007-12-05 14:39:07 +01:00
Jeremy Allison
7d3959f81a Ok, down to just the client/*.c code now.
Jeremy.
2007-12-04 18:02:06 -08:00
Jeremy Allison
fecc3cc45a Remove tok pstring from util_str.c
Do we even make rpctorture anymore ?
Jeremy.
2007-12-04 17:23:19 -08:00
Jeremy Allison
f9c8d62389 Make strhex_to_str clear on string limits. Remove pstring from web/*.c
Jeremy.
2007-12-03 17:17:05 -08:00
Jeremy Allison
fa8115f32b Fix restart after length count.
Jeremy.
2007-11-30 14:15:34 -08:00
Jeremy Allison
0ae61e2654 Add talloc versions of all the next_token() functions.
Now I can really start removing fixed length strings...
Jeremy.
2007-11-30 13:09:04 -08:00
Jeremy Allison
ae7885711f Remove more pstring. Unify talloc_sub functions to make
them a better match for replacing string_sub. Remove
more unused code.
Jeremy.
2007-11-19 18:56:22 -08:00
Jeremy Allison
00760451b6 Remove smbldap_get_single_pstring() and all pstrings
from pdb_ldap.c. I don't have an LDAP passdb setup here,
so I'm going to need some help on testing this.
Jeremy.
2007-11-14 16:05:42 -08:00
Jeremy Allison
eaf14c701b Remove all pstrings from smbd/chgpasswd.c.
Jeremy.
2007-11-12 15:02:50 -08:00
Volker Lendecke
5f205ab48d Make base64_encode_data_blob return a talloced string 2007-11-09 15:12:30 +01:00
Volker Lendecke
4cdebda39b Remove unnecessary code
SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure
2007-11-05 03:40:31 +01:00
Jeremy Allison
f109f82622 Fix bug in writing names into gencache
as well as 2 typos where AF_INET6 was mistypes as AF_INET.
JERRY YOU NEED THESE FIXES.
Fixes smbclient -L localhost -U%
Bugs reported by Kukks (thanks kukks).
Jeremy.
2007-10-25 19:07:25 -07:00
Jeremy Allison
98e154c312 This is a large patch (sorry). Migrate from struct in_addr
to struct sockaddr_storage in most places that matter (ie.
not the nmbd and NetBIOS lookups). This passes make test
on an IPv4 box, but I'll have to do more work/testing on
IPv6 enabled boxes. This should now give us a framework
for testing and finishing the IPv6 migration. It's at
the state where someone with a working IPv6 setup should
(theorecically) be able to type :
smbclient //ipv6-address/share
and have it work.
Jeremy.
2007-10-24 14:16:54 -07:00
Jeremy Allison
315215e20e Reformatting fix for new coding guidelines. BOOL ->bool.
Jeremy.
2007-10-17 12:10:12 -07:00
Gerald (Jerry) Carter
5c6c8e1fe9 [GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch. 2007-10-10 15:34:30 -05:00
Volker Lendecke
b64df8a3c5 r25184: Fix some C++ warnings and an uninitialized variable 2007-10-10 12:30:49 -05:00
Jeremy Allison
39c211a702 r25138: More pstring elimination. Add a TALLOC_CTX parameter
to unix_convert().
Jeremy.
2007-10-10 12:30:44 -05:00
Jeremy Allison
6552e52979 r25121: Remove pstring limits from much of our string handling function.
Still a few left (mainly the substitute ones).
Jeremy.
2007-10-10 12:30:42 -05:00
Andrew Tridgell
b0132e94fc r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text 2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b r23779: Change from v2 or later to v3 or later.
Jeremy.
2007-10-10 12:28:20 -05:00
Volker Lendecke
e6e5703658 r23518: Remove the silly assumption that string_replace requires a pstring.
Jeremy, I am always very confused about the different length arguments
in convert_string and friends. Can you take a look at the change in
string_replace and verify it's ok? Thanks!

While at it, remove the pstring limit for strhasupper and strhaslower.
2007-10-10 12:23:25 -05:00
Simo Sorce
42d846ff87 r23356: We missed to add the 'c' character to the list of valid ones for
shell escaping.

I hate this kind of bugs more than how Jeremy hates off by ones :(

Simo.
2007-10-10 12:23:09 -05:00
Gerald Carter
f65214be68 r22852: merge fixes for CVE-2007-2446 and CVE-2007-2447 to all branches 2007-10-10 12:22:02 -05:00
Jeremy Allison
140881cfbb r22045: As Volker noticed, skip_string's last argument is
redundent. Remove it.
Jeremy.
2007-10-10 12:19:05 -05:00
Jeremy Allison
c3a565081d r22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,
but I've no option.
Jeremy.
2007-10-10 12:19:01 -05:00
Jeremy Allison
437cb7c888 r20208: Change sprintf_append() never to use malloc,
but always use a talloc context.
Thanks to simo for pointing this out.
Jeremy.
2007-10-10 12:16:32 -05:00
Jeremy Allison
0ffca7559e r20090: Fix a class of bugs found by James Peach. Ensure
we never mix malloc and talloc'ed contexts in the
add_XX_to_array() and add_XX_to_array_unique()
calls. Ensure that these calls always return
False on out of memory, True otherwise and always
check them. Ensure that the relevent parts of
the conn struct and the nt_user_tokens are
TALLOC_DESTROYED not SAFE_FREE'd.
James - this should fix your crash bug in both
branches.
Jeremy.
2007-10-10 12:16:24 -05:00
Volker Lendecke
016ddce120 r19786: My last checkin to winreg_StringBuf killed rpccli_winreg_EnumKeys against
W2k3. The server requires that size==0 in the [in] name. Somehow I get the
feeling that something is badly wrong here....

I did not yet recreate the gen_ndr equivalent, see next mail.

Volker
2007-10-10 12:15:55 -05:00
Jeremy Allison
ece00b70a4 r18787: Fix the strlen_m and strlen_m_term code by merging
in (and using elsewhere) next_codepoint from Samba4.
Jerry please test.
Jeremy.
2007-10-10 12:00:57 -05:00
Stefan Metzmacher
9f3599a7ca r18652: libreplace has replacements for strndup and strnlen
metze
2007-10-10 11:52:19 -05:00
Jeremy Allison
84e8cc0593 r17866: Fix possible null deref - found by Stanford checker.
Jeremy.
2007-10-10 11:38:55 -05:00
Jeremy Allison
cfd39c2804 r17862: Fix possible NULL deref (like rev 17861) found by the
Stanford group.
Jeremy.
2007-10-10 11:38:54 -05:00
Volker Lendecke
1e4ee728df r17316: More C++ warnings -- 456 left 2007-10-10 11:38:25 -05:00
Jeremy Allison
9dafb7f48c r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
2007-10-10 11:19:14 -05:00
Jeremy Allison
1d21a3dec9 r16595: Klocwork #2067. Fix possible memleak on error exit.
Jeremy.
2007-10-10 11:19:02 -05:00
Jeremy Allison
b1fc2d8b99 r16554: Sorry, just had to change this. Don't use int when
you're passing a BOOL parameter, don't use "clever"
code in while statement - make things easier and
clearer to understand when triggering something
with an if.
Jeremy.
2007-10-10 11:19:00 -05:00
Derrell Lipman
d90061aa93 r16552: Fix bug 3849.
Added a next_token_no_ltrim() function which does not strip leading separator
characters.  The new function is used only where really necessary, even though
it could reasonably be used in many more places, to avoid superfluous code
changes.

Derrell
2007-10-10 11:19:00 -05:00