1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-18 19:17:08 +03:00

773 Commits

Author SHA1 Message Date
Jeremy Allison
201bcc8ed2 Memory leak fixes from Chere Zhou <czhou@isilon.com>.
Jeremy.
2008-05-27 12:27:57 -07:00
Tim Prouty
6b189dabc5 Cleanup size_t return values in callers of convert_string_allocate
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
2008-05-20 22:40:13 +02:00
root
30956c784f Fix some comments to match get_kdc_ip_string()'s behaviour 2008-05-19 12:08:52 +02:00
Günther Deschner
0388b2f0cc libads/cldap: store client sitename also keyed by dns domain name.
Guenther
2008-05-15 16:38:32 +02:00
Günther Deschner
f3251ba03a Fix Bug #5465 (joining with createcomputer=ou1/ou2/ou3).
Guenther
2008-05-14 23:53:23 +02:00
Günther Deschner
5b0eda98f3 dsgetdcname: make use of nbt_cldap_netlogon_15.
Guenther
2008-05-09 17:41:50 +02:00
Günther Deschner
56be9c98d2 cldap: move out cldap object to fix the build.
Guenther
2008-05-09 14:59:19 +02:00
Günther Deschner
6f9d5e1cc9 cldap: let ads_cldap_netlogon() return all possible cldap replies.
Guenther
2008-05-09 14:59:18 +02:00
Günther Deschner
b261f06312 mailslot/cldap: use nt_version bits in queries.
Guenther
2008-05-06 09:41:41 +02:00
Gerald W. Carter
5ed9b92097 BUG 5107: Fix handling of large DNS replies on AIX and Solaris.
On AIX, Solaris, and possibly some older glibc systems (e.g. SLES8)
truncated replies never give back a resp_len > buflen
which ends up causing DNS resolve failures on large tcp DNS replies.

Also add more debug lines about processing the DNS reply.
2008-04-30 09:57:15 -05:00
Steven Danneman
f1a5405409 Fix bug 5419: memory leak in ads_do_search_all_args() when enumerating 1000s of entries
The ads_do_search_all_args() function attempts to string together several
LDAPMessage structures, returned across several paged ldap requests, into a
single LDAPMessage structure.  It does this by pulling entries off the second
LDAPMessage structure and appending them to the first via the OpenLDAP specific
ldap_add_result_entry() call.

The problem with this approach is it skips non-entry messages such as the
result, and controls.  These messages are leaked.

The short term solution as suggested by Volker is to replace the ads_*_entry()
calls with ads_*_message() calls so we don't leak any messages.

This fixes the leak but doesn't remove the dependence on the OpenLDAP specific
implementation of ldap_add_result_entry().
2008-04-26 08:11:20 -07:00
Volker Lendecke
42de50d2cd Move user/domain from rpc_pipe_client to cli_pipe_auth_data 2008-04-25 11:12:50 +02:00
Günther Deschner
538eefe22a cldap: avoid duplicate definitions so remove ads_cldap.h.
Guenther
2008-04-21 20:21:40 +02:00
Günther Deschner
4cee7b1bd5 cldap: add talloc context to ads_cldap_netlogon().
Guenther
2008-04-21 20:21:40 +02:00
Günther Deschner
751f3064a5 libads: Use libnbt for CLDAP reply parsing.
Guenther
2008-04-21 20:21:39 +02:00
Volker Lendecke
3f6c5b9966 Use rpc_pipe_client->user_name instead of rpc_pipe_client->cli->user_name
Also make sure that rpc_pipe_client->user_name is always talloced.
2008-04-20 00:14:40 +02:00
Volker Lendecke
1d261e78b3 Fix two "ignoring asprintf result" warnings 2008-04-20 00:13:39 +02:00
Volker Lendecke
783afab9c8 Add "desthost" to rpc_pipe_client
This reduces the dependency on cli_state
2008-04-20 00:13:09 +02:00
Karolin Seeger
42fbbeb1ca Fix typo.
Karolin
2008-04-10 08:38:54 +02:00
Karolin Seeger
6cee347035 Fix typos.
Karolin
2008-04-09 16:14:04 +02:00
Günther Deschner
380e9d26db Add ads_check_ou_dn().
Guenther
2008-03-28 16:43:59 +01:00
Volker Lendecke
a0859529c8 Fix Coverity ID 488
"status" was used uninitialized on success -- metze, please check
2008-03-23 19:44:55 +01:00
Volker Lendecke
22cee9c1af Fix Coverity ID 487 2008-03-23 19:44:55 +01:00
Marc VanHeyningen
3fc85d2259 Coverity fixes 2008-03-17 20:52:25 +01:00
Volker Lendecke
f94a63cd8f Use a separate tdb for mutexes
Another preparation to convert secrets.c to dbwrap: The dbwrap API does not
provide a sane tdb_lock_with_timeout abstraction. In the clustered case the DC
mutex is needed per-node anyway, so it is perfectly fine to use a local mutex
only.
2008-03-10 21:08:45 +01:00
Volker Lendecke
c2401811aa Fix Coverity ID 551
Correctly return if we can't create the temporary krb5.conf

Jeremy, please check!
2008-03-08 23:48:12 +01:00
Günther Deschner
d078a87571 Add my copyright.
Guenther
2008-02-27 19:38:48 +01:00
Volker Lendecke
ad37b7b0ae Fix some warnings
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
2008-02-25 16:09:26 +01:00
Günther Deschner
ea609d1b0e Fix some more callers of PAC_DATA.
Guenther
2008-02-17 02:12:00 +01:00
Günther Deschner
5483f5fb44 Some more cleanup in authdata.c.
Guenther
2008-02-17 02:11:59 +01:00
Günther Deschner
c06e507737 Align our krb5 PAC decoding routines to the samba4 ones.
(while keeping all the trans krb5 lib support)

Guenther
2008-02-17 02:11:59 +01:00
Volker Lendecke
feddc1447d str_list_free is not needed anymore 2008-02-04 21:05:41 +01:00
Volker Lendecke
e2c9fc4cf5 Always pass a TALLOC_CTX to str_list_make and str_list_copy 2008-02-04 20:57:49 +01:00
Günther Deschner
2dd7c64fa8 When running with debug level > 10, dump ads_struct in ads_connect().
Guenther
2008-01-31 11:05:25 +01:00
Günther Deschner
c832882e49 Fix the build. Avoid unrequired ndr_print_ads_struct dependencies.
Guenther
2008-01-29 15:17:02 +01:00
Gerald W. Carter
8039a2518c Restrict the enctypes in the generated krb5.conf files to Win2003 types.
This fixes the failure observed on FC8 when joining a Windows 2008 RC1
domain.  We currently do not handle user session keys correctly
when the KDC uses AES in the ticket replies.
2008-01-28 11:32:09 -06:00
Volker Lendecke
fd34ce4370 strtok -> strtok_r 2008-01-23 15:08:04 +01:00
Günther Deschner
f7100156a7 Finally enable pidl generated SAMR & NETLOGON headers and clients.
Guenther
2008-01-17 16:54:46 +01:00
Jeremy Allison
79b7972de4 Tidy up code and debug for non-default krb5 IPv6 port.
Jeremy.
2008-01-16 13:28:24 -08:00
Jeremy Allison
f2aa921505 Fix IPv6 bug #5204, which caused krb5 DNS lookups
for a name '[<ipv6 addr>'.
Jeremy.
2008-01-16 13:21:46 -08:00
Günther Deschner
b7a06b54e0 Fix memleak in ads_build_path().
Guenther
2008-01-16 16:06:15 +01:00
Günther Deschner
44d67e8462 Print principal in debug statement in kerberos_kinit_password() as well.
Guenther
2008-01-14 18:39:08 +01:00
Jeremy Allison
0599d57eff Fix CID 476. Ensure a valid pac_data pointer is always passed to
ads_verify_ticket as it's always derefed.
Jeremy.
2008-01-11 23:53:27 -08:00
Jeremy Allison
1b7cc80c61 Coverity 512, uninitialized var.
Jeremy.
2008-01-11 23:43:33 -08:00
Günther Deschner
ddc1307844 Do not ignore provided machine_name in ads_get_upn().
Guenther
2008-01-08 14:07:01 +01:00
Michael Adam
2e5d01b214 Re-Indent function ldap_open_with_timeout().
This reverts commit #cafda34783f0961c9b463803c19cfcb69f836e3f .

I just learned (the hard way) that these indeted functions
are not indented by accident but that the intention of this
is to not include the prototype into proto.h.

Michael
2008-01-04 22:56:10 +01:00
Michael Adam
7d9d2de390 Add a debug message (when the LDAP server has really been connected).
Michael
2008-01-04 22:09:36 +01:00
Michael Adam
465a3b356c Untangle assignment and result check.
Michael
2008-01-04 22:09:36 +01:00
Michael Adam
9e70d1f24d Enhance DEBUG-verbosity of ldap_open_with_timeout().
Michael
2008-01-04 22:09:36 +01:00
Michael Adam
cafda34783 Unindent function header.
Michael
2008-01-04 22:09:35 +01:00