1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-17 15:17:09 +03:00

125 Commits

Author SHA1 Message Date
Tim Prouty
6b189dabc5 Cleanup size_t return values in callers of convert_string_allocate
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
2008-05-20 22:40:13 +02:00
Günther Deschner
3b0135d57e Use new IDL based PAC structures in clikrb5.c
Guenther
2008-02-17 02:11:59 +01:00
Günther Deschner
507247dcbf Make heimdal and MIT happy when iterating through auth data.
Guenther
2007-12-12 18:58:26 +01:00
Guenther Deschner
c9adc07ca2 Vista SP1-rc1 appears to break against Samba-3.0.27a
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jason,

Jason Haar wrote:
> Patched 3.0.28, compiled, installed and here's the log file.
>
> Hope it helps. BTW I don't think it matters, but this is on 32bit
> CentOS4.5 systems.

yes, it helps. Thanks for that.

Very interesting, there are two auth data structures where the first one
is a PAC and the second something unknown (yet).

Can you please try the attached fix ? It should make it work again.

Guenther
- --
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner@redhat.com
Samba Team                              gd@samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHX9ZESOk3aI7hFogRAivSAJ9bMcD+PcsIzjYYLtAUoLNfVVEl1QCfV/Qd
MPsZW4G31VOVu64SPjgnJiI=
=Co+H
-----END PGP SIGNATURE-----
2007-12-12 09:52:51 -08:00
Jeremy Allison
ec003f3936 Remove next_token - all uses must now be next_token_talloc.
No more temptations to use static length strings.
Jeremy.
2007-12-07 17:32:32 -08:00
Jeremy Allison
bda8c0bf57 Fix the setup_kaddr() call to cope with IPv6.
This is the last obvious change I can see. At
this point we can start claiming IPv6 support
(Hurrah !:-).
Jeremy.
2007-10-29 15:03:36 -07:00
Jeremy Allison
98e154c312 This is a large patch (sorry). Migrate from struct in_addr
to struct sockaddr_storage in most places that matter (ie.
not the nmbd and NetBIOS lookups). This passes make test
on an IPv4 box, but I'll have to do more work/testing on
IPv6 enabled boxes. This should now give us a framework
for testing and finishing the IPv6 migration. It's at
the state where someone with a working IPv6 setup should
(theorecically) be able to type :
smbclient //ipv6-address/share
and have it work.
Jeremy.
2007-10-24 14:16:54 -07:00
Jeremy Allison
f35a266b3c RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
2007-10-18 17:40:25 -07:00
Andrew Tridgell
b0132e94fc r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text 2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b r23779: Change from v2 or later to v3 or later.
Jeremy.
2007-10-10 12:28:20 -05:00
Günther Deschner
accb40446a r23651: Always, always, always compile before commit...
Guenther
2007-10-10 12:23:41 -05:00
Günther Deschner
b9d7a2962a r23650: Fix remaining callers of krb5_kt_default().
Guenther
2007-10-10 12:23:41 -05:00
Günther Deschner
19020d19dc r23649: Fix the build (by moving smb_krb5_open_keytab() to clikrb5.c).
Guenther
2007-10-10 12:23:41 -05:00
Günther Deschner
eb1ec508ac r23609: Removing more redundant codepaths out of smb_krb5_renew_ticket().
Thanks Volker for the pointer hint :)

Guenther
2007-10-10 12:23:36 -05:00
Günther Deschner
277e07c855 r23588: Some more cleanups and error checks in the krb5 renew function.
Guenther
2007-10-10 12:23:33 -05:00
Günther Deschner
0b9acc8610 r23587: Cleanup redundant code in the krb5 renew function.
Guenther
2007-10-10 12:23:33 -05:00
Günther Deschner
1e4a7af993 r23586: Fix heimdal path in the krb5 renew routine when we need to compose the tgt
string ourselves.

Guenther
2007-10-10 12:23:33 -05:00
Günther Deschner
aa3511a5b5 r23582: Fix event based krb5 ticket refreshing in winbindd.
We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.

Guenther
2007-10-10 12:23:32 -05:00
Volker Lendecke
a66a04e9f1 r22747: Fix some C++ warnings 2007-10-10 12:21:54 -05:00
Günther Deschner
dcd902f24a r22664: When we have krb5_get_init_creds_opt_get_error() then try to get the NTSTATUS
codes directly out of the krb5_error edata.

Guenther
2007-10-10 12:19:53 -05:00
Günther Deschner
9ec76c5427 r22479: Add "net ads keytab list".
Guenther
2007-10-10 12:19:37 -05:00
Jeremy Allison
7d30737c8d r22003: Fix from Jiri.Sasek@Sun.COM to wrap our krb5_locate_kdc
call as smb_krb5_locate_kdc to prevent incorrect linking
and crashes on Solaris.
Jeremy.
2007-10-10 12:18:59 -05:00
Jeremy Allison
1e32b44bfc r21846: Try and fix the Darwin build which seems to have a strange krb5.
Jeremy.
2007-10-10 12:18:37 -05:00
Jeremy Allison
c426340fc7 r21845: Refactor the sessionsetupX code a little to allow us
to return a NT_STATUS_TIME_DIFFERENCE_AT_DC error to
a client when there's clock skew. Will help people
debug this. Prepare us for being able to return the
correct sessionsetupX "NT_STATUS_MORE_PROCESSING_REQUIRED"
error with associated krb5 clock skew error to allow
clients to re-sync time with us when we're eventually
able to be a KDC.
Jeremy.
2007-10-10 12:18:37 -05:00
James Peach
c29c69d2df r21778: Wrap calls to krb5_get_init_creds_opt_free to handle the different
calling convention in the latest MIT changes.  Apparantly Heimdal
is also changing to this calling convention.
2007-10-10 12:18:32 -05:00
Günther Deschner
7e1a84b722 r21240: Fix longstanding Bug #4009.
For the winbind cached ADS LDAP connection handling
(ads_cached_connection()) we were (incorrectly) assuming that the
service ticket lifetime equaled the tgt lifetime. For setups where the
service ticket just lives 10 minutes, we were leaving hundreds of LDAP
connections in CLOSE_WAIT state, until we fail to service entirely with
"Too many open files".

Also sequence_number() in winbindd_ads.c needs to delete the cached LDAP
connection after the ads_do_search_retry() has failed to submit the
search request (although the bind succeeded (returning an expired
service ticket that we cannot delete from the memory cred cache - this
will get fixed later)).

Guenther
2007-10-10 12:17:50 -05:00
Günther Deschner
ea38e1f836 r21110: Fix kinit with Heimdal (Bug #4226).
Guenther
2007-10-10 12:17:38 -05:00
Gerald Carter
4fb57bce87 r21046: Backing out svn r20403 (Andrew's krb5 ticket cleanup
as this is causing the WRONG_PASSWORD error in the SetUserInfo()
call during net ads join).

We are now back to always list RC4-HMAC first if supported by
the krb5 libraries.
2007-10-10 12:17:29 -05:00
Andrew Bartlett
0b72c04906 r20403: Cleaning out my Samba 3.0 tree:
As discussed with jerry at the CIFS conf: overriding the
administrator's wishes from the krb5.conf has only every given me
segfaults.  We suggest leaving this up to the defaults from the
libraries anyway.

Andrew Bartlett
2007-10-10 12:16:47 -05:00
Gerald Carter
f53983079b r19939: ,fix compile warning about unused functions when not using heimdal 2007-10-10 12:16:11 -05:00
Günther Deschner
b076c39b6a r19416: Fix some c++ warnings.
Guenther
2007-10-10 12:15:33 -05:00
Stefan Metzmacher
a813c75955 r19374: fix the build with heimdal
metze
2007-10-10 12:15:32 -05:00
Stefan Metzmacher
785ab128c4 r19291: this should fix the build on heimdal systems
metze
2007-10-10 12:15:28 -05:00
James Peach
9b8e179fcc r19270: Stop depending on internal MIT symbols. These are private on MacOS
x, so we can't get at them even if we wanted to.

Kerberos experts, please take a look to make sure I've done the
right thing!
2007-10-10 12:15:27 -05:00
Stefan Metzmacher
d91041d4b6 r19237: fix typo
metze
2007-10-10 12:15:24 -05:00
Gerald Carter
1a58745886 r17162: Fix typo small typos noticed by Paul Green. 2007-10-10 11:38:17 -05:00
Volker Lendecke
083ef11cc9 r16960: Some warnings from host "opi" 2007-10-10 11:19:15 -05:00
Jeremy Allison
9dafb7f48c r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
2007-10-10 11:19:14 -05:00
Günther Deschner
546710d58c r16269: Fix the build.
Guenther
2007-10-10 11:17:29 -05:00
Günther Deschner
535d03cbe8 r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls.
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.

I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.

Guenther
2007-10-10 11:17:29 -05:00
Günther Deschner
10e4211755 r15243: Sorry for the breakage:
* Fix the build without kerberos headers
* Fix memleak in the krb5_address handling

Guenther
2007-10-10 11:16:30 -05:00
Günther Deschner
8b2ba11508 r15240: Correctly disallow unauthorized access when logging on with the
kerberized pam_winbind and workstation restrictions are in effect.

The krb5 AS-REQ needs to add the host netbios-name in the address-list.

We don't get the clear NT_STATUS_INVALID_WORKSTATION code back yet from
the edata of the KRB_ERROR but the login at least fails when the local
machine is not in the workstation list on the DC.

Guenther
2007-10-10 11:16:29 -05:00
Jeremy Allison
bea87e2df4 r15216: Fix the build for machines without krb5. Oops, sorry.
Jeremy.
2007-10-10 11:16:29 -05:00
Jeremy Allison
37ab42afbc r15210: Add wrapper functions smb_krb5_parse_name, smb_krb5_unparse_name,
smb_krb5_parse_name_norealm_conv that pull/push from unix charset
to utf8 (which krb5 uses on the wire). This should fix issues when
the unix charset is not compatible with or set to utf8.
Jeremy.
2007-10-10 11:16:28 -05:00
Günther Deschner
aae8f8ae7a r14506: Remove remaining references to a KCM credential cache type.
Guenther
2007-10-10 11:15:35 -05:00
Volker Lendecke
26377b63a3 r14218: Fix Coverity Bug # 2 2007-10-10 11:15:17 -05:00
Gerald Carter
17e63ac4ed r13316: Let the carnage begin....
Sync with trunk as off r13315
2007-10-10 11:06:23 -05:00
Günther Deschner
088abfcdd1 r13020: Prevent cli_krb5_get_ticket of getting into an infite loop. This whole
area of code needs to be reworked later on.

Guenther
2007-10-10 11:06:10 -05:00
Jeremy Allison
9d2f2385ad r13012: Fix #3421 - it turns out krb5_kt_get_entry() on MIT
does an implicit open/read/close and blows away an
open keytab handle - so make sure we use a new
handle.
Wonderful analysis from Luke <ldeller@xplantechnology.com>
helped fix this.
Jeremy.
2007-10-10 11:06:10 -05:00
Volker Lendecke
d92c83aa42 r11551: Add a few more initialize_krb5_error_table 2007-10-10 11:05:20 -05:00