1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00

303 Commits

Author SHA1 Message Date
Volker Lendecke
b679dda6c9 Fix bogus uninitialized variable warnings
(This used to be commit 71d6580c837adcc2cddcdff561f6fb09701501ee)
2008-01-25 21:20:39 +01:00
Volker Lendecke
587cf54c61 strtok -> strtok_r
(This used to be commit fd34ce437057bb34cdc37f4b066e424000d36789)
2008-01-23 15:08:04 +01:00
Jeremy Allison
e2ae63bcf7 Make all the tools use the proper accessor functions.
Jeremy.
(This used to be commit 6d61bb87975839adb25c304e5e5041f91b12d236)
2007-12-06 18:58:01 -08:00
Jeremy Allison
1b92ea5559 Remove pstrings from client/client.c by doing a large rewrite.
Mostly compiles....
Jeremy.
(This used to be commit c87f3eba9aa52f4ab25d77e2167262bf5c43b1a6)
2007-12-06 17:16:33 -08:00
Volker Lendecke
f4e4df66e7 Fix some C++ warnings
I think were are actually bugs.
(This used to be commit 1be19f07889ae09f79030f1ff8f2cf5e9a3d9dc5)
2007-12-01 10:43:11 -08:00
Jeremy Allison
c049b8157d More trivial pstring removal.
Jeremy.
(This used to be commit bac3bb2f6e9e15b3a9a6a6511c484f8509918ca1)
2007-11-20 15:31:37 -08:00
Jeremy Allison
30191d1a57 RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-18 17:40:25 -07:00
Andrew Tridgell
5e54558c6d r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10 12:28:22 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10 12:28:20 -05:00
Jeremy Allison
79de0ad946 r22588: Make all uses of TALLOC_MEMDUP consistent.
Jeremy.
(This used to be commit 8ad13718af0ba1fcb10a6f1631b1ed3cb8d11175)
2007-10-10 12:19:48 -05:00
Jeremy Allison
7f8d89bc54 r22062: Fix the parsing of info level 3. Flags is not a flags
field, but an offset. Fixed 64-bit display of ACLs on
printers.
Jeremy.
(This used to be commit 0c8949ff5d742dbe59f2af0f57a289f238e3592c)
2007-10-10 12:19:07 -05:00
Volker Lendecke
ecf90c495e r19991: Sorry for this 2000-liner...
The main thing here is a rewrite of srv_winreg_nt.c. The core functionality
has moved to registry/reg_api.c which is then usable by the rest of Samba as
well.

On that way it fixes creating keys with more than one element in the
path. This did not work before.

Two things that sneaked in (sorry :-) is the change of some routines from
NTSTATUS to WERROR the removed "parent" argument to regkey_open_internal.

Volker
(This used to be commit fea52801de8c7b85c578d200c599475680c5339f)
2007-10-10 12:16:18 -05:00
Volker Lendecke
202f63e476 r19811: Decode REG_MULTI_SZ and REG_BINARY
(This used to be commit 679330175185f8504bb5968339dcc7cb20d9140c)
2007-10-10 12:15:57 -05:00
Volker Lendecke
e23781b3b3 r17316: More C++ warnings -- 456 left
(This used to be commit 1e4ee728df7eeafc1b4d533240acb032f73b4f5c)
2007-10-10 11:38:25 -05:00
Jeremy Allison
fbdcf2663b r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need
to do the upper layer directories but this is what
everyone is waiting for....

Jeremy.
(This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10 11:19:14 -05:00
Jeremy Allison
3c9a5c7b58 r16654: Fix bug #3893 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 787539489897e79d43eb1833db6f5969b130c934)
2007-10-10 11:19:06 -05:00
Volker Lendecke
8961048d24 r16339: Fix Klocwork ID
277 278     (cmd_*)

485 487 488 (ldap.c)

Volker
(This used to be commit 5b1eba76b3ec5cb9b896a9a5641b4d83bdbdd4cf)
2007-10-10 11:17:36 -05:00
Jeremy Allison
4f53350b43 r14833: Fix resource leak on error code path. Coverity #280.
Jeremy.
(This used to be commit b985bdcb87eeb70725f2d625a4ea5ec39bda1b94)
2007-10-10 11:15:50 -05:00
Gerald Carter
fb5362c069 r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()
macro which sets the freed pointer to NULL.
(This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10 11:10:14 -05:00
Jeremy Allison
d6a68f8739 r11454: Last 2 uninitialized warnings.
Jeremy.
(This used to be commit 5f10368ff0f5eae646533280a444dc091d732c0d)
2007-10-10 11:05:17 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a788c735e56d53d63265255830ec21208)
2007-10-10 11:05:02 -05:00
Gerald Carter
54abd2aa66 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
(This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10 11:04:48 -05:00
Gerald Carter
44707ad2e0 r9739: conver the reg_objects (REGSUBKEY_CTR & REGVAL_CTR) to use
the new talloc() features:

 Note that the REGSUB_CTR and REGVAL_CTR objects *must* be talloc()'d
 since the methods use the object pointer as the talloc context for
 internal private data.

 There is no longer a regXXX_ctr_intit() and regXXX_ctr_destroy()
 pair of functions.  Simply TALLOC_ZERO_P() and TALLOC_FREE() the
 object.

Also had to convert the printer_info_2->NT_PRINTER_DATA field
to be talloc()'d as well.  This is just a stop on the road to
cleaning up the printer memory management.
(This used to be commit ef721333ab9639cb5346067497e99fbd0d4425dd)
2007-10-10 11:03:25 -05:00
Volker Lendecke
3fb3361266 r9200: Add support for REG_BINARY to rpcclient getdata and setprinterdata.
Volker
(This used to be commit 9e94ba54b0581e4b7636e70f309af6394de6edbf)
2007-10-10 11:00:27 -05:00
Volker Lendecke
6d1f86d3f6 r9189: Add the capability to set different registry value types (string, dword and
multistring) using setprinterdata. In multistring zero-length strings need to
be specified by "NULL", which is a bit crappy. But poptParseArgvString seems
to eat '' strings. Fix that in getdata as well.

Volker
(This used to be commit df85b41462be6367eb0e932fe9de589f72cc5ea2)
2007-10-10 11:00:27 -05:00
Günther Deschner
8ea8a78abc r9076: fix two other issues invented along the
cli_spoolss_enumprinterkey-changes.

Guenther
(This used to be commit db8fce2e05bf1981866a7737703ad414ea91febc)
2007-10-10 11:00:24 -05:00
Gerald Carter
0d40d4f8db r8900: fix typo thyat broke compile in my last commit
(This used to be commit 0b9faafe402137f28f99ceb5a2e6f930d2136224)
2007-10-10 11:00:19 -05:00
Gerald Carter
14a9d52832 r8899: various compiler warning fixes reported by Jason Mader <jason@ncac.gwu.edu>
(This used to be commit d8ae9f2b3e5387ef2c4e84cd9c33f4a7c795b0d3)
2007-10-10 11:00:19 -05:00
Gerald Carter
ecafd3754f r8654: merging cli_spoolss_XX() updates from trunk
(This used to be commit cd961e50a3029898868d21263ccacb7d5f1f07b9)
2007-10-10 11:00:14 -05:00
Gerald Carter
0dbdb7f662 r5944: cleaning up compiler warnings reported by Jason Mader
(This used to be commit 8f87d9c5b66bfbbb1c2eb409bc424fa730b66ff0)
2007-10-10 10:56:10 -05:00
Günther Deschner
416cf9886a r5891: Make enum- and getform use the same form_display-function.
Guenther
(This used to be commit dec1ab360691d628cb83c7efdef55ea0447f6558)
2007-10-10 10:56:07 -05:00
Günther Deschner
ee049ef614 r5760: Be more verbose on listing forms.
Guenther
(This used to be commit 0f25c35fb9a658f4593bc0ce47a9276e81233e65)
2007-10-10 10:56:00 -05:00
Gerald Carter
5ee2170519 r4966: don't enumerate the drivers for the same architecture string more than once
(This used to be commit c488ce9934aaf640c3f63cbdabc3110b8cf70fae)
2007-10-10 10:55:09 -05:00
Jeremy Allison
acf9d61421 r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
(This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10 10:53:32 -05:00
Günther Deschner
784832d2e0 r3649: Fix a couple of rpcclient spoolss commands (setprinter, setprintername,
getdriver) w.r.t to printer-naming scheme.

Guenther
(This used to be commit 968c3fc416e836c3958a068df7b4599682028a99)
2007-10-10 10:53:11 -05:00
Günther Deschner
d7bbbb28bd r3645: Allow deldriverex in rpcclient to delete drivers for a specific
architecture and a specific version.

Guenther
(This used to be commit a24df09386f177e625fb99c975896cbe7a594b4b)
2007-10-10 10:53:11 -05:00
Gerald Carter
2d0f5486f0 r3639: patch from Martin Zielinski <mz@seh.de> to add DeleteDriverEx() function to rpcclient
(This used to be commit cfd51c02447f7b42cffcaf4cc6179237d58c8229)
2007-10-10 10:53:11 -05:00
Günther Deschner
31afaeeb81 r3627: Allow to add dummy-form in rpcclient.
Guenther
(This used to be commit 11622805fb946b7b022d06ec4a85db2bfbf71f12)
2007-10-10 10:53:10 -05:00
Günther Deschner
2d016a67b8 r2821: Adding "Windows x64" as architecture string and driverdir "x64" for the
64bit AMD platform.

(This used to be "Windows AMD64" and "AMD64" in one of the release
candidates of SP2 for Windows XP. AMD64 is obviously still supported but
not documented.)

Guenther
(This used to be commit cc5892f0411b8eb5daebe746164a2cf21d3d4c68)
2007-10-10 10:52:53 -05:00
Gerald Carter
278f9467f2 r2133: Several fixes:
* BUG 1627: fix for NIS compiles on HPUX 11.00, AIX 4.3 and 5.1
  patch from Olaf Flebbe <o.flebbe@science-computing.de>.
  Will need to watch this one in the build farm.

* Fix bug found by rwf@loonybin.net where the PRINT_ATTRIBUTE_PUBLISHED
  was getting reset by attempts to sanitize the defined attributes
  (PRINTER_ATTRIBUTE_SAMBA)

* Resolve name conflict on DEC OSF-5.1 (inspired by patch from
  Adharsh Praveen <rprav@india.hp.com>)

* Work around parsing error in the print change notify code
  (not that the alignment bug is still there but reording the
   entries in the array works around it).

* remove duplicate declaration of getprintprocdir from rpcclient.
(This used to be commit 7474c6a446037f3ca2546cb6984d800bfc524029)
2007-10-10 10:52:32 -05:00
Günther Deschner
bf645415f6 r2073: Adding getprinter level 7 to rpcclient.
Is there any other rpc-call to get the guid of a published printer?

Guenther
(This used to be commit 944ad569c7a88e1d2f14311eed10f80ea9861963)
2007-10-10 10:52:30 -05:00
Günther Deschner
93c20b30e4 r2009: compile-fix for #1626 (spotted by Olaf Flebbe
<o.flebbe@science-computing.de>).

Guenther
(This used to be commit 2e954709de6d0048fafc653b0d70af05cdb0d3c2)
2007-10-10 10:52:27 -05:00
Günther Deschner
60727acc3b r1692: first commit :)
* add IA64 to the architecture table of printer-drivers

* add new "net"-subcommands:

  net rpc printer migrate {drivers|printers|forms|security|settings|all}
        [printer]
  net rpc share migrate {shares|files|all} [share]

  this is the first part of the migration suite. this will will (once
  feature-complete) allow to do 1:1 server-cloning in the best possible way by
  making heavy use of samba's rpc_client-functions. all migration-steps
  are implemented as rpc/smb-client-calls; net communicates via rpc/smb
  with two servers at the same time (a remote, source server and a
  destination server that currently defaults to the local smbd). this
  allows e. g. printer-driver migration including driverfiles, recursive
  mirroring of file-shares including file-acls, etc. almost any migration
  step can be called with a migrate-subcommand to provide more flexibility
  during a migration process (at the cost of quite some redundancy :) ).

  "net rpc printer migrate settings" is still in a bad condition (many
  open questions that hopefully can be adressed soon).

  "net rpc share migrate security" as an isolated call to just migrate
  share-ACLs will be added later.

  Before playing with it, make sure to use a test-server. Migration is a
  serious business and this tool-set can perfectly overwrite your
  existing file/print-shares.

* along with the migration functions had to make I the following
  changes:

        - implement setprinter level 3 client-side

        - implement net_add_share level 502 client-side

        - allow security descriptor to be set in setprinterdata level 2
          serverside

guenther
(This used to be commit 8f1716a29b7e85baf738bc14df7dabf03762f723)
2007-10-10 10:52:19 -05:00
Gerald Carter
924ddbac48 r1361: patch from Guenther Deschner <gd@sernet.de> to ensure that REG_SZ values in the SetPrinterData actually get written in UNICODE strings rather than ASCII
(This used to be commit 29000c1f800c35d5434b39b7c76fe7f10afaaecc)
2007-10-10 10:52:07 -05:00
Volker Lendecke
7984ec9edb r1237: Correctly honor infolevel argument. Thanks to Guenther Deschner <gd@sernet.de>.
Volker
(This used to be commit fece76cfc2f268d2855944d8a71d0aca3f99e0fb)
2007-10-10 10:52:01 -05:00
Volker Lendecke
b76daee923 r1101: Implement 'rpcclient setprintername'.
Thanks to Guenther Deschner <gd@sernet.de>.

This needs to be generalized somewhat. Jerry, which of the parameters in the
printer_info_2 struct are settable via cli_spoolss_setprinter?

Volker
(This used to be commit 473dd03833f5b742499750c5f3c91ea515c78f7e)
2007-10-10 10:51:55 -05:00
Tim Potter
80bbfbaf44 Fix comment.
(This used to be commit a999f7f23fc68e51dd04f1c5a2c84f19d5c4a0a5)
2003-12-07 10:48:31 +00:00
Tim Potter
36d534ef74 Patch from James Henstridge to allow rpcclient adddriver command to specify
printer driver version.  Closes bug #514.
(This used to be commit c5865e3dfe0166a4714129a3ddfe1c39218e28f0)
2003-11-05 16:40:13 +00:00
Jeremy Allison
cc88a03cd0 Fixed typo spotted by Daniel Jarboe <daniel.jarboe@custserv.com>.
Jeremy.
(This used to be commit 89d42685b706233ab31734764e2e641834af3675)
2003-10-20 21:02:08 +00:00
Jeremy Allison
d3b9384308 Fix for #480. Change the interface for init_unistr2 to not take a length
but a flags field. We were assuming that 2*strlen(mb_string) == length of ucs2-le string.
This is not the case. Count it after conversion.
Jeremy.
(This used to be commit f82c273a42f930c7152cfab84394781744815e0e)
2003-09-25 21:26:16 +00:00