1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-19 23:17:05 +03:00

35 Commits

Author SHA1 Message Date
Matthew DeVore
232054c09b lib/util: remove extra safe_string.h file
lib/util/safe_string.h is similar to source3/include/safe_string.h, but
the former has fewer checks. It is missing bcopy, strcasecmp, and
strncasecmp.

Add the missing elements to lib/util/safe_string.h remove the other
safe_string.h which is in the source3-specific path. To accomodate
existing uses of str(n?)casecmp, add #undef lines to source files where
they are used.

Signed-off-by: Matthew DeVore <matvore@google.com>
Reviewed-by: David Mulder <dmulder@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Aug 28 02:18:40 UTC 2020 on sn-devel-184
2020-08-28 02:18:40 +00:00
Swen Schillig
a16477e6e6 registry: Free memory at the end of each loop run to prevent mem leak
Found during torture test runs with enable address-sanitizer.

Signed-off-by: Swen Schillig <swen@linux.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Aug  8 06:44:12 UTC 2019 on sn-devel-184
2019-08-08 06:44:12 +00:00
Günther Deschner
b0d21f44e5 werror: replace WERR_GENERAL_FAILURE with WERR_GEN_FAILURE in source4/lib/registry/
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:21 +02:00
Günther Deschner
70807a4267 werror: replace WERR_BADFILE with WERR_FILE_NOT_FOUND in source4/lib/registry/
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2016-09-28 00:04:17 +02:00
Michael Adam
2d8a3125f2 s4:registry:patchfile: fix O3 error unused result of write
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
2016-05-13 00:16:15 +02:00
Volker Lendecke
f6a75cf4d1 registry: Fix CID 240989 Buffer not null terminated
This makes it clearer that we don't really have a string in .hdr

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
2015-03-10 21:48:03 +01:00
Jelmer Vernooij
f9ca9e46ad Finish removal of iconv_convenience in public API's. 2010-05-18 11:45:30 +02:00
Matthias Dieter Wallnöfer
0b7bb7f85a s4:registry - "patchfile_preg.c" - use more "sizeof"s on length specification
This makes the code more clear to read.
2010-04-10 19:58:09 +02:00
Matthias Dieter Wallnöfer
458a441f7f s4:registry - "patchfile_preg.c" - fix indentation 2010-04-10 19:58:08 +02:00
Matthias Dieter Wallnöfer
c7c8f0ccf3 s4:registry - "patchfile_preg.c" - fix a datatype
This should be an "uint16_t" (only two bytes are written).
2010-04-10 19:58:08 +02:00
Matthias Dieter Wallnöfer
0a154b940d s4:registry - "patchfile_preg.c" - assign a better type to the "i" counter variable
The "i" variable sums up "size" values which are of type "size_t". Therefore
also "i" itself should be from this type.
2010-04-08 23:57:35 +02:00
Matthias Dieter Wallnöfer
aa9e782a4d s4:registry - "patchfile_preg.c" - make a SIVAL statement nicer 2010-04-08 23:57:34 +02:00
Matthias Dieter Wallnöfer
e2aec9d81f s4:registry - "patchfile_preg.c" - fix the read operation of the data length on big-endian platforms 2010-04-08 12:27:27 +02:00
Matthias Dieter Wallnöfer
2164ba51e2 s4:registry - "patchfile_preg.c" - use "sizeof(uint32_t)" for some size specifications
Looks nicer.
2010-04-08 12:27:27 +02:00
Matthias Dieter Wallnöfer
6f7f16dc80 s4:registry - "patchfile_preg.c" - also here don't accumulate the memory usage
Free always the unused stuff.
2010-03-22 12:26:40 +01:00
Andrew Tridgell
5ab6a8d077 s4-registry: fixed byte order assumptions
the registry tests were broken on big-endian systems
2010-02-07 18:41:59 +11:00
Jelmer Vernooij
80420745ff Add a new non-convenience version of push_codepoint. 2009-04-23 17:50:18 +02:00
Stefan Metzmacher
4cb9ccd841 s4:lib/registry: fix c++ warnings
metze
2009-02-05 17:48:10 +01:00
Jelmer Vernooij
23302413b3 Remove unused include param/param.h. 2008-10-24 16:37:56 +02:00
Jelmer Vernooij
fd01b27edd Fix const.
(This used to be commit b74fc23825a54eb101b413ee76b21ee605dfb16c)
2008-04-15 22:19:05 +02:00
Wilco Baan Hofman
439f75f522 More patchfile fixes. Write support should work now.
(This used to be commit cc38f2f086b92bbe65bd6e7f4e03fdf7f21ef2f6)
2008-04-15 21:35:59 +02:00
Wilco Baan Hofman
5e687d7953 Fix PReg write support.
Add tests for patch files (.REG and PReg).
(This used to be commit 497977c36c621a4820be51cbcb7b78eac1e292b7)
2008-04-15 19:57:29 +02:00
Wilco Baan Hofman
0b8d2b3cb7 Fixed the patchfile tests and tidy up the patchfile backends.
(This used to be commit 6e9b1e35a269af2eda79356c1525f5413656d648)
2008-04-15 11:52:33 +02:00
Wilco Baan Hofman
212644b5a1 Attempt to fix the patchfile_preg backend for big endian machines.
Update some functions to properly state what is not supported (yet).
Registry .reg uses UCS-2, not UTF-16.
(This used to be commit 664a035dd9fc6e3b50a771baa98f8d79360cc4c1)
2008-04-14 12:48:25 +02:00
Jelmer Vernooij
5be50a222f Merge patchfile.h into registry.h
(This used to be commit 7b434df67aefc667993f0ebd955af9c1c258f153)
2008-04-02 13:58:05 +02:00
Andrew Kroeger
8f8c56bfbc Convert some more files to GPLv3.
(This used to be commit ebe5e8399422eb7e2ff4deb546338823e2718907)
2008-03-28 01:08:49 -05:00
Jelmer Vernooij
3101cb888d Remove uses of global_loadparm.
(This used to be commit a16c9a2129ce92e7e1a613b2badd168e42ead436)
2008-02-25 12:51:55 +01:00
Jelmer Vernooij
d891c0c74a r26429: Avoid use of global_smb_iconv_convenience.
(This used to be commit d37136b7abfbba75ef2e5ab855eb3382b9648b8c)
2007-12-21 05:49:56 +01:00
Kai Blin
46b54defe9 r26407: Janitorial: Remove a pstring and compiler warnings.
(This used to be commit bdc482033546e3986bf8c8b65dbf11c54dc57b8e)
2007-12-21 05:49:37 +01:00
Jelmer Vernooij
39ee38d9c1 r26316: Use contexts for conversion functions.
(This used to be commit f6420d933b5b011d428974f3a2a57edf19e6f482)
2007-12-21 05:48:30 +01:00
Günther Deschner
cc8f4eb3cd r25544: Cleanup some more indents in lib/registry.
Guenther
(This used to be commit 0d9826dc54057db2cfebcb806e5442c4dcf60daa)
2007-10-10 15:07:51 -05:00
Jelmer Vernooij
7e297ecfa4 r25047: Fix more warnings.
(This used to be commit 69de86d2d2e49439760fbc61901eb87fb7fc5d55)
2007-10-10 15:05:49 -05:00
Jelmer Vernooij
cd962355ab r25000: Fix some more C++ compatibility warnings.
(This used to be commit 08bb1ef643ab906f1645cf6f32763dc73b1884e4)
2007-10-10 15:05:27 -05:00
Jelmer Vernooij
6cf69fee18 r24994: Fix some C++ warnings.
(This used to be commit 925abf74fa1ed5ae726bae8781ec549302786b39)
2007-10-10 15:05:26 -05:00
Jelmer Vernooij
b409d4120f r24667: Finally merge the registry improvements that Wilco Baan Hofman and I have
been working on for at least half a year now. Contains the following
improvements:

 * proper layering (finally!) for the registry library. Distinction is
   now made between 'real' backends (local, remote, wine, etc) and
   the low-level hive backends (regf, creg, ldb, ...) that are only used
   by the local registry backend
 * tests for all important hive and registry operations
 * re-enable RPC-WINREG tests (still needs more work though, as
							   some return values aren't checked yet)
 * write support for REGF files
 * dir backend now supports setting/reading values, creating keys
 * support for storing security descriptors
 * remove CREG backend as it was incomplete, didn't match the data model
   and wasn't used at all anyway
 * support for parsing ADM files as used by the policy editor (see lib/policy)
 * support for parsing PREG files (format used by .POL files)
 * new streaming interface for registry diffs (improves speed and memory usage
	for regdiff/regpatch significantly)

   ... and fixes a large number of bugs in the registry code
(This used to be commit 7a1eec6358bc863dfc671c542b7185d3e39d7b5a)
2007-10-10 15:02:34 -05:00