1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-08 05:57:51 +03:00

119 Commits

Author SHA1 Message Date
Jeremy Allison
be5b4e2fa3 r9483: Changed DIR to SMB_STRUCT_DIR because of the amazing stupidity of a UNIX vendor
not understanding abstract data types :-(.
Jeremy.
2007-10-10 11:01:11 -05:00
Jeremy Allison
ac8f22a328 r9457: Attempt to fix bug #3010 by handling END_OF_DIRECTORY_OFFSET
consistently.
Jeremy.
2007-10-10 11:01:11 -05:00
Jeremy Allison
31104e5bcf r9286: Fix false positive found by Coverity - wcard must not be null.
Jeremy.
2007-10-10 11:00:31 -05:00
Jeremy Allison
217cc66e46 r8689: Fixes bugid #2889 for sure. Turns out the OS/2 dos box doesn't like two offsets
to be identical. Make offsets for . and .. different (and explicit).
Jeremy.
2007-10-10 11:00:15 -05:00
Jeremy Allison
a3ceabf7c6 r8655: Still trying to fix #2889. We don't need the DPTR_MASK after
all, now thinking it might be to do with flags2...
Jeremy.
2007-10-10 11:00:14 -05:00
Jeremy Allison
99dae22dcf r8610: If I'm going to do a debug level zero, at least make it useful.
Jeremy.
2007-10-10 11:00:13 -05:00
Jeremy Allison
6415657942 r8609: Fix for bugid #2889. I think the problem is that the top 16 bits of the "server state" field must be
non-zero. As we're using the 32 bit field as an offset then normally this field
will be zero. W2K3 fills this field with a counter enumerating the number of
SMBsearch calls on this directory - starting at 1. Add back the 1<<31 bit flag
DPTR_MASK to ensure this is non-zero - with better checks on use.
Jeremy.
2007-10-10 11:00:13 -05:00
Jeremy Allison
c7fe18761e r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the torture
tests on this as it's very late NY time (just wanted to get this work
into the tree). I'll test this over the weekend....
Jerry - in looking at the difference between the two trees there
seem to be some printing/ntprinting.c and registry changes we might
want to examine to try keep in sync.
Jeremy.
2007-10-10 10:58:18 -05:00
Jeremy Allison
0f03a6bdcd r7893: Add in the extra parameters to opendir() to fix the large directory/insane app
problem. Rev vfs version. Doesn't change the normal codepath.
Jeremy.
2007-10-10 10:58:02 -05:00
Jeremy Allison
e9b8d23d61 r7842: With the patch I sent Steve yesterday this gives us complete POSIX pathnames.
ie. files containing : and \ can be accessed from Linux.
Jeremy.
2007-10-10 10:57:59 -05:00
Jeremy Allison
f397cc08b5 r7617: Fix for bug #2801 - delete veto files was broken with the new
large directory code.
Jeremy.
2007-10-10 10:57:16 -05:00
Jeremy Allison
7b6e907922 r7474: A *foul* and *disgusting* hack to ensure that, at the very lowest
level, . and .. are the first two entries returned when reading a
directory. This also means we can't seek to these offsets, but we
will never be doing that anyway (as far as I can think). The reason
we have to do this is that the NT4 explorer will happily display a
folder marked ".." as a clickable folder (and probably would display
"." as a clickable folder too) if these are not in positions zero
and one of the returned file list. W2K seems to have fixed this but
there are too many older systems out there... Never mind, more for
the "Undocumented CIFS talk", coming to a CIFS2005 conference near
you soon.... :-).
Jeremy.
2007-10-10 10:57:10 -05:00
Jeremy Allison
53c3a954ee r7210: Fix my own mistakes up, sorry.
Jeremy.
2007-10-10 10:57:05 -05:00
Jeremy Allison
0b6f87d5e1 r7200: Don't use memset, use SET_STAT_INVALID (has the same effect).
Jeremy.
2007-10-10 10:57:05 -05:00
Jeremy Allison
b1bfa9cb37 r6625: Remove another global variable left over from a long time ago (magic char).
Jeremy.
2007-10-10 10:56:47 -05:00
Jeremy Allison
5b86e3dcdf r6550: Move function make_dir_struct from util to dir.c
Jeremy.
2007-10-10 10:56:45 -05:00
Jeremy Allison
927681c8c4 r6548: Fix bug #2622 - remove DPTR_MASK as it makes no sense.
Jeremy.
2007-10-10 10:56:44 -05:00
Jeremy Allison
7c173dec2e r6473: Fix for bug #2644 - test for special files to be ignored was reversed.
Jeremy.
2007-10-10 10:56:41 -05:00
Jeremy Allison
a60fe9aba1 r6417: Strange old IRIX systems return -1 for telldir() when
end of directory reached. Don't check for that and bail
when reading directory entries as it's a valid value.
Excellent work from Cale Fairchild <cale@brocku.ca>
tracked this down.
Jeremy.
2007-10-10 10:56:41 -05:00
Herb Lewis
efea76ac71 r6225: get rid of warnings from my compiler about nested externs 2007-10-10 10:56:30 -05:00
Jeremy Allison
065ab9182d r6169: Fix bug #2563. Infinite loop on non-existant file with findnext.
Jeremy
2007-10-10 10:56:26 -05:00
Jeremy Allison
67f6473f50 r6044: Ensure the old search calls always ask mask_match to translate
patterns like ????????.??? - even if using an NT1 protocol.
Matches W2K3 behavior.
Jeremy.
2007-10-10 10:56:18 -05:00
Jeremy Allison
cf8949f684 r6022: Fix for bug #2533. Incorrect dir listings from OS/2 clients.
Jeremy.
2007-10-10 10:56:16 -05:00
Jeremy Allison
e32a58742e r5922: Fix for NASTY NASTY bug #2501. All my fault :-(. Brown paper bag time.
Stops Win98 from looping doing findnext on a singleton directory. More
testing very welcome.
Jeremy.
2007-10-10 10:56:09 -05:00
Jeremy Allison
1f988333ec r5843: Removed unused variable - pointed out by jason@ncac.gwu.edu in bugid #2460.
Jeremy.
2007-10-10 10:56:05 -05:00
Jeremy Allison
3da5006027 r5632: Fix infinite looping bug found by nasty BlueArc test :-).
When finding a singleton directory remember that we're
at the end and don't continuously return the same name.
Jeremy.
2007-10-10 10:55:51 -05:00
Jeremy Allison
76e1d90aef r5508: Typo - ZERO_STRUCT -> ZERO_STRUCTP.
Jeremy.
2007-10-10 10:55:43 -05:00
Jeremy Allison
c43bae306a r5183: Ensure we correctly set the per-connection "case_sensitive" setting.
Rename dptrs_open to the more correct dirhandles_open.
Remove old #if 1.
Jeremy.
2007-10-10 10:55:32 -05:00
Jeremy Allison
0b04dd9d0c r5160: First cut at refactoring of directory code to handle non-wildcard
directory match more efficiently. Passes RAW-SEARCH under valgrind but needs more
testing (which I'll do later today :-).
Jeremy.
2007-10-10 10:55:30 -05:00
Jeremy Allison
a38eeb765f r5154: Tidy up interface a little.
Jeremy.
2007-10-10 10:55:29 -05:00
Jeremy Allison
cfa8150fd9 r5152: Restructure the directory handling code, stop using void * pointers
that just allow the wrong pointer to be assigned :-) and make the
interface more consistent. Fix the FreeBSD directory problem. Last
thing to do is to add the "singleton" directory concept from James
Peach's code.
Jeremy.
2007-10-10 10:55:29 -05:00
Volker Lendecke
5f34139b68 r5096: Attempt to fix the build 2007-10-10 10:55:14 -05:00
Jeremy Allison
0af1d2f6f2 r5063: Shamelessly steal the Samba4 logic (and some code :-) for directory
evaluation. This stops us from reading the entire directory into
memory at one go, and allows partial reads. It also keeps almost
the same interface to the OpenDir/ReadDir etc. code (sorry James :-).
Next I will optimise the findfirst with exact match code. This speeds
up our interactive response for large directories, but not when a
missing (ie. negative) findfirst is done.
Jeremy
2007-10-10 10:55:13 -05:00
Jeremy Allison
620f2e608f r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
2007-10-10 10:53:32 -05:00
Jeremy Allison
ba473a5802 r2076: Removed old dir caching code - not being used now we have the
statcache anyway. New dir caching will be done on nanosecond
timestamps.
Jeremy.
2007-10-10 10:52:30 -05:00
Jeremy Allison
894cc6d162 r1085: Now it's had some proper user testing, merge in the deferred open fix. I'm
still doing more testing, but it fixes a behaviour that we've been wrong
on ever since the start of Samba.
Jeremy.
2007-10-10 10:51:54 -05:00
Jeremy Allison
ed653cd468 Added per-share parameter "store dos attributes". When set, will store
dos attributes in an EA. Based on an original patch from tridge, but
modified somewhat to cover all cases.
Jeremy.
-
Jeremy Allison
bee4b3348e Fix for special files being hidden from admins by Dmitry Butskoj <buc@odusz.elektra.ru>
Jeremy.
-
Jeremy Allison
183c9ed405 Change get_nt_acl() to include security_info wanted. Only return this.
This gets us closer to W2k+ in what we return for file ACLs. Fix horribly
broken make_sec_desc() that screwed up the size when given a SD with no
owner or group (how did it get this bad... ?).
Jeremy.
-
Alexander Bokovoy
c2689ed118 Prefix VFS API macros with SMB_ for consistency and to avoid problems with VFS_ macros at system side. We currently have one clash with AIX and its VFS_LOCK. Compiled and tested -- no new functionality or code, just plain rename of macros for yet-unreleased VFS API version. Needs to be done before a24 is out -
Alexander Bokovoy
91984ef5ca Fix VFS layer:
1. Finally work with cascaded modules with private data storage per module
2. Convert VFS API to macro calls to simplify cascading
3. Add quota support to VFS layer (prepare to NT quota support)

Patch by Stefan (metze) Metzemacher, with review of Jelmer and me
Tested in past few weeks. Documentation to new VFS API for third-party developers to follow
-
Tim Potter
8fe5bab565 Whitespace syncup. -
Andrew Bartlett
10b53d7c6f Merge from HEAD:
- Make ReadDirName return a const char*.

 - Consequential changes from that

 - mark our fstring/pstring assumptions in function prototypes

Andrew Bartlett
-
Gerald Carter
4aa611958e don't forget the NULL -
Gerald Carter
e1b21381f3 and the winner of "i should have just written it in assembly
is..."

don't use pstrcpy() when you are not dealing with pstrings.
-
Gerald Carter
9b0a49a0bc don't pass NULL pointers to strcmp() -
Andrew Bartlett
c1cfc296c2 Cleanups: (merge from HEAD)
- use safe_strcpy() instead of pstrcpy() for malloc()ed strings

 - CUPS: a failure in an attempt to automaticly add a printer is not level 0 stuff.

 - Fix up a possible Realloc() failure segfault

Andrew Bartlett
-
Gerald Carter
c8266011b7 removing unused variable and unused file -
Jeremy Allison
62038a0abf Fix problem with "hide unreadable". stat file opens are baaack :-).
Jeremy.
-
Andrew Bartlett
3a7458f947 Merge from HEAD - make Samba compile with -Wwrite-strings without additional
warnings.  (Adds a lot of const).

Andrew Bartlett
-