Andrew Tridgell
f455772b99
s3-winbind: another strlcpy()/fstring fix
...
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri May 6 07:50:33 CEST 2011 on sn-devel-104
2011-05-06 07:50:33 +02:00
Andrew Tridgell
2fc8ad8887
s3-auth: fixed bug with usernames longer than sizeof(char *)
...
using sizeof(user) when user is "fstring user" as a C parameter
actually returns sizeof(char *), which means that long usernames
aren't allowed.
Jeremy, you need a longer username :-)
Cheers, Tridge
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-06 14:49:47 +10:00
Jeremy Allison
153a091d9c
Fix const in smbtorture.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 6 02:45:00 CEST 2011 on sn-devel-104
2011-05-06 02:45:00 +02:00
Jeremy Allison
a5a84415e2
Fix broken interface to set_namearray() - don't modify incoming string.
2011-05-06 01:44:07 +02:00
Jeremy Allison
bb00bdbe8f
Fixup use of const.
2011-05-06 01:44:07 +02:00
Jeremy Allison
7d6ebe0de7
More const fixes. Remove CONST_DISCARD.
2011-05-06 01:44:07 +02:00
Jeremy Allison
76f5a39c7f
Change the char * pointers in the struct to const char * (which is how they're treated).
2011-05-06 01:44:07 +02:00
Jeremy Allison
9eee6e2fd2
More const fixes... getting near the end now.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 6 00:57:00 CEST 2011 on sn-devel-104
2011-05-06 00:57:00 +02:00
Jeremy Allison
f85e095dd2
More simple const fixups.
2011-05-05 23:56:08 +02:00
Jeremy Allison
02af307585
More simple const fixes.
2011-05-05 23:56:07 +02:00
Jeremy Allison
e131c94ac1
More const fixes for compiler warnings from the waf build.
2011-05-05 23:56:07 +02:00
Jeremy Allison
38492b16fe
Fixup build without --with-aio.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu May 5 21:38:23 CEST 2011 on sn-devel-104
2011-05-05 21:38:23 +02:00
Jeremy Allison
9efea96d16
More const compiler warning fixes.
2011-05-05 11:29:01 -07:00
Jeremy Allison
4f41be356a
Fix many const compiler warnings.
2011-05-05 10:41:59 -07:00
Jeremy Allison
10a628b6e1
Don't reuse a non-const pointer when manipulating const.
2011-05-05 10:41:40 -07:00
Volker Lendecke
1c407da7c3
s3: Fix a typo
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 5 16:10:35 CEST 2011 on sn-devel-104
2011-05-05 16:10:35 +02:00
Volker Lendecke
82b9fa3a19
s3: Fix dup_smb2_vec3
...
Metze, Jeremy, please check!
Thanks,
Volker
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 5 13:39:40 CEST 2011 on sn-devel-104
2011-05-05 13:39:40 +02:00
Andrew Tridgell
323c744571
s4-auth: removed the password combinations code in auth_unix
...
this code never did anything due to a typo, and was untested. We
should not be inluding a password cracker in Samba anyway.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu May 5 07:00:14 CEST 2011 on sn-devel-104
2011-05-05 07:00:14 +02:00
Günther Deschner
8563d5c384
s3-rpc_server: run minimal_includes.pl.
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 5 03:04:38 CEST 2011 on sn-devel-104
2011-05-05 03:04:38 +02:00
Günther Deschner
bd92826aa8
s3-rpc_client: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
c11d52c7f6
s3-rpcclient: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
c9f3a2c83e
s3-printing: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
62314da805
s3-param: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
ea8960448d
s3-libsmb: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
a05a59e8e2
s3-libnet: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
653b84d2d6
s3-libads: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:26 +02:00
Günther Deschner
63ebc918e4
s3-lib: run minimal_includes.pl.
...
Guenther
2011-05-05 02:05:26 +02:00
Günther Deschner
58db720e27
s3-auth: run minimal_includes.pl
...
Guenther
2011-05-05 02:05:26 +02:00
Matthieu Patou
7f36f3effa
s4-samba-tool: allow specification of targetdir when joining as (RO)DC
...
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Thu May 5 02:04:13 CEST 2011 on sn-devel-104
2011-05-05 02:04:13 +02:00
Jeremy Allison
1c714850d5
Clean up some const and other compiler warnings.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu May 5 00:59:40 CEST 2011 on sn-devel-104
2011-05-05 00:59:40 +02:00
Jeremy Allison
ff215f5c89
I added them, so I get to kill them :-). Finally remove all uses of safe_strcpy and safe_strcat. Change to strlcpy, strlcat.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 4 22:14:14 CEST 2011 on sn-devel-104
2011-05-04 22:14:14 +02:00
Jeremy Allison
8380835fc6
Fix warning messages caused by addition of null check in fstrcpy macro.
2011-05-04 12:12:15 -07:00
Jeremy Allison
df023b8657
Tidy up some missing checks for NULL in strlcpy.
2011-05-04 12:12:15 -07:00
Jeremy Allison
a3e913ae8b
Add in bufflen limit when storing NetBIOS names. Remove safe_strcpy.
2011-05-04 12:12:15 -07:00
Jeremy Allison
6f7c4a0539
Convert safe_strXX to strlXXX. Clean up off-by-ones.
2011-05-04 12:12:15 -07:00
Jeremy Allison
0dcc75f2df
Remove magic numbers. Standardize on macro. Move from safe_strcat to strlcat.
2011-05-04 12:12:14 -07:00
Jeremy Allison
8ff244ec2d
Cope with +1 change on moving from safe_strcat to strlcat.
2011-05-04 12:12:14 -07:00
Jeremy Allison
2938fe6f90
Fold null terminator into listlen length, change to strlcpy.
2011-05-04 12:12:14 -07:00
Jeremy Allison
e4667926ce
Fix the only place we reply on the NULL handling for the source in safe_strcpy.
2011-05-04 12:12:14 -07:00
Jeremy Allison
18582016d9
Fix off-by-one when used with safe_strcpy.
2011-05-04 12:12:14 -07:00
Jeremy Allison
5c53d63348
sasl_secret_t ends in a char [1] size. This means the extra character is implicit in the safe_strcpy. When changing to strlcpy ensure we allocate an extra char for it. This fixes a bug where secret->len+1 used with safe_strcpy could actually write into secret->len+2.
2011-05-04 12:12:14 -07:00
Jeremy Allison
cabd9e70e2
Simple +1 changes in hardcoded lengths when changing from safe_strcpy to strlcpy.
2011-05-04 12:12:14 -07:00
Jeremy Allison
265338c194
BUGFIX when converting from safe_strcpy to strlcpy.
...
We must have a blob legth > 0 in order to safely copy
the (possibly) 16 bytes + 1 byte zero character safely.
2011-05-04 12:12:14 -07:00
Jeremy Allison
5fa6f390d1
Remove overmalloc_safe_strcpy - can be simple strlcpy.
2011-05-04 12:12:14 -07:00
Jeremy Allison
a2915089de
Remove obvious use of safe_strcpy + safe_strcat -> strlcpy + strlcat.
2011-05-04 12:12:14 -07:00
Jeremy Allison
0c464df22b
Change safe_strcpy_base to strlcpy_base. Note the size doesn't change here as the original macro auto-added the -1.
2011-05-04 12:12:14 -07:00
Jeremy Allison
017e0c8d95
Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1.
2011-05-04 12:12:13 -07:00
Volker Lendecke
deba880986
s3-torture: Add a test for notify upon read&x
...
This makes sure that when a file is brought online by a read call
we notify the client for FILE_NOTIFY_CHANGE_ATTRIBUTES.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May 4 21:09:22 CEST 2011 on sn-devel-104
2011-05-04 21:09:22 +02:00
Volker Lendecke
a491e8e8d3
Always build before commit ... :-)
2011-05-04 20:08:04 +02:00
Jeremy Allison
54727f9316
Remove unused function parse_add_domuser().
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 4 20:05:42 CEST 2011 on sn-devel-104
2011-05-04 20:05:42 +02:00