1
0
mirror of https://github.com/samba-team/samba.git synced 2025-11-28 12:23:49 +03:00
Commit Graph

10309 Commits

Author SHA1 Message Date
Stefan Metzmacher
26228e4b2e r18593: try to get the same socket_wrapper file building in samba3 and samba4
this is preparation of adding libreplace to samba3 later.

metze
2007-10-10 14:18:54 -05:00
Stefan Metzmacher
e9fe725cf4 r18592: we don't need this twice
metze
2007-10-10 14:18:53 -05:00
Simo Sorce
34ce1f8e1b r18591: Better defaults for share creation
Fix logic error in paged_results
2007-10-10 14:18:53 -05:00
Simo Sorce
2c035787d4 r18590: Some more work on the srvsvc pipe 2007-10-10 14:18:53 -05:00
Andrew Tridgell
ac71f40f8f r18589: make inclusion of net/if.h conditional. It breaks HPUX with gcc. 2007-10-10 14:18:53 -05:00
Andrew Tridgell
f6b65fd631 r18588: save one more character in the socket wrapper path - seems it still
was occasionally too long for IRIX 6.4
2007-10-10 14:18:53 -05:00
Andrew Tridgell
935f6f34cf r18587: fixed a potential memory leak in libnet 2007-10-10 14:18:52 -05:00
Andrew Tridgell
6d53f2f5bc r18586: fixed a potential fd and memory leak in the socket_wrapper code 2007-10-10 14:18:52 -05:00
Andrew Tridgell
fb5b8c4f8c r18585: 50 open searches is still too many for some of the build farm hosts,
which have a ulimit -n of 100. Drop the number of searches to 20.

That should limit the maximum total fd count to about 76, most of
which is all the listening sockets on the various interfaces
2007-10-10 14:18:52 -05:00
Andrew Tridgell
1c0a3de398 r18584: found one of the fd leaks. The registry backend was using a
talloc(NULL, xxx) to allocate the registry context. That had two
consequences

1) it was a massive memory leak, as all winreg operations leaked their
   entire context (including an open ldb database) every time

2) event_context_find() never found the exsting event context, so we
   used a new event context each time, which called epoll_create()
   each time, which caused a fd to be allocated
2007-10-10 14:18:52 -05:00
Andrew Tridgell
83bf458ec9 r18583: a nasty hack to allow me to monitor the number of open file
descriptors in smbd on all build farm machines. I suspect we have a fd
leak somewhere, but its hard to track down.

I know part of the problem is the number of (fake) network interfaces
we define in the build farm tests, with each of them listening on a
whole bunch of different protocol ports. That chews up around 48 file
descriptors just to startup. I don't think thats the real problem
though, and I suspect something else is leaking file descriptors on
some hosts.
2007-10-10 14:18:51 -05:00
Andrew Tridgell
ce2baf7385 r18582: disable synchronous ldb in the build farm. Some hosts have very slow
filesystems and the tests are taking more than 1.5 hours. We will
still be testing the sync code paths, as the ldb tests still run
synchronous, but doing all of our other tests synchronously just costs
too much time.
2007-10-10 14:18:51 -05:00
Andrew Tridgell
024ca6a91c r18581: also check for SEC_STD_DELETE, and split out the check into a separate
static function
2007-10-10 14:18:51 -05:00
Andrew Tridgell
ceffc34f3e r18580: map the PVFS_FLAG_READONLY bit in the posix backend onto
NT_STATUS_ACCESS_DENIED in the access mask checks
2007-10-10 14:18:51 -05:00
Andrew Tridgell
75dab73ac6 r18579: fixed boolean parameters on big endian hosts which have
sizeof(BOOL) != sizeof(int)

this broke with the conversion to a real BOOL type
2007-10-10 14:18:50 -05:00
Andrew Tridgell
fea75d2c97 r18578: steve, I think you may have forgotten to commit test_cifsposix.sh ? 2007-10-10 14:18:50 -05:00
Andrew Tridgell
3cee6a7863 r18577: reduce the number of tests run in 'make quicktest' again, so it
completes in a minute on my laptop (the benchmark I usually use).

Simo, I removed th ldb tests, as ldb is pretty well tested by lots of
the other tests, and its a pretty slow test. We could instead add a
"ldb-testquick.sh" which does only minimal testing. The full tests
will of course be run with 'make test' and in the build farm.
2007-10-10 14:18:50 -05:00
Andrew Tridgell
c2fc347102 r18576: unfortunately our current build farm results are a bit too good!
when I changed the test output to be easier to read, I also broke it
so that it always gives a zero exit status. Fix now, and unfortunately
I expect to see some more red in the farm as a result :(
2007-10-10 14:18:49 -05:00
Andrew Tridgell
da37e963ce r18575: - use the right variable to teststatus
- don't display the "(NN tests failed so far)" message unless a test
  has failed
2007-10-10 14:18:49 -05:00
Andrew Tridgell
5e143267d7 r18574: re-enable the echo pipe in smbscript. I suspect disabling this was an
accidental part of commit in the recent echo.idl changes (in r18565)
2007-10-10 14:18:49 -05:00
Andrew Tridgell
a57decb96a r18571: try to make it a lot more obvious when 'make test' or 'make quicktest'
has failed. The output was too subtle for people who aren't used to
it.
2007-10-10 14:18:48 -05:00
Steve French
64062d16a2 r18570: Fix up function names in cifs unix/posix extensions backend. Enable tiny quick test for torture for them 2007-10-10 14:18:48 -05:00
Andrew Tridgell
262bee07dc r18569: add really simple testing of the 'simple' ntvfs backend, so we know
when it breaks. It isn't much good as a template for developers to use
unless it works :-)
2007-10-10 14:18:48 -05:00
Andrew Tridgell
6784058923 r18568: this warning is not needed now that it is the job of the unixuid ntvfs
module to handle euid
2007-10-10 14:18:48 -05:00
Andrew Tridgell
7005806aa6 r18567: fixed the winreg js code for the new names of the fields in winreg.idl
When changing a field name in idl, please remember to check for use of
those functions in any js code as well.
2007-10-10 14:18:47 -05:00
Andrew Tridgell
555aed43ba r18566: fixed the winreg pipe and winreg tests
Jerry, there is a big difference on the wire between these two:

  [out] uint32 x;
and
  [out] uint32 *x;

if you change from

  [out] uint32 x;

then you need to change to:

  [out,ref] uint32 *x;

otherwise it changes the format on the wire, which means we are no
longer compatible with MS servers.

but be aware that even if you change to a ref ptr, you also need to
change all the client code to set all the return variables in the out
part of the structure. That's why I don't like the MIDL restriction of
forcing the use of ref pointers for output variables - it makes life
much harder when writing client code, and makes the code much more
error prone (just look at all the extra code needed to make this work
again).

I know we could auto-allocate these variables in the generated client
side NDR code, but if we did that then we would have no way of doing a
_real_ ref out pointer, which we really wanted to set to some already
allocated variable.

So please hold off on changing our idl to use the MIDL convention for
output variables until Jelmer and I have had a good "chat" about this :-)
2007-10-10 14:18:47 -05:00
Jelmer Vernooij
ab0a798c57 r18565: Fix echo.idl to be Samba3-, MIDL and midlc compatible 2007-10-10 14:18:47 -05:00
Steve French
57f5695717 r18564: update for cifs unix/posix extensions stub version to build and beginnings of smbtorture test for it 2007-10-10 14:18:47 -05:00
Andrew Tridgell
bde18f3d5c r18563: - move more of the header checks into lib/replace/
- change the test for net/if.h to do a full compile, not just an
  existance test. net/if.h is completely broken on hpux, and can never
  compile (it uses stuff before it defines it), so by using a
  AC_TRY_COMPILE() test we avoid using net/if.h on hpux, which should
  fix the build
2007-10-10 14:18:46 -05:00
Gerald Carter
694677dafe r18561: Fix [out] pointers in winreg IDL 2007-10-10 14:18:46 -05:00
Jelmer Vernooij
86b4624226 r18559: [string] always applies to the last pointer 2007-10-10 14:18:46 -05:00
Simo Sorce
4daf5f7764 r18558: Fix ShareCheck which was assuming all paths are "C:\"
Also cope with the fact that we define the FSTYPE as NTFS by default.
We never use this anywhere else, so we may just change it, but just
detect the fact and return DISK in share_classic for now.
2007-10-10 14:18:46 -05:00
Stefan Metzmacher
d9137edbdb r18555: use C:\ as default not C:
metze
2007-10-10 14:18:45 -05:00
Jelmer Vernooij
caac6cf817 r18554: Fix warnings about [out] arguments. 2007-10-10 14:18:45 -05:00
Stefan Metzmacher
04a0a5144a r18553: - confdefs.h is always included in configure checks no need to include them explicit
- undefine _XOPEN_SOURCE_EXTENDED for the AIX interface detection test
  #define _XOPEN_SOURCE_EXTENDED 1 brings in sa_len to sockaddr on Tru64
  which means the AIX code compiles...

metze
2007-10-10 14:18:45 -05:00
Simo Sorce
60076fa87d r18550: Return a path not just a disk drive 2007-10-10 14:18:45 -05:00
Stefan Metzmacher
888a769af5 r18549: move gcc version check to libreplace and reorder the tests a bit
for nicer output

metze
2007-10-10 14:18:45 -05:00
Stefan Metzmacher
8fa9852160 r18548: don't use #elif as we don't notice when 2 HAVE_IFACE_ versions are defined
try to find the problem on Tru64...where configure says the AIX method finds 1 interface
but later can't compile netif.c. (revision 18486 was the last that detects ifconf with 2 interfaces)

metze
2007-10-10 14:18:45 -05:00
Stefan Metzmacher
212fa7977d r18545: if yapp isn't availabe touch the target file, as it is commited to svn,
to prevent rebuilding.

we do

make everything
make everything
make bin/smbtorture
make test

in the buildfarm and rebuilding parts isn't that nice

metze
2007-10-10 14:18:44 -05:00
Stefan Metzmacher
1ea52d7584 r18544: - use AC_LIBREPLACE_LOCATION_CHECKS in samba4
- to get the ordering right we need to specify AC_CANONICAL_BUILD explicit
- add AC_CANONICAL_TARGET

metze
2007-10-10 14:18:44 -05:00
Simo Sorce
ae2f6d4a5a r18542: Some late nite work.
Now we can add and remove a share from the "Computer Management"
console (not yet modify!) usinf share backend = ldb
2007-10-10 14:18:44 -05:00
Andrew Tridgell
ce5d5a1872 r18541: with 100 old style searches we can run out of file descriptors on some
systems. drop to 50
2007-10-10 14:18:44 -05:00
Andrew Tridgell
1dfac46664 r18540: show the additional smbd output from each test, rather than only
showing on test failure and showing all the smbd output each time.
2007-10-10 14:18:43 -05:00
Andrew Tridgell
5a8becb1be r18539: 'make distclean' should delete config.cache 2007-10-10 14:18:43 -05:00
Andrew Tridgell
588c91f06b r18538: we need a pipe here, not a logical OR
also fix cn name for this record, and ensure tests/tmp is created
2007-10-10 14:18:43 -05:00
Andrew Tridgell
9afbd60f91 r18537: after testing for poptGetContext, if the test fails, don't try to use
the external popt (this affects hpisgr8)
2007-10-10 14:18:43 -05:00
Andrew Tridgell
fbe13ed83e r18536: fixed the loading of external binary files from ldif into ldb 2007-10-10 14:18:43 -05:00
Andrew Tridgell
823cd3ab35 r18535: move the AC_CANONICAL_HOST and host specific flag tests into
libreplace. This should fix the standalone build of tdb on HPUX, where
we need to blacklist mmap.

Unfortunately this requires that we have a copy of config.guess and
config.sub in each of our project subdirectories. I tried to find a
way to use something like AC_CONFIG_AUX_DIR($libreplacedir) and just
put config.{guess,sub} in the lib/replace/ directory, but I couldn't
figure out how to do that in a way that kept autoconf happy for each
of our separate builds. Any autoconf guru out there see a way to do
this?
2007-10-10 14:18:42 -05:00
Andrew Tridgell
95455b5789 r18528: work around what appears to be a compiler bug in gcc on irix. It
caused the RPC-SECRETS test to crash smbd in an inlined version of
this memcmp() call. This patch should have absolutely no effect at
all, but in fact it prevents the crash.

Disassembling at the point of the crash, it shows that gcc is inlining
the memcmp(). I don't know enough MIPS assembler to actually spot the
bug. In case anyone reading this does know MIPS assembler, here is the
gcc generated code that crashes:

0x105e0218 <gssapi_krb5_verify_header+168>:     lw      $t1,52($sp)
0x105e021c <gssapi_krb5_verify_header+172>:     lw      $t1,0($t1)
0x105e0220 <gssapi_krb5_verify_header+176>:     lhu     $t1,0($t1)
0x105e0224 <gssapi_krb5_verify_header+180>:     lw      $t2,68($sp)
0x105e0228 <gssapi_krb5_verify_header+184>:     lhu     $t2,0($t2)
0x105e022c <gssapi_krb5_verify_header+188>:     subu    $t1,$t1,$t2

it gets a segv at 0x105e0220.

lha, what do you think of this? The change should be innocuous on all
other platforms, apart from making the code harder to read :(
2007-10-10 14:18:42 -05:00
Jelmer Vernooij
0ee42669d3 r18524: Pre-allocate out arguments. 2007-10-10 14:18:42 -05:00