1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-08 04:58:40 +03:00

23 Commits

Author SHA1 Message Date
Jim McDonough
0e0d21dd3d r14408: More on fix for coverity #36. The previous fix would cause us to
marshall a buffer based on an unknown size.  Zero out the sec_desc
buffer to prevent this.  This is still not getting proper results for
a registry security descriptor (everything gets ACCESS DENIED), but
at least we aren't blowing out memory now...
(This used to be commit cb370cc28ce361628df137c9aef02739aca062db)
2007-10-10 11:15:29 -05:00
Jeremy Allison
fa42d65a47 r14406: Disable this call until we can sort out how this
should be done correctly. Fix coverity #37.
Jeremy.
(This used to be commit d241f74e06eac7b61e5b7e09c2b9a955ec560fec)
2007-10-10 11:15:29 -05:00
Jeremy Allison
e6676a9a69 r14387: Try and fix the coverity issues (#53, #54) with negative
sink by ensuring all uses of rpcstr_push are consistent
with a size_t dest size arg.
Jeremy.
(This used to be commit f65d7afe1977d9d85046732842f9643716c15088)
2007-10-10 11:15:27 -05:00
Simo Sorce
be738dd31d r14377: Fix coverity #4 for 3_0 too
(This used to be commit aa26642ee19dcf7cfa3cb36032eadc823b01966b)
2007-10-10 11:15:27 -05:00
Volker Lendecke
5c1e6f0a9e r14367: Not that I fully understand what's going on here, but the code as it was here
was clearly buggy as Coverity showed with bug id #36.

According to samba4 idl the sec_desc_buf is [in,out,ref], so we _have_ to ship
it in the request.

Volker
(This used to be commit 075e784491e6f2b491bd063db08ff1267f9cabbb)
2007-10-10 11:15:27 -05:00
Jeremy Allison
15603e1c2f r14261: Fix coverity #38. No null deref.
Jeremy.
(This used to be commit 2a2b966b7b92ac340d61ba157d207a42509a93d1)
2007-10-10 11:15:21 -05:00
Volker Lendecke
cdf4508058 r14224: Fix Coverity bug # 6
(This used to be commit e1c617adae51a4645804421394aba05de9dc1e3f)
2007-10-10 11:15:18 -05:00
Jeremy Allison
de106cf702 r14212: Definately fixes a coverity issue but I've lost track
of the coverity id.... Oh well - definately needs a fix.
Jeremy.
(This used to be commit 54c899ef3b82af612bc2dad450140c5f47d2332e)
2007-10-10 11:15:16 -05:00
Jeremy Allison
1e34c29596 r14196: Move to using talloc, not malloc for all policy handles.
Jeremy
(This used to be commit 6f4804a265f60c614e6e215ed663da0d8205c613)
2007-10-10 11:15:16 -05:00
Jeremy Allison
cfa4589662 r14194: Coverity bug #35. Fix uninitialized pipe_hnd.
Jeremy.
(This used to be commit 8aca76f03540f3df5a81ddab2588c1f8219ac550)
2007-10-10 11:15:16 -05:00
Jeremy Allison
5fe30d0f35 r14192: Don't forget to correctly initialize pipe_hnd.
Coverity fix #34.
Jeremy.
(This used to be commit 6b3dc96dcf9b14177abfd3c901bfb0baad8afa76)
2007-10-10 11:15:16 -05:00
Jeremy Allison
b96f20a316 r14190: Coverity bug #33. Missing initialization of pipe_hnd.
Jeremy.
(This used to be commit 144fda363793f233236a5e539daec64fa2966f3b)
2007-10-10 11:15:15 -05:00
Jeremy Allison
2992ba0690 r14188: Coverity fix #32. Don't deref null.
Jeremy.
(This used to be commit 218c924d91a09517909ab09668a3ba7a0c6cb305)
2007-10-10 11:15:15 -05:00
Jeremy Allison
cc122aa6ff r14186: Coverity fix #31. Don't deref null.
Jeremy.
(This used to be commit 014a3c86613f5c3fcbf12cd7df35c68bdce29331)
2007-10-10 11:15:15 -05:00
Günther Deschner
9f2e29799e r13864: Some cleanup and the samr set security object function client-side.
Guenther
(This used to be commit 0ae3fddf95a95ec8a2f4d52e1276c1721b33ddfd)
2007-10-10 11:10:57 -05:00
Gerald Carter
fb5362c069 r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()
macro which sets the freed pointer to NULL.
(This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10 11:10:14 -05:00
Jeremy Allison
6791180b81 r13491: Fix bug # 3498 from jason@ncac.gwu.edu. Unsigned comparison
with < 0.
Jeremy.
(This used to be commit 9a083837070c6540a9b92f6a055f8ecc23a32a49)
2007-10-10 11:10:06 -05:00
Gerald Carter
0af1500fc0 r13316: Let the carnage begin....
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10 11:06:23 -05:00
Jeremy Allison
8d7c886671 r11137: Compile with only 2 warnings (I'm still working on that code) on a gcc4
x86_64 box.
Jeremy.
(This used to be commit d720867a788c735e56d53d63265255830ec21208)
2007-10-10 11:05:02 -05:00
Gerald Carter
d77621c425 r11125: remove unused variables
(This used to be commit d404919d926be6bc4e21d7d5aaf2dfe795ba2726)
2007-10-10 11:05:01 -05:00
Gerald Carter
846d52efae r11124: Commit Chris' fixes for libmsrpc after the rpc_client
rewrite.  His comments:

        I've gotten the libmsrpc code to work with TRUNK.
        I've put the patch at:
        www.uoguelph.ca/~cnicholl/libmsrpc_trunk_v1.patch.gz

        It is from revision 11093.

        I also fixed a minor bug in the svcctl code, the timeout
        parameter for all the control functions was working
        in milliseconds instead of seconds.

Also fixed bug in Makefile when building libmsrpc.a
(This used to be commit d3a52900ec223316779e59a13cea87ecb500bccc)
2007-10-10 11:05:01 -05:00
Gerald Carter
945abd1cb7 r10005: forgot to remove one object file
(This used to be commit adba19fb48326bebf7c84b3f12658d0ce87475db)
2007-10-10 11:03:31 -05:00
Gerald Carter
3c6b0f9655 r10003: in the rush for 10k, I forgot to run add the rest of Chris' libmsrpc files
(This used to be commit 32bebc452dffa8348b94c5b866350b1fe761986f)
2007-10-10 11:03:30 -05:00