sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-12-06 16:23:49 +03:00
Code Activity
11,535 Commits 64 Branches 1,179 Tags
26901af91eaa119df0e1192be95b514ecf26c6a6
Commit Graph

23 Commits

Author SHA1 Message Date
Andrew Tridgell
8d45bf644a it is possible for some of the real time signals to be used by glibc, 
which then changes SIGRTMIN. It is also possible for bash to leave
some real time signals blocked at startup. This fixes both problems.
 -
Andrew Bartlett
f8d9880c5f Ensure we do not pass uninitialised data to the kernel. (Picked up by 
valgrind).

Andrew Bartlett
 -
Jeremy Allison
78df2c916a Fix fd leak with kernel change notify. 
Jeremy.
 -
Gerald Carter
29874f4b8f compile warngin fixes merged from 2.2 -
Jeremy Allison
db8932c297 Remove blocksignals call as it's never going to bloody work right... 
Jeremy.
 -
Jeremy Allison
b06862e2de Fix for Linux kernel bug where signal mask set within a signal handler 
is being ignored on sighandler exit. This means we have to have a small
array of fd's, not a single one.
Jeremy.
 -
Jeremy Allison
65742067e0 Fix different args to sys_fcntl without going varargs.... 
Jeremy.
 -
Jeremy Allison
c7ff521bab Added sys_fcntl (not to be used everywhere). Added sys_read/sys_write 
for transfer_file.
Jeremy.
 -
Tim Potter
6a58c9bd06 Removed version number from file header. 
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
 -
Tim Potter
2d0922b0ea Removed 'extern int DEBUGLEVEL' as it is now in the smb.h header. -
Simo Sorce
a95943fde0 move to SAFE_FREE() -
Andrew Tridgell
debb471267 The big character set handling changeover! 
This commit gets rid of all our old codepage handling and replaces it with
iconv. All internal strings in Samba are now in "unix" charset, which may
be multi-byte. See internals.doc and my posting to samba-technical for
a more complete explanation.
 -
Andrew Tridgell
e2ecff419f fixed usage of socklen_t and also tidied up SIG_ATOMIC_T, using a typedef instead of a define -
Tim Potter
88a7b2c3f8 More compiler warning fixes. -
Jeremy Allison
f952380c5d utils/torture.c: Added one more delete on close test. 
smbd/notify_kernel.c: This code was wrong I believe. It was structured to only
return a changenotify event on being called from timeout processing (t != 0).
The kernel changenotify events should fire on *asynchronous* processing (EINTR
return from select caused by the realtime signal delivery) with t == 0.
Reported by Juergen Hasch (Hasch@t-online.de).
ANDREW PLEASE CHECK THIS !
Currently the hash style changenotify is done on async processing as well
as timeout processing. As this is expensive we may want to revisit doing this
and maybe set it to fire only on timeout processing.
Jeremy.
 -
Jeremy Allison
0be41d5158 Merge of new 2.2 code into HEAD (Gerald I hate you :-) :-). Allows new SAMR 
RPC code to merge with new passdb code.
Currently rpcclient doesn't compile. I'm working on it...
Jeremy.
 -
Jeremy Allison
07dffc4ee9 Fix to allow a timestamp of zero to cause an instantaneous changenotify 
scan - then call this from renames. This allows instantaneous update for
W2k renames.
Jeremy.
 -
Jeremy Allison
b737c784e3 Paranoia changes to ensure that anything touched by a signal handler 
and the main code is declared as VOLATILE SIG_ATOMIC_T.
Jeremy.
 -
Andrew Tridgell
b1441d9622 allow the notify implementation to choose the select timeout change -
Andrew Tridgell
9f542484d1 use DN_ATTRIB kernel change notify attribute -
Andrew Tridgell
20a06b7fb7 always use the DN_CREATE mask (NT expects file creation always to 
cause a notify)
 -
Andrew Tridgell
c6be511fcc enable the Linux change notify code and change some notify debug code -
Andrew Tridgell
44766c39e0 totally rewrote the async signal, notification and oplock notification 
handling in Samba. This was needed due to several limitations and
races in the previous code - as a side effect the new code is much
cleaner :)

in summary:

- changed sys_select() to avoid a signal/select race condition. It is a
  rare race but once we have signals doing notification and oplocks it
  is important.

- changed our main processing loop to take advantage of the new
  sys_select semantics

- split the notify code into implementaion dependent and general
  parts. Added the following structure that defines an implementation:

struct cnotify_fns {
	void * (*register_notify)(connection_struct *conn, char *path, uint32 flags);
	BOOL (*check_notify)(connection_struct *conn, uint16 vuid, char *path, uint32 flags, void *data, time_t t);
	void (*remove_notify)(void *data);
};


then I wrote two implementations, one using hash/poll (like our old
code) and the other using the new Linux kernel change notify. It
should be easy to add other change notify implementations by creating
a sructure of the above type.

- fixed a bug in change notify where we were returning the wrong error
  code.

- rewrote the core change notify code to be much simpler

- moved to real-time signals for leases and change notify

Amazingly, it all seems to work. I was very surprised!
 -