Volker Lendecke
26d736f1ff
s3: Remove two unused variables
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Nov 8 10:14:36 CET 2011 on sn-devel-104
2011-11-08 10:14:36 +01:00
Jeremy Allison
60b7dae3fa
Add the SEC_DIR_LIST check to dptr_create().
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Nov 7 21:11:03 CET 2011 on sn-devel-104
2011-11-07 21:11:03 +01:00
Björn Baumbach
b9e6c48678
s3-wafbuild: Fix inotify detection (bug 8580)
...
Enable inotify if sys or kernel inotify is available.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 7 16:28:38 CET 2011 on sn-devel-104
2011-11-07 16:28:37 +01:00
Björn Baumbach
846809853a
s3-build: Fix inotify detection (bug 8580)
...
Enable inotify if sys or kernel inotify is available.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-07 14:44:28 +01:00
Stefan Metzmacher
230cd1e276
s3:libsmb: return NT_STATUS_OK for if a request is not the last one in the chain
...
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 7 11:38:05 CET 2011 on sn-devel-104
2011-11-07 11:38:05 +01:00
Stefan Metzmacher
597f2ae342
s3:libsmb: make sure have_andx_command() returns false for non AndX commands
...
metze
2011-11-07 09:18:18 +01:00
Stefan Metzmacher
b20775fb3b
s3:libsmb: remember the seqnum on all chained requests
...
This is needed in order to verify the incoming signature
correctly.
metze
2011-11-07 09:18:10 +01:00
Stefan Metzmacher
20fe7658a7
s3:libsmb: get cmd of the chained request before changing wct_ofs
...
metze
2011-11-07 09:18:10 +01:00
Stefan Metzmacher
0c1669ee4b
s3:smb2cli: ignore the NBT/Length header in smb2cli_inbuf_parse_compound()
...
This is not needed and in future we want to support SMBDirect,
which add a different header.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Nov 6 17:17:04 CET 2011 on sn-devel-104
2011-11-06 17:17:04 +01:00
Jeremy Allison
2898485848
Move the SEC_DIR_LIST check into dptr_create for SMB2 and now for SMB1.
...
The pathname check still needs fixing.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Nov 5 01:38:00 CET 2011 on sn-devel-104
2011-11-05 01:38:00 +01:00
Jeremy Allison
7ff5a5584f
can_write_to_file() does now take share permissions into account. Fix comment.
2011-11-04 16:01:16 -07:00
Jeremy Allison
bbcb589ef5
No longer do the pre-check on DELETE_ACCESS - we're correctly checking the ACL every time now.
2011-11-04 15:56:15 -07:00
Jeremy Allison
b988a3233f
Remove can_access_file_acl(). We no longer need this duplicate code (hurrah!).
2011-11-04 15:55:11 -07:00
Jeremy Allison
60b741415d
Remove can_access_file_data() - make it use the standard smbd_check_access_rights() instead.
2011-11-04 15:45:13 -07:00
Jeremy Allison
4851219333
Add const to the smb_filename argument of smbd_check_access_rights().
2011-11-04 15:39:55 -07:00
Jeremy Allison
a30f84a21c
Expose smbd_check_access_rights() to other modules.
2011-11-04 14:37:26 -07:00
Jeremy Allison
32edc1d047
Rename smbd_check_open_rights() to smbd_check_access_rights() as we're going to remove the static from this.
2011-11-04 14:28:08 -07:00
Jeremy Allison
0c886eeb89
Replace smb1_file_se_access_check() with just se_access_check().
2011-11-04 14:21:35 -07:00
Jeremy Allison
55b9ba79f8
Move root check out of smb1_file_se_access_check() in preparation for deleting this function.
2011-11-04 14:16:51 -07:00
Jeremy Allison
07edf6c65e
smb1_file_se_access_check() is now static to smbd/open.c
2011-11-04 14:16:37 -07:00
Jeremy Allison
1fab17de94
Revert "Change function signature of check_parent_access() to take char * instead of struct smb_filename."
...
This reverts commit a11c0a41a3
.
Not needed.
2011-11-04 14:15:47 -07:00
Jeremy Allison
d433af92b9
Revert "Call check_parent_access() on readdir."
...
This reverts commit a763edaf9c
.
Checking the wrong thing..
2011-11-04 14:15:43 -07:00
Henry Wong
51c86c8e67
Properly fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.
...
Ensure we correctly null out the referenced pointer when we decrease the ref. count.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov 4 21:12:13 CET 2011 on sn-devel-104
2011-11-04 21:12:13 +01:00
Christian Ambach
b99becd4fa
s3:smbd increase a debug level
...
logging disconnected clients with level 1 swamps the logs
2011-11-04 17:39:43 +01:00
Stefan Metzmacher
9b4c300922
s3:smbd: also send the server name in the negprot response
...
This matches W2K (at least sp4) and higher.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov 4 15:50:06 CET 2011 on sn-devel-104
2011-11-04 15:50:06 +01:00
Stefan Metzmacher
e99017af72
s3:libsmb: also remember the optional server name from the negprot response
...
W2K (at least sp4) and higher also send the server name.
metze
2011-11-04 14:16:29 +01:00
Stefan Metzmacher
aea76a3aaa
s3:libsmb: the workgroup in the non-extended-security negprot is not aligned ( #8573 )
...
I've tested the fix against NT4 sp6a, W2K sp4, W2K8R2 and Win8pre0.
metze
2011-11-04 14:16:28 +01:00
Michael Adam
e30892764e
s3:selftest: improve logging in the registry upgrade test
...
Don't only log to the log file. Give "make test" a cance to grab
some output. And add some more messages.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Nov 4 01:58:20 CET 2011 on sn-devel-104
2011-11-04 01:58:20 +01:00
Björn Baumbach
2e1f7e137d
s3-selftest: add new registry upgrade test to test list
...
Signed-off-by: Michael Adam <obnox@samba.org>
2011-11-04 00:28:08 +01:00
Björn Baumbach
2f9b453635
s3-selftest: introduce registry upgrade test
...
Signed-off-by: Michael Adam <obnox@samba.org>
2011-11-04 00:28:08 +01:00
Jeremy Allison
767c54d8dd
Fix bug #8562 - talloc: double free error.
...
Ensure we don't access an undefined pointer.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov 4 00:09:46 CET 2011 on sn-devel-104
2011-11-04 00:09:45 +01:00
Günther Deschner
6e67073900
waf: convert NDR_NBT into shared library.
...
Guenther
2011-11-03 18:35:09 +01:00
Günther Deschner
185b94eefa
nbt: trim down header dependencies of nbt.idl.
...
Guenther
2011-11-03 18:35:08 +01:00
Günther Deschner
72879f491f
nbt: merge in LIBCLI_NDR_NETLOGON helper into NDR_NBT.
...
Guenther
2011-11-03 18:35:08 +01:00
Günther Deschner
2ecd50116c
librpc: remove nbt dependency to samr.
...
Guenther
2011-11-03 18:35:08 +01:00
Günther Deschner
e426f37b64
librpc: only let NDR_NBT depend on NDR_NBT_BUF.
...
Guenther
2011-11-03 18:35:08 +01:00
Stefan Metzmacher
05d3a6f219
s3:param: change default of "* signing" to "default"
...
This should not change the bahavior.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 3 18:33:34 CET 2011 on sn-devel-104
2011-11-03 18:33:34 +01:00
Stefan Metzmacher
caa134672c
s3:smbd: make use of SMB_SIGNING_* constants
...
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
7de694974e
s3:libsmb: make use of SMB_SIGNING_* constants
...
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
b3f126b44c
s3:lib: make use of SMB_SIGNING_* constants
...
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
a7051dfcff
s3:libsmb: make use of SMB_SIGNING_* constants
...
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
1b04e54b57
s3:libsmb: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
59dcdfd175
s3:torture: s/Undefined/SMB_SIGNING_DEFAULT/ s/Required/SMB_SIGNING_REQUIRED/
...
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
784cf12fb1
s3:lib: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:13 +01:00
Stefan Metzmacher
19eaaa8030
s3:lib/netapi: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:12 +01:00
Stefan Metzmacher
07cd85fd8b
s3:libnet: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:12 +01:00
Stefan Metzmacher
6db670386b
s3:winbindd: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:12 +01:00
Stefan Metzmacher
c4fecca261
s3:web: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:12 +01:00
Stefan Metzmacher
92a6f577ce
s3:utils: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:12 +01:00
Stefan Metzmacher
f61fb18e0a
s3:nmbd: s/Undefined/SMB_SIGNING_DEFAULT/
...
metze
2011-11-03 16:55:12 +01:00