Günther Deschner
d59cf703ba
dsgetdcname: make use of nbt_cldap_netlogon_15.
...
Guenther
(This used to be commit 5b0eda98f3
)
2008-05-09 17:41:50 +02:00
Günther Deschner
67c644aa59
dsgetdcname: use existing messaging_context if possible.
...
Guenther
(This used to be commit 7889516a38
)
2008-05-09 14:59:20 +02:00
Günther Deschner
c58ab8f3b2
dsgetdcname: the forest name should never be empty.
...
Guenther
(This used to be commit 2c0a96f1e5
)
2008-05-09 14:59:20 +02:00
Günther Deschner
e668cb4594
dsgetdcname: add map_dc_and_domain_names() for consolidating returned names.
...
Guenther
(This used to be commit eb7fee6e2a
)
2008-05-09 14:59:19 +02:00
Günther Deschner
4bd94c8338
cldap: move out cldap object to fix the build.
...
Guenther
(This used to be commit 56be9c98d2
)
2008-05-09 14:59:19 +02:00
Günther Deschner
5e24d83e41
dsgetdcname: fix gencache store for dsgetdcname().
...
While storing always a type 29 reply structure in gencache, we are now able to
deliver correct data according to return flags such as DS_RETURN_FLAT_NAME and
DS_RETURN_DNS_NAME out of the cached data from gencache.
Guenther
(This used to be commit c67b6dc0ca
)
2008-05-09 14:59:19 +02:00
Günther Deschner
5d7a60afd8
dsgetdcname: pure cosmetics.
...
Guenther
(This used to be commit 4b56c294e8
)
2008-05-09 14:59:19 +02:00
Günther Deschner
9adc40a38f
dsgetdcname: simply call ourself with DS_FORCE_REDISCOVERY after cache expiry.
...
Guenther
(This used to be commit 847f258632
)
2008-05-09 14:59:19 +02:00
Günther Deschner
8441681819
dsgetdcname: be more paranoid about the existance of an ip_address.
...
Guenther
(This used to be commit d13fe66f3d
)
2008-05-09 14:59:19 +02:00
Günther Deschner
eaef936523
dsgetdcname: remove invalid assumption in discover_dc_dns().
...
Guenther
(This used to be commit f48b2e844b
)
2008-05-09 14:59:19 +02:00
Günther Deschner
9be17e2187
dsgetdcname: mailslot replies are identical to the cldap ones, use cldap everywhere.
...
Guenther
(This used to be commit fe904ee77a
)
2008-05-09 14:59:19 +02:00
Günther Deschner
926cc82897
dsgetdcname: wait a little longer for mailslot replies.
...
Guenther
(This used to be commit bc0d7a90dc
)
2008-05-09 14:59:18 +02:00
Günther Deschner
9d99ef899c
dsgetdcname: map additional flags to nt_version.
...
Guenther
(This used to be commit 1009123b86
)
2008-05-09 14:59:18 +02:00
Günther Deschner
0354d00ddf
dsgetdcname: use make_dc_info_from_cldap_reply() for cldap replies.
...
Guenther
(This used to be commit a3e5b073f0
)
2008-05-09 14:59:18 +02:00
Günther Deschner
81aa670343
dsgetdcname: add make_dc_info_from_cldap_reply().
...
Guenther
(This used to be commit 9db2e50a20
)
2008-05-09 14:59:18 +02:00
Günther Deschner
9b4ea32c2d
dsgetdcname: add get_cldap_reply_server_flags().
...
Guenther
(This used to be commit 3c05c56d4c
)
2008-05-09 14:59:18 +02:00
Günther Deschner
cdd9913c4a
cldap: let ads_cldap_netlogon() return all possible cldap replies.
...
Guenther
(This used to be commit 6f9d5e1cc9
)
2008-05-09 14:59:18 +02:00
Günther Deschner
64cb9461fb
dsgetdcname: add pull_mailslot_cldap_reply().
...
Guenther
(This used to be commit 95fb01d870
)
2008-05-09 14:59:18 +02:00
Günther Deschner
fcdee39988
dsgetdcname: add map_ds_flags_to_nt_version.
...
Guenther
(This used to be commit 1809ea22c3
)
2008-05-09 14:59:18 +02:00
Günther Deschner
7b5ec90b72
dsgetdcname: remove invalid assumptions when using DNS for the DC query.
...
Guenther
(This used to be commit a81818ae54
)
2008-05-07 14:09:41 +02:00
Günther Deschner
611d79d0ed
build: fix the build w/o ldap.
...
Guenther
(This used to be commit a159ec5f1f
)
2008-05-06 09:48:16 +02:00
Günther Deschner
1f6065765c
mailslot/cldap: use nt_version bits in queries.
...
Guenther
(This used to be commit b261f06312
)
2008-05-06 09:41:41 +02:00
Günther Deschner
5c02872a10
dsgetdcname: use correct dc name for name cache store.
...
Guenther
(This used to be commit ce1556d0fb
)
2008-05-06 09:41:41 +02:00
Volker Lendecke
7245a8e3b8
Fix a C++ warning
...
(This used to be commit e7a4027acf
)
2008-05-05 18:28:59 +02:00
Günther Deschner
4d8836ab96
Fix client authentication with -P switch in client tools (Bug 5435).
...
Guenther
(This used to be commit d077ef64cd
)
2008-05-05 16:59:53 +02:00
Günther Deschner
e7142ef180
ntlmssp: replace UNKNOWN_02000000 with NTLMSSP_NEGOTIATE_VERSION.
...
Guenther
(This used to be commit 2c41d69bcf
)
2008-04-30 18:55:57 +02:00
Günther Deschner
d0411c19dc
errors: add WERR_NOT_FOUND.
...
Guenther
(This used to be commit b9ac03bdfa
)
2008-04-29 20:22:01 +02:00
Günther Deschner
dddac2bc8f
errors: add WERR_INVALID_DOMAINNAME.
...
Guenther
(This used to be commit b11a5e70d3
)
2008-04-25 14:49:31 +02:00
Volker Lendecke
9e9d40d097
Refactoring: Make cli_pipe_auth_data a pointer off rpc_pipe_client
...
(This used to be commit f665afaaa3
)
2008-04-25 11:12:50 +02:00
Günther Deschner
051ff45c60
mailslot/dsgetdcname: do what XP does and request nt_version 11.
...
This allows dsgetdcname to query for a flat, non-dns domain name and
come back with all information about the DC (site names, guid, forest,
etc.) based on a mailslot reply. The version 11 request is downgraded
to version 1 in case we do a query against NT4.
Guenther
(This used to be commit d8b2ff3c87
)
2008-04-24 22:01:52 +02:00
Günther Deschner
b77601a4b7
mailslot: allow to give back struct nbt_ntlogon_packet.
...
Guenther
(This used to be commit 2b178dcae6
)
2008-04-24 22:01:52 +02:00
Günther Deschner
012d678211
mailslot: make sure we are looking at the correct reply structure.
...
Guenther
(This used to be commit c6ce07fdf5
)
2008-04-24 22:01:51 +02:00
Günther Deschner
e66d452466
mailslot: allow to define nt_version in send_getdc_request().
...
Guenther
(This used to be commit ce3728191b
)
2008-04-24 22:01:51 +02:00
Günther Deschner
aba7809188
build: fix the build.
...
Guenther
(This used to be commit 09a0001063
)
2008-04-22 00:06:57 +02:00
Günther Deschner
de9186ecc6
dsgetdcname: Fix discover_dc_dns().
...
Guenther
(This used to be commit ec86deb349
)
2008-04-22 00:05:05 +02:00
Günther Deschner
bd3991ac97
dsgetdcname: add very basic flat name support.
...
Guenther
(This used to be commit bb72d0b71e
)
2008-04-22 00:04:25 +02:00
Volker Lendecke
b78453326b
Remove the "pwd" struct from rpc_pipe_client
...
The only user of this was decrypt_trustdom_secret, and this only needs the NT
hash anyway.
(This used to be commit 3d8c2a47e6
)
2008-04-21 23:36:05 +02:00
Günther Deschner
bcbac69d1a
cldap: avoid duplicate definitions so remove ads_cldap.h.
...
Guenther
(This used to be commit 538eefe22a
)
2008-04-21 20:21:40 +02:00
Günther Deschner
1dd7ab38e7
cldap: add talloc context to ads_cldap_netlogon().
...
Guenther
(This used to be commit 4cee7b1bd5
)
2008-04-21 20:21:40 +02:00
Günther Deschner
ba98dd4989
libads: Use libnbt for CLDAP reply parsing.
...
Guenther
(This used to be commit 751f3064a5
)
2008-04-21 20:21:39 +02:00
Günther Deschner
1eca3f138c
winbind: pass down existing talloc context.
...
Guenther
(This used to be commit 675bf42cff
)
2008-04-21 20:21:39 +02:00
Günther Deschner
937091161b
winbind: Use libnbt for NTLOGON SAMLOGON mailslot request and reply.
...
Guenther
(This used to be commit 2d6a1c5da6
)
2008-04-21 11:03:32 +02:00
Günther Deschner
b437f09595
samlogoncache: Use data_blob_const in netsamlogon_cache_get.
...
Guenther
(This used to be commit f27a20f25c
)
2008-04-21 10:25:28 +02:00
Günther Deschner
e03321697e
cli_cm: Make nicer password prompt in do_connect().
...
Guenther
(This used to be commit cc967e76a3
)
2008-04-20 23:20:21 +02:00
Volker Lendecke
e73e8297f5
Replace cli_rpc_pipe_close by a talloc destructor on rpc_pipe_struct
...
(This used to be commit 99fc3283c4
)
2008-04-20 14:08:16 +02:00
Volker Lendecke
f56eedb95c
Remove the pipe_idx variable from rpc_pipe_client
...
(This used to be commit 4840febcd4
)
2008-04-20 11:47:33 +02:00
Volker Lendecke
9048cafbea
Move srv_name_slash from cli_state to rpc_pipe_client
...
(This used to be commit a9061e52e1
)
2008-04-20 00:14:13 +02:00
Volker Lendecke
2a2188591b
Add "desthost" to rpc_pipe_client
...
This reduces the dependency on cli_state
(This used to be commit 783afab9c8
)
2008-04-20 00:13:09 +02:00
Volker Lendecke
b46d340fd5
Refactoring: Make struct rpc_pipe_client its own talloc parent
...
(This used to be commit a6d74a5a56
)
2008-04-20 00:12:52 +02:00
Volker Lendecke
b7d2e94296
Fix bug 5399
...
Thanks to Jason Mader!
Volker
(This used to be commit 36740f4959
)
2008-04-19 17:04:09 +02:00
Günther Deschner
bbded540b6
Move GETDC mailslot out of winbindd.
...
Guenther
(This used to be commit b003ba65e3
)
2008-04-17 15:17:29 +02:00
Günther Deschner
f466e53b64
dsgetdcname: Fix discover_dc_dns.
...
Guenther
(This used to be commit 2fe416ffa5
)
2008-04-17 00:08:24 +02:00
Günther Deschner
c1d4243c5a
errors: Add WERR_NO_SUCH_USER.
...
Guenther
(This used to be commit 82803186fe
)
2008-04-16 02:37:27 +02:00
Günther Deschner
44912a9fb9
errors: Add WERR_NONE_MAPPED.
...
Guenther
(This used to be commit dc165e1c80
)
2008-04-16 02:23:20 +02:00
Günther Deschner
202e8cc57e
doserr: Add WERR_INVALID_DOMAIN_STATE and WERR_INVALID_DOMAIN_ROLE.
...
Guenther
(This used to be commit 91a55fc27d
)
2008-04-14 15:48:23 +02:00
Volker Lendecke
394150d269
Make use of ZERO_STRUCT instead of memset in namequery.c
...
(This used to be commit 4f1d49615e
)
2008-04-14 13:13:46 +02:00
Günther Deschner
98abf71ff5
Add WERR_USER_ALREADY_EXISTS and WERR_PASSWORD_RESTRICTION.
...
Guenther
(This used to be commit eefd03d39b
)
2008-04-12 18:30:14 +02:00
Tim Prouty
bb869741dd
Cleanup size_t return values in convert_string_allocate
...
This patch is the first iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
(This used to be commit 59124382d2
)
2008-04-11 11:33:33 +02:00
Günther Deschner
1db69e9180
Add some more cli_cm_set_X functions.
...
Guenther
(This used to be commit 882475f556
)
2008-04-10 21:21:27 +02:00
Günther Deschner
e49200c1a2
Add CLI_FULL_CONNECTION_FALLBACK_AFTER_KERBEROS define.
...
This allows to switch on the cli->fallback_after_kerberos switch.
Guenther
(This used to be commit 15ba45e567
)
2008-04-08 14:25:13 +02:00
Bill Ricker
f700ee6418
Fix Kerberos interop with Mac OS X 10.5 clients.
...
Ignore optional req_flags. Use the Kerberos mechanism OID negotiated
with the client rather than hardcoding OID_KERBEROS5_OLD.
(This used to be commit 59a2bcf30f
)
2008-04-07 15:05:51 -07:00
James Peach
2dfec9e829
Use bool for BOOL and true/false for True/False. We need lowercase
...
bool to get the declarations picked up by the prototype parser.
(This used to be commit fd168e7b50
)
2008-04-07 15:05:50 -07:00
Volker Lendecke
aa41d74843
Fix a misleading debug message
...
(This used to be commit 494b32197f
)
2008-04-07 10:20:32 +02:00
Jeremy Allison
1a64916775
When using plaintext ucs2 passwords clistr_push calls ucs2_align, which causes
...
the space taken by the unicode password to be one byte too
long (as we're on an odd byte boundary here). Reduce the
count by 1 to cope with this. Fixes smbclient against NetApp
servers which can't cope. Fix from
bryan.kolodziej@allenlund.com in bug #3840 .
Jeremy.
(This used to be commit 1e7e7d86a1
)
2008-04-04 15:28:14 -07:00
Günther Deschner
69b23a39cd
Always uppercase cli->srv_name_slash.
...
Not that I think it is of any importance...
Guenther
(This used to be commit 352f8440c7
)
2008-04-04 01:44:43 +02:00
Günther Deschner
b028fd3f8c
Add NT_STATUS_RPC_CANNOT_SUPPORT.
...
Guenther
(This used to be commit 9e15ce03ca
)
2008-04-03 00:26:55 +02:00
Günther Deschner
da7863c4c9
Apply some const in clirap.
...
Guenther
(This used to be commit 8a1a9f967d
)
2008-04-02 12:23:07 +02:00
Günther Deschner
99d3590455
Fix NETLOGON credential chain with Windows 2008 all over the place.
...
In order to avoid receiving NT_STATUS_DOWNGRADE_DETECTED from a w2k8
netr_ServerAuthenticate2 reply, we need to start with the AD netlogon negotiate
flags everywhere (not only when running in security=ads). Only for NT4 we need
to do a downgrade to the returned negotiate flags.
Tested with w2k8, w2ksp4, w2k3r2 and nt4sp6.
Guenther
(This used to be commit 0970369ca0
)
2008-04-02 11:12:47 +02:00
Jeremy Allison
d1e99642f7
Fix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.
...
Jeremy.
(This used to be commit d090d25cb7
)
2008-03-28 10:12:07 -07:00
Michael Adam
9644b6cb50
Add a talloc context parameter to current_timestring() to fix memleaks.
...
current_timestring used to return a string talloced to talloc_tos().
When called by DEBUG from a TALLOC_FREE, this produced messages
"no talloc stackframe around, leaking memory". For example when
used from net conf.
This also adds a temporary talloc context to alloc_sub_basic().
For this purpose, the exit strategy is slightly altered: a common
exit point is used for success and failure.
Michael
(This used to be commit 16b5800d4e
)
2008-03-28 16:34:51 +01:00
Volker Lendecke
8f6b03b673
More ssize_t->SMB_OFF_T
...
(This used to be commit 8dd6458049
)
2008-03-28 15:32:02 +01:00
Günther Deschner
33a8e9b537
Check for buffer in decode_wkssvc_join_password_buffer.
...
Guenther
(This used to be commit 2134d80c05
)
2008-03-28 14:15:20 +01:00
Günther Deschner
7f1a0a5cdf
Remove unneeded pack_dsdcinfo/unpack_dsdcinfo.
...
Guenther
(This used to be commit 34dd8f32e1
)
2008-03-28 13:37:25 +01:00
Günther Deschner
76a819c9c0
Use NDR for netr_DsRGetDCNameInfo un-/marshalling in dsgetdcname.
...
Guenther
(This used to be commit 7fa5391105
)
2008-03-28 13:36:31 +01:00
Volker Lendecke
e6a1027757
Fix a valgrind error
...
In winbind, we're using the info3 struct to send it to the winbind client after
netsamlogon_cache_store. Without this info3->base.account_name.string was
prematurely freed.
(This used to be commit aa4377561b
)
2008-03-25 23:36:13 +01:00
Volker Lendecke
4b3351e5dc
On Solaris, size_t seems to be only 32 bit.
...
Fix bug 5341, thanks a lot to Karoly Vegh for testing it!
Volker
(This used to be commit 19eb8c9316
)
2008-03-21 13:41:42 +01:00
Günther Deschner
fe1a6668c8
Add error mapping for WERR_SERVICE_NEVER_STARTED.
...
Guenther
(This used to be commit 818044d877
)
2008-03-20 00:54:20 +01:00
Volker Lendecke
b2ec8372ba
!NT_STATUS_IS_OK != NT_STATUS_IS_ERR
...
When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not*
an error.
(This used to be commit 24018d882d
)
2008-03-19 22:38:13 +01:00
Volker Lendecke
16cbc22a99
Fix bug 5334
...
I did not test with a zero length file :-)
(This used to be commit 7d7a73944c
)
2008-03-18 13:49:46 +01:00
Derrell Lipman
8b0783072a
Fix use of AuthDataWithContext capability
...
During my initial plans for, and the subsequent discussion of a more
significant change to the API for libsmbclient, I had removed the
AuthDataWithContext usage, in favor of a more generalized planned interface.
When the API returned to its original state, I neglected to reinsert this
code.
Use of an authentication function with the context can be tested using
examples/libsmbclient/testbrowse -C
Derrell
(This used to be commit 38eab68dfb
)
2008-03-17 11:34:25 -04:00
Volker Lendecke
e2ab1a0f98
Fix Coverity ID 555
...
(This used to be commit 44122f06d0
)
2008-03-15 22:30:25 +01:00
Günther Deschner
5e86a172a5
For convenience reasons, always create cli->srv_name_slash in the rpc_client.
...
Guenther
(This used to be commit 6363c383d6
)
2008-03-12 16:19:56 +01:00
Günther Deschner
a6fa0ca321
Use rpccli_srvsvc_NetShareEnumAll in libsmbclient.
...
Guenther
(This used to be commit 6aad05f3f1
)
2008-03-10 04:58:43 +01:00
Günther Deschner
d185fb48fb
Remove insane amount of whitespace.
...
Guenther
(This used to be commit 8216310e9f
)
2008-03-10 04:35:31 +01:00
Volker Lendecke
973734cde6
Correctly calculate the max read size
...
(This used to be commit f556c9e162
)
2008-03-08 22:28:01 +01:00
Volker Lendecke
464f74df2f
Move inbuf handling to before the PDU handling
...
In an error case, correctly discard the offending PDU
(This used to be commit 0aa195b5d6
)
2008-03-08 22:02:33 +01:00
Volker Lendecke
8da1e033a8
Pass specific packets to build_nmb and build_dgram
...
To me it was not clear what parts of struct packet_struct are actually used in
build_packet(). This makes it a bit more clear that only the specific parts are
used.
(This used to be commit eb8b6f2404
)
2008-03-08 12:31:21 +01:00
Volker Lendecke
6a2dbea794
Fix some typos
...
(This used to be commit cfa1b83814
)
2008-03-08 12:31:21 +01:00
Derrell Lipman
914cd3e483
Eliminate global variable in_client and a plethora of extern declarations.
...
Derrell
(This used to be commit b7f34e7ef2
)
2008-03-06 10:41:42 -05:00
Volker Lendecke
5eb347193f
Fix a "nested extern declaration" warning
...
(This used to be commit e473e6d50c
)
2008-03-06 15:50:46 +01:00
Derrell Lipman
5b80b9340f
Check for NULL pointers before dereferencing them.
...
(This used to be commit 6f65390cec
)
2008-03-06 09:00:37 -05:00
Volker Lendecke
a015227490
Convert cli_read to use cli_pull
...
(This used to be commit d69b20111a
)
2008-03-06 13:28:23 +01:00
Volker Lendecke
6244578835
Add async cli_pull support
...
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)
Make use of it in the smbclient "get" command.
Volker
(This used to be commit 76f9b360ee
)
2008-03-06 13:28:23 +01:00
Volker Lendecke
1ea0a5d0cd
Add infrastructure to support async SMB requests
...
(This used to be commit e215330135
)
2008-03-06 13:28:23 +01:00
Volker Lendecke
e82c9d1c31
Check the right pointer for non-NULL
...
Fix Coverity ID 558, 559
(This used to be commit 8e33d19d93
)
2008-03-06 11:33:26 +01:00
Derrell Lipman
1363ee9d65
Continued revamping of libsmbclient.
...
- James suggested using gcc's "deprecated" attribute to mark the context
structure fields to generate warnings. This creates a scenario with the
best of all worlds. I'm able to move to an organization that more easily
allows future enhancements, while avoiding any mandatory changes by
applications. Thanks, James!
- Updated WHATSNEW.txt so that it accurately reflects the current state of
affairs.
Derrell
(This used to be commit a67f96fbe9
)
2008-03-03 18:13:33 -05:00
Derrell Lipman
fc65c6698e
Return NULL, not 0, from a function which returns a pointer.
...
(This used to be commit 23cb9c49e3
)
2008-03-01 21:19:52 -05:00
Derrell Lipman
223940d9a8
Additional revamped libsmbclient documentation
...
- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability
Derrell
(This used to be commit 64b7150d92
)
2008-03-01 20:47:22 -05:00
Derrell Lipman
4ba42cbe0f
Modified revamp of the libsmbclient interface.
...
Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach. This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility. I retain, here, the setter and getter functions which all new
code should use. Older programs already compiled should continue to work
fine. Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.
Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval. I hope that this compromise is adequate.
Derrell
(This used to be commit 56429a3d60
)
2008-03-01 20:47:22 -05:00
Derrell Lipman
257b7b0929
Initial revamp of the libsmbclient interface.
...
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(This used to be commit d4b4bae8de
)
2008-03-01 20:47:22 -05:00
Volker Lendecke
45a877f392
Revert "Add infrastructure to support async SMB requests"
...
This reverts commit f535682569
.
(This used to be commit 5f53a62be8
)
2008-03-01 09:38:14 +01:00
Volker Lendecke
a34d158880
Revert "Add async cli_pull support"
...
This reverts commit 844a163458
.
(This used to be commit 5ab1cfda50
)
2008-03-01 09:38:14 +01:00
Volker Lendecke
342859edfc
Revert "Convert cli_read to use cli_pull"
...
This reverts commit 719527f55e
.
(This used to be commit ac301fada2
)
2008-03-01 09:38:14 +01:00
Volker Lendecke
5e0d86c407
Restore 3.0 behaviour with empty /etc/hosts
...
Jeremy, in 3.0 we allowed get_mydnsdomname and get_mydnsfullname to fail
without filling in anything useful. Worked fine. Without this patch and a empty
/etc/hosts and no DNS configured, session setup would return
NT_STATUS_BAD_NETWORK_NAME. This is confusing at best, BAD_NETWORK_NAME afaik
is only ever returned from tcon normally.
This restores the 3.0 behaviour.
Comments?
Volker
(This used to be commit 2bd3b7d474
)
2008-02-29 22:39:45 +01:00
Volker Lendecke
45615d6283
Check the right variable for being NULL
...
(This used to be commit f2c6780379
)
2008-02-29 22:39:45 +01:00
Günther Deschner
bddceee09a
Fix memleak in netsamlogon_cache_get().
...
Guenther
(This used to be commit b736c77dc6
)
2008-02-28 23:15:11 +01:00
Volker Lendecke
95222d115a
Convert cli_read to use cli_pull
...
(This used to be commit 719527f55e
)
2008-02-28 15:27:55 +01:00
Volker Lendecke
525aac775e
Add async cli_pull support
...
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)
Make use of it in the smbclient "get" command.
Volker
(This used to be commit 844a163458
)
2008-02-28 15:27:55 +01:00
Volker Lendecke
1d41b5bd2a
Add infrastructure to support async SMB requests
...
(This used to be commit f535682569
)
2008-02-28 15:27:55 +01:00
Jeremy Allison
6e2e0e2ce7
Fix the build - don't use SMB_TRANS_ENC_GSS without
...
KRB5.
Jeremy.
(This used to be commit d16c295642
)
2008-02-28 06:01:09 -08:00
Volker Lendecke
be4a76a861
Add cli_setup_packet_buf
...
This is == cli_setup_packet but takes an explicit buffer argument
(This used to be commit f64b46dc27
)
2008-02-28 14:20:17 +01:00
Volker Lendecke
57a9fba097
Make cli_struct a talloc parent
...
(This used to be commit e69244a5c8
)
2008-02-28 14:20:17 +01:00
Günther Deschner
11b81cb8e4
Add WERR_TIME_SKEW to werror mapping tables.
...
Guenther
(This used to be commit 74767be627
)
2008-02-28 14:10:53 +01:00
Volker Lendecke
b9f7dd2909
Add explicit buf arg to cli_check_sign_mac
...
(This used to be commit ffc1c8cc03
)
2008-02-28 13:12:34 +01:00
Volker Lendecke
4b5169f590
Add explicit buf arg to cli_encrypt_message and cli_calculate_sign_mac
...
(This used to be commit db6ae9ed23
)
2008-02-28 13:12:34 +01:00
Günther Deschner
0d8985f2da
Let dsgetdcname() return a struct netr_DsRGetDCNameInfo.
...
Guenther
(This used to be commit b1a4b21f8c
)
2008-02-28 12:40:55 +01:00
Jeremy Allison
1d940490e8
Fix from Guenter Kukkukk <linux@kukkukk.com> to fix listing against
...
OS/2 servers. OS/2 returns eclass == ERRDOS && ecode == ERRnofiles
for a zero entry directory listing.
Jeremy.
(This used to be commit b34da62705
)
2008-02-28 02:22:13 -08:00
Günther Deschner
7269a504fd
Add my copyright.
...
Guenther
(This used to be commit d078a87571
)
2008-02-27 19:38:48 +01:00
Günther Deschner
2d01ec2c39
Use new LSA_POLICY defines in lsa rpc server code and other places.
...
Guenther
(This used to be commit 58cca9faf9
)
2008-02-27 15:57:09 +01:00
Derrell Lipman
fa341d5262
add smbc_ftruncate() to emulate POSIX ftruncate()
...
(This used to be commit 6f5051b9c1
)
2008-02-26 21:44:51 -05:00
Derrell Lipman
c58e7427bf
add a function to truncate a file to a specified size
...
(This used to be commit 7e5752812d
)
2008-02-26 21:42:26 -05:00
Volker Lendecke
3176392878
Fix some warnings
...
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
(This used to be commit ad37b7b0ae
)
2008-02-25 16:09:26 +01:00
Volker Lendecke
a5e43bc817
Fix typo
...
(This used to be commit 621db68f32
)
2008-02-23 21:40:39 +01:00
Volker Lendecke
6548493de7
Fix a C++ warning
...
(This used to be commit ac027a9b2e
)
2008-02-23 11:04:13 +01:00
Tim Potter
441de75e58
Fix memory leaks on error path
...
(This used to be commit 47dd0700b4
)
2008-02-20 18:27:40 -08:00
Günther Deschner
5b8ebcf397
Remove unused creds_client_check and creds_client_step.
...
Guenther
(This used to be commit 1dcb32424d
)
2008-02-17 03:08:42 +01:00
Günther Deschner
c1793b2b31
Use new IDL based PAC structures in clikrb5.c
...
Guenther
(This used to be commit 3b0135d57e
)
2008-02-17 02:11:59 +01:00
Günther Deschner
8027b7c25d
Use netr_SamInfo3 in samlogon cache and use ndr functions for storing the blob.
...
Guenther
(This used to be commit bf860ae1ac
)
2008-02-17 02:11:59 +01:00
Günther Deschner
dd65a34935
Use rpccli_netr_ServerPasswordSet in "just_change_the_password()".
...
Guenther
(This used to be commit 33f91c8944
)
2008-02-16 16:04:01 +01:00
Günther Deschner
b6285fc052
Remove unused creds_server_check and creds_server_step.
...
Guenther
(This used to be commit 2fb73a3545
)
2008-02-16 15:14:04 +01:00
Günther Deschner
3f24ef1848
Replace DOM_CHAL with "struct netr_Credential" where we can right now.
...
This allows to remove some more old netlogon client calls.
Guenther
(This used to be commit c0b1a87658
)
2008-02-15 23:57:54 +01:00
Günther Deschner
f8bd3e82e5
Add netlogon_creds_server_check and netlogon_creds_server_step.
...
Guenther
(This used to be commit ea0bf74918
)
2008-02-15 20:58:34 +01:00
Günther Deschner
401c0a6551
Add netlogon_creds_client_check and netlogon_creds_client_step.
...
Guenther
(This used to be commit 41d33a2507
)
2008-02-15 14:04:55 +01:00
Jeremy Allison
39e0dbcf07
Allow the mechOID to be written separately.
...
Jeremy.
(This used to be commit e3e08c6e7d
)
2008-02-14 11:29:54 -08:00
Günther Deschner
0ba3d44f73
Use rpccli_lsa_EnumTrustDom all over the place.
...
Guenther
(This used to be commit a25e7ffbca
)
2008-02-13 00:29:37 +01:00
Volker Lendecke
b4dd60efa9
Add a missing return
...
If I'm not completely blind, we should return here. Not doing it here seems not
to be a major flaw, as far as I can see we're only missing the error code. This
might account for some of the very unhelpful NT_STATUS_UNSUCCESSFUL error
messages people see during joins.
All with stake in Samba client, please check!
(This used to be commit eadd15c936
)
2008-02-11 18:37:58 +01:00
Jeremy Allison
20d6ebe813
We don't need the extra null termination - we've
...
already got this in the cli_receive_trans calls.
Jeremy.
(This used to be commit 99424bba7b
)
2008-02-08 22:02:00 -08:00
Jeremy Allison
0b583e4329
Make clilist work again with OS/2 (kukks help!).
...
Jeremy.
(This used to be commit 2e27309401
)
2008-02-08 19:02:49 -08:00
Jeremy Allison
73d838a2da
From kukks - prevent crashes if finfo.name == NULL.
...
Jeremy.
(This used to be commit 101f194795
)
2008-02-08 18:44:33 -08:00
Jeremy Allison
48ea5852b6
Try and fix length and finfo calls for older clients. Working
...
on issues reported by kukks.
Jeremy.
(This used to be commit dcd77dd4f4
)
2008-02-08 11:22:53 -08:00
Jeremy Allison
c0e92cd4b8
Fix bug reported on IRC enumerating shares with OS/2.
...
Report and fix from kukks (thanks once again !).
Jeremy.
(This used to be commit 3ca58b792f
)
2008-02-08 10:07:05 -08:00
Karolin Seeger
2a6a2288c5
Fix some typos.
...
Karolin
(This used to be commit 2bec0a1fb7
)
2008-02-08 10:05:32 +01:00
Volker Lendecke
88c27f83d4
Convert receive_smb_raw to NTSTATUS
...
(This used to be commit ba771bd858
)
2008-02-02 11:03:23 +01:00
Volker Lendecke
6ddfa6ae77
read_socket_with_timeout_ntstatus->read_socket_with_timeout
...
(This used to be commit 90554799af
)
2008-02-02 11:03:22 +01:00
Volker Lendecke
5e43eeb1b6
Get rid of read_socket_with_timeout
...
(This used to be commit f9c8ac83ff
)
2008-02-02 11:03:22 +01:00
Günther Deschner
5ab43ae0d8
Eliminate remote tree of dsgetdcname (which will happen in libnetapi then).
...
Guenther
(This used to be commit fd490d236b
)
2008-01-29 15:09:56 +01:00
Tim Potter
54db183987
Adding missing calls to va_end().
...
Just a small commit to get a handle on this git thingy. This patch
fixes some missing calls to va_end() to match various calls to va_start()
and VA_COPY().
Tim.
(This used to be commit ec367f307d
)
2008-01-27 09:33:42 +01:00
Günther Deschner
372f74bba2
Add WERR_INVALID_COMPUTER_NAME.
...
Guenther
(This used to be commit cb1ff32eff
)
2008-01-24 23:41:59 +01:00
Derrell Lipman
2e7e3095a6
Merge branch 'setxattr-dos-mode' into v3-2-test
...
(This used to be commit 4c08725a42
)
2008-01-23 20:50:24 -05:00
Derrell Lipman
e0021b586d
Allow clearing all settable DOS mode bits. A mode value of zero is ignored by
...
Windows. If the requested mode is zero, we instead send the appropriate one
of 0x80 (NORMAL) or 0x10 (DIRECTORY).
Thanks Jeremy!
Derrell
(This used to be commit 54abf7d0e5
)
2008-01-23 20:44:54 -05:00
Jeremy Allison
ffc84a1044
Don't leak memory in error path.
...
Jeremy.
(This used to be commit 2df0cdaafd
)
2008-01-23 15:23:16 -08:00
Jeremy Allison
fe8a8f47e0
Use strchr_m in seaching for '.' in the hostname to make sure we're mb safe.
...
Jeremy.
(This used to be commit 090061b73a
)
2008-01-23 15:00:40 -08:00
Andreas Schneider
cfe7b54e96
Fix Windows 2008 (Longhorn) join.
...
During 'net ads join' the cli->desthost is a hostname (e.g.
rupert.galaxy.site). Check if we have a hostname and use only the
first part, the machine name, of the string.
(This used to be commit 5f60ed4af6
)
2008-01-23 14:57:45 -08:00
Andreas Schneider
691c4b1a41
Windows 2008 (Longhorn) auth2 flag fixes.
...
Interop fixes for AD specific flags. Original patch from Todd Stetcher.
(This used to be commit 5aadfcdaac
)
2008-01-23 14:55:22 -08:00
Volker Lendecke
a925a53f61
read_socket_with_timeout has timeout=0 handling
...
(This used to be commit 7101026061
)
2008-01-23 17:09:10 +01:00
Derrell Lipman
bb707b1db6
Fix typo that disabled setting group id. Thanks, Henrik.
...
(This used to be commit 843e1694cf
)
2008-01-18 14:22:49 -05:00
Volker Lendecke
3d3d6e7020
Add the "allinfo" command to smbclient
...
Modeled after the Samba4 allinfo command
(This used to be commit 3fa0cf3fe5
)
2008-01-18 11:08:17 +01:00
Michael Adam
80d7cccfe7
Add and correct some WERROR codes.
...
Michael
(This used to be commit 7aec862ddc
)
2008-01-18 01:10:55 +01:00
Derrell Lipman
4f09727df8
Fix bug 5185: repeated calls to smbc_getxattr() lose sid-name mapping
...
If we're going to cache connections to IPC$, we'd better also cache the policy
handle and not use a stack-based handle that's invalid on subsequent calls.
Derrell
(This used to be commit 67c415661f
)
2008-01-17 11:49:17 -05:00
Derrell Lipman
096e40c916
Fix stat results to be consistent between smbc_stat and smbc_fstat.
...
We create a kludged inode based on the checksum of the path. We therefore
need to use the same (full) path when calculating it in both smbc_stat() and
smbc_fstat().
If struct stat has an rdev field, set it to zero.
Derrell
(This used to be commit b4282fbd6d
)
2008-01-17 09:29:13 -05:00
Jeremy Allison
f44713df4d
Fix bug found by Derrell - windows returns an read return
...
offset of zero if return size is zero. Should fix testread
libsmbclient code.
Jeremy.
(This used to be commit df3c464839
)
2008-01-16 17:33:19 -08:00
Günther Deschner
d06559c1e6
Make resolve_ads() static.
...
Guenther
(This used to be commit 57dc747136
)
2008-01-16 16:06:15 +01:00
Derrell Lipman
6e94cbdc30
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
...
(This used to be commit f963d57096
)
2008-01-16 00:45:06 +00:00
Jeremy Allison
9a6a5fff9c
Fix the API exported for auth_functions. Ensure we call
...
passing 3 fstrings/sizeof(fstrings) as 3.0.x did. Found
by Derrell. Derrell please test !
Thanks,
Jeremy.
(This used to be commit 5467db3883
)
2008-01-15 16:13:11 -08:00
Kai Blin
ce9e918c95
libsmb: Do not upper-case target name on NTLMv2 hash generation
...
This makes our NTLMv2 hash generation compatible to the Davenport example
and fixes a bug when ntlm_auth is called with a non-upper-case --domain
parameter and client ntlmv2 auth = yes
Jerry, please consider for 3.2.0
(This used to be commit ecbe08897c
)
2008-01-15 19:29:08 +01:00
Derrell Lipman
9788383a6c
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
...
(This used to be commit 3a61e663e5
)
2008-01-15 13:58:47 +00:00
Jeremy Allison
d7582b5186
Windows insists on write sizes < max_xmit on signed connections.
...
Jeremy.
(This used to be commit ef9b278b62
)
2008-01-14 13:46:06 -08:00
Derrell Lipman
011e89c858
Fix smbc_listxattr() and friends (bug #5189 )
...
When the capability of using full names for DOS attributes was added, a bug
was introduced which caused the wrong number of bytes to be returned. This
patch to smbc_listxattr_ctx() fixes the problem.
Thanks to Jack Schmidt for this patch.
Derrell
(This used to be commit 913c335d21
)
2008-01-13 17:10:06 -05:00
Jeremy Allison
76d904e6d8
Fix CID 470. resolve_order can't be NULL here so simplify code.
...
Jeremy.
(This used to be commit 2e75f3ecdf
)
2008-01-12 00:05:07 -08:00
Günther Deschner
c79ce2ffa3
As long as DsGetDcName is not part of libnetapi, lowercase the fn name.
...
Guenther
(This used to be commit 19a980f520
)
2008-01-11 15:32:20 +01:00
Michael Adam
c0c299cb26
Fix a memleak found by the IBM checker.
...
Michael
(This used to be commit b4a37a66bb
)
2008-01-09 22:25:52 +01:00
Jeremy Allison
3eb2cfc1ad
Fix CID 461 - resource leak on error.
...
Jeremy.
(This used to be commit eea07b0c83
)
2008-01-08 18:51:55 -08:00
Günther Deschner
a8d200893a
Refactor our DsGetDcName call a bit (before it will move into libnetapi).
...
Guenther
(This used to be commit 41c129da3d
)
2008-01-07 23:06:12 +01:00
Jeremy Allison
1be3fcbf2f
Add the options smb_encrypt_level to set the requested
...
encrypt level and smb_encrypt_on to query it.
Jeremy.
(This used to be commit 07d47996f9
)
2008-01-05 00:51:18 -08:00
Jeremy Allison
9baa97a46e
Add general '-e' option to enable smb encryption
...
on tools.
Jeremy.
(This used to be commit 757653966f
)
2008-01-05 00:23:35 -08:00
Günther Deschner
395c366237
Do not pass emtpy wkssvc_PasswordBuffers to rpc functions.
...
Guenther
(This used to be commit fe75e5ccdf
)
2008-01-04 23:03:55 +01:00
Jeremy Allison
9254bb4ef1
Refactor the crypto code after a very helpful conversation
...
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
(This used to be commit c4e5a50504
)
2008-01-04 12:56:23 -08:00
Michael Adam
f215dec831
Map WERR_NO_SUCH_SERVICE with dos_errstr().
...
Michael
(This used to be commit df5839b537
)
2008-01-04 19:58:19 +01:00
Günther Deschner
f8dacb9860
Add some more join related werror codes.
...
Guenther
(This used to be commit 62e7d467ab
)
2008-01-03 18:15:14 +01:00
Jeremy Allison
6d9b2439d2
Added -e, --encrypt option to smbclient that immediately
...
forces encrypted smb after initial connect. Will document
for 3.2 official release.
Jeremy.
(This used to be commit f02bf41928
)
2007-12-29 22:39:52 -08:00
Volker Lendecke
240391be53
Make use of [un]marshall_sec_desc
...
(This used to be commit 54576733d6
)
2007-12-29 23:13:03 +01:00
Volker Lendecke
a59280792c
Remove tiny code duplication
...
sid_size did the same as ndr_size_dom_sid
(This used to be commit 8aec5d09ba
)
2007-12-29 23:12:51 +01:00
Volker Lendecke
533d6f617e
Remove static zeros
...
(This used to be commit dbcc213710
)
2007-12-28 17:02:34 +01:00
Jeremy Allison
3a52874815
Encryption works better when you add the client decrypt code :-).
...
Jeremy.
(This used to be commit d67b263406
)
2007-12-26 17:17:36 -08:00
Jeremy Allison
afc93255d1
Add SMB encryption. Still fixing client decrypt but
...
negotiation works.
Jeremy.
(This used to be commit d78045601a
)
2007-12-26 17:12:36 -08:00
Günther Deschner
c000a16645
Add get_friendly_werror_msg().
...
Guenther
(This used to be commit b1ad3def98
)
2007-12-21 15:28:21 +01:00
Günther Deschner
574354a7ec
Use ADS_IGNORE_PRINCIPAL define.
...
Guenther
(This used to be commit 763e13315f
)
2007-12-21 14:13:55 +01:00
Volker Lendecke
addf598cde
Some C++ warnings
...
(This used to be commit 5ab82d4f57
)
2007-12-21 09:58:20 +01:00
Volker Lendecke
5f1d36ce9a
Fix debug messages
...
When warning that "client plaintext auth" is not enabled where the server
requested them we should not talk about "client use plaintext auth"
(This used to be commit 7799e18994
)
2007-12-19 20:48:45 +01:00
Volker Lendecke
a37873490f
packet_struct is used in several places as raw memory
...
-> Fix more uninitialized variable warnings
(This used to be commit 0af02db6f2
)
2007-12-19 17:15:45 +01:00
Volker Lendecke
0743d384a6
Some paranoia checks
...
(This used to be commit ff644cfa1b
)
2007-12-19 16:57:48 +01:00
Volker Lendecke
2197801ef1
Zero the tdb key, there might be padding
...
This leads to uninitialized variable warnings if nmbd is run under valgrind.
(This used to be commit 9ec4f91f35
)
2007-12-19 16:57:40 +01:00
Günther Deschner
713e1536fe
Merge WERR_NO_SUCH_LOGON_SESSION from Samba4.
...
Guenther
(This used to be commit 7b52864787
)
2007-12-19 11:15:29 +01:00
Jeremy Allison
5dbc4a23bc
Added patch originally by Andreas Schneider <anschneider@suse.de>
...
to cause us to behave like Vista when looking for remote
machine principal. Modified by me.
Jeremy.
(This used to be commit d0e33840fb
)
2007-12-15 23:22:25 -08:00
Volker Lendecke
2e07c2ade8
s/sid_to_string/sid_to_fstring/
...
least surprise for callers
(This used to be commit eb523ba776
)
2007-12-15 22:47:30 +01:00
Volker Lendecke
14ef4cdec1
Replace sid_string_static with sid_to_string
...
This adds 28 fstrings on the stack, but I think an fstring on the stack is
still far better than a static one.
(This used to be commit c7c885078b
)
2007-12-15 22:09:37 +01:00
Volker Lendecke
d899b8c56a
Use sid_to_string directly
...
It seems a bit pointless to do a fstrcpy(dst, sid_string_static(src))
(This used to be commit c221c246b1
)
2007-12-15 22:09:36 +01:00
Volker Lendecke
900288a2b8
Replace sid_string_static by sid_string_dbg in DEBUGs
...
(This used to be commit bb35e794ec
)
2007-12-15 22:09:36 +01:00
Jeremy Allison
9e733924d9
Arg. The fix for CVE-2007-6015 hadn't been merged into 3.2.
...
Do so now....
Jeremy.
(This used to be commit 6b1246c29a
)
2007-12-13 16:44:24 -08:00
Günther Deschner
022014dba2
Make heimdal and MIT happy when iterating through auth data.
...
Guenther
(This used to be commit 507247dcbf
)
2007-12-12 18:58:26 +01:00
Guenther Deschner
1acd160800
Vista SP1-rc1 appears to break against Samba-3.0.27a
...
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Jason,
Jason Haar wrote:
> Patched 3.0.28, compiled, installed and here's the log file.
>
> Hope it helps. BTW I don't think it matters, but this is on 32bit
> CentOS4.5 systems.
yes, it helps. Thanks for that.
Very interesting, there are two auth data structures where the first one
is a PAC and the second something unknown (yet).
Can you please try the attached fix ? It should make it work again.
Guenther
- --
Günther Deschner GPG-ID: 8EE11688
Red Hat gdeschner@redhat.com
Samba Team gd@samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFHX9ZESOk3aI7hFogRAivSAJ9bMcD+PcsIzjYYLtAUoLNfVVEl1QCfV/Qd
MPsZW4G31VOVu64SPjgnJiI=
=Co+H
-----END PGP SIGNATURE-----
(This used to be commit c9adc07ca2
)
2007-12-12 09:52:51 -08:00
Jeremy Allison
e3e16928c0
Allow cliconnect to loop through multiple ip addresses
...
for a server. We should have been doing this for a while,
but it's more critical with IPv6.
Original patch fixed up by James.
Jeremy.
(This used to be commit 5c7f7629a9
)
2007-12-12 09:42:58 -08:00
Günther Deschner
f0d2edb9a0
Make decode_wkssvc_join_password_buffer() return WERRORs.
...
Guenther
(This used to be commit 88e9da2f14
)
2007-12-12 00:58:58 +01:00
Jeremy Allison
8596a1b609
Ensure we have a non-null flags. Pointed out by Andreas Schneider <anschneider@suse.de>.
...
Jeremy.
(This used to be commit cafde6c372
)
2007-12-10 15:06:31 -08:00
Jeremy Allison
921bbc1331
Fix errors from next_token conversion. Spotted by
...
Andreas Schneider <anschneider@suse.de>.
Jeremy.
(This used to be commit b40efc2fe6
)
2007-12-10 14:21:28 -08:00
Jeremy Allison
7faee02d0d
Remove the char[1024] strings from dynconfig. Replace
...
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2
)
2007-12-10 11:30:37 -08:00
James Peach
f78ce189c2
Support fetching very long server lists with RAP_NetServerEnum3.
...
Use the RAP_NetServerEnum3 server list continuation API for retrieving
server lists that are too long to fit in a single reply.
Patch from George Colley <gcolley@apple.com>.
(This used to be commit 40c26d5573
)
2007-12-09 14:18:54 -08:00
James Peach
39f0e6d22c
Specifically ask for IP4 addresses if we don't have IP6 support.
...
(This used to be commit 4786654992
)
2007-12-09 14:01:57 -08:00
Volker Lendecke
1e26ecf666
Fix C++ warnings
...
(This used to be commit 01a5c3ea4b
)
2007-12-08 09:39:36 -08:00
Jeremy Allison
42cfffae80
Remove next_token - all uses must now be next_token_talloc.
...
No more temptations to use static length strings.
Jeremy.
(This used to be commit ec003f3936
)
2007-12-07 17:32:32 -08:00
Jeremy Allison
acf15ae730
Don't build rpctorture anymore - not maintained. Just remove.
...
Remove all vestiges of pstring (except for smbctool as noted
in previous commit).
Jeremy
(This used to be commit 4c32a22ac5
)
2007-12-07 12:26:32 -08:00
Jeremy Allison
590da03ba3
Fix call to clistr_pull_talloc.
...
Jeremy.
(This used to be commit 86700b7e2e
)
2007-12-07 12:08:55 -08:00
Jeremy Allison
9e8180b983
Remove pstrings completely except for smbctool (what does this do ?).
...
Don't build this for now.
Jeremy.
(This used to be commit 46b67fd82c
)
2007-12-07 12:02:44 -08:00
Jeremy Allison
5b3459e340
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
...
(This used to be commit 0c21c5fa84
)
2007-12-07 09:57:19 -08:00
Günther Deschner
d3b4b69a27
Add NT_STATUS_DOWNGRADE_DETECTED (thanks to Magnus Mertens).
...
Guenther
(This used to be commit 970daaa0a6
)
2007-12-07 16:20:22 +01:00
Jeremy Allison
364b00295f
Fix clidfs.c compile.
...
Jeremy.
(This used to be commit 76034d1529
)
2007-12-06 17:17:03 -08:00
Jeremy Allison
1b92ea5559
Remove pstrings from client/client.c by doing a large rewrite.
...
Mostly compiles....
Jeremy.
(This used to be commit c87f3eba9a
)
2007-12-06 17:16:33 -08:00
Jeremy Allison
4acfce6b03
Don't understand this. I have no changes here....
...
Jeremy.
(This used to be commit 49534432d4
)
2007-12-06 10:10:16 -08:00
Jeremy Allison
8ab33fc335
Fix path length limits on cli_list (outgoing. Incoming
...
will be fixed with pstring elimination).
Jeremy.
(This used to be commit cd43b93d40
)
2007-12-05 16:56:19 -08:00
Jeremy Allison
1938e861d0
Remove arbitrary 1k limit on pathnames. Malloc them.
...
Jeremy.
(This used to be commit 71770b4c1d
)
2007-12-05 13:31:24 -08:00
Volker Lendecke
195d6be38d
remove some statics
...
(This used to be commit 97c9a4042d
)
2007-12-05 14:39:07 +01:00
Volker Lendecke
78c6ee0090
Remove some globals
...
(This used to be commit 31d0a846db
)
2007-12-05 14:39:07 +01:00
Jeremy Allison
774a30989a
Fix signing bug found by Volker. That one was *subtle*.
...
Jeremy
(This used to be commit 816aea6c1a
)
2007-12-04 13:30:22 -08:00
Jeremy Allison
d3609c4c89
Don't forget to delete the stackframe.
...
Jeremy.
(This used to be commit 0551ee3402
)
2007-12-03 18:56:54 -08:00
Jeremy Allison
fe1a12b22f
Remove pstring from clirap2 by completely rewriting the damn
...
thing :-). Now with added paranoia.
Jeremy.
(This used to be commit b6b5f92bc9
)
2007-12-03 14:09:48 -08:00
Günther Deschner
41418ed682
Add decode_wkssvc_join_password_buffer().
...
Guenther
(This used to be commit ba2a544baf
)
2007-12-03 14:06:52 +01:00
Volker Lendecke
bbf2cb6da9
Fix some C++ warnings
...
(This used to be commit 156c7f10bb
)
2007-12-01 10:43:35 -08:00
Volker Lendecke
4a3ee48de5
Fix an uninitialized variable
...
(This used to be commit edce7bd7a9
)
2007-12-01 10:43:23 -08:00
Jeremy Allison
a17a13f7ce
Fix missing error cleanup noticed by Derrell.
...
Jeremy.
(This used to be commit 37f00926c2
)
2007-11-30 21:57:43 -08:00
Jeremy Allison
d19861e29d
Ensure we have 2 bytes of zeros as a pad-buffer at the
...
end of all returned trans/trans2/nttrans client replies.
Not included in a count - for safety purposes.
Jeremy.
(This used to be commit 3e65fa5bcf
)
2007-11-30 18:02:19 -08:00
Jeremy Allison
e23fea9201
Whitespace cleanup.
...
Jeremy.
(This used to be commit 4dfe19be1c
)
2007-11-30 16:45:44 -08:00
Jeremy Allison
4e266bd60f
Remove pstring from clirap.c.
...
Jeremy.
(This used to be commit 6e27663cb4
)
2007-11-30 16:13:35 -08:00
Jeremy Allison
b37ae99c35
Removed all pstrings from libsmbclient. Derryl please
...
check. Passes valgrind tests I've run in examples/libsmbclient.
Jeremy.
(This used to be commit 9d0034faed
)
2007-11-30 14:19:55 -08:00
Günther Deschner
22cf7f5ffa
Merge join error codes from Samba 4.
...
Guenther
(This used to be commit 88a01bd810
)
2007-11-30 22:25:01 +01:00
Günther Deschner
c224118ffe
Make encode_wkssvc_join_password_buffer() non-static.
...
Guenther
(This used to be commit 258ef17a26
)
2007-11-30 22:25:01 +01:00
Günther Deschner
5886f7c9f6
Merge encode_wkssvc_join_password_buffer() from samba4.
...
Guenther
(This used to be commit b1d36cdb86
)
2007-11-30 22:25:00 +01:00
Jeremy Allison
810f760afd
Add talloc versions of all the next_token() functions.
...
Now I can really start removing fixed length strings...
Jeremy.
(This used to be commit 0ae61e2654
)
2007-11-30 13:09:04 -08:00
Jeremy Allison
5b184c3525
Remove pstrings from clifile.c.
...
Jeremy.
(This used to be commit d5658914c2
)
2007-11-29 17:47:31 -08:00
Jeremy Allison
f692694b99
Remove PSTRING_LEN from smbd/ nmbd/.
...
Remove pstring from libsmb/clidfs.c except for a nasty
hack (that will be removed when pstrings are gone from
client/).
Jeremy.
(This used to be commit cc257b71d1
)
2007-11-29 17:25:41 -08:00
Jeremy Allison
d2cf97aeba
Remove the explicit TALLOC_CTX * from cli_struct.
...
Make us very explicit about how long a talloc ctx
should last.
Jeremy.
(This used to be commit ba9e2be2b5
)
2007-11-29 13:24:54 -08:00
Jeremy Allison
42c87fe6e6
Remove pstrings. Ensure we validate offsets.
...
Jeremy.
(This used to be commit ff06cc34e6
)
2007-11-29 13:24:14 -08:00
Jeremy Allison
eced14c6e6
Remove unused code (and pstring).
...
Jeremy.
(This used to be commit a261a61226
)
2007-11-28 14:08:49 -08:00
Jeremy Allison
3daafc5662
Remove pstrings from asn1.c.
...
Jeremy.
(This used to be commit 82f393e603
)
2007-11-27 23:40:54 -08:00
Jeremy Allison
762fde90a0
Remove pstrings from namequery.c.
...
Jeremy.
(This used to be commit 71ccd0c42e
)
2007-11-27 23:10:20 -08:00
Volker Lendecke
1011b32678
Remove some statics
...
(This used to be commit 1fab16ffb8
)
2007-11-27 14:18:47 +01:00
Volker Lendecke
bff221cf1b
In libsmbclient, map NT_STATUS_OBJECT_PATH_NOT_FOUND to ENOENT
...
Thanks to SATOH Fumiyasu!
This fixes bug 4974
(This used to be commit 41e07682dc
)
2007-11-25 12:54:52 +01:00
Volker Lendecke
d2c2635a28
Make remote_password_change return malloced error strings
...
This fixes a segfault in smbpasswd -r
(This used to be commit 49949f0b85
)
2007-11-23 13:04:50 -08:00
Jeremy Allison
de51d3dd5f
More pstring removal....
...
Jeremy.
(This used to be commit 809f5ab4c5
)
2007-11-20 18:55:36 -08:00
Jeremy Allison
cae4c742a8
Always check return from push_ascii.
...
Jeremy.
(This used to be commit 9c3d10521e
)
2007-11-19 17:43:28 -08:00
Volker Lendecke
428e663100
Add stackframes to public libsmbclient functions
...
As we use talloc_tos() in inner libsmbclient/ functions more and more, we need
to make sure not to create memleaks by not free'ing talloc stackframes. This
patch wraps all calls in libsmbclient.c that are publically exported into a
talloc_stackframe()/talloc_free() pair.
Jeremy, Derrell, can you check this?
Thanks,
Volker
(This used to be commit db9fa472a8
)
2007-11-19 16:42:03 -08:00