1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

80214 Commits

Author SHA1 Message Date
Jeremy Allison
6f3e011f84 Fix bug #8873 - self granting privileges in security=ads.
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May  1 01:04:46 CEST 2012 on sn-devel-104
2012-05-01 01:04:46 +02:00
Jeremy Allison
1270cfb45f Fix the loop unrolling inside resolve_ads(). If we don't get
an IP list don't use interpret_string_addr(), as this only
returns one address, use interpret_string_addr_internal()
instead.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Apr 30 23:21:16 CEST 2012 on sn-devel-104
2012-04-30 23:21:16 +02:00
Jeremy Allison
1197360818 Protect all of the name resolution methods from returning null addrs. Ensure all returns go through remove_duplicate_addrs2(). 2012-04-30 09:26:37 -07:00
Jeremy Allison
50766a72f9 Fix convert_ss2service() to filter out zero addresses. 2012-04-30 09:26:37 -07:00
Jeremy Allison
01e884675e Fix remove_duplicate_addrs2 to do exactly what it says. Previously it could leave zero addresses in the list. 2012-04-30 09:26:37 -07:00
Matthias Dieter Wallnöfer
9126f33a57 s4:samldb LDB module - homogenize LDB search attributes arrays
First they do not need to be "static" any longer since we have abandoned
asynchronous result handling (where global variables have been important).
In addition add some "const" in order to protect us from unwanted writes.

Reviewed-by: Andrew Bartlett

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Apr 30 16:46:20 CEST 2012 on sn-devel-104
2012-04-30 16:46:20 +02:00
Andrew Bartlett
887487851f s4-libnet: Add mem_ctx to libnet_rpc_groupdel calls (bug #8889)
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 14:41:36 CEST 2012 on sn-devel-104
2012-04-30 14:41:36 +02:00
Andrew Bartlett
566f066a8d s4-libnet: Add mem_ctx to libnet_rpc_groupadd calls (bug #8889) 2012-04-30 13:08:28 +02:00
Andrew Bartlett
b72597c6e3 s4-libnet: Add mem_ctx to libnet_rpc_usermod calls (bug #8889) 2012-04-30 13:08:28 +02:00
Andrew Bartlett
08f8eb4407 s4-libnet: Add mem_ctx to libnet_rpc_userdel calls (bug #8889) 2012-04-30 13:08:28 +02:00
Andrew Bartlett
fd2b21fc38 s4-libnet: Add mem_ctx to libnet_rpc_useradd calls (bug #8889) 2012-04-30 13:08:28 +02:00
Andrew Bartlett
081e7909fc s4-libnet: Add mem_ctx to libnet_rpc_groupinfo calls (bug #8889) 2012-04-30 13:08:28 +02:00
Andrew Bartlett
a6fa69c1b2 s4-libnet: Add mem_ctx to libnet_DomainClose calls (bug #8889) 2012-04-30 13:08:28 +02:00
Andrew Bartlett
74682826d9 s4-libnet: Add mem_ctx to libnet_DomainOpen calls (bug #8889) 2012-04-30 13:08:28 +02:00
Andrew Bartlett
2d8b6ce1c1 s4-libnet: Add mem_ctx to libnet_Lookup calls (bug #8889) 2012-04-30 13:08:28 +02:00
Christof Schmitt
be8180e030 net: Let get*sid return error from passdb init
When initialize_password_db returns an error this means that the SID
stored in the backend cannot be read. Return this error directly
instead of creating a random SID through get_global_sam_sid.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Apr 30 13:07:20 CEST 2012 on sn-devel-104
2012-04-30 13:07:20 +02:00
Christof Schmitt
6e583c72cc passdb: Do not panic in initialize_password_db
A call to initialize_password_db leads to smb_panic in case the backend
returns an error. All callers to initialize_password_db check the return
value, so this code path should return the status instead of calling
smb_panic.

Move the call to smb_panic from pdb_get_methods_reload pdb_get_methods
to get it out of the initialize code path.  This allows printing the
proper error message for 'net getlocalsid' which is much nicer than
printing the panic stack trace.
2012-04-30 11:30:29 +02:00
Andrew Bartlett
dabb056250 s3-auth_samba4: use new_server_id_task() to allocate server id values
This is rather than just picking a random number out of the air.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 11:29:34 CEST 2012 on sn-devel-104
2012-04-30 11:29:34 +02:00
Andrew Bartlett
442a81e7b2 s3-lib Add a way to allocate the task_id value in server_id
This safely allocates the task_id so that when we have multiple event
contexts, they can each have their own messaging context, particularly
for the imessaging subsystem under source4.

Andrew Bartlett
2012-04-30 17:55:12 +10:00
Andrew Bartlett
f10c638100 s4-messaging: Fill in the whole server_id in all use cases
This started per https://bugzilla.samba.org/show_bug.cgi?id=8872#c4
and avoids any possible collision with a different process.

We also need to ensure that across a Samba installation on a single
node that id.vnn is the same.  Samba4 previously used 0, while Samba3
used NONCLUSTER_VNN.  When a message is sent between these 'different'
nodes, the error NT_STATUS_INVALID_DEVICE_REQUEST is raised.

Andrew Bartlett
2012-04-30 17:55:11 +10:00
Andrew Bartlett
645e4bb436 s4-torture: convert samba3misc tests to use torture_failure and torture_assert
This helps us when these tests fail, as subunit-formatted failures can
be declared as knownfail entries, and show up correctly in the make
test output.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 08:34:52 CEST 2012 on sn-devel-104
2012-04-30 08:34:51 +02:00
Andrew Bartlett
6b982c365c s4-torture: move samba3 tests to use torture helper functions 2012-04-30 07:00:05 +02:00
Andrew Bartlett
7e9ed05277 s4-torture: Move various samba3 tests to the torture_suite_add_1smb_test wrapper 2012-04-30 07:00:05 +02:00
Matthias Dieter Wallnöfer
773304ec8b s4:samldb LDB module - implement "fSMORoleOwner" attribute protection
This is a very essential attribute since it references to various domain
master roles (PDC emulator, schema...) depending on which entry it has
been set. Incautious modifications can cause severe problems.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 02:04:24 CEST 2012 on sn-devel-104
2012-04-30 02:04:23 +02:00
Matthias Dieter Wallnöfer
cd5d282a46 s4:dsdb/common/util.c - samdb_is_pdc() - fail if the "fSMORoleOwner" attribute has not been set 2012-04-29 19:06:52 +02:00
Matthieu Patou
b019248fe8 Add some debug for FOOBAR return case as they are hard to diagnose
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Apr 29 09:08:15 CEST 2012 on sn-devel-104
2012-04-29 09:08:15 +02:00
Matthieu Patou
3616735010 dsdb: more RELAX to DBCHECK control shift so that only dbcheck can do uncontrolled changes 2012-04-29 07:35:10 +02:00
Matthieu Patou
441b20872b dsdb: change control from relax to dbcheck
Comment indicate that this is needed by dbcheck only and it permits
other projects to push broken schema and remain undetected
2012-04-29 07:35:10 +02:00
Matthieu Patou
e2a16909a1 dns server: move very verbose debug to higher level 2 -> 8 2012-04-29 07:35:09 +02:00
Volker Lendecke
5712e5199e s3: Remove a SMB_ASSERT
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Apr 28 23:38:45 CEST 2012 on sn-devel-104
2012-04-28 23:38:45 +02:00
Volker Lendecke
4a28c6ca7c s3: Fix bug 8904 -- wbinfo --lookup-sids "" crashes winbind
Much of the code further down and up the call chain expects the
structures wb_lookupsids returns to be allocated. Do that despite
we have nothing to look up.
2012-04-28 22:04:14 +02:00
Richard Sharpe
0dc3f423d2 Add an audit file VFS routine so we can handle auditing with SACLs.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Sat Apr 28 08:05:00 CEST 2012 on sn-devel-104
2012-04-28 08:05:00 +02:00
Michael Adam
12ee793332 s4:torture: add a check for talloc success in rpc.samba3.randomauth2
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Apr 28 02:10:39 CEST 2012 on sn-devel-104
2012-04-28 02:10:38 +02:00
Michael Adam
97d0b8bfff s4:torture: add a check for talloc success in the rpc.samba3 suite 2012-04-28 00:34:36 +02:00
Michael Adam
8825274f6c s4:torture: add a rpc.samba3.smb2-reauth2 test
like smb-reauth2, only for smb2
2012-04-28 00:31:57 +02:00
Michael Adam
0508f84426 s4:torture: add a rpc.samba3.smb2-reauth1 test 2012-04-27 17:44:06 +02:00
Stefan Metzmacher
5629eb7802 s4:librpc: create a binding on the pipe if necessary in dcerpc_pipe_open_smb2_send()
Pair-Programmed-With: Michael Adam <obnox@samba.org>
2012-04-27 17:44:06 +02:00
Andrew Bartlett
2f35c246fc selftest: Add test to ensure that bug #8872 does not come back
The raw.composite test checks that we handle mutliple concurrent connections.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Apr 27 16:25:37 CEST 2012 on sn-devel-104
2012-04-27 16:25:37 +02:00
Andrew Bartlett
0cb0427f13 selftest: Place the test environment at the end of the failure lines
This allows a knownfail entry to be added for only one environment, rather than
all environments.

Andrew Bartlett
2012-04-27 14:51:05 +02:00
Andrew Bartlett
67a851a050 selftest: Remove silly space before unit test name
When we have no description, there is no need for a leading space here

Andrew Bartlett
2012-04-27 14:51:05 +02:00
Stefan Metzmacher
34ffa6175b s3:winbindd: also try SMB2 when connecting to "IPC$"
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Apr 27 13:10:15 CEST 2012 on sn-devel-104
2012-04-27 13:10:15 +02:00
Stefan Metzmacher
b3a3c50eb8 s3:libsmb/cli_np_tstream: add support for SMB2
metze
2012-04-27 08:31:39 +02:00
Stefan Metzmacher
b88d649e40 s3:libsmb/cli_np_tstream: remove unused tstream_cli_np_existing()
metze
2012-04-27 08:31:38 +02:00
Stefan Metzmacher
8422ab2609 s3:libsmb: add smb2cli_ioctl*
metze
2012-04-27 08:31:38 +02:00
Stefan Metzmacher
42b403c19f libcli/smb: move SMB2_IOCTL_FLAG_IS_FSCTL to smb2_constants.h
metze
2012-04-27 08:31:37 +02:00
Stefan Metzmacher
2ccf5f67a5 s4:ntvfs/ipc: don't echo back the smb2 ioctl input_buffer
metze
2012-04-27 08:31:37 +02:00
Volker Lendecke
54a6d7b3b8 s3: oplock_timeout is a talloc child of fsp
Jeremy, I know you like it explicit, but I stumbled across this
explicit TALLOC_FREE and asked myself about a potentially wrong
talloc hierarchy.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Apr 26 23:00:03 CEST 2012 on sn-devel-104
2012-04-26 23:00:03 +02:00
Volker Lendecke
21985a7f10 s3: Remove code TALLOC_FREE already does 2012-04-26 21:26:27 +02:00
Matthieu Patou
307e2d1387 torture: change dfs tests now that we return a level 4 when level 4 is requested
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Thu Apr 26 21:25:37 CEST 2012 on sn-devel-104
2012-04-26 21:25:37 +02:00
Matthieu Patou
a73b1ed580 dfs_server: fix the response to please XP and Windows 2008R2 doing so avoid continious DFS requests from W2K8R2 2012-04-26 19:51:08 +02:00