1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Commit Graph

1200 Commits

Author SHA1 Message Date
Michael Adam
2e99e141c3 r24991: Kill all those lots of trailing whitespaces from secrets.c.
These red bars in vi really hurt my eyes... :-o

Michael
2007-10-10 12:30:31 -05:00
Michael Adam
b9e76a479e r24990: Kill an incredible amount of trailing whitespaces...
Further reformat get_trust_pw to conform to coding rules.

Michael
2007-10-10 12:30:31 -05:00
Andrew Tridgell
87c91e4362 r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
Andrew Tridgell
b0132e94fc r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text 2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b r23779: Change from v2 or later to v3 or later.
Jeremy.
2007-10-10 12:28:20 -05:00
Jeremy Allison
f3bb102c24 r23688: Fix bug #4759 reported by Raul <ismell@ismell.org>.
"N" is not a valid format entry for ber_printf, should be "n"
Jeremy.
2007-10-10 12:23:45 -05:00
Günther Deschner
e744efa1ee r23630: Found out what LSA_LOOKUP_NAMES level 5 means:
only query transitive forest trusts.

Guenther
2007-10-10 12:23:38 -05:00
James Peach
171dc060e2 r23510: Tidy calls to smb_panic by removing trailing newlines. Print the
failed expression in SMB_ASSERT.
2007-10-10 12:23:23 -05:00
Gerald Carter
bcc8a3290a r23244: Fix loop with nscd and NSS recusive calls.
> Here's the problem I hit:
>
> getgrnam("foo") -> nscd -> NSS -> winbindd ->
>   winbindd_passdb.c:nam_to_sid() -> lookup_global_sam_name() ->
>   getgrnam("foo") -> nscd -> ....
>
> This is in the SAMBA_3_0 specifically but in theory could happen
> SAMBA_3_0_25 (or 26) for an unknown group.
>
> The attached patch passes down enough state for the
> name_to_sid() call to be able to determine the originating
> winbindd cmd that came into the parent.  So we can avoid
> making more NSS calls if the original call came in trough NSS
> so we don't deadlock ?  But you should still service
> lookupname() calls which are needed for example when
> doing the token access checks for a "valid groups" from
> smb.conf.
>
> I've got this in testing now.  The problem has shown up with the
> DsProvider on OS X and with nscd on SOlaris and Linux.
2007-10-10 12:22:58 -05:00
Gerald Carter
3c9fb1c6f3 r23194: cherry pick two fixes from SAMBA_3_0_26
* strptime() failure check
* make legcacy sid/uid/gid calls static
2007-10-10 12:22:53 -05:00
Gerald Carter
6af4c1a73c r23192: Remove fallback to looking up group mappings by the
Unix name after discussion with Simo.
2007-10-10 12:22:53 -05:00
Simo Sorce
2d636ad2a3 r23051: sid_to_[ug]id fixes for smbd 2007-10-10 12:22:17 -05:00
Gerald Carter
3d48a7e72d r23046: Few missing merges from cleaning out the Centeris winbindd tree.
Nothing of major interest.  Will fix a few problems with one way trusts.
2007-10-10 12:22:17 -05:00
Jeremy Allison
4e1a0b2549 r23005: If we're running on a system where time_t is 8 bytes
we have to take care to preserve the "special" values
for Windows of 0x80000000 and 0x7FFFFFFF when casting
between time_t and uint32. Add conversion functions
(and use them).
Jeremy.
2007-10-10 12:22:13 -05:00
Gerald Carter
51aac0fcb4 r22977: Trim noise by removing redundant WARNING log message that
would flood at log level 2.  We know when we're using the legacy
mapping code anyways since it will log an informative msg.
2007-10-10 12:22:12 -05:00
Volker Lendecke
3d3d61687e r22844: Introduce const DATA_BLOB data_blob_null = { NULL, 0, NULL }; and
replace all data_blob(NULL, 0) calls.
2007-10-10 12:22:01 -05:00
Volker Lendecke
590d2164b3 r22786: Some cleanup by Karolin Seeger: Remove unused pdb_find_alias, and change
return values of some alias-releated pdb functions from BOOL to NTSTATUS

Thanks :-)
2007-10-10 12:21:57 -05:00
Volker Lendecke
2c5b951eba r22767: Argl. Typed in 'svn ci' in the wrong branch. Revert. 2007-10-10 12:21:55 -05:00
Volker Lendecke
fb6ac8a5b2 r22766: Merge from 3_0:
r22412 | obnox | 2007-04-20 14:23:36 +0200 (Fr, 20 Apr 2007) | 5 lines

Add a "deletelocalgroup" subcommand to net sam.

Thanks to Karolin Seeger <ks@sernet.de>.
2007-10-10 12:21:55 -05:00
James Peach
bbc102172a r22631: Remove the possibility of sid_check_is_domain and
sid_check_is_in_our_domain getting out of sync.
2007-10-10 12:19:51 -05:00
Volker Lendecke
d4c5d5ffb3 r22613: Fix an uninitialized variable warning 2007-10-10 12:19:50 -05:00
Jeremy Allison
8968808c3b r22589: Make TALLOC_ARRAY consistent across all uses.
Jeremy.
2007-10-10 12:19:49 -05:00
Volker Lendecke
1c0ceb5fe2 r22125: Fix a warning 2007-10-10 12:19:14 -05:00
Jeremy Allison
f3ffb3f984 r22096: become_root_uid_only() is unneeded - it's only used in
messages.c. Refactor to use become_root() instead and
make it local to messages.c
Jeremy.
2007-10-10 12:19:11 -05:00
Gerald Carter
fc1aeee52d r22066: Ensure that winbind can resolve SIDs in the S-1-22-{1,2}
domain to a uid.gid using the idmap_passdb backend.
2007-10-10 12:19:09 -05:00
Stefan Metzmacher
3a28443079 r22009: change TDB_DATA from char * to unsigned char *
and fix all compiler warnings in the users

metze
2007-10-10 12:19:00 -05:00
Stefan Metzmacher
fa322f0cc9 r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.

also fix all the callers to prevent compiler warnings

metze
2007-10-10 12:18:59 -05:00
Stefan Metzmacher
5a5579d842 r21983: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

metze
2007-10-10 12:18:56 -05:00
Stefan Metzmacher
9ebaa4c573 r21982: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

metze
2007-10-10 12:18:55 -05:00
Stefan Metzmacher
2d2f809968 r21981: as we use tdb_trans_store(), we should also use tdb_trans_delete()
metze
2007-10-10 12:18:55 -05:00
Jeremy Allison
8ff76a9cb8 r21954: Someone misused a '!' instead of a '~' for a binary NOT
command. Jerry, Simo, please check.
Jeremy.
2007-10-10 12:18:52 -05:00
James Peach
86a70adb6a r21881: Make sure we are very specific when testing whether a backand can handle a
particular SID. Make sure that the passdb backend will accept the same set
range of local SIDs that the idmap system sends it.

Simo, Jerry - this is a 3_0_25 candidate. Can you please review?
2007-10-10 12:18:43 -05:00
Volker Lendecke
d0d16cc55a r21853: Fix a valgrind error 2007-10-10 12:18:38 -05:00
Volker Lendecke
fd0ee6722d r21831: Back out r21823 for a while, this is going into a bzr tree first.
Volker
2007-10-10 12:18:37 -05:00
Volker Lendecke
f94e5af72e r21823: Let secrets_store_machine_password() also store the account name. Not used
yet, the next step will be a secrets_fetch_machine_account() function that
also pulls the account name to be used in the appropriate places.

Volker
2007-10-10 12:18:36 -05:00
Volker Lendecke
4efc7b4598 r21819: Wrap all steps in secrets_store_machine_password into one single
transaction. Succeed all or store nothing.

Volker
2007-10-10 12:18:36 -05:00
Volker Lendecke
f88eab91c4 r21818: Remove some unused code 2007-10-10 12:18:36 -05:00
Volker Lendecke
af3308ce5a r21784: Replace smb_register_idle_event() with event_add_timed(). This fixes winbind
who did not run the idle events to drop ldap connections.

Volker
2007-10-10 12:18:33 -05:00
Volker Lendecke
a2dc1f62fd r21782: Fix a memleak 2007-10-10 12:18:33 -05:00
James Peach
7246b31696 r21738: Remove unused file. 2007-10-10 12:18:27 -05:00
Jeremy Allison
df07a662e3 r21609: Fix memory leaks in error code paths (and one in winbindd_group.c).
Patch from Zack Kirsch <zack.kirsch@isilon.com>.
Jeremy.
2007-10-10 12:18:16 -05:00
Jeremy Allison
cbe725f1b0 r21608: Fix a couple of memleaks in error code paths before
Coverity finds them :-)
Jeremy.
2007-10-10 12:18:16 -05:00
Simo Sorce
5b4838f62a r21606: Implement escaping function for ldap RDN values
Fix escaping of DN components and filters around the code
Add some notes to commandline help messages about how to pass DNs

revert jra's "concistency" commit to nsswitch/winbindd_ads.c, as it was
incorrect.
The 2 functions use DNs in different ways.

- lookup_usergroups_member() uses the DN in a search filter,
and must use the filter escaping function to escape it
Escaping filters that include escaped DNs ("\," becomes "\5c,") is the
correct way to do it (tested against W2k3).

- lookup_usergroups_memberof() instead uses the DN ultimately as a base dn.
Both functions do NOT need any DN escaping function as DNs can't be reliably
escaped when in a string form, intead each single RDN value must be escaped
separately.

DNs coming from other ldap calls (like ads_get_dn()), do not need escaping as
they come already escaped on the wire and passed as is by the ldap libraries

DN filtering has been tested.
For example now it is possible to do something like:
'net ads add user joe#5' as now the '#' character is correctly escaped when
building the DN, previously such a call failed with Invalid DN Syntax.

Simo.
2007-10-10 12:18:16 -05:00
Gerald Carter
6a69caf690 r21507: Fix some "cannot access LDAP when no root" bugs.
The two culprits were

* pdb_get_account_policy()
* pdb_get_group_sid()
2007-10-10 12:18:09 -05:00
Volker Lendecke
a5a1c8c785 r20998: Fix debug message 2007-10-10 12:17:25 -05:00
Gerald Carter
2a7311db27 r20985: leave room for terminating NULL when printing password hashes via 'pdbedit -L -w' 2007-10-10 12:17:22 -05:00
Volker Lendecke
b48ea4d777 r20851: To read account policies from LDAP we need root.
Volker
2007-10-10 12:17:13 -05:00
Volker Lendecke
3c879745cf r20824: Send access to the trusted domain passwords through the pdb backend, so that
in the next step we can store them in LDAP to be replicated across DCs.

Thanks to Michael Adam <ma@sernet.de>

Volker
2007-10-10 12:17:10 -05:00
Volker Lendecke
d78c18a9fa r20707: Clean up pdb_interface.c a bit -- patch from Michael Adam <ma@sernet.de> 2007-10-10 12:17:04 -05:00
Volker Lendecke
f1f5d035db r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> for the hint. 2007-10-10 12:17:01 -05:00