sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-04-30 18:53:31 +03:00
Code
78,835 Commits 62 Branches 1,158 Tags
Commit Graph

32 Commits

Author SHA1 Message Date
Jelmer Vernooij
a0ff4c349c Revert "samba-tool: moved takes_optiongroups definition to Command base class" 
This reverts commit f6fa8684896b8f3f9f8b7bd3742c99906973274c.

This keeps the main command class fairly slim, and makes it a bit
more obvious where the arguments to run() are coming from.

Conflicts:

	source4/scripting/python/samba/netcmd/__init__.py
	source4/scripting/python/samba/netcmd/domain.py
	source4/scripting/python/samba/netcmd/gpo.py
	source4/scripting/python/samba/netcmd/newuser.py
	source4/scripting/python/samba/netcmd/testparm.py
	source4/scripting/python/samba/netcmd/user.py
	source4/scripting/python/samba/tests/samba_tool/__init__.py
 2012-02-07 01:11:08 +01:00
Amitay Isaacs
1f0298dd1b python: Change except: statement to except Exception: 
This way we only catch true exceptions and keyboard interrupts
are not caught here.

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue Jan 24 03:32:40 CET 2012 on sn-devel-104
 2012-01-24 03:32:40 +01:00
Andrew Tridgell
86338ab551 dbcheck: cope with objects disappearing during checking 
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Dec  8 03:23:49 CET 2011 on sn-devel-104
 2011-12-08 03:23:49 +01:00
Jelmer Vernooij
9213f398ad samba-tool: Don't require full prog line to be in synopsis. 2011-10-14 00:22:57 +02:00
Jelmer Vernooij
88d997a63e samba-tool: Use self.outf in a few more places. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 13 05:06:52 CEST 2011 on sn-devel-104
 2011-10-13 05:06:52 +02:00
Andrew Tridgell
0921e75001 s4-dbcheck: fixed transaction nesting in dbcheck 
ensure we don't cancel a transaction we didn't start

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Sep 22 03:39:59 CEST 2011 on sn-devel-104
 2011-09-22 03:39:59 +02:00
Giampaolo Lauria
342146e0b4 samba-tool: Fixed "dbcheck" subcommand syntax 
Fixed syntax for "dbcheck" subcommand

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
 2011-09-09 15:24:04 +10:00
Jelmer Vernooij
6eb496cf45 dbcheck: Cancel transaction if operation fails. 
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Aug  2 01:41:07 CEST 2011 on sn-devel-104
 2011-08-02 01:41:07 +02:00
Giampaolo Lauria
41f073eb60 samba-tool: add -H or --URL where necessary 
To improve consistency, I've made sure all the commands take either a -H
or --URL when specifying a URL

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-07-28 15:20:51 +10:00
Giampaolo Lauria
f6fa868489 samba-tool: moved takes_optiongroups definition to Command base class 
The option groups should be defined at the Command base class level as they are in common across all samba-tool commands.
Major move advantages:
1. more OOP approach
2. enforcing consistency across commands
3. avoiding the need of declaring for every new command

Signed-off-by: Andrew Tridgell <tridge@samba.org>
 2011-07-21 10:32:24 +10:00
Andrew Tridgell
534c1ca00e dbcheck: fixed ldap check with no database specified 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
 2011-07-13 12:51:05 +02:00
Andrew Tridgell
0ab3086b46 dbcheck: added --reindex option 
this allows you to force a reindex of the database

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-07-13 12:51:05 +02:00
Andrew Tridgell
e14725c8fe dbcheck: check all objects, including deleted objects 
this makes dbcheck search over all objects, deleted or not. This
matters because when another DC replicates from this DC it replicates
the deleted objects as well, so invalid attributes in deleted objects
can cause problems on the new DC (for example, windows can get stuck
or even crash during the replication)

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
 2011-07-11 14:32:44 +10:00
Andrew Tridgell
059941b6e7 dbcheck: use specified DB schema for non-LDAP URLs 
when connecting to a local database with -H we can use that databases
schema

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
 2011-07-11 14:32:44 +10:00
Andrew Tridgell
c6985f1e7e dbcheck: only use a paged search when checking a ldap database 
paged searches don't work against a local database (they return only
the first N objects)
 2011-07-05 07:10:03 +02:00
Andrew Tridgell
4fe9ebc2e3 dbchecker: fixed argument error for -H and DN 2011-06-22 20:13:08 +02:00
Andrew Tridgell
9676c26fdd samba-tool: added --attrs option to dbcheck 
this allows checking of a specific list of attributes
 2011-06-22 20:13:08 +02:00
Andrew Tridgell
7fff636bce samba-tool: make the dbcheck class available outside of samba-tool 
this will be used in provision, and probably in upgradeprovision as
well
 2011-06-22 20:13:08 +02:00
Andrew Tridgell
9be9f0e43c samba-tool: added --quiet option to dbcheck 
this will be used to allow for other tools (such as provision) to call
into dbcheck without generating a lot of noise
 2011-06-22 20:13:08 +02:00
Andrew Tridgell
6d1fe054dd samba-tool: allow for running dbcheck against a remove ldap server 
this is useful for running it against a Windows server
 2011-06-22 11:16:26 +02:00
Andrew Tridgell
ff8cdeecfc samba-tool: expanded dbcheck DN checking 
this now checks for bad GUID elements in DN links, and offers to fix
them when possible

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-06-22 11:16:26 +02:00
Andrew Tridgell
9e766f019b samba-tool: added missing GUID component checks to dbcheck 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Jun 22 07:59:30 CEST 2011 on sn-devel-104
 2011-06-22 07:59:30 +02:00
Andrew Tridgell
c4a7908f46 samba-tool: try to keep dbcheck.py in a logical ordering 
keep individual error handlers together and separate from driver code
 2011-06-22 14:47:07 +10:00
Matthieu Patou
9c94943d26 s4-sambatool: extract the confirm function in a separte module for reuse 2011-06-19 23:21:09 +02:00
Matthieu Patou
bc549575dd s4-samba-tool: remove unused imports 2011-06-19 23:21:08 +02:00
Matthieu Patou
db03091607 s4-samba-tool: use correct object notation ie. obj.method rather than method(obj, ...) 2011-06-19 23:21:08 +02:00
Matthieu Patou
8a04863f0d s4-sambatool: use correct way to call class methods 2011-06-19 23:21:08 +02:00
Andrew Tridgell
0b3b7e3797 samba-tool: exit with non-zero status on dbcheck failure 
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
 2011-06-17 15:25:42 +10:00
Andrew Tridgell
a8269792aa samba-tool: report total error count and suggest --fix if needed 2011-06-17 12:32:55 +10:00
Andrew Tridgell
08dc1aa4cc samba-tool: added attribute normalisation checks 
this checks that all attributes have the right normalisation, and
offers to fix the ones that don't
 2011-06-17 12:32:55 +10:00
Andrew Tridgell
d575b2b0ab samba-tool: disable validation on removing an empty attribute in dbcheck 
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Jun 14 10:49:34 CEST 2011 on sn-devel-104
 2011-06-14 10:49:34 +02:00
Andrew Tridgell
0c89d624e6 s4-samba-tool: added dbcheck commmand 
this will be used as a consistency checker and repair tool for
sam.ldb. This initial checkin just checks for empty attributes and
offers to fix them

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jun 10 10:31:56 CEST 2011 on sn-devel-104
 2011-06-10 10:31:56 +02:00