1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

74110 Commits

Author SHA1 Message Date
Gregor Beck
7eb9c70342 s3:smbldap: free the idle event scheduled in smbldap_open in smbldap_close
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-01 11:23:43 +02:00
Gregor Beck
343ef46b9b s3:smbldap: use smbldap_state as memory context for idle event
ensure the event is canceled if the smbldap_state gets freed
this fixes a panic of winbindd if verify_idpool fails

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-07-01 11:22:56 +02:00
Andrew Bartlett
f3c3768d30 s4-dsdb guard principalName parse for invalid inputs
We need to ensure that if this parses name.name_string as just one
val, then we don't read uninitialised and possibly unallocated memory.
Found by Adam Thorn <alt36@cam.ac.uk>

While we are checking that, we need to fix the strncasecmp() check to
first check if the string is the expected length, then check for a
match against sAMAccountName-without-doller, as otherwise we will
permit a string such as machinefoo to match a sAMAccountName of
machine.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Jul  1 03:55:00 CEST 2011 on sn-devel-104
2011-07-01 03:55:00 +02:00
Andrew Bartlett
f1b1a66615 s4-dsdb Allow a servicePrincipalName of machine$
This is pointless, but MacOS X (version 10.6.8 was tested) apparently
sets machine$ into this field.

Andrew Bartlett
2011-07-01 10:43:29 +10:00
Jeremy Allison
1053a24a87 Part of fix for bug 8276 - FD_SET out of bounds access crash.
Ensure we never add fd's set to -1 to the pollfd set.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jun 30 21:15:25 CEST 2011 on sn-devel-104
2011-06-30 21:15:25 +02:00
Stefan Metzmacher
4804013210 script/librelease.sh: keep dots in the release tag
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 30 18:52:06 CEST 2011 on sn-devel-104
2011-06-30 18:52:06 +02:00
Stefan Metzmacher
84d9cdb511 release-scripts/create-tarball: always create a tag in form of samba-${version}
metze
2011-06-30 17:12:05 +02:00
Michael Adam
76467dc406 s3:build: add vfs_examples to the everything target
So that one can not pass autobuild without keeping the vfs examples intact.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Jun 30 16:52:48 CEST 2011 on sn-devel-104
2011-06-30 16:52:48 +02:00
Michael Adam
c2e88320a0 s3:build: add a vfs_examples target. 2011-06-30 15:41:25 +02:00
Michael Adam
197df817a3 examples/VFS: add include path for s3's autoconf config.h 2011-06-30 15:41:24 +02:00
Björn Baumbach
576cb574a1 examples/VFS: fix skel_transparent.c in reference to shadow_copy changes
Signed-off-by: Michael Adam <obnox@samba.org>
2011-06-30 15:41:24 +02:00
Björn Baumbach
776672805c examples/VFS: fix skel_opaque.c in reference to shadow_copy changes
Signed-off-by: Michael Adam <obnox@samba.org>
2011-06-30 15:41:24 +02:00
Björn Baumbach
6930afc9f4 examples/VFS: fix shadow_copy_test.c in reference to shadow_copy changes
Signed-off-by: Michael Adam <obnox@samba.org>
2011-06-30 15:41:23 +02:00
Michael Adam
1f72088633 s3:registry: when deleting the records for a key, also delete the sorted subkeys cache
This prevents orphaned empty sorted subkeys cache records from filling the database.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Signed-off-by: Michael Adam <obnox@samba.org>
2011-06-30 15:41:23 +02:00
Michael Adam
2b162db6e9 s3:registry: add helper function regdb_delete_sorted_subkeys()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Signed-off-by: Michael Adam <obnox@samba.org>
2011-06-30 15:41:22 +02:00
Stefan Metzmacher
c234b4b0c0 lib/util/string_wrappers: move everything into one HAVE_COMPILER_WILL_OPTIMIZE_OUT_FNS block
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 30 14:29:41 CEST 2011 on sn-devel-104
2011-06-30 14:29:41 +02:00
Stefan Metzmacher
75e9f21108 s3:nmbd_subnetdb: close all sockets attached to a subnet in close_subnet() (bug #8276)
metze
2011-06-30 13:20:05 +02:00
Christian Ambach
847ca0a5d7 s3:smbd do not panic when CTDB is unhealthy (Bug #8278)
when CTDB is unhealthy, log a message and exit cleanly
instead of creating a core file

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Jun 30 13:18:12 CEST 2011 on sn-devel-104
2011-06-30 13:18:12 +02:00
Christian Ambach
d2adf96402 docs: fix some whitespace
replace spaces with tabs, removing whitespaces at end of lines
2011-06-30 12:08:25 +02:00
Christian Ambach
1ae9a7160c docs: fix a typo 2011-06-30 12:08:25 +02:00
Jelmer Vernooij
a61176900f rebuildexetendeddn: PEP8: Use spaces rather than tabs.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Jun 30 12:07:32 CEST 2011 on sn-devel-104
2011-06-30 12:07:32 +02:00
Jelmer Vernooij
6dbe3e3600 rpcclient: PEP8: Use spaces rather than tabs. 2011-06-30 10:55:26 +02:00
Jelmer Vernooij
a67683eb6d smbstatus: PEP8: Use spaces rather than tabs. 2011-06-30 10:55:26 +02:00
Jelmer Vernooij
e4e9c5d140 mischema: Remove unused import. 2011-06-30 10:55:26 +02:00
Jelmer Vernooij
ac28c8216f enablerecyclebin: Remove unused imports, fix formatting. 2011-06-30 10:55:26 +02:00
David Disseldorp
c9e3f6ab02 s3-printing: skip migration of non-existent printers
Skip tdb migration of printer and security descriptor entries which
refer to non-existent printers.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jun 30 10:54:23 CEST 2011 on sn-devel-104
2011-06-30 10:54:23 +02:00
David Disseldorp
a36ce0735f s3-printing: fill devicemode size in migrate_printer()
Signed-off-by: Günther Deschner <gd@samba.org>
2011-06-30 09:40:50 +02:00
Günther Deschner
44a434a301 s3-winbind: Fix bug 7888 -- deal with buggy 3.0 based PDCs
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jun 30 00:42:23 CEST 2011 on sn-devel-104
2011-06-30 00:42:23 +02:00
Günther Deschner
5586095512 s3-waf: lowercase libcli_lsa3 library name.
Guenther
2011-06-29 23:29:29 +02:00
Günther Deschner
e9bc0933ef s3-waf: lowercase libsmb library name.
Guenther
2011-06-29 23:29:29 +02:00
Günther Deschner
8996d7737e s3-waf: lowercase util_cmdline library name.
Guenther
2011-06-29 23:29:29 +02:00
Günther Deschner
f124c638e8 s3-waf: lowercase popt_samba3 library name.
Guenther
2011-06-29 23:29:28 +02:00
Jeremy Allison
5882c75d40 Second part of fix for bug #8219 - SMB Panic from Windows 7 Client.
Pass in the correct vector to the signing algorithm in an async
response - we must start with vector[1] which has the SMB2_HDR_BODY
length, not vector[0] which is the 4 byte packet length. Also
note we're passing in 2 vectors not 3.

Metze please review.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jun 29 20:09:21 CEST 2011 on sn-devel-104
2011-06-29 20:09:21 +02:00
Andrew Bartlett
8b04345a0e s4-param Handle BOOLREV parameters
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jun 29 08:57:27 CEST 2011 on sn-devel-104
2011-06-29 08:57:27 +02:00
Andrew Bartlett
489f528857 param: Merge param headers into lib/param/loadparm.h
This defines a common table format, so we can in future define a
common table.

Andrew Bartlett
2011-06-29 15:44:09 +10:00
Andrew Bartlett
ff13827537 s3-param use C99 boolean for false 2011-06-29 15:44:09 +10:00
Andrew Bartlett
f8c0a89939 s3-param use C99 boolean for true 2011-06-29 15:44:09 +10:00
Andrew Bartlett
9adc0e9ed8 s3-param Convert sDefault to C99 initialisers
The conversion has been verified with gdb (p sDefaults before and after)

C99 booleans were helpfully provided by gdb, which was used to generate
the C99 format, and so have been kept.

Andrew Bartlett
2011-06-29 15:44:09 +10:00
Andrew Bartlett
3b0b0d3c51 s4-param Match source3's param: use C99 initialisers
This makes it much easier to compare the parameter sets.

Andrew Bartlett
2011-06-29 15:44:09 +10:00
Andrew Bartlett
7384a2b0b7 s4-param Merge struct parm_struct with version from source3/ 2011-06-29 15:44:09 +10:00
Andrew Bartlett
658f55bbb7 s3-param Remove unused FLAG_DOS_STRING 2011-06-29 15:44:08 +10:00
Andrew Bartlett
7198d540e8 param: Merge struct parm_struct definitions
This will allow the parameter tables to be shared between source3 and
source4.

Andrew Bartlett
2011-06-29 15:44:08 +10:00
Andrew Bartlett
21756b7c7d s3-param Use .offset rather than .ptr when defining parameters
This change has a number of purposes:

 * It removes the fancy logic around pointers into sDefault for all
   per-share parameters.  Instead, this is always expressed as an
   offset, rather than implicitly via PTR_DIFF macros.

 * It makes struct parm_struct almost identical to that as used in
   source4/param.  This will very shortly allow the loadparm tables
   and most of the 'special' helper functions to be placed in common.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jun 29 05:50:46 CEST 2011 on sn-devel-104
2011-06-29 05:50:46 +02:00
Andrew Bartlett
573109d346 s3-param Remove .offset == 0 checks as 'valid' will have offset 0
The validity of an entry in the parm_table is by having a .p_class of
P_LOCAL or P_GLOBAL rather than P_SEPARATOR.  Termination of the table
is by having a .label of non-NULL.  This is possible because there are
no longer any specially handled smb.conf options without a value in
the struct loadparm_globals or struct loadparm_service.

This is required because the first element in the structure will have
.offset = 0, and skipping that would be unfortunate (particularly as it
is the vital 'valid' variable).

Andrew Bartlett
2011-06-29 04:42:04 +02:00
Andrew Bartlett
0e38199a84 s3-param use .offset rather than .ptr (renames)
This commit uses GLOBAL_VAR and LOCAL_VAR macros to hide the use of .ptr
in the source3 loadparm code.

This will then be changed to use offsetof() in a future commit, removing
the #define offset ptr hack.

Andrew Bartlett
2011-06-29 04:42:03 +02:00
Jeremy Allison
1fffddb238 Fix bug #8219 - SMB Panic from Windows 7 Client
Caused by referencing an uninitialized variable in the
duplicated struct smbd_smb2_request when sending a signed
intermediate reply.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jun 29 04:37:28 CEST 2011 on sn-devel-104
2011-06-29 04:37:28 +02:00
Andrew Bartlett
e63d5d2cd5 s3-param use lp_parm_ptr() rather than parm.ptr directly
This will help with a change from .ptr to .offset

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jun 29 03:26:21 CEST 2011 on sn-devel-104
2011-06-29 03:26:21 +02:00
Jelmer Vernooij
4f64ba6ce1 Remove obsolete BUGS file.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Jun 29 01:47:26 CEST 2011 on sn-devel-104
2011-06-29 01:47:26 +02:00
Stefan Metzmacher
b005fa142f s4:kdc/mit_samba: disable mit_samba_check_s4u2proxy()
As mit_samba_update_pac_data() doesn't support adding
S4U_DELEGATION_INFO to the pac (and I have no clue how to add that)
we should disable S4U2Proxy until this is implemented.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jun 28 20:35:19 CEST 2011 on sn-devel-104
2011-06-28 20:35:18 +02:00
Stefan Metzmacher
73b1e1466c s4:kdc: generate the S4U_DELEGATION_INFO in the regenerated pac
metze
2011-06-28 19:23:43 +02:00