1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-10 12:58:35 +03:00

4298 Commits

Author SHA1 Message Date
Gerald Carter
94967b31bb Added lib/util_list.[c|o] to Makefile.in
--jerry
-
Gerald Carter
381aba2c9a Fixed some more client SPOOLSS functions. The following
functions work now:

  - spoolenum
  - spoolopen
  - spoolgetprinter
  - spoolgetprinterdriver

Items todo:

  - track down memory bug with spoolenumdata
  - fix spoolgetprinterdriverdir
  - fix spoolgetdata
  - fix display_job_info_ctr in spooljobs

All part of the ongoing rpcclient work.

Also included a new generic list ADT.  Cleaner and simplier
than the stuff in util_array.c i think (but then that's why I wrote it).





--jerry
-
Gerald Carter
f7bc6df3be fixed a bug (my own) in create_ntc_from_cli_state()
--jerry
-
Gerald Carter
0863ce3a31 I really didn't like the way generic arrays (lists) were
implemented in util_array.c so I wrote a smaller (and simplier
package).

I would like to replace the use of util_array.c functions
in the rest of the source tree if no one objects.
This will be an interface change, but not really a difference
in the functionality provided.


--jerry
-
Gerald Carter
ccebd70df2 grab functions that return RPC_HND_NODE (declared
in include/util_list.h)



-- jerry
-
Gerald Carter
84349394a9 Fixed some more client SPOOLSS functions. The following
functions work now:

  - spoolenum
  - spoolopen
  - spoolgetprinter
  - spoolgetprinterdriver

Items todo:

  - track down memory bug with spoolenumdata
  - fix spoolgetprinterdriverdir
  - fix spoolgetdata
  - fix display_job_info_ctr in spooljobs

All part of the rpcclient work.

Jeremy, this check includes emthods for associating
POLICY_HNDs and client states.  See the RpcHndList_...()
function calls (implemented in lib/util_list.c)



--jerry
-
Gerald Carter
15b3591271 Fixed some more SPOOLSS functions. The following
functions work now:

  - spoolenum
  - spoolopen
  - spoolgetprinter
  - spoolgetprinterdriver

Items todo:

  - track down memory bug with spoolenumdata
  - fix spoolgetprinterdriverdir
  - fix spoolgetdata
  - fix display_job_info_ctr in spooljobs


--jerry
-
Tim Potter
5c1c562226 Missing var. -
Tim Potter
dea06ad7a5 Reverted changes from rpcclient merge - contains memory leak! -
Tim Potter
bc5f9c00be Free security descriptor after access check in update_printer_sec() -
Tim Potter
a5b7cafc87 Initialise current time to time(NULL) in add_a_printer_2()
Added get and free security old descriptor in nt_printing_setsec() after
access checking was moved up to rpc level.
-
Tim Potter
df0ef98d7e make proto -
Tim Potter
4443a8b6e6 make proto -
Tim Potter
90b1857c81 Allow job owner to delete own print job. -
Tim Potter
e92e161a81 Moved access check for nt_printing_setsec() up into rpc function.
Use sid + rid instead of lp_workgroup()/Administrator for printer owner sid
as per JF's advice.

Default printer owner is either the administrator of the pdc workgroup or
Everyone depending on whether winbindd is running.  Still the subject of
some debate...

Renamed se_access_check() parameters.
-
Tim Potter
714b50b47d Renamed arguments to se_access_check() -
Tim Potter
587c8e58fd Renamed a parameter in init_request() function.
Initialise response structure correctly.
-
Tim Potter
ff7938310d Added some debugs.
Changed interface to se_access_check to take a user struct instead of each
bit as a separate parameter.
-
Christopher R. Hertel
34f69f09f8 I committed this change to the cliffs archive a while back and have heard
no complaints.  ;)

Basically, instead of ignoring single-line C-style comments in IDL source
files this change allows token.awk to ignore both single- and multi-line
C-style comments.

Chris -)-----
-
Gerald Carter
f850935617 Lots of changes but no real progress in functionality.
more changes to remove the ncarpc_l_* stuff.

Fixed some cut and paste errors from TNG

There are very subtle bugs in this code.  I'll work on simplifying
them in round two or three.



--jerry
-
Gerald Carter
b2317babb5 reverted a some previous additions.
Removed msrpc_local struct


--jerry
-
Gerald Carter
9206d59360 a few changes to Makefile.in to clean up dependencies for rpcclient
--jerry
-
Gerald Carter
233b074f49 More functions merged from TNG for rpcclient. They don't all work
currently as I have to do something about the policy handle caching
issues.



--jerry
-
Gerald Carter
3d00e969df cleaned up access to prs_struct variables. Replaced all calls
prs_free_data() => prs_mem_free
	prs_realloc_data => prs_grow


--jerry
-
Gerald Carter
549d1d2621 removed references to loopback RPC connections.
added a few more kfunctions from TNG for rpcclient



--jerry
-
Gerald Carter
3bc9af4c1d removed prs_data(), prs_free_data(), and prs_realloc_data()
as these were unneeded and replaced by the real functions
already in HEAD.

Added a few more functions to parse_spoolss.c to help with the
rpcclient merge from TNG.
-
Gerald Carter
8599e1bc39 Fixed a bug in cmd_interp.c where if user%pass was entered on
the command line, the password would still be cached in memory
in plain text for the lifetime of the rpcclient command line session.

removed loopback connection functions from msrpc-client.c since
we don't support that in the server code now anyways.  simplify,
simplify, ...


--jerry
-
Gerald Carter
eb3f545f54 make proto
and a few changes to ntdomain for rpcclient printing functions


--jerry
-
Gerald Carter
0faf21662d adding more spoolss command into rpcclient. They don't all work
currently.  More to come later.


--jerry
-
Tim Potter
363a9c45bf Don't return winbind groups or users when responding to samr_enum_dom_users
and samr_enum_dom_aliases commands.  Unfortunately the algorithm for
determining winbind groups from normal groups is simply to check for the
presence of the lp_winbind_separator() character.  )-:
-
Tim Potter
a895868912 Uninitialised variables. -
Jean-François Micouleau
08b41bab17 we are now sure the printer_info_2 timestamp is updated everytime
required.

	J.F.
-
Jean-François Micouleau
493f7d11ac - The printers are indexed by the sharename in both get_a_printer() and
add_a_printer() now.

- correctly unpack the private part of a devmode and remove a memleak

- correctly retrieve the pair(value,data) for getprinterdata

- handle null devicemode in printer_info_2

I still have some bugs but I'm not crashing anymore NT4SP6 d/c build :-)


        J.F.
-
Christopher R. Hertel
d8656304d5 An improved version of the Negative Query Response fix. The earlier fix
only did a short-cut on an rcode of 3, which is 'name not found'.  This
does a short-cut on any non-zero rcode.  It also puts out a DEBUG message
(if DEBUGLEVEL is >= 3) detailing the error.

Chris -)-----
-
Christopher R. Hertel
6ee63ecfa5 Typo. It said "DEGUG" in the comments. I dunno how to degug, or gug for
that matter.  crh
-
Gerald Carter
fb0e1fb9e3 #ifndef RPCCLIENT_TEST
use old prs_unistr()
#else
	use new prs_unistr() which handles UNMARSHALL
#endif /* RPCCLIENT_TEST */



jerry
-
Jeremy Allison
9bd64da1e2 Allow name lookup to fail and fall back to using the "Everyone" SID
as SD owner. Allows smbd to work without winbindd running.
Check for security implications !
Jeremy.
-
Jeremy Allison
d85deb9e4e Add local fallback for name lookup if no winbindd running...
Jeremy.
-
Jeremy Allison
7a95c289cd Ensure correct driver paths are returned in INFO_2 struct.
Jeremy.
-
Gerald Carter
ae85cc43fe make proto -
Gerald Carter
588aadb29f spoolenum commend (when compiled with the new prs_unistr())
now works.   :-)




jerry
-
Gerald Carter
ebcb7473c6 Fixed a bug in parsing the command line.
jerry
-
Gerald Carter
4f431ea1f5 included a a new prs_unistr(). Is currently #if'd out (denoted
by RPCCLIENT_TEST) in order to not break anything in the smbd
code (and to give time to review it).  Originally written by JF.
In effect, this checkin makes no changes to parse_prs.c at all.





jerry
-
Tim Potter
da67a5099e Added wbinfo and .libs -
Tim Potter
898a483cda Fixes for various compile warnings on Solaris 8. -
Tim Potter
f866c18f6b Moved winbind client functions from various odd locations to
nsswitch/wb_client.c

Merge of nsswitch/common.c rename to nsswitch/wb_common.c from TNG.
-
Tim Potter
5f355a2443 make proto -
Tim Potter
2abce4dcfa Re-instated lanman printing security checks (oops).
A user can now pause, resume or delete their own job even if they don't
have the Manage Documents privilege.

Added call to se_access_check() for changing printer properties.  The Full
Access privilege is required for the user to perform this.

Several uninitialised variables and memory leaks plugged.

Modified default ACL created on new printers to be Everyone / Print instead
of Everyone / Full Access.  This required some random stuffing around with
the value of the revision field to correspond with the ACL that NT produces
when setting the same permission on the printer.

Fixed dodgy function call in printing/printfsp.c
-
Tim Potter
c1d242f1dd Spelling fixes. -
Tim Potter
3ee111bff7 Fix for passing NULL pointer as an array parameter in
domain_client_validate()
-