Rusty Russell
5a7874e119
tdb_traverse/tdb_traverse_read: check returns for negative, not -1.
...
TDB2 returns a negative error number on failure. This is compatible
if we always check for < 0 instead of == -1.
Also, there's no tdb_traverse_read in TDB2: we don't try to make
traverse reliable any more, so there are no write locks anyway.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Rusty Russell
058c4f8492
tdb_fetch_compat: use instead of tdb_fetch.
...
This is a noop for tdb1.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-20 11:18:35 +02:00
Michael Adam
241ed0a042
s3:registry/reg_parse_internal.c: add copyright information
2011-06-11 11:44:31 +02:00
Michael Adam
d901905210
s3:registry/reg_parse_internal.h: add copyright information
2011-06-11 11:44:31 +02:00
Andrew Bartlett
74eed8f3ed
s3-param Remove special case for global_myname(), rename to lp_netbios_name()
...
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.
Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
8d4a8389bb
s3-talloc Change TALLOC_MEMDUP() to talloc_memdup()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_MEMDUP isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
5e26e94092
s3-talloc Change TALLOC_ZERO_ARRAY() to talloc_zero_array()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
ad0a07c531
s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
d5e6a47f06
s3-talloc Change TALLOC_P() to talloc()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653
s3-talloc Change TALLOC_ARRAY() to talloc_array()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
73b377432c
s3-talloc Change TALLOC_REALLOC_ARRAY() to talloc_realloc()
...
Using the standard macro makes it easier to move code into common, as
TALLOC_REALLOC_ARRAY isn't standard talloc.
Andrew Bartlett
2011-06-09 12:40:08 +02:00
Andrew Bartlett
381423b1bd
libcli/security: move secdesc.c to the top level libcli/security
...
This code does not rely on lp_ or other source3 only functions, so can
be part of the common library.
Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
da662b82b8
s3-lib Replace StrnCaseCmp() with strncasecmp_m()
...
strncasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.
Andrew Bartlett
2011-05-18 16:12:08 +02:00
Andrew Bartlett
c615ebed6e
s3-lib Replace StrCaseCmp() with strcasecmp_m()
...
strcasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.
Andrew Bartlett
2011-05-18 16:12:08 +02:00
Michael Adam
26b6831164
s3:registry: add a warning debug message when the sorted subkeys is created from key_exists()
2011-05-12 11:48:30 +02:00
Michael Adam
daf5f29d49
s3:registry: recreate the sorted subkeys cache when storing keys
...
This is to avoid turning the next read operation into a write op.
2011-05-12 11:48:30 +02:00
Michael Adam
1a6ac6a944
s3:registry: add create_sorted_subkeys() to delete and recreate the sorted subkeys key
...
This is to be used from other places than the key_exists() code path.
2011-05-12 11:48:30 +02:00
Michael Adam
b1eac2daf3
s3:registry: turn create_sorted_subkeys_internal to NTSTATUS return type
...
(from bool)
2011-05-12 11:48:30 +02:00
Michael Adam
f5f9355ebe
s3:registry: rename create_sorted_subkeys() to create_sorted_subkeys_internal()
2011-05-12 11:48:29 +02:00
Michael Adam
04f0a1cb7b
s3:registry: fix a typo in a debug message
2011-05-12 11:48:29 +02:00
Günther Deschner
d8cfca3a9b
s3: only include tdb headers where needed.
...
Guenther
2011-05-06 10:48:10 +02:00
Jeremy Allison
7d6ebe0de7
More const fixes. Remove CONST_DISCARD.
2011-05-06 01:44:07 +02:00
Jeremy Allison
10a628b6e1
Don't reuse a non-const pointer when manipulating const.
2011-05-05 10:41:40 -07:00
Volker Lendecke
b48e22347d
s3: Fix Coverity ID 2047, UNUSED_VALUE
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Apr 22 10:53:24 CEST 2011 on sn-devel-104
2011-04-22 10:53:24 +02:00
Volker Lendecke
a5495e70cc
s3: Make reg_backend_db.h includable by itself
...
(cherry picked from commit 6ba31d3bd29dd11b1b98859f4d8a65d9be7dac60)
2011-04-11 21:22:44 +02:00
Günther Deschner
5fcb4d328c
rep_parse_prs: remove some dead, unused code.
...
Guenther
2011-03-31 00:14:01 +02:00
Günther Deschner
c2d6260f10
s3: only include lib/privileges.h where needed.
...
This finally removes the global lsa.h inclusion.
Guenther
2011-03-30 01:13:10 +02:00
Günther Deschner
235f148590
s3-passdb: use passdb headers where needed.
...
Guenther
2011-03-30 01:13:08 +02:00
Günther Deschner
0a250f4946
registry: create and use shared libcli/registry/util_reg.h header.
...
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
49ccae1c20
s3-includes: no point in including all security headers globally.
...
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
0e771263ee
s3-includes: only include system/filesys.h when needed.
...
Guenther
2011-03-30 01:13:07 +02:00
Günther Deschner
310d268527
s3-includes: only include system/iconv.h when needed.
...
Guenther
2011-03-30 01:13:06 +02:00
Andrew Tridgell
15e84a9a09
charcnv: removed the allow_badcharcnv and allow_bad_conv options to convert_string*()
...
we shouldn't accept bad multi-byte strings, it just hides problems
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
2011-03-24 01:47:26 +01:00
Günther Deschner
fa8471a616
s3-registry: remove some unused headers.
...
Guenther
2011-03-18 13:22:07 +01:00
Michael Adam
aa8c9ef138
s3:registry: fix invalid write in iconvert_talloc()
...
For a non-preallocated dest-string and sourcestring of len < 2,
(one or both of the) final two two zero-bytes would be written
after the end of the allocated dest-string. The sourcelen did
not include the source string terminator. For longer strings,
this was not a problem because the dest-string would have been
reallocated in the convert-loop. This is fixed now by allocating
two extra bytes for the terminating 0-bytes that are needed anyways
in the initial allocation.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2011-03-05 01:31:33 +01:00
Volker Lendecke
4b354e67fc
s3-amend: Don't overwrite existing values
...
This saves a ton of tdb transactions on smbd startup
Andreas, Günther, please check!
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Feb 15 19:11:25 CET 2011 on sn-devel-104
2011-02-15 19:11:25 +01:00
Andreas Schneider
a3ee831f2d
s3-perfcount: Create the directory on tdb open.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:02 +01:00
Andreas Schneider
b2ddfc642d
s3-smbd: Init the svcctl registry keys on service startup.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
1adbbeef32
s3-registry: Remove obsolete reg_eventlog.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:01 +01:00
Andreas Schneider
a3a38fdb55
s3-smbd: Init the eventlog registry on service startup.
...
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
34e8a50e5a
s3-util: Moved eventlog_add_source to admin util.
...
This function is only used in the admin util.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Günther Deschner
50be0b2c1e
s3: Remove superfluous ;
...
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb 2 15:44:21 CET 2011 on sn-devel-104
2011-02-02 15:44:21 +01:00
Michael Adam
b1f800a0d1
s3:registry: in deletekey_recursive, fix return code upon error.
...
correctly keep the werr from inside the transaction when the opearation
inside the transaction fails.
What is the correct behaviour if the cancel operation fails?
2011-01-30 14:09:04 +01:00
Michael Adam
14502c5458
s3:registry: fix comments in regdb_store_regdb_version()
2011-01-27 21:43:48 +01:00
Christian Ambach
d49d203279
s3:registry correct a debug level
...
this is not a level 0 message, move it to 10
2011-01-21 10:10:03 +01:00
Michael Adam
d91189727a
s3:registry: improve debug messages about regdb refcount changes
...
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Dec 7 15:18:03 CET 2010 on sn-devel-104
2010-12-07 15:18:03 +01:00
Volker Lendecke
4b2e2f94bb
s3: Streamline regdb_normalize_keynames_fn a bit
...
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Oct 28 14:32:11 UTC 2010 on sn-devel-104
2010-10-28 14:32:11 +00:00
Volker Lendecke
8b87603de4
s3: Fix the registry upgrade code
...
The strings have the 0-terminator as part of the keys. The rest of the registry
code would not cope well without.
2010-10-28 15:50:14 +02:00
Sven Neumann
0bc94c21e5
Fix bug 7754 - samba uses index(), marked as legacy.
...
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 27 19:25:16 UTC 2010 on sn-devel-104
2010-10-27 19:25:16 +00:00
Jeremy Allison
272feb7bd1
Revert "Wrap security_token_has_privilege() with a check for lp_enable_privileges(). Needed"
...
Not needed - privileges code prevents "enable privileges = no" from adding privileges
anyway.
This reverts commit a8b95686a7
.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 22 23:41:36 UTC 2010 on sn-devel-104
2010-10-22 23:41:36 +00:00