1
0
mirror of https://github.com/samba-team/samba.git synced 2025-10-30 08:23:49 +03:00
Commit Graph

162 Commits

Author SHA1 Message Date
Volker Lendecke
735f593154 Remove Get_Pwnam and its associated static variable
All callers are replaced by Get_Pwnam_alloc
2007-12-19 21:09:10 +01:00
Jeremy Allison
545cd2139c Fix bug #5121 (unix passwd sync not working on a streams based
system).
Jeremy.
2007-12-17 10:44:09 -08:00
Jeremy Allison
898c56c0ea Remove a static fstring.
Jeremy.
2007-12-16 18:02:32 -08:00
Jeremy Allison
446ebae76d More work on bug #5082, use LC_ALL as this takes
precedence.
Jeremy.
2007-12-15 22:28:38 -08:00
Jeremy Allison
bc13e93954 Fix for bug #5082 from Mathias Gug <mathiaz@ubuntu.com>, Steve Langasek <vorlon@debian.org>.
Recent versions of Linux-PAM support localization of user prompts,
so Samba must use the C locale when invoking PAM (directly or via
/usr/bin/passwd) to ensure that password chat values match the prompts in a
locale-invariant fashion.
Jeremy.
2007-12-14 17:02:50 -08:00
Jeremy Allison
ec003f3936 Remove next_token - all uses must now be next_token_talloc.
No more temptations to use static length strings.
Jeremy.
2007-12-07 17:32:32 -08:00
Jeremy Allison
eaf14c701b Remove all pstrings from smbd/chgpasswd.c.
Jeremy.
2007-11-12 15:02:50 -08:00
Jeremy Allison
c15819b757 Three more pstring removals.
Jeremy.
2007-11-11 21:46:52 -08:00
Jeremy Allison
255c2adf7b Remove the horror that was the global smb_rw_error.
Each cli struct has it's own local copy of this variable,
so use that in client code. In the smbd server, add one
static to smbd/proccess.c and use that inside smbd. Fix
a bunch of places where smb_rw_error could be set by
calling read_data() in places where we weren't reading
from the SMB client socket (ie. winbindd).
Jeremy.
2007-11-05 11:12:56 -08:00
Jeremy Allison
f35a266b3c RIP BOOL. Convert BOOL -> bool. I found a few interesting
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
2007-10-18 17:40:25 -07:00
Andrew Tridgell
b0132e94fc r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text 2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b r23779: Change from v2 or later to v3 or later.
Jeremy.
2007-10-10 12:28:20 -05:00
Simo Sorce
436555f05c r23682: Old patch I forgot in one of my 3.0.25 trees.
Make sure we honour the directive not to allow machine password changes.
2007-10-10 12:23:45 -05:00
Stefan Metzmacher
fa322f0cc9 r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.

also fix all the callers to prevent compiler warnings

metze
2007-10-10 12:18:59 -05:00
Günther Deschner
e99696c970 r19094: Fix debug statement.
Guenther
2007-10-10 12:15:11 -05:00
Jim McDonough
21abbeaee9 r19058: Implement "user cannot change password", and complete "user must change
password at next logon" code.  The "password last set time" of zero now
means "user must change password", because that's how windows seems to
use it.  The "can change" and "must change" times are now calculated
based on the "last set" time and policies.

We use the "can change" field now to indicate that a user cannot change
a password by putting MAX_TIME_T in it (so long as "last set" time isn't
zero).  Based on this, we set the password-can-change bit in the
faked secdesc.
2007-10-10 12:15:06 -05:00
Volker Lendecke
e56e3c19e1 r16248: Fix Coverity ID 297 2007-10-10 11:17:27 -05:00
Jeremy Allison
c66620770d r15887: Ensure we use sys_write so we're not interrupted.
Jeremy.
2007-10-10 11:17:12 -05:00
James Peach
514a767c57 r14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-based
HSM is interested in. Tested on both IRIX and SLES9.
2007-10-10 11:15:42 -05:00
James Peach
763f4c0148 r14600: Refactor capability interface from being IRIX-specific to using only
the POSIX interface. Note that this removes support for inherited
capabilities. This wasn't used, and probably should not be.
2007-10-10 11:15:39 -05:00
Günther Deschner
5b89e8bc24 r13711: * Correctly handle acb_info/acct_flags as uint32 not as uint16.
* Fix a couple of related parsing issues.
* in the info3 reply in a samlogon, return the ACB-flags (instead of
  returning zero)

Guenther
2007-10-10 11:10:25 -05:00
Gerald Carter
6f1afa4acc r13590: * replace all pdb_init_sam[_talloc]() calls with samu_new()
* replace all pdb_{init,fill}_sam_pw() calls with samu_set_unix()
2007-10-10 11:10:16 -05:00
Gerald Carter
19b7593972 r13576: This is the beginnings of moving the SAM_ACCOUNT data structure
to make full use of the new talloc() interface.  Discussed with Volker
and Jeremy.

* remove the internal mem_ctx and simply use the talloc()
  structure as the context.
* replace the internal free_fn() with a talloc_destructor() function
* remove the unnecessary private nested structure
* rename SAM_ACCOUNT to 'struct samu' to indicate the current an
  upcoming changes.  Groups will most likely be replaced with a
  'struct samg' in the future.

Note that there are now passbd API changes.  And for the most
part, the wrapper functions remain the same.

While this code has been tested on tdb and ldap based Samba PDC's
as well as Samba member servers, there are probably still
some bugs.  The code also needs more testing under valgrind to
ensure it's not leaking memory.

But it's a start......
2007-10-10 11:10:15 -05:00
Volker Lendecke
bb40e544de r13494: Merge the stuff I've done in head the last days.
Volker
2007-10-10 11:10:06 -05:00
Günther Deschner
58baf718be r13444: Add REJECT_REASON_OTHER for samr_chgpasswd_user3
Guenther
2007-10-10 11:10:03 -05:00
Günther Deschner
f60eddc0a4 r13442: Implement samr_chgpasswd_user3 server-side.
Guenther
2007-10-10 11:10:03 -05:00
Gerald Carter
17e63ac4ed r13316: Let the carnage begin....
Sync with trunk as off r13315
2007-10-10 11:06:23 -05:00
Volker Lendecke
b02b1d3ef3 r13291: NT checks the minimum password age dynamically. That means we have to ignore
the sambapwdmustchange field if we can access the corresponding account
policy and calculate it dynamically based on the pwdlastset field.

Volker
2007-10-10 11:06:21 -05:00
Jeremy Allison
5fc0ef8087 r12938: Fix for #3408 (change password fails) from William Jojo <jojowil@hvcc.edu>.
Jeremy.
2007-10-10 11:06:08 -05:00
Jeremy Allison
0c7b8a7637 r12279: unix_mask_match has been broken for *ever*... (How).
Ensure it returns a BOOL.
Jerry (and anyone else) please check this, I think
all uses are now correct but could do with another
set of eyes. Essential for 3.0.21 release.
Jeremy.
2007-10-10 11:05:51 -05:00
Gerald Carter
939c3cb5d7 r10656: BIG merge from trunk. Features not copied over
* \PIPE\unixinfo
* winbindd's {group,alias}membership new functions
* winbindd's lookupsids() functionality
* swat (trunk changes to be reverted as per discussion with Deryck)
2007-10-10 11:04:48 -05:00
Jeremy Allison
b242f27860 r9545: (Hopefully the last) fixes for DIR -> SMB_STRUCT_DIR.
Jeremy.
2007-10-10 11:01:12 -05:00
Günther Deschner
fd91378925 r8454: Fix Bug #2502
Removing deprecated lp_min_password_length (the same functionality is
provided by the account policy).

Note that we now allow to set passwords less then 5 chars (if the admins
decides to do so by setting the account policy).

Thanks to Daniel Beschorner <db@unit-netz.de>

Guenther
2007-10-10 11:00:05 -05:00
Jeremy Allison
9506b8e145 r7882: Looks like a large patch - but what it actually does is make Samba
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
2007-10-10 10:58:00 -05:00
Gerald Carter
9e77da9320 r5961: final round of compiler warning fixes based on feedback from Jason Mader 2007-10-10 10:56:13 -05:00
Volker Lendecke
f7218d1c66 r5905: Fix two warnings found by AIX. They might actually be bugs on 64-bit
platforms.

Volker
2007-10-10 10:56:07 -05:00
Günther Deschner
fdf9bdbbac r5349: After talking with Jerry, reverted the addition of account policies to
passdb in 3_0 (they are still in trunk).

Guenther
2007-10-10 10:55:38 -05:00
Günther Deschner
75af83dfcd r4925: Migrate Account Policies to passdb (esp. replicating ldapsam).
Does automated migration from account_policy.tdb v1 and v2 and offers a
pdbedit-Migration interface. Jerry, please feel free to revert that if
you have other plans.

Guenther
2007-10-10 10:55:08 -05:00
Andrew Bartlett
1c70583a19 r4337: Produce a slightly different error message is lanman authentication is
disabled, rather than simply unavailable.

Andrew Bartlett
2007-10-10 10:53:45 -05:00
Andrew Tridgell
04a6573f89 r3954: bring Samba3 into line with the Samba4 password change code 2007-10-10 10:53:26 -05:00
Tim Potter
1327d83d90 r2899: Change some #if DEBUG_PASSWORD's to #ifdef DEBUG_PASSWORD.
Bugzilla #1903.
2007-10-10 10:52:56 -05:00
Günther Deschner
d036837729 r2772: Check correct string length when verifying password-policies. Do not
allow e.g. two umlauts and one ascii char to comply with account-policy
"min password length" of 5.

Thanks to Uwe Morgenroth from CC Compunet and Volker.

TODO: we do check the length against AP_MIN_PASSWORD_LEN *and*
lp_min_passwd_length() - both can have differing values.
2007-10-10 10:52:52 -05:00
Simo Sorce
05a80c3737 r2333: check the script is not a 0 lenght string 2007-10-10 10:52:39 -05:00
Simo Sorce
f836be323a r2331: check password script code and example from trunk 2007-10-10 10:52:39 -05:00
Gerald Carter
22cde8f665 r2013: BUG 1658: little bit of const (patch from : Helmut Heinreichsberger <helmut.heinreichsberger@chello.at>) 2007-10-10 10:52:27 -05:00
Jeremy Allison
82e4036aaa r1661: Changed the password history format so that each history entry
consists of a 16 byte salt, followed by the 16 byte MD5 hash of
the concatination of the salt plus the NThash of the historical
password. Allows these to be exposed in LDAP without security issues.
Jeremy.
2007-10-10 10:52:17 -05:00
Jeremy Allison
dd54b2a3c4 r1388: Adding password history code for ldap backend, based on a patch from
"Jianliang Lu" <j.lu@tiesse.com>. Multi-string attribute changed to
linearised pstring due to ordering issues. A few other changes to
fix race conditions. I will add the tdb backend code next. This code
compiles but has not yet been tested with password history policy
set to greater than zero. Targeted for 3.0.6.
Jeremy.
2007-10-10 10:52:09 -05:00
Gerald Carter
df94b0471e r283: removing --with-cracklib after discussion with abartklet @ sambaXP 2007-10-10 10:51:16 -05:00
Jeremy Allison
94a272b9a8 Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
-
Gerald Carter
b60f6ec30d remerge andrew's cracklib patch from HEAD and fix a compile warnings -