Jeremy Allison
8f36def18e
Now conn is part of smb_request, we don't need it as
...
an extra parameter. This cleans up quite a few places
we were passing it around without needing it.
Jeremy.
2008-01-04 15:37:24 -08:00
Jeremy Allison
c4e5a50504
Refactor the crypto code after a very helpful conversation
...
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
2008-01-04 12:56:23 -08:00
Jeremy Allison
3f6cc82637
Don't need an fstring here, we can talloc.
...
Jeremy.
2007-12-10 15:31:05 -08:00
Jeremy Allison
f04e37a630
Fix crash bug with vl's new trans handling in old transs
...
calls. Make this look like the (working) transs2 handling
(replace inbuf, not write to outbuf - outbuf isn't allocated
yet so you get a null deref).
Jeremy.
2007-12-04 12:53:21 -08:00
Jeremy Allison
f35a266b3c
RIP BOOL. Convert BOOL -> bool. I found a few interesting
...
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
2007-10-18 17:40:25 -07:00
Jeremy Allison
b3f0d39d11
r25103: Ensure we don't return unwritten memory (valgrind caught).
...
Jeremy.
2007-10-10 12:30:40 -05:00
Volker Lendecke
708f5af2e8
r24320: Fix the wct checks in reply_trans2 and the reply_trans calls
...
No idea what I've been smoking here.
Thanks to Stefan for closely looking
2007-10-10 12:29:28 -05:00
Volker Lendecke
c08366f840
r24244: Complete the conversion of reply_trans[s]
...
Remove reply_prep/post_legacy from send_trans_replies
2007-10-10 12:29:20 -05:00
Volker Lendecke
b01664b43b
r24243: Remove reply_prep_legacy from api_reply
2007-10-10 12:29:20 -05:00
Volker Lendecke
160f65946a
r24242: Remove reply_prep_legacy from api_rpc_trans_reply
2007-10-10 12:29:20 -05:00
Volker Lendecke
8702450e91
r24241: Remove reply_prep_legacy from api_WNPHS and api_SNPHS
2007-10-10 12:29:20 -05:00
Volker Lendecke
0bb95639d6
r24240: Push down reply_prep_legacy one level inside api_fd_reply
2007-10-10 12:29:20 -05:00
Volker Lendecke
e2a9649792
r24239: Push reply_prep_legacy into api_fd_reply
2007-10-10 12:29:20 -05:00
Volker Lendecke
a6a2d97fac
r24238: Push down reply_prep_legacy one level
2007-10-10 12:29:19 -05:00
Volker Lendecke
f0598b3ca0
r24237: Add send_trans_reply_new
2007-10-10 12:29:19 -05:00
Volker Lendecke
b38f9347e8
r24236: Push reply_prep_legacy() into named_pipe()
2007-10-10 12:29:19 -05:00
Volker Lendecke
06d0c74b74
r24235: Make handle_trans reply to errors itself
2007-10-10 12:29:19 -05:00
Volker Lendecke
040d6d5db6
r24234: Reformatting -- SCNR
2007-10-10 12:29:19 -05:00
Volker Lendecke
dc27c3c668
r24233: Push reply_prep_legacy into handle_trans
2007-10-10 12:29:19 -05:00
Volker Lendecke
511f8bc030
r24232: Push down reply_prep_legacy inside reply_transs
2007-10-10 12:29:18 -05:00
Volker Lendecke
74ae19cca6
r24231: Push allocating InBuffer/OutBuffer into reply_transs
2007-10-10 12:29:18 -05:00
Volker Lendecke
50a2bfd9e0
r24230: Push down reply_prep_legacy in reply_trans
...
The last checkin was for reply_trans, not reply_transs
2007-10-10 12:29:18 -05:00
Volker Lendecke
39a7809aa4
r24229: Push allocating InBuffer/OutBuffer into reply_transs
2007-10-10 12:29:18 -05:00
Volker Lendecke
fc8759e63c
r24224: Check wct in reply_trans
2007-10-10 12:29:18 -05:00
Volker Lendecke
17b875ae5b
r23823: Memory leak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
...
Thanks!
Volker
2007-10-10 12:28:30 -05:00
Andrew Tridgell
b0132e94fc
r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
2007-10-10 12:28:22 -05:00
Jeremy Allison
407e6e695b
r23779: Change from v2 or later to v3 or later.
...
Jeremy.
2007-10-10 12:28:20 -05:00
Volker Lendecke
836782b07b
r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
...
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.
2007-10-10 12:23:49 -05:00
Jeremy Allison
2d80a96120
r22391: Looks bigger than it is. Make "inbuf" available
...
to all callers of smb_setlen (via set_message()
calls). This will allow the server to reflect back
the correct encryption context.
Jeremy.
2007-10-10 12:19:30 -05:00
Volker Lendecke
0eea6b84ce
r22059: Over-allocate and NULL out 100 bytes for lanman.c.
...
Volker
2007-10-10 12:19:06 -05:00
James Peach
d6382092e7
r20237: Replace exit_server with exit_server_cleanly where appropriate. All
...
send_smb failures should be clean exits. All times when we exit as
a matter of policy should also be clean exits.
2007-10-10 12:16:34 -05:00
Jeremy Allison
b33bde7b39
r20178: Ensure we allocate the intermediate trans structs
...
off conn->mem_ctx, not the null context so we can
safefy free everything on conn close. Should fix
possible memleak.
Jeremy.
2007-10-10 12:16:29 -05:00
Volker Lendecke
1e4ee728df
r17316: More C++ warnings -- 456 left
2007-10-10 11:38:25 -05:00
Jeremy Allison
952547471f
r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
...
in a format string.
Jeremy.
2007-10-10 11:17:30 -05:00
Volker Lendecke
c24bfdce62
r15911: Make us survive rpc-authcontext committed next
2007-10-10 11:17:13 -05:00
Volker Lendecke
3e616c3272
r15266: Fix bug 3720. I wonder why -O1 compiles did not catch this...
...
Thanks to Jason Mader for reporting this.
Volker
2007-10-10 11:16:30 -05:00
Jeremy Allison
08e52ead03
r15018: Merge Volker's ipc/trans2/nttrans changes over
...
into 3.0. Also merge the new POSIX lock code - this
is not enabled unless -DDEVELOPER is defined.
This doesn't yet map onto underlying system POSIX
locks. Updates vfs to allow lock queries.
Jeremy.
2007-10-10 11:15:57 -05:00
Jeremy Allison
9a763da073
r14849: Fix >= that should be >. Too strict condition
...
checked by Volker.
Jeremy.
2007-10-10 11:15:50 -05:00
Volker Lendecke
49043a756d
r13980: Fix Coverity bug # 63. Jeremy, could you take a look at this?
...
Thanks,
Volker
2007-10-10 11:11:02 -05:00
Jeremy Allison
9506b8e145
r7882: Looks like a large patch - but what it actually does is make Samba
...
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
2007-10-10 10:58:00 -05:00
Gerald Carter
6a6e4af46a
r5165: BUG 2295: always use get_local_machine_name() rather than digging in the gloval variable 'local_machine'
2007-10-10 10:55:31 -05:00
Jeremy Allison
599c281464
r4830: Fix for problem noticed by Guy Harris <gharris@apple.com>, return
...
correct DOS/NT error code on transact named pipe on closed pipe
handle.
Jeremy.
2007-10-10 10:53:57 -05:00
Jeremy Allison
620f2e608f
r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
...
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
Jeremy.
2007-10-10 10:53:32 -05:00
Jeremy Allison
10b2489e3b
r3666: Generalise fix for trans and nttrans multi-fragment requests.
...
Jeremy
2007-10-10 10:53:12 -05:00
Rafal Szczesniak
3e57c2c685
Yet another '\n' termination of debug message.
...
rafal
-
Jeremy Allison
206464a748
Ensure the server can cope with multiple secondary trans
...
requests when signing is turned on.
Jeremy.
-
Jeremy Allison
7eaae388b3
Fix for bug #64 , Win9x Nexus tools not working against Samba3.0. Missing
...
map in errormap for ERROR_MORE_DATA -> ERRDOS, ERRmoredata.
Jeremy.
-
Jeremy Allison
4e00cad645
Typo broke win9x logins.
...
Jeremy.
-
Jeremy Allison
41d1870a51
Tidyup wrap checking.
...
Jeremy.
-
Jeremy Allison
3a789cb7f0
More fixes for client and server side signing. Ensure sequence numbers
...
are updated correctly on returning an error for server trans streams.
Ensure we turn off client trans streams on error.
Jeremy.
-