Günther Deschner
47c024fd75
s3-spoolss: rename temporary convert_devicemode_new function.
...
Guenther
2009-03-17 18:39:17 +01:00
Günther Deschner
04fd767c0b
s3-spoolss: remove obsolete get_a_builtin_ntform.
...
Guenther
2009-03-17 10:37:53 +01:00
Günther Deschner
670a22852c
s3-spoolss: use DSPRINT flags instead of SPOOLS_DS flags.
...
Guenther
2009-02-27 13:33:15 +01:00
Jeremy Allison
15f108f091
Fix some NetBSD warnings.
...
Jeremy.
2009-02-25 09:59:53 -08:00
Günther Deschner
e1749a1f78
s3-spoolss: use marshall/unmarshall_sec_desc_buf in nt_printing_setsec/getsec.
...
Guenther
2009-02-24 12:41:21 +01:00
Günther Deschner
dfa559145c
s3-spoolss: remove whitespace in printing code.
...
Guenther
2009-02-09 12:42:42 +01:00
Günther Deschner
894d05bc41
s3-spoolss: restore delete_a_form().
...
Guenther
2009-02-09 10:42:46 +01:00
Günther Deschner
9ef58a9196
s3-spoolss: use pidl for _spoolss_SetForm.
...
Guenther
2009-02-09 10:42:33 +01:00
Günther Deschner
3a1f9411e5
s3-spoolss: use pidl for spoolss_AddForm.
...
Guenther
2009-02-09 10:42:12 +01:00
Günther Deschner
b56c5bf510
s3-spoolss: rework some form functions and add form_by_string functions.
...
Guenther
2009-02-07 01:52:28 +01:00
Michael Adam
166ffc0d0d
s3: put printing/ under cache_dir, not lock_dir
...
Michael
2009-01-16 01:02:24 +01:00
Jelmer Vernooij
08259c1c52
Add iconv_convenience argument to size functions.
2009-01-01 04:45:33 +01:00
Jeremy Allison
d0eeb9aa8d
Fix more asprintf warnings and some error path errors.
...
Jeremy.
2008-12-23 12:11:12 -08:00
Jeremy Allison
b143938b8a
Fix more asprintf errors and error code paths.
...
Jeremy.
2008-12-23 11:27:19 -08:00
Tim Prouty
5844012285
s3: Change SMB_VFS_CREATE_FILE to take a create_file_flags argument
...
This replaces the is_dos_path bool with a more future-proof argument.
The next step is to plumb INTERNAL_OPEN_ONLY through this flag instead
of overridding the oplock_request.
2008-12-03 17:51:44 -08:00
Tim Prouty
08ce060475
s3: Modify direct callers of open_file_ntcreate and open_directory to call SMB_VFS_CREATE_FILE
2008-12-03 17:51:16 -08:00
Volker Lendecke
c25f5c778a
Convert delete_driver_files to use create_conn_struct
...
Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
cb4f8573ba
Convert get_correct_cversion to use create_conn_struct
...
Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
783ab0480b
Convert move_driver_to_download_area to use create_conn_struct
...
This removes a use of struct current_user and the vuid
The become_user() here is unnecessary, within the spoolss handling code we have
switched to the authenticated pipe user anyway.
Jerry, please check!
2008-11-24 11:39:03 +01:00
Volker Lendecke
c6973e69b7
Remove an unused variable
2008-11-02 09:40:30 +01:00
Jelmer Vernooij
ddcab787c4
Rename dos_errstr() to win_errstr() for consistency with Samba 4.
2008-11-01 17:19:26 +01:00
Jeremy Allison
8344e94574
Unify se_access_check with the S4 code. Will make
...
calculation of SEC_FLAG_MAXIMUM_ALLOWED much easier
for files.
Jeremy.
2008-10-31 10:51:45 -07:00
Jeremy Allison
7c53ffea28
Allow a new file to inherit the Windows ACL from its parent.
...
Now to do the same for directories.
Jeremy.
2008-10-29 13:27:14 -07:00
Jelmer Vernooij
f0c4829e82
Remove silly safe_free() function which is a wrapper around SAFE_FREE().
...
Since it's a function it just sets the local pointer to NULL and basically
is an equivalent to free().
It also claims it's being used for callbacks but isn't used that way
anywhere.
2008-10-19 13:06:14 +02:00
Jelmer Vernooij
a62c510d8b
Use GUID_from_string.
2008-10-14 02:33:41 +02:00
Jelmer Vernooij
1f3e4f39c5
Use GUID_string rather than smb_uuid_string().
2008-10-14 02:26:18 +02:00
Volker Lendecke
c530009401
Pass struct smb_request to file_free
...
on the way to get rid of chain_fsp
2008-10-13 19:32:38 +02:00
Jelmer Vernooij
1b99d8fbb5
Use common util_file code.
2008-10-12 17:34:43 +02:00
Jeremy Allison
e5692d4cbe
Remove SEC_ACCESS. It's a uint32_t.
...
Jeremy.
2008-10-09 09:49:03 -07:00
Jeremy Allison
c383e8d760
Ensure we null out fsp after a close in all paths.
...
Jeremy.
2008-09-29 10:57:22 -07:00
Jelmer Vernooij
55e201b0a1
Avoid freeing fsp twice when opening new_file fails. (Debian #431696 )
...
If opening new_file fails, fsp would still be set to the files_struct of
old_file.
2008-09-29 19:09:53 +02:00
Volker Lendecke
44e9a2bb9a
remove unused extern current_user from nt_printing.c
...
(This used to be commit b34283adeffaa6e481c57926709ea80d48733ef0)
2008-06-26 13:13:23 +02:00
Volker Lendecke
a3c0be6325
Change print_access_check to take auth_serversupplied_info instead of current_user
...
Reason: This is the main user of p->current_user which I would like to remove
(This used to be commit fd43059b3dfa8cdac9814de1c76f963ba5de9bcb)
2008-06-26 13:13:23 +02:00
Volker Lendecke
320fadd8fc
Remove the reference to current_user_info from share_access.c
...
This required to pass around the domain a bit
(This used to be commit 17b0db20d28d1b737c5e86b78106657e8ca5ce9c)
2008-05-25 11:43:57 +02:00
Tim Prouty
fb37f15600
Cleanup size_t return values in callers of convert_string_allocate
...
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
(This used to be commit 6b189dabc562d86dcaa685419d0cb6ea276f100d)
2008-05-20 22:40:13 +02:00
Jeremy Allison
fbc780b604
Try and fix bug #5095 , "Manage Documents privilege is not functional".
...
Should map the created sd to printer jobs, not printer.
Jerry please test and I'll add to 3.2 if it passes. Thanks,
Jeremy.
(This used to be commit 0a1fe8d6013d925ab6695f6b7f189b731ec42ccc)
2008-05-05 16:24:52 -07:00
Jeremy Allison
501562f15c
Fix from Martin Zielinski <mz@seh.de>. Don't delete files when
...
they're in use by other drivers.
Jeremy.
(This used to be commit 205c352caeb32693a02fcfaeb3f18515719ac373)
2008-04-24 15:02:23 -07:00
Jeremy Allison
40d16fa275
Fix bug #5372 . With a large CUPS installation with a remote server, contacting
...
the server when searching for a name for the location and comment fields can
take so much time the client times out. When searching for a name we don't
use these fields anyway, so add a function get_a_printer_search() which
doesn't contact the CUPS server.
Jeremy.
(This used to be commit 92d9f20852d5384e92a93dd0b051034718840ca8)
2008-04-04 11:14:09 -07:00
Volker Lendecke
c5356479c1
Some simplifications
...
(This used to be commit b59b436997fba47afd02ffb6f1194dfaef229d44)
2008-03-17 21:10:16 +01:00
Marc VanHeyningen
e06aa46b9f
Coverity fixes
...
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-17 20:52:25 +01:00
Volker Lendecke
594a164548
Fix a crash bug in nt_printer_publish_ads
...
Reported by Martin Zielinski <mz@seh.de>
(This used to be commit 4db26c803de52d3efccc940efc55f14131a057f5)
2008-01-16 11:39:20 +01:00
Jeremy Allison
23aab9dab7
Fix CID 498. Ensure we don't prs_mem_free an uninitialized
...
prs_struct.
Jeremy.
(This used to be commit 7b9d9fba230b9e61079869a6a2751cda37fb8a9e)
2008-01-11 23:24:13 -08:00
Michael Adam
87a684f7fc
Remove redundant parameter fd from SMB_VFS_FSTAT().
...
Michael
(This used to be commit 0b86c420be94d295f6917a220b5d699f65b46711)
2008-01-07 15:59:01 +01:00
Michael Adam
6f657c873e
Remove redundant parameter fd from SMB_VFS_LSEEK().
...
Michael
(This used to be commit df929796f2698698d2875227bda8500589cca2df)
2008-01-07 15:59:01 +01:00
Jeremy Allison
9254bb4ef1
Refactor the crypto code after a very helpful conversation
...
with Volker. Mostly making sure we have data on the incoming
packet type, not stored in the smb header.
Jeremy.
(This used to be commit c4e5a505043965eec77b5bb9bc60957e8f3b97c8)
2008-01-04 12:56:23 -08:00
Volker Lendecke
7cbdb48475
Remove tiny code duplication
...
ndr_size_security_descriptor does the same as sec_desc_size
(This used to be commit bc3bd7a8e7c6e9e27acb195c86abb92c0f53112f)
2007-12-29 23:13:26 +01:00
Jeremy Allison
7326612cfd
Two more static fstrings gone.
...
Jeremy.
(This used to be commit 4056bb8645821fba95d6e9ca4d82e2d5084c1e5c)
2007-12-18 18:16:40 -08:00
Volker Lendecke
900288a2b8
Replace sid_string_static by sid_string_dbg in DEBUGs
...
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)
2007-12-15 22:09:36 +01:00
Jeremy Allison
b9342eaaa6
Remove unused wpstring and macros. Stop using pstrcpy in smbd/*.c
...
Jeremy.
(This used to be commit e72bce5b62fb0a9d0ff4a3d76490219994f303cf)
2007-12-03 15:19:22 -08:00
Jeremy Allison
bcf033b38e
Change tdb_unpack "P" to return a malloc'ed string rather
...
than expect a pstring space to put data into.
Fix the (few) callers.
Jeremy.
(This used to be commit 7722a7d2c63f84b8105aa775b39f0ceedd4ed513)
2007-12-03 14:54:06 -08:00