1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

1311 Commits

Author SHA1 Message Date
Andrew Tridgell
36af1c0dc4 - don't try to print pointers
- removed some unused mangling code
-
Simo Sorce
7257d07563 Convert other parameters (read list, write list, valid users...) to the P_LIST format.
changed functions to use list instead of strings
addedd lp_list_substitute function
-
Jeremy Allison
c343e4f490 We were making an assumption in the oplock
break code path that was invalid (ie. we were assuming
we could infer a non-levelII oplock when such an oplock
was detected - this may no longer be valid once we've
processed the break process dealing with the break will
change the state of it anyway.
This prevents the state where we get the following packet
trace :

client                      server
NTcreate ->
                         <- NTcreate resp
NTcreate ->
                         <- break to level II
ok - broken ->
                         <- break to none

Thanks to Alan Romeril for providing the trace that allowed
me to track this down.

Jeremy.
-
Jeremy Allison
eea1c30df2 Fix case insensitive password change code.
Fixed crash bug with un-zeroed talloced memory.
Jeremy.
-
Andrew Bartlett
7cb517329b This patch fixes up a few issues where we would do lookups in the local system
on username we already know are perfectly valid, and in their final form.  In
particular we don't want to do a lookup for DOMAIN\nobody, it just does not
make sense, nor should we do map_username and the like if the username is as
specified in the vuid - we have done it already.

Andrew Bartlett
-
Jeremy Allison
0b13f495b3 Tidied up calling yield_connection on connection allocation fail.
Restore debug message to level zero.
Jeremy.
-
Jeremy Allison
d7da59f54e Connection record not existing is not a debug level 0.
Jeremy.
-
Jeremy Allison
f591ca9f25 Fixes from Jens-Uwe.Walther@force.de to make the -l option behave
consistently.
Jeremy.
-
Simo Sorce
8a2f6fbacd move the global_machine_password_needs_changing where we need it. -
Simo Sorce
065d8f69d5 Test if machine password has expired.
This test was lost somehow...
-
Jeremy Allison
8db233c8b5 Toomas Soome's fix for joining a domain the old way.
Jeremy.
-
Andrew Tridgell
d472ee3a69 added winbind_exclude_domain() so smbd can tell the winbind client
code not to do lookups for a particular domain. This allows winbind to
operate on a Samba PDC
-
Andrew Bartlett
04f090c224 This removes unused paramaters from various authtication functions, and should
not change behaviour.

This should make my later diffs smaller, where I actualy start cleaning up this
mess...

Andrew Bartlett
-
Andrew Tridgell
d5097b2f20 fixed some unicode and LANMAN2 bugs in trans2 find first/next -
Andrew Bartlett
4f7b2f51b0 You can't dump_data() a function pointer...
Andrew Bartlett
-
Jeremy Allison
ed5a1f70c6 Wrapped dlerror() in the same way as the other dlxxx() calls.
Jeremy.
-
Andrew Tridgell
4b35a3494c fixed bug where we looked at the first byte of a password to determine
if the password is blank. That ain't valid with encrypted passwords!

Jeremy, this changes the semantics of session setup. We no longer
automatically set guest=True when the client happens to choose their
username == the guest username. Instead we rely on the map_to_guest
code. I'm pretty sure this is now the right thing, but please look at
it carefully before putting it in 2.2

This is the bug that was causing the build farm to sometimes
fail. Basically we failed every 256 attempts - ie. when the first byte
of the encrypted password happened to be 0
-
Jeremy Allison
af5b649b01 Fix race where wrong action (created or opened) could be returned.
Jeremy.
-
Jeremy Allison
7efaefdf60 Fix for rabbit-pellet mode. Chris please test this. Thanks for Dave CB
for help on this.
Jeremy.
-
Andrew Tridgell
970236ee99 this fixes the failure of MS office on VFAT partitions on Linux
The problem is that ftruncate can't expand on VFAT, but it can on
ext2. That means our autoconf test is useless. I have recoded it to
use the alternative to ftruncate when then sys_ftruncate fails.

Jeremy, do you want this for 2.2.1?
-
Andrew Tridgell
a1dee993cb fixed a bug in the parameters SMBctemp uses in open_file_shared() -
Andrew Tridgell
3b9eb528f5 use alpha_strcpy on the domain as it comes off the wire -
Jean-François Micouleau
04575ff17b allow to use usrmgr/svrmgr tools in win95
pretty cool
-
Andrew Tridgell
c41fc06376 strchr and strrchr are macros when compiling with optimisation in gcc, so we can't redefine them. damn. -
Andrew Tridgell
debb471267 The big character set handling changeover!
This commit gets rid of all our old codepage handling and replaces it with
iconv. All internal strings in Samba are now in "unix" charset, which may
be multi-byte. See internals.doc and my posting to samba-technical for
a more complete explanation.
-
Andrew Tridgell
657836599a check for bad usernames early in session setup -
Jeremy Allison
8f57233c0f Ensure we correctly round down to 2 second boundary if dos filetime
set for a share.
Jeremy.
-
Jeremy Allison
110061ff5a Remove the exit_server() calls that stop nmbd linking.
Jeremy.
-
Jeremy Allison
310d2af6b0 Fixed incorrect debug parameters for lock_pid.
Jeremy.
-
Christopher R. Hertel
c2977be340 Very minor cleanup. I was looking for another problem and found some bits
of code that were unclear.

Chris -)-----
-
Jeremy Allison
a3925cb9c6 Fixed the nastiest locking bug to track down.... smb_pids are sent in the
lockingX calls - use that instead of smb_pid in the packet.
Jeremy.
-
Simo Sorce
200110a3b4 - fix bug in reply_nt- fix bug in reply_nt1 -
Jeremy Allison
5c42845b5b Fixed the first locking error (test #8 found by locktest code from
Clarion locktest.
Jeremy.
-
Jeremy Allison
c24e6b41ea Ensured all the system calls in msdfs.c go through the vfs layer.
Added vfs calls to symlink() and readlink() with appropriate configure
checks.
Jeremy.
-
Tim Potter
b4a9079833 Win9x weirdness. When setting the named pipe handle state on a Unicode
server, Win9x only sends \PIPE instead of \PIPE\.  Looks suspiciously like
an off-by one bug in the Win9x dce/rpc pipe code.
-
Jeremy Allison
52143c0853 Always use DOMAIN\user first that this is the more specific case.
Jeremy.
-
Andrew Bartlett
b33000cdc0 Remove warning about trapdoor systems for non-root mode.
Andrew Bartlett
-
Jeremy Allison
fa721b4adf Fixed stupid typo that would stop trusted domains working.
Jeremy.
-
Andrew Tridgell
e2ecff419f fixed usage of socklen_t and also tidied up SIG_ATOMIC_T, using a typedef instead of a define -
Andrew Tridgell
55109a7525 - make the regresison test mode code build in by default. This should
allow us to have test targets without special configure options
- fixed make proto so that it actually does something
-
Jeremy Allison
f8c121c69c Log debug before and after netbios names copied so we know if they've been
changed.
Jeremy.
-
Jeremy Allison
e059fffd03 Added other_safe_chars to alpha_strcpy(). Needs testing but is a better
fix for the problem.
Jeremy.
-
Jeremy Allison
17c3faa367 Better fix for client name vulnarability.
Jeremy.
-
Jeremy Allison
08c1682423 Fixed logic bug in timeout processing spotted by Ying Chen <ying@almaden.ibm.com>.
Jeremy.
-
Andrew Tridgell
7e8e6ae9a8 added the ability to test smbd safely as an ordinary user. The way it works is
that libsmb/ creates a local tcp socket then launches smbd as a subprocess
attached to that socket. smbd thinks it is being launched from inetd.

to use it do the following:

- compile with -DSMB_REGRESSION_TEST
- run like this (also works with smbtorture etc)
    export SMBD_TEST=1
    export LIBSMB_PROG=bin/smbd
    smbclient //server/share -Uuser%pass

obviously you need to setup a smb.conf etc. Using --prefix to configure
is useful.

The aim of all this stuff is to add a decent set of regression tests
to the build farm, so we know if smbd actually runs correctly on all the
platforms, not just builds. We can run smbtorture, masktest, locktest etc,
plus a bunch of smbclient scripts and any new tests we write.

This doesn't help much with nmbd (at least not yet) but its a good start.
-
Jeremy Allison
0187cd6aef Andrew - please look this over. I've fixed a long standing (maybe 4-5
years old) bug when chainging a sessionsetup_and_X and tcon together.
The wrong username was being entered into the tdb, even though the
correct user was used for accessing files. This is related to the fact
that authorise_login() is not used for sessionsetup, but only for tcon
auths.
Jeremy.
-
Andrew Tridgell
674ee2f1d1 next_token() was supposed to be a reentrant replacement for strtok(),
but the code suffered from bitrot and is not now reentrant. That means
we can get bizarre behaviour
i've fixed this by making next_token() reentrant and creating a
next_token_nr() that is a small non-reentrant wrapper for those lumps
of code (mostly smbclient) that have come to rely on the non-reentrant
behaviour
-
Andrew Tridgell
86613493a9 Added STR_NOALIGN flags to clistr and srvstr fns. Yes, NT actually does
send unaligned unicode strings sometimes!
Fixed our handling of the workgroup name tacked on the end of the
NT1 negprot response (a unaligned unicode)
fixed a couple of places where we should be using the message_end fns instead
of pre-calculated buffer lengths
-
Jeremy Allison
244aec8ea6 Following info from TAKAHASHI Motonobu <monyo@samba.gr.jp>,
Samba Users Group Japan, ensure that we don't use dos_to_unix(xx,True),
but always use dos_to_unix(xx,False) to prevent overwriting.
Jeremy.
-
Jeremy Allison
05a2911403 Fixed W2K SP2 joining a Samba PDC hosted domain.
Jermey.
-