1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

1747 Commits

Author SHA1 Message Date
Günther Deschner
ec06c81db3 s3-rpc_client: use netlogon_creds_arcfour_crypt() in init_netr_CryptPassword.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2012-12-09 19:39:07 +01:00
Günther Deschner
3c486dfee4 s3-rpc_client: make dcerpc_lsa_lookup_names_generic() public.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:41 +01:00
Günther Deschner
2d38154f91 s3-rpc_cli: make dcerpc_lsa_lookup_sids_generic() public.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:38 +01:00
Günther Deschner
457c933ff0 s3-rpc_cli: Remove some unused wrapping code.
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2012-11-30 11:49:21 +01:00
Günther Deschner
b11ba24883 s3-rpc_client: try to use socket_addr if available in rpc_pipe_open_tcp() (bug #9426)
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Nov 26 17:36:20 CET 2012 on sn-devel-104
2012-11-26 17:36:19 +01:00
Günther Deschner
2032f2746d s3-rpc_client: lookup nametype 0x20 in rpc_pipe_open_tcp_port(). (bug #9426)
The server name type (0x20) is much more likely to be available in the name cache, as
this type gets stored by winbind itself - the primary user of the ncacn_ip_tcp
code currently.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Nov 23 16:30:57 CET 2012 on sn-devel-104
2012-11-23 16:30:56 +01:00
Andreas Schneider
24fc5b46f2 s3-spoolss: Fix builtin forms order to match Windows again.
Thanks to mamachine@gmail.com.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Sep 26 20:07:44 CEST 2012 on sn-devel-104
2012-09-26 20:07:43 +02:00
Stefan Metzmacher
8e1c6d4232 s3:rpc_client: rename pipe_auth_data->user_session_key to transport_session_key
metze
2012-08-01 14:17:15 +02:00
Stefan Metzmacher
8b42f526f4 s3:rpc_client: make use of smbXcli_session_application_key()
metze
2012-08-01 14:17:14 +02:00
Andreas Schneider
33206b1e24 s3-rpc_client: Fix updating netlogon credentials.
Signed-off-by: Günther Deschner <gd@samba.org>
2012-07-17 13:53:37 +02:00
Andreas Schneider
572b549063 s3-rpc_client: Add capabilities check for AES encrypted connections.
Signed-off-by: Günther Deschner <gd@samba.org>
2012-07-17 13:53:37 +02:00
Andreas Schneider
a866dcc4f6 s3-rpc: Return the correct ntstatus depending on the transport. 2012-07-06 10:00:57 +02:00
Volker Lendecke
b9a15f1bfa s3: Give machine password changes 10 minutes of time
This is what we do at domain join time as well, see
lib/netapi/joindomain.c:141

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-22 17:28:20 +02:00
Stefan Metzmacher
1e5010fd99 s3:rpc_client: tstream_cli_np_open_send() doesn't expect a leading backslash
This fixes winbindd against a windows server using SMB2.

metze
2012-05-28 19:51:46 +02:00
Luk Claes
4f6f4ea93c s3:libsmb: get rid of cli_state_remote_name
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-28 14:49:45 +02:00
Volker Lendecke
9b0b60c67e s3: Fix Coverity ID 242715 Uninitialized scalar variable
In an error path we are closing hive_hnd without opening it
2012-05-10 09:11:58 +02:00
Volker Lendecke
6d5bbb9a4b s3: Fix Coverity ID 242716 Uninitialized scalar variable
In an error path we are closing key_hnd without opening it
2012-05-10 09:11:57 +02:00
Volker Lendecke
05e59739b3 s3: Fix Coverity ID 242691 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:57 +02:00
Volker Lendecke
8c2f826553 s3: Fix Coverity ID 242692 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
318cf16f7b s3: Fix Coverity ID 242693 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
c0471d1d96 s3: Fix Coverity ID 242694 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
39577f1e99 s3: Fix Coverity ID 242695 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
600c4c9c45 s3: Fix Coverity ID 242696 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
995ea20fa2 s3: Fix Coverity ID 242697 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
3a8c4ab2ad s3: Fix Coverity ID 242698 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
75271528f3 s3: Fix Coverity ID 242699 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
f9f4d705c2 s3: Fix Coverity ID 242700 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
a7b23cec6d s3: Fix Coverity ID 242701 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
e0bc3767e3 s3: Fix Coverity ID 242702 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
11085bd93a s3: Fix Coverity ID 242703 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
6c34e1a015 s3: Fix Coverity ID 242704 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
37b7095c8a s3: Fix Coverity ID 242705 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Volker Lendecke
67e306703b s3: Fix Coverity ID 242706 Dereference before null check
winreg_printer_openkey above already dereferences winreg_handle
2012-05-10 09:11:56 +02:00
Jelmer Vernooij
2c9444685d cli_pipe: Avoid sys_connect. 2012-03-24 14:57:47 +01:00
Jelmer Vernooij
95ca5fbadd libndr: Rename ndr64_transfer_syntax and null_ndr_syntax_id so they have a ndr_ prefix.
This makes the NDR namespace a bit clearer, in preparation of ABI checking.
2012-03-20 13:54:07 +01:00
Andreas Schneider
034489718c s3-rpc_client: Add debug message for printer dataex errors. 2012-03-14 17:56:14 +01:00
Christian Ambach
7936fb0ab8 Fix bug #8807 - dcerpc_lsa_lookup_sids_noalloc() crashes when groups has more than 1000 groups
Use correct talloc heirarchy.

Signed-off-by: Jeremy Allison <jra@samba.org>
2012-03-13 12:17:31 -07:00
Volker Lendecke
1bf126c0b3 s3: Remove some superfluous () 2012-03-09 17:21:11 +01:00
Stefan Metzmacher
083d80c502 s3:rpc_client: initialize struct schannel_state to zero
metze
2012-03-02 07:07:10 +01:00
Andrew Bartlett
2b511f0e92 s3-librpc: Use gensec_spnego for DCE/RPC authentication
This ensures that we use the same SPNEGO code on session setup and on
DCE/RPC binds, and simplfies the calling code as spnego is no longer
a special case in cli_pipe.c

A special case wrapper function remains to avoid changing the
application layer callers in this patch.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16 15:18:42 +01:00
Stefan Metzmacher
0c5cbb557b s3:rpc_client: fix comment
metze
2012-02-16 15:18:41 +01:00
Andrew Bartlett
bd2a7aac2c s3-librpc: make gensec result handling more generic
This prepares us for handling SPNEGO via gensec

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16 15:18:41 +01:00
David Disseldorp
ec094bf9ac WERROR type variable being incorrectly checked with a NT_STATUS_IS_X
type macro.
2012-01-23 12:18:01 -08:00
Andrew Bartlett
40715e1251 s3-librpc: pass struct ndr_interface_table down to cli_pipe_open_generic/spnego()
This allows the target service (as determined from the IDL) to be
passed to GSSAPI (rather than the current, incorrect, "cifs").

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:24 +01:00
Andrew Bartlett
c62af4f652 s3-librpc Make cli_rpc_pipe_open_spnego_ntlmssp() generic
This also avoids passing NULL as the server to
gensec_set_target_hostname() in spnego_generic_init_client().

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:23 +01:00
Andrew Bartlett
f2efb0f6a3 s3-librpc Remove special case for spnego session key
SPNEGO is implemented only in terms of gensec mechanisms now.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:23 +01:00
Andrew Bartlett
0c1b4c2321 s3-librpc Call SPENGO/GSSAPI via the auth_generic layer and gensec
This simplifies a lot of code, as we know we are always dealing
with a struct gensec_security, and allows the gensec module being
used to implement GSSAPI to be swapped for AD-server operation.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:22 +01:00
Andrew Bartlett
e012ad9d8b s3-librpc Call GSSAPI via the auth_generic layer and gensec
This simplifies a lot of code, as we know we are always dealing with a
struct gensec_security, and allows the gensec module being used to
implement GSSAPI to be swapped when required for AD-server operation.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-18 16:23:22 +01:00
Andrew Bartlett
49bafcfa48 s3-librpc Supply target service and server to spnego_generic_init_client()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-11 09:09:43 +01:00
Andrew Bartlett
50a939ad85 s3-librpc: Rename spnego_ntlmssp_init_client and make generic
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-11 09:05:01 +01:00
Andrew Bartlett
e574489be4 s3-librpc Set target service and server into gensec
This will allow cli_rpc_pipe_open_generic_auth() to handle kerberos mechanisms.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-11 09:04:48 +01:00
Andrew Bartlett
b89a0439b3 s3-librpc Rename and rework cli_rpc_pipe_open_ntlmssp() to be generic
This also includes renaming the helper function
rpccli_ntlmssp_bind_data, and allows this function to operate on any
gensec-supplied auth type.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-11 09:04:41 +01:00
Andrew Bartlett
1e5e219a4b s3-librpc Rename create_ntlmssp_auth_rpc_bind_req() to be more generic
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-11 09:04:24 +01:00
Andrew Bartlett
a00032a92d s3-libsmb Make auth_ntlmssp client more generic
As well as renaming, this allows us to start the mech by DCE/RPC auth
type or OID.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-01-06 08:12:49 +01:00
Andrew Bartlett
6391fff9da s3-auth rename auth_ntlmssp_state -> auth_generic_state
This structure handles more than NTLMSSP now, at least when we are an AD DC
and so changing the name may avoid some confusion in the future.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-12-22 19:25:10 +01:00
Andrew Bartlett
c9d929af8b s4-lsarpc handle more info levels in SetInfoTrustedDomain calls
This uses the very helpful conversion functions written for the s3 lsa server
and places these in common.

Andrew Bartlett
2011-12-12 12:57:07 +01:00
Stefan Metzmacher
790c6b4027 s3:rpc_client: remove references to auth_ntlmssp_state
metze

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct 27 16:40:15 CEST 2011 on sn-devel-104
2011-10-27 16:40:15 +02:00
Simo Sorce
8870daeb8d idl: Improve MS-PAC IDL
Change some misleading variable names to reflect the actual function.
Add missing field name/types previously marked as unkown.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Oct 24 19:19:28 CEST 2011 on sn-devel-104
2011-10-24 19:19:28 +02:00
Andrew Bartlett
0a0839821a s3-ntlmssp Remove auth_ntlmssp_session_key()
We now just call the gensec_session_key() directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-10-21 08:43:38 +02:00
Andrew Bartlett
3f079885b2 s3-ntlmssp Remove auth_ntlmssp_want_feature()
We now just call the gensec_want_feature() directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-10-21 08:43:33 +02:00
Andrew Bartlett
083025ccd5 s3-ntlmssp Remove auth_ntlmssp_update wrapper
We now just call gensec_update directly.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-10-21 08:43:10 +02:00
Andrew Bartlett
f9b042641f s3-ntlmssp split auth_ntlmssp_client_start() into two parts
This will allow it to be a wrapper around a gensec module, which
requires that they options be set on a context, but before the
mechanism is started.

This also simplfies the callers, by moving the lp_*() calls
into one place.

Andrew Bartlett
2011-10-18 12:25:30 +02:00
Andrew Bartlett
f3333bdade s3-rpc_client remove cli_auth_ntlmssp_data_destructor
This can be an ordinary talloc child without causing any problem.

This seems to have been inherited from a time when ntlmssp_client_start()
returned malloc() based memory.

Andrew Bartlett
2011-10-18 12:25:30 +02:00
Andrew Bartlett
0c6e4adcb2 ntlmssp: Move ntlmssp code to auth/ntlmssp
This brings in the code from both libcli/auth and
source4/auth/ntlmssp.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-10-18 13:13:31 +11:00
Gregor Beck
85b145d745 s3:utils change data_blob_dup_talloc() to take a DATA_BLOB by value
Signed-off-by: Michael Adam <obnox@samba.org>
2011-10-12 22:45:53 +02:00
Volker Lendecke
dea2bd5b9b s3: Fix two c++ warnings 2011-09-18 17:24:22 +02:00
Stefan Metzmacher
cc5f973884 s3:rpc_client: return NT_STATUS_CONNECTION_DISCONNECTED
We should return the same in all places
and don't mix NT_STATUS_INVALID_CONNECTION and NT_STATUS_CONNECTION_INVALID.

metze
2011-09-14 18:03:17 +02:00
Volker Lendecke
e63d0c5f0c s3: Fix Coverity ID 2613 -- UNINIT
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Sep 13 12:39:10 CEST 2011 on sn-devel-104
2011-09-13 12:39:10 +02:00
Volker Lendecke
67605bfc55 s3: Fix Coverity ID 2614 -- UNINIT 2011-09-13 11:00:15 +02:00
Sumit Bose
456aee80f5 s3-lsa: Add conversion for auth info structs
struct lsa_TrustDomainInfoAuthInfo and struct
trustAuthInOutBlob can store the same information for different usage. The added
routines can convert one struct into the other.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Sep 12 15:52:17 CEST 2011 on sn-devel-104
2011-09-12 15:52:17 +02:00
Stefan Metzmacher
56319cf1b7 s3:rpc_transport_tstream: only use tstream_cli_np_use_trans() for sync requests
Currently the caller doesn't cope with multiple async requests anyway,
so this is just protection for the future.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Aug  5 22:31:12 CEST 2011 on sn-devel-104
2011-08-05 22:31:12 +02:00
Andrew Bartlett
1231b784a1 s3-ntlmssp Remove auth_ntlmssp_and_flags()
There is no need to mask out these flags as they simply are not set
yet.

The correct abstraction is to ask for NTLMSSP features.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03 18:48:03 +10:00
Andrew Bartlett
da4345a8d1 s3-ntlmssp Remove rpccli_get_pwd_hash and auth_ntlmssp_get_nt_hash
The session key we want here (the only one that is availble to the
encryption layer) is the one obtained by cli_get_session_key(), as
NTLMSSP creates a per-session session key via key exchange and NTLMv2
negotiation.

The key was never directly the NT hash anyway (this is simply a
mistake, the extra MD4() was lost during my previous cleanup
f28f113d8e in 2008), but was MD4(NT
hash) in early implementations of NTLMSSP.

However, regardless this call is not available on domain trusts
between AD domains and Windows 2003 R2, making this less useful.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03 18:48:03 +10:00
Andrew Bartlett
bba5f0a641 s3-ntlmssp Remove auth_ntlmssp_or_flags
We now just use auth_ntlmssp_want_feature to get extra flags
on the NTLMSSP context

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03 18:48:03 +10:00
Andrew Bartlett
6d7ac4f1ad s3-ntlmssp Add mem_ctx argument to auth_ntlmssp_update
This clarifies the lifetime of the returned token.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-08-03 18:48:03 +10:00
Andrew Bartlett
dee845eb70 s3-ntlmssp Add mem_ctx argument to auth_ntlmssp_get_session_key() 2011-08-03 18:48:02 +10:00
Stefan Metzmacher
a833aaf52c s3:rpc_transport_tstream: call tstream_cli_np_use_trans() before tstream_writev_queue_send()
This will be needed when tstream_writev_queue_send() changes it's behavior and
avoids using an immediate event when the queue is empty.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Aug  1 14:55:00 CEST 2011 on sn-devel-104
2011-08-01 14:55:00 +02:00
Andreas Schneider
8831402596 s3-rpc_client: Fix memory context in winreg_enum_printer_dataex(). 2011-07-27 08:49:58 +02:00
Andreas Schneider
5045281e17 s3-rpc_client: Close policy handles before creating defaults.
We reopen the hive and key so close them before reopen.
2011-07-27 08:49:58 +02:00
Andreas Schneider
f8afaa76f2 s3-rpc_client: Close the hive handle before we open it again. 2011-07-27 08:49:58 +02:00
Andreas Schneider
a0597b75e6 s3-rpc_client: Close hive if opening of the key fails. 2011-07-27 08:49:58 +02:00
Stefan Metzmacher
49c8534ae4 s3:cli_pipe_schannel: make use of cli_state_remote_name()
metze
2011-07-22 17:06:09 +02:00
Stefan Metzmacher
efc2c3159e s3:cli_pipe: make use of cli_state_remote_name()
metze
2011-07-22 17:06:09 +02:00
Stefan Metzmacher
ef23fb3412 s3:cli_pipe: use result->desthost instead of cli->desthost
metze
2011-07-22 17:06:09 +02:00
Andrew Bartlett
9fcc617ff5 s3-auth Use the common auth_session_info
This patch finally has the same structure being used to describe the
authorization data of a user across the whole codebase.

This will allow of our session handling to be accomplished with common code.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-20 09:17:13 +10:00
Andrew Bartlett
f16d8f4eb8 s3-auth Use struct auth3_session_info outside the auth subsystem
This seperation between the structure used inside the auth modules and
in the wider codebase allows for a gradual migration from struct
auth_serversupplied_info -> struct auth_session_info (from auth.idl)

The idea here is that we keep a clear seperation between the structure
before and after the local groups, local user lookup and the session
key modifications have been processed, as the lack of this seperation
has caused issues in the past.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-20 09:17:10 +10:00
Vicentiu Ciorbaru
e858ec6e92 s3-rpc_server: Removed no longer used functions.
Removed winreg_printer_delete_subkeys().
Removed winreg_printer_enumvalues().

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Jul 13 12:42:02 CEST 2011 on sn-devel-104
2011-07-13 12:42:02 +02:00
Vicentiu Ciorbaru
0b1ba88f22 s3-rpc_client: Migrate to dcerpc_winreg_delete_subkeys_recursive().
Functions now use dcerpc_winreg_delete_subkeys_recursive() instead of the more
specific printer function winreg_printer_delete_subkeys().

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-13 11:31:22 +02:00
Vicentiu Ciorbaru
a336cc44d9 s3-rpc_client: Migrate to dcerpc_winreg_enumvals() function.
The functions that called winreg_printer_enumvalues() function now use
dcerpc_winreg_enumvals().

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-13 11:30:55 +02:00
Vicentiu Ciorbaru
4558225cdd s3-rpc_client: Added dcerpc_winreg_delete_subkeys_recursive() function.
This function is set to replace the more specific printer function
winreg_printer_delete_subkeys().

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-13 10:09:08 +02:00
Vicentiu Ciorbaru
8b3eff8b36 s3-rpc_client: Added dcerpc_winreg_enumvals() function.
The function is set to replace the more specific printer function
winreg_printer_enumvalues() function.

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-13 10:08:56 +02:00
David Disseldorp
2a02f1c4af winreg: Ensure server return status is set on success
Currently cli_winreg.c functions only set the returned server werror
status on failure, if the server request succeeds the value remains
uninitialised.

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Jul  8 16:32:39 CEST 2011 on sn-devel-104
2011-07-08 16:32:39 +02:00
David Disseldorp
1271066200 winreg: Use the ntstatus return code for client side errors
cli_winreg.c functions indicate status to the caller in two ways. The
ntstatus return code indicates client side errors, the pwerr argument
carries the server response error code.

Many functions are filling the pwerr argument on client side error, this
change removes these cases.

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-07-08 15:22:27 +02:00
Günther Deschner
f2be8378b9 s3-printing: add rpc_client/cli_winreg_spoolss.c
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07 18:06:01 +02:00
Günther Deschner
43cf3a28dc s3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07 18:06:01 +02:00
Günther Deschner
74e416031b s3-printing: move driver_info_ctr_to_info8 to init_spoolss.h
Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
2011-07-07 18:06:01 +02:00
Andreas Schneider
541f3cf639 s3-rpc_server: Migrate rpc function to tsocket_address.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-07-04 18:27:58 +10:00
Andreas Schneider
a45120aea7 s3-rpc_client: Fix some valgrind warnings.
These are in/out values and need to be initialized.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-06-21 17:46:37 +02:00
Günther Deschner
cd16a1be93 source3/rpc_client/util_netlogon.h: fix licence/copyright
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jun 10 16:27:24 CEST 2011 on sn-devel-104
2011-06-10 16:27:23 +02:00
Günther Deschner
4942aeb9b5 source3/rpc_client/init_spoolss.h: fix licence/copyright
Guenther
2011-06-10 15:12:46 +02:00
Günther Deschner
054e54e881 source3/rpc_client/init_samr.h: fix licence/copyright
Guenther
2011-06-10 15:12:45 +02:00
Günther Deschner
f3ca8ff2bf source3/rpc_client/init_netlogon.h: fix licence/copyright
Guenther
2011-06-10 15:12:43 +02:00
Günther Deschner
9284036ce1 source3/rpc_client/init_lsa.h: fix licence/copyright
Guenther
2011-06-10 15:12:41 +02:00
Günther Deschner
b95b1813b9 source3/rpc_client/cli_spoolss.h: fix licence/copyright
Guenther
2011-06-10 15:12:39 +02:00
Günther Deschner
2d10c48259 source3/rpc_client/cli_netlogon.h: fix licence/copyright
Guenther
2011-06-10 15:12:37 +02:00
Andrew Bartlett
74eed8f3ed s3-param Remove special case for global_myname(), rename to lp_netbios_name()
There is no reason this can't be a normal constant string in the
loadparm system, now that we have lp_set_cmdline() to handle overrides
correctly.

Andrew Bartlett
2011-06-09 12:40:09 +02:00
Andrew Bartlett
ad0a07c531 s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
Using the standard macro makes it easier to move code into common, as
TALLOC_ZERO_P isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
3d15137653 s3-talloc Change TALLOC_ARRAY() to talloc_array()
Using the standard macro makes it easier to move code into common, as
TALLOC_ARRAY isn't standard talloc.
2011-06-09 12:40:08 +02:00
Andrew Bartlett
73b377432c s3-talloc Change TALLOC_REALLOC_ARRAY() to talloc_realloc()
Using the standard macro makes it easier to move code into common, as
TALLOC_REALLOC_ARRAY isn't standard talloc.

Andrew Bartlett
2011-06-09 12:40:08 +02:00
Rusty Russell
56e72337b0 lib/util/time.c: timeval_current_ofs_msec
Several places want "milliseconds from current time", and several were
simply doing "msec * 1000" which can (and does in one place) result in
a usec value over 1 a million.

Using a helper to do this is safer and more readable.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-01 10:38:47 +02:00
Günther Deschner
675573d54b s3-includes: finally only include client.h when libsmb is used.
Guenther
2011-05-06 16:37:22 +02:00
Jeremy Allison
4f41be356a Fix many const compiler warnings. 2011-05-05 10:41:59 -07:00
Günther Deschner
bd92826aa8 s3-rpc_client: run minimal_includes.pl.
Guenther
2011-05-05 02:05:27 +02:00
Günther Deschner
0bb4701a74 s3: remove various references to server side dcerpc structs (which are not needed).
Guenther
2011-05-02 15:03:44 +02:00
Günther Deschner
bc781bf7d9 s3-proto: remove duplicate prototypes.
Guenther
2011-04-29 21:01:05 +02:00
Günther Deschner
50883cfeb4 s3-tevent: only include ../lib/util/tevent wrappers where needed.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104
2011-04-29 14:00:30 +02:00
Günther Deschner
12476223c6 s3-tsocket: only include ../lib/tsocket/tsocket.h where needed.
Guenther
2011-04-29 12:19:04 +02:00
Stefan Metzmacher
f7bc84409a s3:rpc_client: map fault codes to NTSTATUS with dcerpc_fault_to_nt_status()
Most fault codes have a NTSTATUS representation, so use that.

This brings the fault handling in common with the source4/librpc/rpc code,
which make it possible to share more highlevel code, between source3 and
source4 as the error checking can be the same now.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Apr 24 10:44:53 CEST 2011 on sn-devel-104
2011-04-24 10:44:53 +02:00
Volker Lendecke
9a0676d5c9 s3: Fix Coverity ID 986, BUFFER_SIZE_WARNING
strncpy can leave the destination unterminated
2011-04-22 10:06:34 +02:00
Günther Deschner
bb65187b89 s3-proto: move more rpc client prototypes to cli_pipe.h.
Guenther
2011-04-21 18:28:07 +02:00
Jeremy Allison
bde2bcc8ef Fix bug 8088 - rpccli_samr_chng_pswd_auth_crap segfaults if any input blobs are null.
Correct fix - ensure we have enough length, and correctly null out
passed in structs if not.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Apr 19 00:17:08 CEST 2011 on sn-devel-104
2011-04-19 00:17:08 +02:00
Günther Deschner
9824e2e5ee s3-rpc_client: add and use rpc_client/rpc_client.h.
Guenther
2011-04-13 22:23:59 +02:00
Günther Deschner
4b3fe5247a s3-cli_pipe: fix timeout in rpc_pipe_open_tcp_port().
Make sure we use a timeout of 60 seconds, not 60 milliseconds...

This prevented us from successfully using the ncacn_ip_tcp client in a lot of
places, I guess.

Guenther

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Apr 13 18:59:19 CEST 2011 on sn-devel-104
2011-04-13 18:59:19 +02:00
Günther Deschner
64b664155b s3-rpc_client: move rpc_cli_transport structs and protos to rpc_transport.h
Guenther
2011-04-12 12:20:43 +02:00
Günther Deschner
643b08dd25 s3: include ../librpc/gen_ndr/lsa.h where needed.
Guenther
2011-03-30 01:13:10 +02:00
Günther Deschner
6e3f0d28a4 s3-includes: only include ntdomain.h where needed.
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
146c1aac99 s3-auth: rpc_server needs auth.h
Guenther
2011-03-30 01:13:09 +02:00
Günther Deschner
235f148590 s3-passdb: use passdb headers where needed.
Guenther
2011-03-30 01:13:08 +02:00
Günther Deschner
0a250f4946 registry: create and use shared libcli/registry/util_reg.h header.
Guenther
2011-03-30 01:13:07 +02:00
Michael Adam
e0681441af s3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Mar 29 01:34:28 CEST 2011 on sn-devel-104
2011-03-29 01:34:28 +02:00
Günther Deschner
d2d3ac66ec s3-rpc_client: actually call lsa_open_policy2() in rpccli_lsa_open_policy2().
Found by Sumit Bose <sbose@redhat.com>, thanks!

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 23 20:12:38 CET 2011 on sn-devel-104
2011-03-23 20:12:38 +01:00
Andreas Schneider
da718a5961 s3-epmapper: Use DCERPC_AUTH_LEVEL_CONNECT for ep ncalrpc. 2011-03-23 17:19:22 +01:00
Volker Lendecke
889e03617d s3: Fix Coverity ID 2232, REVERSE_INULL
No point checking for !cli after dereferencing it
2011-03-16 22:07:24 +01:00
Volker Lendecke
d8068b5a4b s3: Fix Coverity ID 2319: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-16 18:08:51 +01:00
Volker Lendecke
d9a58791b0 s3: Fix Coverity ID 2278: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
c98c36e38b s3: Fix Coverity ID 2280: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:46 +01:00
Volker Lendecke
e68cf5e9bf s3: Fix Coverity ID 2282: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:45 +01:00
Volker Lendecke
09677d664f s3: Fix Coverity ID 2288: Uninitialized read
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
2011-03-15 11:10:43 +01:00
Volker Lendecke
70c75b9ddf s3: Fix a typo
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Mar 11 13:15:00 CET 2011 on sn-devel-104
2011-03-11 13:15:00 +01:00
Andreas Schneider
038042363a s3-rpc_client: Don't ask endpoint mapper for its own port. 2011-03-09 09:28:42 +01:00
Andreas Schneider
d343409d6b s3-rpc_client: Added DCERPC_AUTH_TYPE_NCALRPC bind.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-08 11:41:29 +01:00
Andreas Schneider
bf18403c81 s3-rpc_client: Move client pipe functions to own header. 2011-02-28 18:15:04 +01:00
Stefan Metzmacher
1f13d512d4 s3:rpc_client: we need to pass a non-blocking socket to tstream_bsd_existing_socket()
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb 24 07:43:59 CET 2011 on sn-devel-104
2011-02-24 07:43:59 +01:00
Andrew Bartlett
2e69e89456 s3-auth Rename auth_serversupplied_info varaiables: server_info -> session_info
These variables, of type struct auth_serversupplied_info were poorly
named when added into 2001, and in good consistant practice, this has
extended all over the codebase in the years since.

The structure is also not ideal for it's current purpose.  Originally
intended to convey the results of the authentication modules, it
really describes all the essential attributes of a session.  This
rename will reduce the volume of a future patch to replaced these with
a struct auth_session_info, with auth_serversupplied_info confined to
the lower levels of the auth subsystem, and then eliminated.

(The new structure will be the output of create_local_token(), and the
change in struct definition will ensure that this is always run, populating
local groups and privileges).

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-02-22 16:20:10 +11:00
Andreas Schneider
da9cd736d2 s3-rpc_client: Fixed an uninitialized variable.
Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Feb 10 18:32:08 CET 2011 on sn-devel-104
2011-02-10 18:32:08 +01:00
Andreas Schneider
8cffe147eb s3-rpc_client: Added dcerpc_winreg_int_openkey() which dectects the hive.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-10 17:47:04 +01:00
Andreas Schneider
8ed5808390 s3-rpc_client: Fixed winreg int documentation.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-10 17:47:04 +01:00
Stefan Metzmacher
f915dd5dd4 s3:rpc_client: make rpccli_bh_create() non-static for now
metze
2011-02-09 11:46:20 +01:00
Andreas Schneider
01b49b1a2b s3-rpc_client: Added a winreg query security descriptor helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
35439a7b18 s3-rpc_client: Added a winreg set security descriptor helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
a370b9605c s3-rpc_client: Added a winreg set binary helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
56963d1f44 s3-rpc_client: Added a winreg query sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
69e6db1a53 s3-rpc_client: Added a winreg helper to enum keys.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:32:00 +01:00
Andreas Schneider
8ed91d6027 s3-rpc_client: Added a winreg add multi sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
8c119e4757 s3-rpc_client: Added a winreg query multi sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
913426b0c3 s3-rpc_client: Added a winreg set multi sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
34d3e85f35 s3-rpc_client: Added a winreg set expand sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
4b32f6c9d5 s3-rpc_client: Added a winreg set sz helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
e5eb7582d3 s3-rpc_client: Added a winreg set dword helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
d24bd4be91 s3-rpc_client: Added winreg query binary helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
9c7607d3d3 s3-rpc_client: Added winreg query dword helper.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Andreas Schneider
12cd4002e6 s3-rpc_client: Added dcerpc_winreg_int_openkey().
Signed-off-by: Günther Deschner <gd@samba.org>
2011-02-07 12:31:59 +01:00
Volker Lendecke
8af7400d55 s3: Fix some nonempty blank lines 2011-02-06 16:44:56 +01:00
Günther Deschner
f60398d7b2 s3-winbindd: let winbind try to use samlogon validation level 6. (bug #7945)
The benefit of this that it makes us more robust to secure channel resets
triggered from tools outside the winbind process. Long term we need to have a
shared tdb secure channel store though as well.

Guenther

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Feb  4 18:11:04 CET 2011 on sn-devel-104
2011-02-04 18:11:04 +01:00
Günther Deschner
ac4127a9f4 s3-auth: add copy_netr_SamBaseInfo().
Guenther

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-02-04 16:57:32 +01:00
Günther Deschner
50be0b2c1e s3: Remove superfluous ;
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Feb  2 15:44:21 CET 2011 on sn-devel-104
2011-02-02 15:44:21 +01:00
Günther Deschner
1232fb5a1e s3-rpc_client: remove some more obsolete cli_X.h header files.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 11:18:44 CET 2011 on sn-devel-104
2011-01-28 11:18:44 +01:00
Günther Deschner
99437614fa s3-rpcclient: allow to define validation level for samlogon.
Guenther
2011-01-24 16:56:00 +01:00
Günther Deschner
6923cc8016 s3-rpc_client: fix dcerpc_try_samr_connects().
Only return when both results are ok.

Guenther
2011-01-21 16:10:15 +01:00
Günther Deschner
e873ce9b65 s3-rpc_client: no need to include gen_ndr/cli_samr.h anymore.
Guenther
2011-01-21 16:10:15 +01:00
Günther Deschner
1f26b101ed s3-rpc_client: fix uninitialized variable found by -O3.
Guenther
2011-01-21 16:10:15 +01:00
Günther Deschner
e94ffc790e s3-rpc_client: prefer dcerpc_spoolss_X functions.
Guenther
2011-01-21 15:20:22 +01:00
Andreas Schneider
5db115a304 s3-rpc_client: Added dcerpc_try_samr_connects.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 15:19:01 CET 2011 on sn-devel-104
2011-01-21 15:19:01 +01:00
Andreas Schneider
089c25cbbb s3-rpc_client: Rename get_query_dispinfo_params. 2011-01-21 14:34:18 +01:00
Andreas Schneider
e6475f2151 s3-rpc_client: Added dcerpc_samr_chgpasswd_user3. 2011-01-21 14:34:18 +01:00
Andreas Schneider
200772653a s3-rpc_client: Added dcerpc_samr_chng_pswd_auth_crap. 2011-01-21 14:34:18 +01:00
Andreas Schneider
3de564b9b6 s3-rpc_client: Added dcerpc_samr_chgpasswd_user2. 2011-01-21 14:34:17 +01:00
Andreas Schneider
78c4f72c31 s3-rpc_client: Added dcerpc_samr_chgpasswd_user. 2011-01-21 14:34:17 +01:00
Andreas Schneider
8b1ffc770c s3-rpc_client: Added header information to cli_samr.h. 2011-01-21 14:34:17 +01:00
Andreas Schneider
1efa9b1cbd s3-rpc_client: Added header information to cli_lsarpc.h. 2011-01-21 14:34:17 +01:00
Günther Deschner
5efe6566a0 s3-rpc_client: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
Guenther
2011-01-18 23:54:31 +01:00
Andreas Schneider
93da0aab97 s3-rpc_client: Fixed status check of dcerpc_lsa_lookup_sids_noalloc.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Jan 17 17:35:50 CET 2011 on sn-devel-104
2011-01-17 17:35:50 +01:00
Andreas Schneider
296a958c57 s3-rpc_client: Fixed return values of dcerpc_lsa_lookup_sids_generic. 2011-01-17 16:50:55 +01:00
Günther Deschner
232378c6e5 s3-rpc_client: prefer dcerpc_netr_X functions.
Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
2011-01-13 12:36:54 +01:00
Andreas Schneider
3f21b971a9 s3-rpc_client: Fixed the dcerpc_lsa_LookupNames4 client_revision.
The spec states that the ClientRevision value MUST be one of the
following: LSA_CLIENT_REVISION_1 or LSA_CLIENT_REVISION_2.

LSA_CLIENT_REVISION_2 means Windows 2000 and newer.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 10 19:05:31 CET 2011 on sn-devel-104
2011-01-10 19:05:31 +01:00
Andreas Schneider
b1df95cbc5 s3-rpc_client: Fixed the dcerpc_lsa_LookupNames4 lookup_options.
Use the enum value in dcerpc_lsa_LookupNames4 for _lookup_options.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:55 +01:00
Andreas Schneider
e02916c453 s3-rpc_client: Fixed the dcerpc_lsa_LookupSids3 client_revision.
The spec states that the ClientRevision value MUST be one of the
following: LSA_CLIENT_REVISION_1 or LSA_CLIENT_REVISION_2.

LSA_CLIENT_REVISION_2 means Windows 2000 and newer.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:55 +01:00
Andreas Schneider
a53e0831d2 s3-rpc_client: Fixed the dcerpc_lsa_LookupSids3 lookup_options.
Use the enum value in dcerpc_lsa_LookupSids3 for _lookup_options.

Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:55 +01:00
Andreas Schneider
fd1fff608c s3-rpc_client: Added dcerpc_lsa_lookup_names.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:55 +01:00
Andreas Schneider
c91e756f8d s3-rpc_client: Added dcerpc_lsa_lookup_sids and dcerpc_lsa_lookup_sids3.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:55 +01:00
Andreas Schneider
8f14229b28 s3-rpc_client: Added dcerpc_lsa_open_policy2.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:55 +01:00
Andreas Schneider
2f819505af s3-rpc_client: Added dcerpc_lsa_open_policy.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-01-10 18:20:54 +01:00
Stefan Metzmacher
fba2fdf265 s3:rpc_client: use dcerpc_epm_Map() and don't ignore 'result' anymore.
metze
2011-01-04 21:28:49 +01:00
Stefan Metzmacher
8b47fcea04 s3:rpc_client: implement rpc_transport_np_init() on top of rpc_transport_tstream_init()
This also makes use of tstream_cli_np_open() to get the tstream.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Dec 15 16:12:30 CET 2010 on sn-devel-104
2010-12-15 16:12:30 +01:00
Stefan Metzmacher
0342ed3ee0 s3:rpc_client: implement rpc_transport_sock_init() on top of rpc_transport_tstream_init()
metze
2010-12-15 15:26:05 +01:00
Stefan Metzmacher
122dc1e213 s3:rpc_client/rpc_transport_tstream.c: add some logic to handle cli_np tstreams
metze
2010-12-15 15:26:05 +01:00
Stefan Metzmacher
9a14dace22 s3:rpc_client/rpc_transport_tstream: timeout should be unsigned int
metze
2010-12-15 15:26:05 +01:00
Stefan Metzmacher
e55426fe79 s3:rpc_client: let rpc_transport_tstream_init() create read and write queue
metze
2010-12-15 15:26:05 +01:00
Volker Lendecke
8d28ae10d2 s3: Correctly calculate the wbinfo -s result 2010-11-24 16:07:55 +01:00
Andrew Bartlett
f768b32e37 libcli/security Provide a common, top level libcli/security/security.h
This will reduce the noise from merges of the rest of the
libcli/security code, without this commit changing what code
is actually used.

This includes (along with other security headers) dom_sid.h and
security_token.h

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 12 05:54:10 UTC 2010 on sn-devel-104
2010-10-12 05:54:10 +00:00
Simo Sorce
3453bc7b11 s3-dcerpc: make auth context opaque
This way we always double check in advance that the context
is of the right type with talloc_get_type_abort instead of
potentially accessing random memory by addressing the wrong
structure in the union.

Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:24 -07:00
Simo Sorce
d10e192b83 s3-dcerpc: finally remove the legaqcy spnego_type variable from pipe_auth_data
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:23 -07:00
Simo Sorce
2c9f420d75 s3-dcerpc: move client spnego stuff in /librpc/crypto
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:22 -07:00
Simo Sorce
59722ef2fb spnego: avoid explicit dependency on dcerpc specific structures
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:54:22 -07:00
Simo Sorce
412ebad02b gssapi: avoid explicit dependency on dcerpc specific structures
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:36:54 -07:00
Simo Sorce
0e5eb82a6f s3-dcerpc: move crypto stuff in /librpc/crypto
Signed-off-by: Günther Deschner <gd@samba.org>
2010-09-23 10:36:54 -07:00
Günther Deschner
102a70e809 s3-util: use shared dom_sid_dup.
Guenther
2010-09-20 14:05:07 -07:00
Günther Deschner
c7fe04abc7 s3-build: only include async headers where needed.
Guenther
2010-09-20 13:54:42 -07:00
Stefan Metzmacher
78b6265ac2 s3:rpc_client: remove unused rpc_pipe_set_hnd_state()
metze
2010-09-17 15:42:36 +02:00
Stefan Metzmacher
fde3412ccb s3:rpc_client: use rpc_api_pipe_send() for auth3
metze
2010-09-17 15:42:35 +02:00
Stefan Metzmacher
6ecf8d16bc s3:rpc_client: rpc_pipe_bind_step_one_done() doesn't need reply_pdu
metze
2010-09-17 15:42:35 +02:00
Stefan Metzmacher
de6254d3d6 s3:rpc_client: allow DCERPC_PKT_AUTH3 via rpc_api_pipe_send/recv
metze
2010-09-17 15:42:34 +02:00
Simo Sorce
7b1748d959 s3-rpc_client: Added a tstream based transport.
Signed-off-by: Andreas Schneider <asn@cynapses.org>
2010-09-15 12:53:41 +02:00
Stefan Metzmacher
a510b9de39 s3:rpc_client: implement rpccli_bh_set_timeout()
metze
2010-09-04 09:01:15 +02:00
Günther Deschner
7b6fc9f414 s3-dcerpc: only include rpc_dce.h where needed.
Guenther
2010-08-26 00:20:29 +02:00
Günther Deschner
0ed16e94c3 s3: separate out cli schannel functions that depend on cli_netlogon.
Guenther
2010-08-26 00:16:57 +02:00
Günther Deschner
e978a3d3f4 s3-lsa: separate out init_lsa headers.
Guenther
2010-08-25 22:50:39 +02:00
Günther Deschner
898c612335 s3-dcerpc: avoid talloc_move on schannel creds in cli_rpc_pipe_open_schannel_with_key().
Initially, the schannel creds were talloc memduped, then, during the netlogon
creds client merge (baf7274fed) they were first
talloc_referenced and then later (53765c81f7)
talloc_moved.

The issue with using talloc_move here is that users of that function in winbind
will only be able to have two schanneled connections, as the cached schannel
credentials pointer from the netlogon pipe will be set to NULL. Do a deep copy
of the struct instead.

Guenther
2010-08-24 02:04:27 +02:00
Simo Sorce
a782a80d2f s3-dcerpc: Allocate structure members on the right context 2010-08-23 17:11:32 -04:00
Günther Deschner
35052d71d3 s3-dcerpc: fix uninitialized variable in cli_get_session_key().
Simo, please check.

Guenther
2010-08-17 13:06:13 +02:00
Simo Sorce
f40ef7e24c s3-dcerpc: Use common send functions for ntlmssp too
Remove unused function.
2010-08-17 06:33:14 -04:00
Simo Sorce
86914b8fab s3-dcerpc: properly implement gse/spnego_get_session_key 2010-08-17 06:33:13 -04:00
Simo Sorce
26a3ba60e6 s3-dcerpc: Check data and return appropriate error 2010-08-17 06:33:13 -04:00
Simo Sorce
9a9a38c666 Change debug statements to use __location__ 2010-08-17 06:33:13 -04:00
Simo Sorce
72a0098415 s3-dcerpc: Pull packet in the caller, before validation 2010-08-17 06:33:13 -04:00
Simo Sorce
558320cf58 Add my (c) 2010-08-17 06:33:13 -04:00
Stefan Metzmacher
745f63fd1e s3:rpc_client: remove unused cli_do_rpc_ndr* functions
metze
2010-08-16 14:30:18 +02:00
Stefan Metzmacher
dd16d3b2d6 s3:rpc_client: remove unused rpc_pipe_open_local()
metze
2010-08-16 14:30:17 +02:00
Stefan Metzmacher
2c0e296dd7 s3:rpc_client: add dcerpc_binding_handle backend
metze
2010-08-12 14:31:21 +02:00
Volker Lendecke
0a224bc77b s3: Save the received trans2 from the inbuf in cli_trans 2010-08-05 13:57:29 +02:00
Günther Deschner
64b26affe0 s3-dcerpc: fix some uninitialized variables build warnings.
Guenther
2010-08-03 15:57:56 +02:00
Günther Deschner
813fbbd68c s3-build: avoid to globally include printing and spoolss headers.
This shrinks precompiled headers by 3MB and will slightly speed up any build.

Guenther
2010-07-31 00:50:31 +02:00
Simo Sorce
4c64e4d4af s3-dceprc: Improve dcerpc_guess_sizes() interface
Make it possible to pass in the NDR padding size so that theoretically
client and server code can decide to use a different alignment.

Pass in the header length as a parameter so that this function can be used for
different type of packets.

Make sure padding size will not make the fragment exceed the maximum length.

Calculate padding taking in account the header length.
2010-07-30 14:55:28 -04:00
Simo Sorce
a9d3a596a7 s3-dcerpc: Make function to guess pdu sizes common. 2010-07-30 14:55:27 -04:00
Simo Sorce
9329a9fe84 s3-dceprc: consolidate use of dcerpc_push_dcerpc_auth() 2010-07-30 14:55:27 -04:00
Simo Sorce
da6c246aac s3-dcerpc: Remove unused functions 2010-07-30 14:55:27 -04:00
Simo Sorce
186f93633b s3-dcerpc: use common spengo wrapper code for client SPNEGO/NTLMSSP 2010-07-30 14:55:27 -04:00
Simo Sorce
984438ca15 s3-dcerpc: add sign/seal support when using SPNEGO/KRB5 2010-07-30 14:55:27 -04:00
Simo Sorce
0b24e8e869 s3-dcerpc: Add SPNEGO incapsulation for KRB5 auth 2010-07-30 14:55:27 -04:00
Simo Sorce
7c9c075987 Do not refernece pipe_auth_data directly in dcerpc_gssapi.c 2010-07-28 15:53:56 -04:00
Simo Sorce
d17abc69f6 s3-dcerpc: Avoid ifdef, it is handled within dcerpc_gssapi.c already 2010-07-28 15:35:59 -04:00
Simo Sorce
7eaa15af2c s3-dcerpc: Add sign/seal with gssapi 2010-07-28 12:42:15 -04:00
Simo Sorce
1abcbd70ae s3-dcerpc: Add next authentication step with gssapi 2010-07-28 12:24:44 -04:00
Simo Sorce
135a82e78f s3-decrpc: Introduce gssapi support for dcerpc krb5 auth 2010-07-28 12:24:44 -04:00
Simo Sorce
183e0a0d9f s3-dcerpc: Refactor calculate_data_len_tosend() 2010-07-28 12:23:22 -04:00
Simo Sorce
c08d684f4e s3-dcerpc: Add auth trailer only when appropriate. 2010-07-28 12:23:00 -04:00
Simo Sorce
866f85e319 s3-dcerpc: consolidate unmarshalling of dcerpc_auth 2010-07-28 12:22:31 -04:00
Simo Sorce
146af48d48 s3-dcerpc: revive cli_rpc_pipe_open_krb5() 2010-07-28 12:21:29 -04:00
Simo Sorce
2463a87177 s3-dcerpc: Use dcerpc_AuthType in pipe_auth_data 2010-07-28 12:19:32 -04:00
Simo Sorce
1e915d231d s3-dcerpc: Cleanup and refactor create_rpc_bind_req() 2010-07-28 12:18:45 -04:00