1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-29 11:21:54 +03:00
Commit Graph

18773 Commits

Author SHA1 Message Date
Volker Lendecke
28fb5b6f97 r12313: Introduce yet another copy of the string_sub function:
talloc_string_sub. Someone with time on his hands could convert all the
callers of all_string_sub to this.

realloc_string_sub is *only* called from within substitute.c, it could be
moved there I think.

Volker
(This used to be commit be6c9012da)
2007-10-10 11:05:53 -05:00
Volker Lendecke
0a585102d6 r12312: Reformatting and a trivial change: is_share_read_only_for_user only uses
conn->service, so there's no point in passing down the whole conn struct.

Volker
(This used to be commit 39041297c7)
2007-10-10 11:05:53 -05:00
Volker Lendecke
46dee7219d r12311: Reformatting
(This used to be commit 23f5be1dcb)
2007-10-10 11:05:53 -05:00
Volker Lendecke
f2c8291791 r12308: Reformatting
(This used to be commit 97acfa12e5)
2007-10-10 11:05:53 -05:00
Volker Lendecke
862e4a11c1 r12307: Reformatting plus a trivial if/else simplification. There's no point in doing
an else branch that only returns NULL.

Volker
(This used to be commit ef4d9d96de)
2007-10-10 11:05:53 -05:00
Volker Lendecke
286fed3627 r12306: Reformatting
(This used to be commit 3f1dad5fdb)
2007-10-10 11:05:53 -05:00
Volker Lendecke
b15c32800d r12305: Reformatting
(This used to be commit f574e980aa)
2007-10-10 11:05:52 -05:00
Volker Lendecke
e1dd50bfd7 r12303: Move split_domain_and_name to util_getent.c and make it static there.
Volker
(This used to be commit e7f348fcf8)
2007-10-10 11:05:52 -05:00
Volker Lendecke
8ee13ab866 r12291: Make getgroups_user static.
Jeremy, there's a #ifdef'ed 0 call to this in your usershare code. We need to
talk about what exactly what you intend to do here and in what scenarios.

Volker
(This used to be commit 95094ef758)
2007-10-10 11:05:52 -05:00
Volker Lendecke
7ae0fd8ed8 r12290: Typo
(This used to be commit de839cc165)
2007-10-10 11:05:52 -05:00
Gerald Carter
31c73b9913 r12281: adding a note about WINS and NetLogon not being remotely manageable
(This used to be commit b86528865a)
2007-10-10 11:05:51 -05:00
Jeremy Allison
10b5609a14 r12279: unix_mask_match has been broken for *ever*... (How).
Ensure it returns a BOOL.
Jerry (and anyone else) please check this, I think
all uses are now correct but could do with another
set of eyes. Essential for 3.0.21 release.
Jeremy.
(This used to be commit 0c7b8a7637)
2007-10-10 11:05:51 -05:00
Jeremy Allison
76796e212c r12275: Fix memory leak found by Mikhail Kshevetskiy <kl@laska.dorms.spbu.ru>
and followed up by derrell@samba.org.
Jeremy.
(This used to be commit 5cab88f144)
2007-10-10 11:05:51 -05:00
Günther Deschner
f6e8106076 r12273: Fix copy paste error.
Guenther
(This used to be commit 266f5fc9af)
2007-10-10 11:05:51 -05:00
Gerald Carter
6f91e3a862 r12262: * patch from Brian Moran to fix segv in eventlogadm when not eventlogs
are listed in smb.conf
* initialize the local group description in set_alias_info()
(This used to be commit 58f8b42069)
2007-10-10 11:05:51 -05:00
Jeremy Allison
91efc453ab r12250: Patch from Martin Koeppe <mkoeppe@gmx.de> for #3287
to make the dev/inode numbers match what SFU expects.
If we're using 8 byte inodes we'll lose the top 4 bytes
and replace them with a dev_t instead, but this seem
reasonable to ensure uniqueness.
Jeremy.
(This used to be commit e53574d0b4)
2007-10-10 11:05:51 -05:00
Jeremy Allison
3a405096c5 r12245: eDirectory returns LDAP_UNWILLING_TO_PERFORM if the
account is disabled. If we get this we can't check
the password so have to tell the client the account
was disabled.
Jeremy.
(This used to be commit 43c2d545ab)
2007-10-10 11:05:50 -05:00
Derrell Lipman
0dc59604f7 r12236: r11740@cabra: derrell | 2005-12-14 13:16:58 -0500
check in the DEBUG message referenced in the previous commit
(This used to be commit 6c04a8f9ad)
2007-10-10 11:05:50 -05:00
Derrell Lipman
103f720617 r12235: r11738@cabra: derrell | 2005-12-14 13:15:14 -0500
Ensure that when libsmbclient copies a cli, it prevents the cli from later
 being freed, by turning off the 'allocated' flag.

 Change a DEBUG message in pipe_open code from level 0 to level 1 since
 libsmbclient is now regularly attempting to open a pipe for share enumeration,
 and falling back to RAP if RPC is unavailable (e.g. win98).  We don't want
 the debug message to display when the pipe open fails, under these normal
 circumstances.
(This used to be commit 965025c057)
2007-10-10 11:05:50 -05:00
Jeremy Allison
e7d2e311a2 r12234: Reduce the race condition for renames by holding the lock
longer. Instigated by complaints on the fix for #3303 from
SATOH Fumiyasu <fumiyas@miraclelinux.com>.
Jeremy.
(This used to be commit 855f5f8c32)
2007-10-10 11:05:50 -05:00
Derrell Lipman
765daab643 r12225: r11729@cabra: derrell | 2005-12-13 22:59:45 -0500
1. Fix a crash bug which should have reared its ugly head ages ago, but for
    some reason, remained dormant until recently.  The bug pertained to
    libsmbclient doing a structure assignment of a cli after having opened a
    pipe.  The pipe open code makes a copy of the cli pointer that was passed
    to it.  If the cli is later copied (and that cli pointer that was saved
    is no longer valid), the pipe code will cause a crash during shutdown or
    when the copied cli is closed.

 2. The 'type' field in enumerated shares was not being set correctly with
    the new RPC-based mechanism for enumerating shares.
(This used to be commit 62a02b8f2a)
2007-10-10 11:05:50 -05:00
Gerald Carter
728e527d2c r12224: adding more characters to the invalid share name string
(This used to be commit e461143639)
2007-10-10 11:05:50 -05:00
Jeremy Allison
762901cfb9 r12221: Fix error code paths that can potentially leave a dangling lock.
Jeremy.
(This used to be commit 123135ed1d)
2007-10-10 11:05:49 -05:00
Jeremy Allison
4d3152e145 r12214: Fix compile if SYNC_DNS is set.
Jeremy.
(This used to be commit 7c545e1e77)
2007-10-10 11:05:49 -05:00
Jeremy Allison
ab7a4f7e8e r12213: Final fix for #3303 - send rename messages to smbd's
that have open file handles to allow them to correctly
implement delete on close. There is a further correctness
fix I'm intending to add to this to cope with different share
paths, but not right now...
Jeremy.
(This used to be commit 932e337db8)
2007-10-10 11:05:49 -05:00
Jeremy Allison
7d2771e758 r12203: Add the share path into the sharemode db. This involves
revving the minor version number for libsmbsharemodes (we
now have a new _ex interface that takes the share path
as well as the filename). Needed for #3303. Some code written
by SATOH Fumiyasu <fumiya@samba.gr.jp> included in the changes
to locking/locking.c. The smbstatus output is a bit of a mess
and needs overhauling...
Jeremy.
(This used to be commit 9d93af713f)
2007-10-10 11:05:49 -05:00
Gerald Carter
3f6d9a7b9d r12196: patch from Krishna Ganugapati <krishnag@centeris.com>
Use the subtree delete ldap control when running 'net ads leave'
to ensure that the machine account is actually deleted.
(This used to be commit e96000c16c)
2007-10-10 11:05:49 -05:00
Jeremy Allison
fa4df827d0 r12194: Ensure that when we set a connection path we've canonicalized
the name (must be abolute - start with /, must not end in /,
must have ./ and ../ removed). Of course for realpath resolved
paths this won't be the case but for others we need this name
to be canonicalized. This name is going into the sharemode db
for #3303 so needs to be in a normalized format.
Jeremy.
(This used to be commit 22e3300911)
2007-10-10 11:05:48 -05:00
Günther Deschner
c9c8781ccf r12193: Fix some typos.
Guenther
(This used to be commit 499224f02a)
2007-10-10 11:05:48 -05:00
Volker Lendecke
db6eea0fb4 r12185: Cosmetic cleanup
(This used to be commit d1e8f9afff)
2007-10-10 11:05:48 -05:00
Volker Lendecke
4d03fc55df r12182: Cosmetic cleanup
(This used to be commit 81c358b511)
2007-10-10 11:05:48 -05:00
Gerald Carter
2c0114d211 r12177: last of outstanding patches in my queue to deal with MMC.
Validate the share name and fail when trying to creating
a share with bad characters.
(This used to be commit 174fe494f9)
2007-10-10 11:05:48 -05:00
Gerald Carter
7cd1af4a63 r12176: fix type mismatch after rpc structure change in rpc_svcctl.h
(This used to be commit ba67d3ae04)
2007-10-10 11:05:48 -05:00
Gerald Carter
143103954c r12174: Simple patch to work around the current lack of BUILTIN
nested group support.  Always add the BUILTIN\Administrators
SID to a Domain Admins token.

This solves the extra steps of establishing a group map for
the local Administrators SID in order to control services.
Windows also tends to expect the Administrators group to be
usable when setting up security permissions on shares.

Volker's work will probably fix this long term, but this
gets us past some of the setup hurdles for 3.0.21.
(This used to be commit 170b6a68bc)
2007-10-10 11:05:48 -05:00
Gerald Carter
a489553067 r12173: doing some service control work
* Add a few new error codes for disabled services
* dump some more details about service status in 'net rpc service'
* disable the WINS and NetLogon services if not configured in smb.conf

Still trying to figure out how to disable the start button
on the NetLogon and WINS services.
(This used to be commit c0f54eeebc)
2007-10-10 11:05:47 -05:00
Volker Lendecke
1e0684678e r12170: Fix a segfault -- this is post-3.0.21 code
(This used to be commit 8b30cf8e09)
2007-10-10 11:05:47 -05:00
Volker Lendecke
c911ac23a9 r12169: Remove an unused function
(This used to be commit 209e4f8793)
2007-10-10 11:05:47 -05:00
Volker Lendecke
661c5c741a r12163: Change lookup_sid and lookup_name to return const char * instead of char *,
use a temporary talloc_ctx for clarity.

Volker
(This used to be commit b15815c804)
2007-10-10 11:05:46 -05:00
Jeremy Allison
78fa625d25 r12160: The filename parameter to get_share_mode_lock is going
to become very important as we fix #3303, so make sure
we don't accidently set it here.
Jeremy.
(This used to be commit d1a9d0587c)
2007-10-10 11:05:46 -05:00
Volker Lendecke
6a92f418ea r12133: Fix an uninitialized variable in new code in rpc_server/srv_samr_nt.c.
Fix winbind_lookup_name for the local domain, ie for aliases on a member
server.

Volker
(This used to be commit 4ba50c823e)
2007-10-10 11:05:46 -05:00
Günther Deschner
5ffc3b18ef r12131: Fix it really, this time :)
Guenther
(This used to be commit 4a506dbc3c)
2007-10-10 11:05:46 -05:00
Günther Deschner
09c1b2a20e r12130: display domain GUID.
Guenther
(This used to be commit 8e63da0366)
2007-10-10 11:05:46 -05:00
Volker Lendecke
ab51c18cc9 r12129: Fix uninitialized variables.
Volker
(This used to be commit 8a7d6eb2c0)
2007-10-10 11:05:46 -05:00
Derrell Lipman
7bf8de2f02 r12119: r10812@cabra: derrell | 2005-12-07 22:44:26 -0500
sync to repository didn't work correctly...???
(This used to be commit 86ab4cf42b)
2007-10-10 11:05:45 -05:00
Derrell Lipman
e48ef5b9b1 r12118: r10805@cabra: derrell | 2005-12-07 22:34:55 -0500
first go at supporting long file names.  seeems to work; requires more testing
(This used to be commit 99fbe44ac5)
2007-10-10 11:05:45 -05:00
Jeremy Allison
2c93f195be r12111: Fix the "everything" build by re-adding debug2html. Oops.
Jeremy.
(This used to be commit d270b809ed)
2007-10-10 11:05:45 -05:00
Jeremy Allison
ba10b97956 r12110: We're using a tdb-based wins backend now. Thanks to the
ubiqx code, which has served us well for many a year..
"Well done, thou good and faithful servant".
Jeremy.
(This used to be commit 32380002e4)
2007-10-10 11:05:45 -05:00
Jeremy Allison
83b987befd r12107: Move to a tdb-based wins database. At the moment we still
use it as though it were an in-memory db and dump out to
a flat file every 2 mins, but that can now change.
Jeremy.
(This used to be commit a342681792)
2007-10-10 11:05:45 -05:00
Günther Deschner
436b3dd88a r12106: Fix return value
Guenther
(This used to be commit 1fa8039397)
2007-10-10 11:05:45 -05:00
Derrell Lipman
44293df2ae r12098: r10797@cabra: derrell | 2005-12-06 12:09:00 -0500
fixed another memory leak and reverted an (incorrect) fix from yesterday
(This used to be commit 8a86d7bddc)
2007-10-10 11:05:44 -05:00