1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-03 12:58:35 +03:00

27820 Commits

Author SHA1 Message Date
Michael Adam
2feaaa885a s3:winbindd: make do_async_domain() static.
Michael
2009-02-17 18:21:53 +01:00
Michael Adam
08bef5bba0 s3:build: improve the check for a working krb5-config.
Not only check if it exists and is executable, but also
check whether it accepts the command line "krb5-config --libs gssapi".

Chris Hoogendyk <hoogendyk@bio.umass.edu> has reported configure
failing on a Solaris machine due to krb5-config raising errors on
these options.

Michael
2009-02-17 18:21:52 +01:00
Günther Deschner
df17774412 s3-spoolss: remove old spoolss_ResetPrinter.
Guenther
2009-02-17 10:52:32 +01:00
Günther Deschner
ce71a7c9a7 s3-spoolss: use pidl for _spoolss_ResetPrinter.
Guenther
2009-02-17 10:52:31 +01:00
Günther Deschner
dc7f04aac7 s3-netapi: fix Coverity #881 and #882.
Guenther
2009-02-17 10:21:22 +01:00
Volker Lendecke
ea192f08e6 Fix an invalid typecasting
entry->num_of_strings is a uint16_t. Casting it with

(int *)&entry->num_of_strings

is wrong, because it gives add_string_to_array the illusion that the object
"num" points to is an int, which it is not.

In case we are running on a machine where "int" is 32 or 64 bits long, what
happens with that cast? "add_string_to_array" interprets the byte field that
starts where "num_of_strings" starts as an int. Under very particular
circumstances this might work in a limited number of cases: When the byte order
of an int is such that the lower order bits of the int are stored first, the
subsequent bytes which do not belong to the uint16_t anymore happen to be 0 and
the result of the increment still fits into the first 2 bytes of that int, i.e.
the result is < 65536.

The correct solution to this problem is to use the implicit type conversion
that happens when an assignment is done.

BTW, this bug is found if you compile with -O3 -Wall, it shows up as a warning:

rpc_server/srv_eventlog_lib.c:574: warning: dereferencing type-punned pointer
	will break strict-aliasing rules

Thanks,

Volker
2009-02-17 10:20:55 +01:00
Günther Deschner
046cb24d0a s3-rpcclient: use rpccli_spoolss_RemoteFindFirstPrinterChangeNotifyEx.
Guenther
2009-02-17 03:51:50 +01:00
Yasuma Takeda
e32f946114 Fix bug 5920
The length of the memcpy was calculated wrong, r->out.return_authenticator is
a pointer
2009-02-16 14:08:39 +01:00
Stefan Metzmacher
fe417b29bd s3:netlogon: implement _netr_LogonGetCapabilities() with NT_STATUS_NOT_IMPLEMENTED
This hopefully fixes bug #6100.

metze
2009-02-16 11:34:35 +01:00
Zach Loafman
8e19a28805 s3 auth: Add parameter that forces every user through an NSS lookup
When set to yes, "force username map" forces every user, even AD
users, through an NSS lookup. This allows the token to be overridden
with information from NSS in certain broken environments.
2009-02-16 00:29:21 -08:00
Tim Prouty
57a31ef203 s3 perfcount: Fix segfault with smbclient 'echo 3 foo' 2009-02-16 00:29:20 -08:00
Tim Prouty
6bd7e2b097 s3 OneFS: Add defaults to the fake timestamp parameters 2009-02-16 00:29:20 -08:00
Tim Prouty
dea223ba79 make receive_smb_raw_talloc more readable 2009-02-16 00:29:20 -08:00
Jeremy Allison
9a5d5cc1db Attempt to fix bug #6099. According to Microsoft
Windows 7 looks at the negotiate_flags
returned in this structure *even if the
call fails with access denied ! So in order
to allow Win7 to connect to a Samba NT style
PDC we set the flags before we know if it's
an error or not.
Jeremy.
2009-02-15 18:12:20 -08:00
Derrell Lipman
f608588ea3 remove accidental white space 2009-02-14 22:29:28 -05:00
Derrell Lipman
a796832683 enums are traditionally signed. Avoid use of high bit in bit flags. 2009-02-14 22:29:11 -05:00
Derrell Lipman
aee9bab6e1 Get rid of the warnings I had for testing 2009-02-14 18:56:33 -05:00
Derrell Lipman
2b097cbb4e It seems some systems use f_flags instead of f_flag. Use the appropriate one. 2009-02-14 16:01:05 -05:00
Volker Lendecke
b222de4eb3 Remove a pointless NULL check 2009-02-14 22:01:03 +01:00
Volker Lendecke
4e34c0ceca Fix some nonempty blank lines 2009-02-14 22:01:03 +01:00
Volker Lendecke
913c547cf6 Rename lp_smb_perfcount_module() to lp_perfcount_module() to match the parameter name 2009-02-14 22:01:03 +01:00
Volker Lendecke
b08e24a44c Replace a // style comment with a /* */ one 2009-02-14 22:01:02 +01:00
Volker Lendecke
ef3672a655 Fix some C++ warnings 2009-02-14 22:01:02 +01:00
Volker Lendecke
208b8f76b3 Make smb_load_perfcount_module static 2009-02-14 22:00:44 +01:00
Derrell Lipman
7caadefaa2 f_frsize field is not ubiquitous. Check for it. 2009-02-14 12:30:23 -05:00
Derrell Lipman
20b5e64659 The f_fsid field is not always an integer type. Don't set it in that case. 2009-02-14 12:27:40 -05:00
Derrell Lipman
fcb2e8904e Ensure consistency of values on stack (caught by AIX compiler) 2009-02-14 10:08:10 -05:00
Derrell Lipman
c2661aec24 Check for the right error return value 2009-02-14 09:44:36 -05:00
Derrell Lipman
352c97561e [Bug 6069] Add a fstatvfs function for libsmbclient
- Revert Tim's changes for the moment. I need to see what the issue is and
  arrange to use "struct statvfs" if at all possible.

Derrell
2009-02-14 09:44:36 -05:00
Volker Lendecke
6c07b9b7e7 Attempt to fix the build on Solaris 8 2009-02-14 11:42:05 +01:00
Volker Lendecke
8dbfd59adc Fix a valgrind error 2009-02-14 08:05:26 +01:00
Tim Prouty
85eccea0b4 s3 OneFS: Add recvfile implementation 2009-02-13 21:36:42 -08:00
Tim Prouty
c05eb1a835 s3 vfs: Fix SMB_VFS_RECVFILE/SENDFILE macros 2009-02-13 21:31:26 -08:00
Tim Prouty
add9b4afb1 s3: Fix uninitialized const char * 2009-02-13 17:56:08 -08:00
Holger Hetterich
4261cae2eb Enable total anonymization in vfs_smb_traffic_analyzer, by mapping any user names to the one given by anonymize_prefix, without generating a hash number. This setting is optional and is compatible with the module configuration format of Samba 3.3. 2009-02-13 17:22:25 -08:00
Günther Deschner
bcdf345df9 s3-spoolss: remove unused convert_printer_info.
Guenther
2009-02-14 01:42:11 +01:00
Günther Deschner
cd2af58af9 s3-spoolss: use pidl for _spoolss_SetPrinter.
Guenther
2009-02-14 01:42:07 +01:00
Günther Deschner
fbcccbc410 s3-spoolss: use pidl for _spoolss_AddPrinterEx.
Guenther
2009-02-14 01:42:01 +01:00
Günther Deschner
9992827838 s3-spoolss: add printer_info2_to_nt_printer_info2 and convert_printer_info_new.
Guenther
2009-02-14 01:42:00 +01:00
Günther Deschner
cba40f6521 s3-rpcclient: use rpccli_spoolss_AddPrinterEx.
Guenther
2009-02-14 01:42:00 +01:00
Günther Deschner
75562a1e34 s3-netlogon: some more appropriate debug messages.
Guenther
2009-02-14 01:21:20 +01:00
Jeremy Allison
4df9f1860e Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba 2009-02-13 16:07:07 -08:00
Jeremy Allison
49b52ec16f Parameterize in local.h the MAX_RPC_DATA_SIZE, and ensure
that "offered" read from the rpc packet in spoolss is under
that size. Tidyup from analysis from Veracode.
Jeremy.
2009-02-13 16:06:17 -08:00
Zack Kirsch
ca87726f81 s3: Fix uninitialized variable warning (and bug). 2009-02-13 15:59:39 -08:00
Jeremy Allison
f6821a15a0 Noted by Vericode analysis. Correctly use chroot().
Jeremy.
2009-02-13 15:02:32 -08:00
Tim Prouty
5e5d2b2cfa s3 libsmbclient: Fix fstatvfs to be more portable
The statvfs struct isn't guaranteed to be portable across operating
systems.  Since libsmbclient isn't actually calling statvfs and just
using the statvfs struct to store similar information, this patch adds
a new portable smbc_statvfs struct.  This fixes a few of the failures
in the build farm introduced by:
ae259575c447e61665c8e7070c476914161b953f

Derrell, please check.
2009-02-13 12:59:30 -08:00
Aravind Srinivasan
6085ba3dec s3 OneFS: Add vfs implementation for SMB_VFS_GET_REAL_FILE_NAME 2009-02-13 12:59:30 -08:00
todd stecher
dbe2588e46 s3: Test module for perfcount system
Add 'perfcount module = pc_test' to exercise this module. Results are
logged into smb.log every 50 operations (configurable via smb.conf).
2009-02-13 12:59:30 -08:00
Volker Lendecke
ad07bb8dbd Fix Coverity ID 740 (RESOURCE_LEAK) 2009-02-13 21:55:10 +01:00
Jeremy Allison
7d73130125 Fix the build. When you do "make distclean; ./autogen; ./configure; make" and it still doesn't build you know it's messed up.
Jeremy.
2009-02-13 10:36:11 -08:00